[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search

[Suma Shivaprasad (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492435#comment-15492435
 ] 

Suma Shivaprasad commented on ATLAS-1098:
-

Reopening issue to revert the earlier changes and reattach the patch after 
appling Shwetha's patch to address [~davidrad]'s review comments. [~apoorvnaik] 
Can you raise a patch for the same

> Atlas allows creation of tag with name "isa" which causes exceptions during 
> search
> --
>
> Key: ATLAS-1098
> URL: https://issues.apache.org/jira/browse/ATLAS-1098
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sharmadha Sainath
>Assignee: Apoorv Naik
> Attachments: ATLAS-1098.patch
>
>
> Created a tag with name "isa". DSL query "Table where Table isa isa" throws 
> exception . Search in Tag tab also throws exception.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search

[Suma Shivaprasad (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad reopened ATLAS-1098:
-

> Atlas allows creation of tag with name "isa" which causes exceptions during 
> search
> --
>
> Key: ATLAS-1098
> URL: https://issues.apache.org/jira/browse/ATLAS-1098
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sharmadha Sainath
>Assignee: Apoorv Naik
> Attachments: ATLAS-1098.patch
>
>
> Created a tag with name "isa". DSL query "Table where Table isa isa" throws 
> exception . Search in Tag tab also throws exception.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ATLAS-1173) Doc: Minor editorial bug in the example given for property atlas.server.ha.zookeeper.auth

[Hemanth Yamijala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemanth Yamijala reassigned ATLAS-1173:
---

Assignee: Hemanth Yamijala

> Doc: Minor editorial bug in the example given for property 
> atlas.server.ha.zookeeper.auth
> -
>
> Key: ATLAS-1173
> URL: https://issues.apache.org/jira/browse/ATLAS-1173
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Hemanth Yamijala
>Priority: Minor
> Attachments: ATLAS-1173.patch
>
>
> In {{Configuration.twiki}}, we have specified the example for Zookeeper 
> security configs as follows (under the High Availability Properties).
> {code}
> atlas.server.ha.zookeeper.acl=auth:sasl:cli...@comany.com
> {code}
> The auth: prefix in the value is incorrect and should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1173) Doc: Minor editorial bug in the example given for property atlas.server.ha.zookeeper.auth

[Hemanth Yamijala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemanth Yamijala updated ATLAS-1173:

Attachment: ATLAS-1173.patch

Very trivial patch fixing the issue.

> Doc: Minor editorial bug in the example given for property 
> atlas.server.ha.zookeeper.auth
> -
>
> Key: ATLAS-1173
> URL: https://issues.apache.org/jira/browse/ATLAS-1173
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Priority: Minor
> Attachments: ATLAS-1173.patch
>
>
> In {{Configuration.twiki}}, we have specified the example for Zookeeper 
> security configs as follows (under the High Availability Properties).
> {code}
> atlas.server.ha.zookeeper.acl=auth:sasl:cli...@comany.com
> {code}
> The auth: prefix in the value is incorrect and should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1173) Doc: Minor editorial bug in the example given for property atlas.server.ha.zookeeper.auth

[Hemanth Yamijala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemanth Yamijala updated ATLAS-1173:

Affects Version/s: 0.7-incubating

> Doc: Minor editorial bug in the example given for property 
> atlas.server.ha.zookeeper.auth
> -
>
> Key: ATLAS-1173
> URL: https://issues.apache.org/jira/browse/ATLAS-1173
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Hemanth Yamijala
>Priority: Minor
> Attachments: ATLAS-1173.patch
>
>
> In {{Configuration.twiki}}, we have specified the example for Zookeeper 
> security configs as follows (under the High Availability Properties).
> {code}
> atlas.server.ha.zookeeper.acl=auth:sasl:cli...@comany.com
> {code}
> The auth: prefix in the value is incorrect and should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1173) Doc: Minor editorial bug in the example given for property atlas.server.ha.zookeeper.auth

[Hemanth Yamijala (JIRA)]

Hemanth Yamijala created ATLAS-1173:
---

 Summary: Doc: Minor editorial bug in the example given for 
property atlas.server.ha.zookeeper.auth
 Key: ATLAS-1173
 URL: https://issues.apache.org/jira/browse/ATLAS-1173
 Project: Atlas
  Issue Type: Bug
Reporter: Hemanth Yamijala
Priority: Minor


In {{Configuration.twiki}}, we have specified the example for Zookeeper 
security configs as follows (under the High Availability Properties).

{code}
atlas.server.ha.zookeeper.acl=auth:sasl:cli...@comany.com
{code}

The auth: prefix in the value is incorrect and should be removed.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (ATLAS-1035) In some scenarios, creation of 2 instances with references between them in one call fails

[David Kantor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Kantor resolved ATLAS-1035.
-
Resolution: Not A Bug
  Assignee: David Kantor

I have debugged this issue, and Atlas is working as designed. In Atlas, the 
value of a non-composite reference is the referenced object's ID.  The target 
of a non-composite reference is not implicitly created by Atlas if it does not 
already exist. When setting a non-composite reference, either the target object 
must already exist, or, the target must be created in the same Atlas entity 
operation as the referencing object by either:

* being specified as one of the "root" entities when calling the Atlas 
operation, or
* being the target of a composite reference from some other entity that is 
being created

If neither of these is true, and the target of a non-composite reference does 
not exist, then the Atlas entity operation will fail with exception you 
encountered, because Atlas is saying: "This is a non-composite reference, but 
the target object has no existing vertex in the graph, and is not being created 
in this operation, so I don't know what ID to use for setting the reference". 
To avoid the "EntityNotFoundException: Could not find vertex for Class 
Reference" error, ensure that both entities are explicitly specified when 
calling the Atlas entities operation. The other option is changing the model, 
such that the reference is defined as composite. Note that this option has 
other ramifications, as it means the fully inflated target object will be 
returned whenever the source object is queried, and, the target object will be 
automatically deleted when the source object is deleted. Feel free to ping me 
if you'd like to discuss this further.

> In some scenarios, creation of 2 instances with references between them in 
> one call fails
> -
>
> Key: ATLAS-1035
> URL: https://issues.apache.org/jira/browse/ATLAS-1035
> Project: Atlas
>  Issue Type: Bug
>Reporter: Prasad  S Madugundu
>Assignee: David Kantor
>
> If I create 2 instances that have references between them in one call, it 
> fails with the following exception:
> SEVERE: org.apache.atlas.typesystem.exception.EntityNotFoundException: Could 
> not find vertex for Class Reference (type: 
> ConnectorDirectoryModel_OMRSConnectorDirectory, id: )
> Caused by: org.apache.atlas.repository.RepositoryException: 
> org.apache.atlas.typesystem.exception.EntityNotFoundException: Could not find 
> vertex for Class Reference (type: 
> ConnectorDirectoryModel_OMRSConnectorDirectory, id: )
>   at 
> org.apache.atlas.repository.graph.GraphBackedMetadataRepository.createEntities(GraphBackedMetadataRepository.java:137)
>   at 
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:42)
>   at 
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:337)
>   at 
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:333)
>   at 
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:125)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
>

[jira] [Resolved] (ATLAS-1172) Feature request

[Ashish Shrowty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Shrowty resolved ATLAS-1172.
---
Resolution: Invalid

> Feature request
> ---
>
> Key: ATLAS-1172
> URL: https://issues.apache.org/jira/browse/ATLAS-1172
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashish Shrowty
>Priority: Minor
>
> Ability for Sqoop to support MySQL or Postgres as the metastore DB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1172) Feature request

[Ashish Shrowty (JIRA)]

Ashish Shrowty created ATLAS-1172:
-

 Summary: Feature request
 Key: ATLAS-1172
 URL: https://issues.apache.org/jira/browse/ATLAS-1172
 Project: Atlas
  Issue Type: Improvement
Reporter: Ashish Shrowty
Priority: Minor


Ability for Sqoop to support MySQL or Postgres as the metastore DB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-712) Support getTrait() API

[Suma Shivaprasad (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491889#comment-15491889
 ] 

Suma Shivaprasad commented on ATLAS-712:


+1

> Support getTrait() API
> --
>
> Key: ATLAS-712
> URL: https://issues.apache.org/jira/browse/ATLAS-712
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Suma Shivaprasad
>Assignee: Vimal Sharma
> Attachments: ATLAS-712-v2.patch, ATLAS-712-v3.patch, ATLAS-712.patch
>
>
> Given entity id and trait name, support rest API that returns the trait 
> instance for the entity. Currently, the other way of getting it is 
> getEntity() which returns full entity with all trait instances 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1139) Parameter name of a HDFS DataSet entity should contain filesystem path

[Suma Shivaprasad (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491304#comment-15491304
 ] 

Suma Shivaprasad commented on ATLAS-1139:
-

[~svimal2106] Pls check for potential NPEs when parsing the HDFS paths. Could 
they be null in some cases ? Pls check else looks good

> Parameter name of a HDFS DataSet entity should contain filesystem path
> --
>
> Key: ATLAS-1139
> URL: https://issues.apache.org/jira/browse/ATLAS-1139
> Project: Atlas
>  Issue Type: Bug
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Attachments: ATLAS-1139-v2.patch, ATLAS-1139.patch
>
>
> In lineage graph, input and output HDFS path entity can have the same value 
> in attribute "name". This causes ambiguity for the user to correctly 
> understand the lineage graph.
> The proposal is to set normalized path as the value of "name" attribute for 
> HDFS paths in all Atlas Hooks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1171) Structured, high-level public APIs

[Madhan Neethiraj (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-1171:

Attachment: ATLAS-1171.1.patch

Patch is available at the review board here: https://reviews.apache.org/r/51896/

> Structured, high-level public APIs
> --
>
> Key: ATLAS-1171
> URL: https://issues.apache.org/jira/browse/ATLAS-1171
> Project: Atlas
>  Issue Type: Bug
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
> Attachments: ATLAS-1171.1.patch
>
>
> Many Atlas APIs use opaque JSON strings (or HTTP request/response contents 
> that are not defined in the interface) to pass details of types/entities - 
> for example here are some APIs:
>  - TypesResource.submit(HttpServletRequest request)
>  - TypesResource.update(HttpServletRequest request)
>  - Response getDefinition(HttpServletRequest request, String typeName)
>  - Response.getTypesByFilter(HttpServletRequest request, String typeCategory, 
> String superType, String notSuperType)
>  - EntityResource.submit(HttpServletRequest request)
>  - EntityResource.updateEntities(HttpServletRequest request)
>  - Response LineageResource.inputsGraph(String guid)
>  - Response LineageResource.outputsGraph(String guid)
>  - Response LineageResource.schema(String guid)
>  - ..
> Also, some APIs expose unnecessary details in the interface, like the one 
> shown below. These look like implementation details which is better not 
> exposed in the interface.
> {code}
> "jsonClass": 
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Reference"
> {code}
> A structured API, with explicit details of the parameters and return value 
> contents, would make it easier to understand the Atlas APIs and create 
> applications that use Atlas services.
> I will shortly add a patch that shows the first-cut of this API. Please 
> review and provide your feedback. The initial patch does not include bunch of 
> APIs - like lineage, search, REST, Java API, etc; but it should give a pretty 
> good idea of the data-structures that will be used in the APIs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/
---

Review request for atlas.


Bugs: ATLAS-1171
https://issues.apache.org/jira/browse/ATLAS-1171


Repository: atlas


Description
---

first-cut API for review


Diffs
-

  common/pom.xml e3b6465 
  common/src/main/java/org/apache/atlas/api/AtlasEntities.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/AtlasTypes.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasAttributeDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasBuiltInDatatypes.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasEntity.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasEntityDef.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasEnumDef.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasObjectId.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasProcess.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasStruct.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasStructDef.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasTrait.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/AtlasTraitDef.java PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/TestAtlasEntity.java PRE-CREATION 
  pom.xml 95f28b0 

Diff: https://reviews.apache.org/r/51896/diff/


Testing
---


Thanks,

Madhan Neethiraj

[jira] [Updated] (ATLAS-1139) Parameter name of a HDFS DataSet entity should contain filesystem path

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1139:

Description: 
In lineage graph, input and output HDFS path entity can have the same value in 
attribute "name". This causes ambiguity for the user to correctly understand 
the lineage graph.

The proposal is to set normalized path as the value of "name" attribute for 
HDFS paths in all Atlas Hooks

  was:
In lineage graph, input and output entity can have the same value in attribute 
"name". This causes ambiguity for the user to correctly understand the lineage 
graph.

The proposal is to set normalized path as the value of "name" attribute.


> Parameter name of a HDFS DataSet entity should contain filesystem path
> --
>
> Key: ATLAS-1139
> URL: https://issues.apache.org/jira/browse/ATLAS-1139
> Project: Atlas
>  Issue Type: Bug
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Attachments: ATLAS-1139.patch
>
>
> In lineage graph, input and output HDFS path entity can have the same value 
> in attribute "name". This causes ambiguity for the user to correctly 
> understand the lineage graph.
> The proposal is to set normalized path as the value of "name" attribute for 
> HDFS paths in all Atlas Hooks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1139) Parameter name of a HDFS DataSet entity should contain filesystem path

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1139:

Summary: Parameter name of a HDFS DataSet entity should contain filesystem 
path  (was: Parameter name of a DataSet entity should contain filesystem path)

> Parameter name of a HDFS DataSet entity should contain filesystem path
> --
>
> Key: ATLAS-1139
> URL: https://issues.apache.org/jira/browse/ATLAS-1139
> Project: Atlas
>  Issue Type: Bug
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Attachments: ATLAS-1139.patch
>
>
> In lineage graph, input and output entity can have the same value in 
> attribute "name". This causes ambiguity for the user to correctly understand 
> the lineage graph.
> The proposal is to set normalized path as the value of "name" attribute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1171) Structured, high-level public APIs

[Madhan Neethiraj (JIRA)]

Madhan Neethiraj created ATLAS-1171:
---

 Summary: Structured, high-level public APIs
 Key: ATLAS-1171
 URL: https://issues.apache.org/jira/browse/ATLAS-1171
 Project: Atlas
  Issue Type: Bug
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Many Atlas APIs use opaque JSON strings (or HTTP request/response contents that 
are not defined in the interface) to pass details of types/entities - for 
example here are some APIs:
 - TypesResource.submit(HttpServletRequest request)
 - TypesResource.update(HttpServletRequest request)
 - Response getDefinition(HttpServletRequest request, String typeName)
 - Response.getTypesByFilter(HttpServletRequest request, String typeCategory, 
String superType, String notSuperType)
 - EntityResource.submit(HttpServletRequest request)
 - EntityResource.updateEntities(HttpServletRequest request)
 - Response LineageResource.inputsGraph(String guid)
 - Response LineageResource.outputsGraph(String guid)
 - Response LineageResource.schema(String guid)
 - ..

Also, some APIs expose unnecessary details in the interface, like the one shown 
below. These look like implementation details which is better not exposed in 
the interface.
{code}
"jsonClass": "org.apache.atlas.typesystem.json.InstanceSerialization$_Reference"
{code}


A structured API, with explicit details of the parameters and return value 
contents, would make it easier to understand the Atlas APIs and create 
applications that use Atlas services.

I will shortly add a patch that shows the first-cut of this API. Please review 
and provide your feedback. The initial patch does not include bunch of APIs - 
like lineage, search, REST, Java API, etc; but it should give a pretty good 
idea of the data-structures that will be used in the APIs.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1170) JVM state determined to be unstable

[feroz shaik (JIRA)]

feroz shaik created ATLAS-1170:
--

 Summary: JVM state determined to be unstable
 Key: ATLAS-1170
 URL: https://issues.apache.org/jira/browse/ATLAS-1170
 Project: Atlas
  Issue Type: Improvement
Reporter: feroz shaik


Issue description: We have a 4 node cluster on AWS and after recent changes to 
GC strategy from CMS to G1, We have frequent shutdown of cassandra nodes 
throwing " JVM state determined to be unstable.  Exiting forcefully due to:
java.lang.OutOfMemoryError: Java heap space". The cluster has issues with the 
data model itself which is being worked upon. Just trying to understand why 
changing the GC setting not being helpful and rather causing more problem. 
java_heap also was changed to 16G on the nodes from earlier 8G. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1169) Tag details page shows showing 1-6 records found for 0 records.

[Nixon Rodrigues (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-1169:
---
Attachment: (was: Bug-printscreen.png)

> Tag details page shows showing 1-6 records found for 0 records.
> ---
>
> Key: ATLAS-1169
> URL: https://issues.apache.org/jira/browse/ATLAS-1169
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>
> ETL tag details page shows showing 1-6 records found for 0 records.
> Due to duplicate guid returned from api response while searching for tag 
> details, UI is facing issue in rendering them. below is api response with 
> duplicate guid.
> *was not able to replicate this issue on other instance.
> API call -> http://172.22.106.121:21000/api/atlas/types/ETL
> Response
> {noformat}
> {
> "requestId": "qtp511473681-8953 - 9993ef24-5ef5-4047-acb3-c47c479345f0",
> "query": "`ETL`",
> "queryType": "dsl",
> "count": 6,
> "results": [
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "2f155c77-2d0f-4861-9092-4f4daf133472",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "573e064b-b267-48e4-bf0e-adc7b8655894",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "0428840f-d19c-4ce0-be82-ea0c8d3303a0",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "573e064b-b267-48e4-bf0e-adc7b8655894",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "0428840f-d19c-4ce0-be82-ea0c8d3303a0",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "2f155c77-2d0f-4861-9092-4f4daf133472",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> }
> ],
> "dataType": {...}
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1169) Tag details page shows showing 1-6 records found for 0 records.

[Nixon Rodrigues (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-1169:
---
Attachment: Bug-printscreen.png

> Tag details page shows showing 1-6 records found for 0 records.
> ---
>
> Key: ATLAS-1169
> URL: https://issues.apache.org/jira/browse/ATLAS-1169
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
> Attachments: Bug-printscreen.png
>
>
> ETL tag details page shows showing 1-6 records found for 0 records.
> Due to duplicate guid returned from api response while searching for tag 
> details, UI is facing issue in rendering them. below is api response with 
> duplicate guid.
> *was not able to replicate this issue on other instance.
> API call -> http://172.22.106.121:21000/api/atlas/types/ETL
> Response
> {noformat}
> {
> "requestId": "qtp511473681-8953 - 9993ef24-5ef5-4047-acb3-c47c479345f0",
> "query": "`ETL`",
> "queryType": "dsl",
> "count": 6,
> "results": [
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "2f155c77-2d0f-4861-9092-4f4daf133472",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "573e064b-b267-48e4-bf0e-adc7b8655894",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "0428840f-d19c-4ce0-be82-ea0c8d3303a0",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "573e064b-b267-48e4-bf0e-adc7b8655894",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "0428840f-d19c-4ce0-be82-ea0c8d3303a0",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> },
> {
> "$typeName$": "__tempQueryResultStruct872",
> "instanceInfo": {
> "$typeName$": "__IdType",
> "guid": "2f155c77-2d0f-4861-9092-4f4daf133472",
> "state": "ACTIVE",
> "typeName": "LoadProcess"
> },
> "traitDetails": null
> }
> ],
> "dataType": {...}
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1169) Tag details page shows showing 1-6 records found for 0 records.

[Nixon Rodrigues (JIRA)]

Nixon Rodrigues created ATLAS-1169:
--

 Summary: Tag details page shows showing 1-6 records found for 0 
records.
 Key: ATLAS-1169
 URL: https://issues.apache.org/jira/browse/ATLAS-1169
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


ETL tag details page shows showing 1-6 records found for 0 records.


Due to duplicate guid returned from api response while searching for tag 
details, UI is facing issue in rendering them. below is api response with 
duplicate guid.

*was not able to replicate this issue on other instance.

API call -> http://172.22.106.121:21000/api/atlas/types/ETL


Response


{noformat}
{

"requestId": "qtp511473681-8953 - 9993ef24-5ef5-4047-acb3-c47c479345f0",

"query": "`ETL`",

"queryType": "dsl",

"count": 6,

"results": [

{

"$typeName$": "__tempQueryResultStruct872",

"instanceInfo": {

"$typeName$": "__IdType",

"guid": "2f155c77-2d0f-4861-9092-4f4daf133472",

"state": "ACTIVE",

"typeName": "LoadProcess"

},

"traitDetails": null

},

{

"$typeName$": "__tempQueryResultStruct872",

"instanceInfo": {

"$typeName$": "__IdType",

"guid": "573e064b-b267-48e4-bf0e-adc7b8655894",

"state": "ACTIVE",

"typeName": "LoadProcess"

},

"traitDetails": null

},

{

"$typeName$": "__tempQueryResultStruct872",

"instanceInfo": {

"$typeName$": "__IdType",

"guid": "0428840f-d19c-4ce0-be82-ea0c8d3303a0",

"state": "ACTIVE",

"typeName": "LoadProcess"

},

"traitDetails": null

},

{

"$typeName$": "__tempQueryResultStruct872",

"instanceInfo": {

"$typeName$": "__IdType",

"guid": "573e064b-b267-48e4-bf0e-adc7b8655894",

"state": "ACTIVE",

"typeName": "LoadProcess"

},

"traitDetails": null

},

{

"$typeName$": "__tempQueryResultStruct872",

"instanceInfo": {

"$typeName$": "__IdType",

"guid": "0428840f-d19c-4ce0-be82-ea0c8d3303a0",

"state": "ACTIVE",

"typeName": "LoadProcess"

},

"traitDetails": null

},

{

"$typeName$": "__tempQueryResultStruct872",

"instanceInfo": {

"$typeName$": "__IdType",

"guid": "2f155c77-2d0f-4861-9092-4f4daf133472",

"state": "ACTIVE",

"typeName": "LoadProcess"

},

"traitDetails": null

}

],

"dataType": {...}

}
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1168) Wrong message for Term in audit, it shows as Tag Added or Tag Deleted instead of Term.

[Nixon Rodrigues (JIRA)]

Nixon Rodrigues created ATLAS-1168:
--

 Summary: Wrong message for Term in audit, it shows as Tag Added or 
Tag Deleted instead of Term.
 Key: ATLAS-1168
 URL: https://issues.apache.org/jira/browse/ATLAS-1168
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


If any term is added or deleted, then in audit section, after clicking on 
detail, message in popup appears as Tag Added and Tag Deleted instead of Term



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1167) Cannot create term with deleted term name

[Nixon Rodrigues (JIRA)]

Nixon Rodrigues created ATLAS-1167:
--

 Summary: Cannot create term with deleted term name
 Key: ATLAS-1167
 URL: https://issues.apache.org/jira/browse/ATLAS-1167
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


If a Term is created (TermTest) and it is been deleted and the user again wants 
to create term with same name(TermTest) term then he is not able to create.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1166) The next page pagination button is active, When search records are returned from search are equal to pagination-size

[Nixon Rodrigues (JIRA)]

Nixon Rodrigues created ATLAS-1166:
--

 Summary: The next page pagination button is active, When search 
records are returned from search are equal to pagination-size
 Key: ATLAS-1166
 URL: https://issues.apache.org/jira/browse/ATLAS-1166
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


When exact 25 search records are returned from search, 
the next page button is active and after clicking next button it return same 25 
records with prev/next button is disable



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1165) The "\" character in tag name is causing issue in loading tag attribute page with entities.

[Nixon Rodrigues (JIRA)]

Nixon Rodrigues created ATLAS-1165:
--

 Summary: The "\" character in tag name is causing issue in loading 
tag attribute page with entities.
 Key: ATLAS-1165
 URL: https://issues.apache.org/jira/browse/ATLAS-1165
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


When tag is created with \ in it , the "\" character in tag name is causing 
issue in loading tag attribute page with entities.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1131) Atlas hooks produce excess Kafka logs if Kafka topic is not created already

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490066#comment-15490066
 ] 

Vimal Sharma commented on ATLAS-1131:
-

Created https://issues.apache.org/jira/browse/KAFKA-4164 to track the issue.

> Atlas hooks produce excess Kafka logs if Kafka topic is not created already
> ---
>
> Key: ATLAS-1131
> URL: https://issues.apache.org/jira/browse/ATLAS-1131
> Project: Atlas
>  Issue Type: Bug
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Attachments: ATLAS-1131.patch
>
>
> Hooks for Atlas publish messages to a Kafka topic named ATLAS_HOOK. If this 
> topic is not present and Atlas does not have permission to create this topic, 
> Kafka produces excessive logs as below (example in /tmp/hive/hive.log).
> 2016-08-22 06:43:47,655 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1177 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:47,756 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1178 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:47,858 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1179 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:47,961 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1180 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:48,062 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1181 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:48,165 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1182 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:48,265 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1183 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:48,366 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1184 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}
> 2016-08-22 06:43:48,467 WARN  [kafka-producer-network-thread | producer-1]: 
> clients.NetworkClient (NetworkClient.java:handleResponse(600)) - Error while 
> fetching metadata with correlation id 1185 : 
> {ATLAS_HOOK=UNKNOWN_TOPIC_OR_PARTITION}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51800: Support getTrait() API

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51800/
---

(Updated Sept. 14, 2016, 8:16 a.m.)


Review request for atlas.


Repository: atlas


Description
---

Given entity id and trait name, support rest API that returns the trait 
instance for the entity. Currently, the other way of getting it is getEntity() 
which returns full entity with all trait instances


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
82016d0 
  
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 
a1988ef 

Diff: https://reviews.apache.org/r/51800/diff/


Testing
---


File Attachments (updated)


ATLAS-712-v2.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/13/b5079426-19d0-48f2-88f7-08e4e645bb32__ATLAS-712-v2.patch
ATLAS-712-v3.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/14/462d4e5c-276c-40a0-b709-c946373856f2__ATLAS-712-v3.patch


Thanks,

Vimal Sharma

[jira] [Updated] (ATLAS-712) Support getTrait() API

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-712:
---
Attachment: ATLAS-712-v3.patch

Uploading new patch which addresses Suma's comments

> Support getTrait() API
> --
>
> Key: ATLAS-712
> URL: https://issues.apache.org/jira/browse/ATLAS-712
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Suma Shivaprasad
>Assignee: Vimal Sharma
> Attachments: ATLAS-712-v2.patch, ATLAS-712-v3.patch, ATLAS-712.patch
>
>
> Given entity id and trait name, support rest API that returns the trait 
> instance for the entity. Currently, the other way of getting it is 
> getEntity() which returns full entity with all trait instances 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search

[Shwetha G S (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-1098:
---
Attachment: ATLAS-1098.patch

The attached patch fixes the queryparser. The query {{Table isa `isa`}} works 
with this patch and returns the right results

> Atlas allows creation of tag with name "isa" which causes exceptions during 
> search
> --
>
> Key: ATLAS-1098
> URL: https://issues.apache.org/jira/browse/ATLAS-1098
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sharmadha Sainath
>Assignee: Apoorv Naik
> Attachments: ATLAS-1098.patch
>
>
> Created a tag with name "isa". DSL query "Table where Table isa isa" throws 
> exception . Search in Tag tab also throws exception.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Current use cases for POST /entities

[David Radley]

Hi,
Yes I agree this is reasonable to not send information supplied by the 
sender in the create response. If there are multiple objects being created 
we need to return a list of containing the new guids 
ResournceProvider.createResources already returns lists of guids already  
- we would need to ensure that the order was the same as the request, it 
might be worth adding a name (ideally fully qualified name) with the guid 
for readability and to aid debugging. If there are contained objects that 
are created with guids, it would be worth returning a response which 
contains the nested object structure, but only containing the guids (and 
name) in the object bodies.
 
With the guids, we could return other useful information like  the last 
update date and created date. It might be that we introduce a start date 
which could also gain the creation date by default. My suggestion would be 
to put this sort of response information in a named json object that used 
by creates , updates , deletes, gets and is consistently used by all 
objects (types, terms , tags entities etc). I would like that this sort of 
information should go in a top level object (I notice interface 
ResourceDefinition does not contain this information). 
 
   all the best, David Radley. 


From:   Shwetha Shivalingamurthy 
To: "dev@atlas.incubator.apache.org" 
Date:   14/09/2016 06:13
Subject:Re: Current use cases for POST /entities



We can remove the definition, but I think we should return the guids.

The location in the response header contains the guid. But we should find
a way of returning all the guids created - probably list of locations?

When you change the create API, make sure to change even the update and
delete APIs.

Regards,
Shwetha




On 14/09/16, 3:46 AM, "Suma Shivaprasad" 
wrote:

>+1
>
>On Mon, Sep 12, 2016 at 9:22 PM, Apoorv Naik 
>wrote:
>
>> Is anyone relying on the definition object within the response of a
>>create
>> entity call ? If not, let¹s remove it from the response as it can be
>> inferred from the request body itself and the only useful piece seems
>>to be
>> the GUIDs.
>>




Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Shwetha GS]

> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 309
> > 
> >
> > This is equals check - typename equals keyword. Does it work if 
> > typename contains keyword e.g., if typename is 'isa PII'?
> > 
> > Not sure if keywords in DSL is case sensitive. You may want to verify
> 
> Apoorv Naik wrote:
> Right now this will go through.
> 
> Apoorv Naik wrote:
> I've tried changing the case but seems like the dsl is not case sensitive 
> for those keywords
> 
> Apoorv Naik wrote:
> While testing, I see that if the keyword has any prefix or suffix 
> separated by a space. The query parser doesn't break. Is that what you're 
> looking for ?
> 
> Shwetha GS wrote:
> You mean DSL is case sensitive for the keywords, so the check need not be 
> case insensitive?
> 
> Weird that the query "Table isa `isa PII`" works, but "Table isa `isa`" 
> doesn't work. As David pointed out, its good if we don't add restrictions on 
> typenames. Can you check queryparser to see if its simple enough fix?

The queries have ` around the typenames with keywords. Formatting removed them


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Shwetha GS]

> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 309
> > 
> >
> > This is equals check - typename equals keyword. Does it work if 
> > typename contains keyword e.g., if typename is 'isa PII'?
> > 
> > Not sure if keywords in DSL is case sensitive. You may want to verify
> 
> Apoorv Naik wrote:
> Right now this will go through.
> 
> Apoorv Naik wrote:
> I've tried changing the case but seems like the dsl is not case sensitive 
> for those keywords
> 
> Apoorv Naik wrote:
> While testing, I see that if the keyword has any prefix or suffix 
> separated by a space. The query parser doesn't break. Is that what you're 
> looking for ?

You mean DSL is case sensitive for the keywords, so the check need not be case 
insensitive?

Weird that the query "Table isa `isa PII`" works, but "Table isa `isa`" doesn't 
work. As David pointed out, its good if we don't add restrictions on typenames. 
Can you check queryparser to see if its simple enough fix?


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>