Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-04 Thread Vimal Sharma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151459
---




repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
(line 68)


what is the need for this check? We are iterating over model files anyway.

If there can be directories inside "models" directory, we should get the 
files inside those directories and call registerType.


- Vimal Sharma


On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 4, 2016, 11:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>



Re: Review Request 52509: ATLAS-1206 - Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.

2016-10-04 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52509/
---

(Updated Oct. 5, 2016, 4:43 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Shwetha GS, and Suma 
Shivaprasad.


Bugs: ATLAS-1206
https://issues.apache.org/jira/browse/ATLAS-1206


Repository: atlas


Description
---

ATLAS-1206 - Atlas UI not working with IE or Chrome on Windows OS in Kerberos 
mode. Its giving error Error:-
HTTP ERROR 403
Problem accessing /index.html. Reason:
GSSException: Defective token detected (Mechanism level: GSSHeader did not find 
the right tag)

This patch fix the above issue by making a check for existingAuth from 
springcontext, so that next request dont go for kerberos authentication flow.
Also this patch consist fix for non-kerberized browser's first request hanging 
issue by making isBrowser check.


Diffs
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 605fe89 

Diff: https://reviews.apache.org/r/52509/diff/


Testing (updated)
---

Tested Atlas in following scenario's

* Tested UI in FireFox, Chrome (Linux) / Firefox , Chrome ,IE9 campatiblity 
view in Windows OS.

* Tested Hive Import with kinit on kerberized cluster and on simple cluster

* Created Hive tables from beeline client with kinit on kerberized cluster and 
on simple cluster and metadata reflecting in Atlas UI.

* Run Quick start with kinit from atlas user on kerberized cluster and on 
simple cluster.

* Executed Curl commands with kinit on kerberized cluster and without kinit on 
simple cluster

* Ran Unit test cases.


Thanks,

Nixon Rodrigues



答复: Re: whats different "tags" between atlas and falcon

2016-10-04 Thread zhao . hongtao
thanks Shwetha
 as you say i have find the interface  that falcon use ATlas APIs to fetch 
the tags ; 

   Regards,
 Randy zhao 







发件人: Shwetha Shivalingamurthy 

收件人: "dev@atlas.incubator.apache.org" 
, 
日期:   2016/10/03 16:36
主题:   Re: whats different "tags" between atlas and falcon




Atlas was not not conceptualised when tags were added in Falcon. Now that
Atlas maintains the tags, it makes sense to store the falcon entity’s 
tags
in Atlas and use Atlas as the source of truth, and falcon can use Atlas
APIs to fetch the tags.

Atlas now has falcon integration, Atlas maintains minimal info of falcon
entities. But falcon tags are still not integrated in Atlas

Regards,
Shwetha






On 02/10/16, 1:03 PM, "zhao.hong...@zte.com.cn" 
wrote:

>hi,
> recently when i integration atlas and falcon ,
> i find both have "tags",  as we know atlas have its tags and  it very
>userful for us to classifying metadata ,
> however falcon also have its "tags" and "colo",
>when i integration atlas and falcon
>i find falcon's tags can not transmission to atlas
>can anyone explain  what's "tags" different and connection between atlas
>and falcon 
> 
>
>
>
>
>
>赵洪涛 
>
>
>
>TEL:+86-15062208803
>
>
>
>
>
>
>
>





Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-04 Thread Sarath Kumar Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/
---

(Updated Oct. 4, 2016, 4:17 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Bugs: ATLAS-1210
https://issues.apache.org/jira/browse/ATLAS-1210


Repository: atlas


Description
---

for clients who have not updated to latest code, this patch adds the "position" 
attribute to hive_column type and updates version to 2.0


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 28078f4 
  distro/src/main/assemblies/standalone-package.xml ff7b784 
  
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
c269c3a 
  src/main/patches/001-hive_column_add_position.json PRE-CREATION 

Diff: https://reviews.apache.org/r/52533/diff/


Testing (updated)
---

on older builds - updates the type by adding new attribute and updates version 
to 2.0
new builds - ignore the patch since version is already in 2.0


Thanks,

Sarath Kumar Subramanian



[jira] [Created] (ATLAS-1210) include patch file to add "position" attribute to hive_column type

2016-10-04 Thread Sarath Subramanian (JIRA)
Sarath Subramanian created ATLAS-1210:
-

 Summary: include patch file to add "position" attribute to 
hive_column type
 Key: ATLAS-1210
 URL: https://issues.apache.org/jira/browse/ATLAS-1210
 Project: Atlas
  Issue Type: Bug
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian


for clients who have not updated to latest code, this patch adds the "position" 
attribute to hive_column type and updates version to 2.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: apache-atlas-nightly #436

2016-10-04 Thread Apache Jenkins Server
See 

Changes:

[sumasai.shivaprasad] ATLAS-1171 Structured, high-level public APIs - Fix JAXB 
issues with

--
[...truncated 9411 lines...]
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities/478cbfb2-e297-4857-90c8-7824cbb1cd2c HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities/72eaf8f6-ab20-4d1b-aef7-def5d65c5ed6 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities/aa23b652-0e74-45ae-ba6a-210573e85ec4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities/aa23b652-0e74-45ae-ba6a-210573e85ec4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablepb18fyvuax@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:21 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablepb18fyvuax@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:22 +] "GET 
/api/atlas/entities/72eaf8f6-ab20-4d1b-aef7-def5d65c5ed6 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablepb18fyvuax@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablepb18fyvuax@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablepb18fyvuax@primary:1475621415000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablepb18fyvuax@primary:1475621415000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities/478cbfb2-e297-4857-90c8-7824cbb1cd2c HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities/72eaf8f6-ab20-4d1b-aef7-def5d65c5ed6 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities/aa23b652-0e74-45ae-ba6a-210573e85ec4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:24 +] "GET 
/api/atlas/entities/aa23b652-0e74-45ae-ba6a-210573e85ec4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablepb18fyvuax@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablepb18fyvuax@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablepb18fyvuax@primary:1475621415000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablepb18fyvuax@primary:1475621415000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities/478cbfb2-e297-4857-90c8-7824cbb1cd2c HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities/72eaf8f6-ab20-4d1b-aef7-def5d65c5ed6 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities/1a4ca57d-b83d-4b74-9a9e-c48ae00f98a3 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 
/api/atlas/entities/aa23b652-0e74-45ae-ba6a-210573e85ec4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:22:50:27 +] "GET 

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review151403
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 (line 356)


can remove propertyname and get it from PropertyKey everywhere?


- Suma Shivaprasad


On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated Oct. 4, 2016, 1:28 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now an optional Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph) - see 
> repository\pom.xml, other pom.xmls
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used.  See GremlinQuery.scala, 
> GraphPersistenceStrategies.scala
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new optional configuration property
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
> 
> Last rebase: 10/3/2016
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   addons/falcon-bridge/pom.xml 1365bd05a388dc92f7a56c7f7427b5b85f97c7da 
>   addons/hdfs-model/pom.xml 492f39cea085c6e69781e17bcbdbc3a231806df3 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 6993bdb938a6095ca24482e290393eeeb3911bcb 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  ad7a4a5d09d8542a841701dfe04981f65f767c14 
>   addons/sqoop-bridge/pom.xml 8c9d278d43b5979ea1743d10845905c13249f8a6 
>   addons/storm-bridge/pom.xml 12c1208b448d456a923bd7309601174ddb561ba5 
>   catalog/pom.xml 2f58a8f0748de65ab78eab35df6abd2fe7c336af 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
> e7bb505075983371ca12d9bc1d8c6eb240c3d134 
>   distro/src/conf/atlas-application.properties 
> d334600dc5534840409b586157799ef3abf9abf2 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
> dd4b7e614cdd9bf30f957fb6a839d8c60f3e1701 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
>  1bc0fc38c0802897f32260520770a16795474d04 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> 995c5457ac7f807172f367cc8e3348b3a98dd6f3 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
>  41194d34f079842db0d95c73a8b099459f76ff2f 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  c8cd2842ca3090b6bbd384c773b4eb45aff149ce 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  93447495bcf18e9f19df9df68fd1cbe1427fc462 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  e719d306ffe9f68e3ac6f7406baaf60a12390c34 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
>  315ecddb861e1a1be6e0ab9b36fe4c0a52486ae8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java
>  fff6fb79247e7d0615ce83c4cbbd93d1bf8cf29c 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  366cfe131512f36c02f59ad7e969ff94dfb0e12c 
>   
> 

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review151399
---




repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(line 295)


why is this needed? We fixed this earlier by allowing keywords which are 
escaped by quotes ``


- Suma Shivaprasad


On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated Oct. 4, 2016, 1:28 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now an optional Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph) - see 
> repository\pom.xml, other pom.xmls
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used.  See GremlinQuery.scala, 
> GraphPersistenceStrategies.scala
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new optional configuration property
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
> 
> Last rebase: 10/3/2016
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   addons/falcon-bridge/pom.xml 1365bd05a388dc92f7a56c7f7427b5b85f97c7da 
>   addons/hdfs-model/pom.xml 492f39cea085c6e69781e17bcbdbc3a231806df3 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 6993bdb938a6095ca24482e290393eeeb3911bcb 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  ad7a4a5d09d8542a841701dfe04981f65f767c14 
>   addons/sqoop-bridge/pom.xml 8c9d278d43b5979ea1743d10845905c13249f8a6 
>   addons/storm-bridge/pom.xml 12c1208b448d456a923bd7309601174ddb561ba5 
>   catalog/pom.xml 2f58a8f0748de65ab78eab35df6abd2fe7c336af 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
> e7bb505075983371ca12d9bc1d8c6eb240c3d134 
>   distro/src/conf/atlas-application.properties 
> d334600dc5534840409b586157799ef3abf9abf2 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
> dd4b7e614cdd9bf30f957fb6a839d8c60f3e1701 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
>  1bc0fc38c0802897f32260520770a16795474d04 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> 995c5457ac7f807172f367cc8e3348b3a98dd6f3 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
>  41194d34f079842db0d95c73a8b099459f76ff2f 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  c8cd2842ca3090b6bbd384c773b4eb45aff149ce 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  93447495bcf18e9f19df9df68fd1cbe1427fc462 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  e719d306ffe9f68e3ac6f7406baaf60a12390c34 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
>  315ecddb861e1a1be6e0ab9b36fe4c0a52486ae8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java
>  fff6fb79247e7d0615ce83c4cbbd93d1bf8cf29c 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-10-04 Thread Suma Shivaprasad


> On Oct. 4, 2016, 9 p.m., Suma Shivaprasad wrote:
> > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java,
> >  line 130
> > 
> >
> > Does the index here refer to the edgeLabel we are trying to create an 
> > idex for? Do we have everything we need in this interface to index an edge 
> > label?

I see that the index here refers to the indexName and not the edgeLabel. We 
need to provide for indexing edge labels as well even though we dont use that 
currently


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review151393
---


On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated Oct. 4, 2016, 1:28 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now an optional Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph) - see 
> repository\pom.xml, other pom.xmls
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used.  See GremlinQuery.scala, 
> GraphPersistenceStrategies.scala
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new optional configuration property
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
> 
> Last rebase: 10/3/2016
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   addons/falcon-bridge/pom.xml 1365bd05a388dc92f7a56c7f7427b5b85f97c7da 
>   addons/hdfs-model/pom.xml 492f39cea085c6e69781e17bcbdbc3a231806df3 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 6993bdb938a6095ca24482e290393eeeb3911bcb 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  ad7a4a5d09d8542a841701dfe04981f65f767c14 
>   addons/sqoop-bridge/pom.xml 8c9d278d43b5979ea1743d10845905c13249f8a6 
>   addons/storm-bridge/pom.xml 12c1208b448d456a923bd7309601174ddb561ba5 
>   catalog/pom.xml 2f58a8f0748de65ab78eab35df6abd2fe7c336af 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
> e7bb505075983371ca12d9bc1d8c6eb240c3d134 
>   distro/src/conf/atlas-application.properties 
> d334600dc5534840409b586157799ef3abf9abf2 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
> dd4b7e614cdd9bf30f957fb6a839d8c60f3e1701 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
>  1bc0fc38c0802897f32260520770a16795474d04 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> 995c5457ac7f807172f367cc8e3348b3a98dd6f3 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
>  41194d34f079842db0d95c73a8b099459f76ff2f 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  c8cd2842ca3090b6bbd384c773b4eb45aff149ce 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  93447495bcf18e9f19df9df68fd1cbe1427fc462 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  e719d306ffe9f68e3ac6f7406baaf60a12390c34 
>   
> 

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review151396
---




graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 (line 78)


can we change the vararg to a List everywhee to keep it consistent?


- Suma Shivaprasad


On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated Oct. 4, 2016, 1:28 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now an optional Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph) - see 
> repository\pom.xml, other pom.xmls
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used.  See GremlinQuery.scala, 
> GraphPersistenceStrategies.scala
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new optional configuration property
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
> 
> Last rebase: 10/3/2016
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   addons/falcon-bridge/pom.xml 1365bd05a388dc92f7a56c7f7427b5b85f97c7da 
>   addons/hdfs-model/pom.xml 492f39cea085c6e69781e17bcbdbc3a231806df3 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 6993bdb938a6095ca24482e290393eeeb3911bcb 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  ad7a4a5d09d8542a841701dfe04981f65f767c14 
>   addons/sqoop-bridge/pom.xml 8c9d278d43b5979ea1743d10845905c13249f8a6 
>   addons/storm-bridge/pom.xml 12c1208b448d456a923bd7309601174ddb561ba5 
>   catalog/pom.xml 2f58a8f0748de65ab78eab35df6abd2fe7c336af 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
> e7bb505075983371ca12d9bc1d8c6eb240c3d134 
>   distro/src/conf/atlas-application.properties 
> d334600dc5534840409b586157799ef3abf9abf2 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
> dd4b7e614cdd9bf30f957fb6a839d8c60f3e1701 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
>  1bc0fc38c0802897f32260520770a16795474d04 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> 995c5457ac7f807172f367cc8e3348b3a98dd6f3 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
>  41194d34f079842db0d95c73a8b099459f76ff2f 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  c8cd2842ca3090b6bbd384c773b4eb45aff149ce 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  93447495bcf18e9f19df9df68fd1cbe1427fc462 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  e719d306ffe9f68e3ac6f7406baaf60a12390c34 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
>  315ecddb861e1a1be6e0ab9b36fe4c0a52486ae8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java
>  fff6fb79247e7d0615ce83c4cbbd93d1bf8cf29c 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  366cfe131512f36c02f59ad7e969ff94dfb0e12c 
>   
> 

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-10-04 Thread Suma Shivaprasad


> On Sept. 23, 2016, 8:36 p.m., Suma Shivaprasad wrote:
> > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java,
> >  line 188
> > 
> >
> > can rename this to clear instead of removeTestGraph?
> > Also initializeTestGraph can be removed for now?
> 
> Jeff Hagelberg wrote:
> I suppose we could remove it.  I was trying to make the interfaces as 
> close as possible to what we have in our fork, and this method is used by the 
> other implementations.  I guess I missed this comment in my last round of 
> testing and rebasing.  Would cleanupTestGraph be ok as a name?  The issue is 
> that the cleanup mechanism is actually specific to the graph database.  Titan 
> clears the graph.  However, in IBM Graph, clearing the graph is not allowed, 
> so we actually remove it, and initializeTestGraph sets things up so that a 
> new graph gets created for each test class.  Let's see what comments my 
> latest changes get.  I'll put this in while addressing those, assuming there 
> are some :-).
> 
> Jeff Hagelberg wrote:
> or maybe just cleanup()

yes am okay with cleanup. Could we have an initiliaze method for all graphs 
instead that can be used for tests to setup the graph and for non-tests/prod 
deployments may be empty impl if nothing is required?


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review150231
---


On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated Oct. 4, 2016, 1:28 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now an optional Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph) - see 
> repository\pom.xml, other pom.xmls
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used.  See GremlinQuery.scala, 
> GraphPersistenceStrategies.scala
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new optional configuration property
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
> 
> Last rebase: 10/3/2016
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   addons/falcon-bridge/pom.xml 1365bd05a388dc92f7a56c7f7427b5b85f97c7da 
>   addons/hdfs-model/pom.xml 492f39cea085c6e69781e17bcbdbc3a231806df3 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 6993bdb938a6095ca24482e290393eeeb3911bcb 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  ad7a4a5d09d8542a841701dfe04981f65f767c14 
>   addons/sqoop-bridge/pom.xml 8c9d278d43b5979ea1743d10845905c13249f8a6 
>   addons/storm-bridge/pom.xml 12c1208b448d456a923bd7309601174ddb561ba5 
>   catalog/pom.xml 2f58a8f0748de65ab78eab35df6abd2fe7c336af 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
> e7bb505075983371ca12d9bc1d8c6eb240c3d134 
>   distro/src/conf/atlas-application.properties 
> d334600dc5534840409b586157799ef3abf9abf2 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
> dd4b7e614cdd9bf30f957fb6a839d8c60f3e1701 
>   
> 

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review151393
---




graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 (line 111)


Does the index here refer to the edgeLabel we are trying to create an idex 
for? Do we have everything we need in this interface to index an edge label?


- Suma Shivaprasad


On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated Oct. 4, 2016, 1:28 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now an optional Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph) - see 
> repository\pom.xml, other pom.xmls
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used.  See GremlinQuery.scala, 
> GraphPersistenceStrategies.scala
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new optional configuration property
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
> 
> Last rebase: 10/3/2016
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   addons/falcon-bridge/pom.xml 1365bd05a388dc92f7a56c7f7427b5b85f97c7da 
>   addons/hdfs-model/pom.xml 492f39cea085c6e69781e17bcbdbc3a231806df3 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 6993bdb938a6095ca24482e290393eeeb3911bcb 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  ad7a4a5d09d8542a841701dfe04981f65f767c14 
>   addons/sqoop-bridge/pom.xml 8c9d278d43b5979ea1743d10845905c13249f8a6 
>   addons/storm-bridge/pom.xml 12c1208b448d456a923bd7309601174ddb561ba5 
>   catalog/pom.xml 2f58a8f0748de65ab78eab35df6abd2fe7c336af 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
> e7bb505075983371ca12d9bc1d8c6eb240c3d134 
>   distro/src/conf/atlas-application.properties 
> d334600dc5534840409b586157799ef3abf9abf2 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
> dd4b7e614cdd9bf30f957fb6a839d8c60f3e1701 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
>  1bc0fc38c0802897f32260520770a16795474d04 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> 995c5457ac7f807172f367cc8e3348b3a98dd6f3 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
>  41194d34f079842db0d95c73a8b099459f76ff2f 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  c8cd2842ca3090b6bbd384c773b4eb45aff149ce 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  93447495bcf18e9f19df9df68fd1cbe1427fc462 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  e719d306ffe9f68e3ac6f7406baaf60a12390c34 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
>  315ecddb861e1a1be6e0ab9b36fe4c0a52486ae8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java
>  fff6fb79247e7d0615ce83c4cbbd93d1bf8cf29c 
>   
> 

Build failed in Jenkins: apache-atlas-nightly #435

2016-10-04 Thread Apache Jenkins Server
See 

Changes:

[sumasai.shivaprasad] ATLAS-1206 Atlas UI not working with IE or Chrome on 
Windows OS in

--
[...truncated 9411 lines...]
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities/85cee210-0214-49c7-8cfe-14245f25cfe4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities/c0e725dd-416f-41d5-9734-532de61c2d2e HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities/a55903fd-bd1d-48ae-b7b2-4a57422f20c4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities/a55903fd-bd1d-48ae-b7b2-4a57422f20c4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewpahrpouy5@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewpahrpouy5@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:23 +] "GET 
/api/atlas/entities/c0e725dd-416f-41d5-9734-532de61c2d2e HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewpahrpouy5@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewpahrpouy5@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewpahrpouy5@primary:1475610376000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewpahrpouy5@primary:1475610376000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities/85cee210-0214-49c7-8cfe-14245f25cfe4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities/c0e725dd-416f-41d5-9734-532de61c2d2e HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities/a55903fd-bd1d-48ae-b7b2-4a57422f20c4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:25 +] "GET 
/api/atlas/entities/a55903fd-bd1d-48ae-b7b2-4a57422f20c4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewpahrpouy5@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewpahrpouy5@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewpahrpouy5@primary:1475610376000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewpahrpouy5@primary:1475610376000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities/85cee210-0214-49c7-8cfe-14245f25cfe4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities/c0e725dd-416f-41d5-9734-532de61c2d2e HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities/93910cf8-6baf-4078-a9dd-897d06db0619 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 
/api/atlas/entities/a55903fd-bd1d-48ae-b7b2-4a57422f20c4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:19:46:28 +] "GET 

Re: Review Request 52478: ATLAS-1171: updated APIs that return list to use REST serialization friendly list classes

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52478/#review151369
---


Ship it!




Ship It!

- Suma Shivaprasad


On Oct. 3, 2016, 4:39 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52478/
> ---
> 
> (Updated Oct. 3, 2016, 4:39 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated APIs that return list to use REST serialization friendly list 
> classes: replaced PList with type specific list class
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 69b02b9 
>   intg/src/main/java/org/apache/atlas/api/AtlasApiTypes.java 6950406 
>   intg/src/main/java/org/apache/atlas/api/PList.java c6a3025 
>   intg/src/main/java/org/apache/atlas/api/SearchFilter.java f9235ad 
>   intg/src/main/java/org/apache/atlas/model/PList.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> 2f034d4 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java e1d7bc6 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> 6936cdc 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java cfe4938 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> d40354c 
>   
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
> f0188d9 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> aaa2bac 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 5347461 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> af42c05 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 42cfd42 
> 
> Diff: https://reviews.apache.org/r/52478/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 52257: Return system attributes in get entity definition

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151364
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 (line 295)


can we add asserts in getEntityDefintion for these props?


- Suma Shivaprasad


On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> ---
> 
> (Updated Oct. 4, 2016, 11:13 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 
> 2f52b3b 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
> 92f98c6 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea46 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java
>  25aa7c5 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 
> 42280d0 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
>  73b3526 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala
>  68c47ec 
>   
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala
>  9e656a5 
> 
> Diff: https://reviews.apache.org/r/52257/diff/
> 
> 
> Testing
> ---
> 
> Testing done with Hive table creation and updation
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>



Re: Review Request 52257: Return system attributes in get entity definition

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151362
---




typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java (line 
54)


sorry didnt notice  this earlier. Didnt get why these were added as part of 
the Id?  They dont uniquely identify an entity and should not go into the Id 
IMO.


- Suma Shivaprasad


On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> ---
> 
> (Updated Oct. 4, 2016, 11:13 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 
> 2f52b3b 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
> 92f98c6 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea46 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java
>  25aa7c5 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 
> 42280d0 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
>  73b3526 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala
>  68c47ec 
>   
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala
>  9e656a5 
> 
> Diff: https://reviews.apache.org/r/52257/diff/
> 
> 
> Testing
> ---
> 
> Testing done with Hive table creation and updation
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>



Re: Review Request 52257: Return system attributes in get entity definition

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151360
---




typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala
 (line 94)


can we add valid date data in the tests? Also can you add a test for these 
keys in GraphBackedDiscoveryServiceTest.


- Suma Shivaprasad


On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> ---
> 
> (Updated Oct. 4, 2016, 11:13 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 
> 2f52b3b 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
> 92f98c6 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea46 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java
>  25aa7c5 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 
> 42280d0 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
>  73b3526 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala
>  68c47ec 
>   
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala
>  9e656a5 
> 
> Diff: https://reviews.apache.org/r/52257/diff/
> 
> 
> Testing
> ---
> 
> Testing done with Hive table creation and updation
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>



Re: Review Request 52257: Return system attributes in get entity definition

2016-10-04 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151357
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 (line 239)


Dont see any indexes created on these properties in GraphbackedSearchIndexer


- Suma Shivaprasad


On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> ---
> 
> (Updated Oct. 4, 2016, 11:13 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 
> 2f52b3b 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
> 92f98c6 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea46 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java
>  25aa7c5 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 
> 42280d0 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
>  73b3526 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala
>  68c47ec 
>   
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala
>  9e656a5 
> 
> Diff: https://reviews.apache.org/r/52257/diff/
> 
> 
> Testing
> ---
> 
> Testing done with Hive table creation and updation
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>



Re: Rename trait to classification

2016-10-04 Thread Nigel Jones

On 03/10/2016 11:35, David Radley wrote:


I am not sure I follow your first point. The classification hierarchy I
was thinking of is the classification scheme, which is not flat. Maybe we


* I'll try to clarify... Mandy pointed out in an earlier message that 
classifications may be ordered (for example going from unclassified to 
top secret) as well as contain subclassifications (the 
confidential/personal confidential example). We've not discussed 
ordering yet, but in a policy deployed in ranger I'd like to be 
logically able to have a condition like "confidentiality >= 
Confidential". Whilst this could be done (fudged?) with the name, or in 
the rule using "confidentiality in 
('Confidential','Sensitive','Restricted','Top Secret'), if the order is 
frequently used we need to add the notion of ordering to make rules 
easier to develop. See also my point below about flattening.. purely as 
an interim measure.




should consider leaving term classification and term classification
inheritance to a follow on Jira.


Agreed - I will open a new jira for my concern, though I was referring 
to classifications rather than business terms.


On another point, you refer in your proposal summary "top level elements 
like entity and terms" - but terms are implemented as traits today, 
whilst entities are .. entities.  I think we're suggesting 
classifications are also implemented as a specialization of annotations 
and thus as traits, so can traits have traits? - my familiarity with the 
data model/api isnt' developed enough yet... The distinction between 
entities and traits is getting more blurred - mostly it's the easy 
association & lack of guid yet in many ways terms may need to become 
first class entities in their own right?




I agree that changing the existing Ranger tags to sync with Atlas
classifications makes sense to not break existing Ranger integration.



Agreed - I suggest that the initial approach focusses on getting the 
model/api right in atlas, whilst considering that these classifications 
need to be used flexibly at the point of data access. Ranger initially 
preserves the simple "tag" approach used today (and must be part of any 
change in this area to avoid breakage) - perhaps flattening & label 
modification, and another JIRA is then opened (first here, then ranger) 
to explore better ways of providing more flexibility in the rules later.


Additionally:

 * Annotations - David you mentioned we may not wish to police 
uniqueness of annotations. In the existing implementation the name of a 
trait is unique. I think we would want to keep unique names, even for 
ad-hoc annotations - though to adopt a fully social model including 
commenting, voting we may also have to consider visibility of the 
annotations themselves (I'd be inclined to keep it simple though). I 
propose we open a social features JIRA to continue that longer termed 
discussion.


 * update the docs/wiki to add definitions for entity, term, 
classification, annotation, trait, classification, classification 
scheme, classification hierarchy etc. This could also be a sub-JIRA?


Nigel.




[jira] [Created] (ATLAS-1209) Hive Hook does a full update of related entities

2016-10-04 Thread Vimal Sharma (JIRA)
Vimal Sharma created ATLAS-1209:
---

 Summary: Hive Hook does a full update of related entities
 Key: ATLAS-1209
 URL: https://issues.apache.org/jira/browse/ATLAS-1209
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma


Currently, whenever a change is made to Hive table(column addition, rename), 
all the entities associated with the operation(DB, Table, Columns) are fully 
updated even if there is no change in some entities. The reason this is done is 
to make sure that we have the latest correct information about the entity as 
changes can be performed on Hive Metastore by clients where Atlas Hook is not 
installed(JDBC client). 

The changes should be detected on Atlas server side and only if there is a 
change, update should be performed on the entity



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 52257: Return system attributes in get entity definition

2016-10-04 Thread Vimal Sharma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/
---

(Updated Oct. 4, 2016, 11:13 a.m.)


Review request for atlas.


Changes
---

Updated the patch and addressed Shweta's and Suma's comments


Bugs: ATLAS-916
https://issues.apache.org/jira/browse/ATLAS-916


Repository: atlas


Description
---

Atlas should maintain system attributes created time, last modified time, 
created by user and last modified by user for every entity. This information 
should be returned in get entity definition


Diffs (updated)
-

  catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 
2f52b3b 
  common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0 
  repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
92f98c6 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 263ea46 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
1ce87c9 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
 5c7cb2e 
  
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java
 25aa7c5 
  
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
 2e0414e 
  typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 
42280d0 
  
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
 73b3526 
  
typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 
68c47ec 
  
typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala
 9e656a5 

Diff: https://reviews.apache.org/r/52257/diff/


Testing (updated)
---

Testing done with Hive table creation and updation


Thanks,

Vimal Sharma



[jira] [Updated] (ATLAS-916) Return system attributes in get entity definition

2016-10-04 Thread Vimal Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-916:
---
Attachment: ATLAS-916-v2.patch

> Return system attributes in get entity definition
> -
>
> Key: ATLAS-916
> URL: https://issues.apache.org/jira/browse/ATLAS-916
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Shwetha G S
>Assignee: Vimal Sharma
> Attachments: ATLAS-916-v2.patch, ATLAS-916.patch
>
>
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1208) DSL query optimisation

2016-10-04 Thread Shwetha G S (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-1208:
---
Assignee: (was: Shwetha G S)

> DSL query optimisation
> --
>
> Key: ATLAS-1208
> URL: https://issues.apache.org/jira/browse/ATLAS-1208
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sharmadha Sainath
> Fix For: 0.8-incubating
>
>
> DSL queries always have the type. The DSL query is transformed into gremlin 
> of the form: {{g.V().has(type, ).has(name, )}}. This is not 
> efficient as the first has clause returns many vertices. Instead, if we 
> generate the gremlin query as {{g.V().has(name, ).has(type, )}}, 
> the query should execute faster as the first predicate will filter more 
> vertices



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: apache-atlas-nightly #434

2016-10-04 Thread Apache Jenkins Server
See 

Changes:

[sshivalingamurthy] ATLAS-1205 Improve atlas build time (shwethags)

--
[...truncated 9525 lines...]
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities/9b1dec83-f41b-40e5-8ccc-dfb1f350985b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities/ebf19acf-f667-4104-8355-91fe821d9b5d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities/bbc49c34-19cf-4f79-961b-5c2857c4d4ab HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities/bbc49c34-19cf-4f79-961b-5c2857c4d4ab HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableptltpraiwt@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableptltpraiwt@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:37 +] "GET 
/api/atlas/entities/ebf19acf-f667-4104-8355-91fe821d9b5d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableptltpraiwt@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableptltpraiwt@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableptltpraiwt@primary:1475577451000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableptltpraiwt@primary:1475577451000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities/9b1dec83-f41b-40e5-8ccc-dfb1f350985b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities/ebf19acf-f667-4104-8355-91fe821d9b5d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities/bbc49c34-19cf-4f79-961b-5c2857c4d4ab HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:40 +] "GET 
/api/atlas/entities/bbc49c34-19cf-4f79-961b-5c2857c4d4ab HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableptltpraiwt@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableptltpraiwt@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableptltpraiwt@primary:1475577451000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableptltpraiwt@primary:1475577451000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities/9b1dec83-f41b-40e5-8ccc-dfb1f350985b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities/ebf19acf-f667-4104-8355-91fe821d9b5d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities/147cdcf5-e6f3-48ab-b317-234fe0162f48 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 
/api/atlas/entities/bbc49c34-19cf-4f79-961b-5c2857c4d4ab HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [04/Oct/2016:10:37:42 +] "GET 

[jira] [Created] (ATLAS-1208) DSL query optimisation

2016-10-04 Thread Shwetha G S (JIRA)
Shwetha G S created ATLAS-1208:
--

 Summary: DSL query optimisation
 Key: ATLAS-1208
 URL: https://issues.apache.org/jira/browse/ATLAS-1208
 Project: Atlas
  Issue Type: Bug
Reporter: Sharmadha Sainath
 Fix For: 0.8-incubating


DSL queries always have the type. The DSL query is transformed into gremlin of 
the form: {{g.V().has(type, ).has(name, )}}. This is not efficient 
as the first has clause returns many vertices. Instead, if we generate the 
gremlin query as {{g.V().has(name, ).has(type, )}}, the query 
should execute faster as the first predicate will filter more vertices



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-1207) Dataset exists query in lineage APIs takes longer

2016-10-04 Thread Shwetha G S (JIRA)
Shwetha G S created ATLAS-1207:
--

 Summary: Dataset exists query in lineage APIs takes longer
 Key: ATLAS-1207
 URL: https://issues.apache.org/jira/browse/ATLAS-1207
 Project: Atlas
  Issue Type: Bug
Reporter: Sharmadha Sainath
Assignee: Shwetha G S
 Fix For: 0.8-incubating


Hive_column now extends DataSet. Lineage Service uses the DSL query Dataset 
where __guid =  which maps to the gremlin query g.V().has(supertype, 
Dataset).has(__guid, ). Since the first filter is on type which returns 
many vertices, this query is slow. Supertypes is a list property and not sure 
how adding combined index will work. This can be replaced with graph query 
directly like 
{code}
titanGraph.query().has(Constants.GUID_PROPERTY_KEY, guid)
  .has(Constants.SUPER_TYPES_PROPERTY_KEY, 
AtlasClient.DATA_SET_SUPER_TYPE)
{code}

Thanks [~ssainath] for helping to test this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1206) Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.

2016-10-04 Thread Nixon Rodrigues (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-1206:
---
Attachment: ATLAS-1206.patch

> Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.
> --
>
> Key: ATLAS-1206
> URL: https://issues.apache.org/jira/browse/ATLAS-1206
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1206.patch
>
>
> Atlas UI works in Firefox browser and NOT with IE or Chrome on Windows OS in 
> Kerberos mode.
> Error:-
> HTTP ERROR 403
> Problem accessing /index.html. Reason:
> GSSException: Defective token detected (Mechanism level: GSSHeader did not 
> find the right tag)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 52509: ATLAS-1206 - Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.

2016-10-04 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52509/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Shwetha GS, and Suma 
Shivaprasad.


Bugs: ATLAS-1206
https://issues.apache.org/jira/browse/ATLAS-1206


Repository: atlas


Description
---

ATLAS-1206 - Atlas UI not working with IE or Chrome on Windows OS in Kerberos 
mode. Its giving error Error:-
HTTP ERROR 403
Problem accessing /index.html. Reason:
GSSException: Defective token detected (Mechanism level: GSSHeader did not find 
the right tag)

This patch fix the above issue by making a check for existingAuth from 
springcontext, so that next request dont go for kerberos authentication flow.
Also this patch consist fix for non-kerberized browser's first request hanging 
issue by making isBrowser check.


Diffs
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 605fe89 

Diff: https://reviews.apache.org/r/52509/diff/


Testing
---

Tested Atlas in following scenario's

* Tested UI in FireFox, Chrome (Linux) / Firefox , Chrome ,IE9 campatiblity 
view in Windows OS.

* Tested Hive Import with kinit on kerberized cluster and on simple cluster

* Created Hive tables from beeline client with kinit on kerberized cluster and 
on simple cluster and metadata reflecting in Atlas UI.

* Run Quick start with kinit from atlas user on kerberized cluster and on 
simple cluster.

* Executed Curl commands with kinit on kerberized cluster and without kinit on 
simple cluster

* Ran Unit test cases.

Instance urls
https://172.22.67.45:21443/ [kerberos]

http://172.22.86.213:21000 [simple]


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-1206) Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.

2016-10-04 Thread Nixon Rodrigues (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-1206:
---
Affects Version/s: 0.7-incubating

> Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.
> --
>
> Key: ATLAS-1206
> URL: https://issues.apache.org/jira/browse/ATLAS-1206
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
> Fix For: 0.8-incubating
>
>
> Atlas UI works in Firefox browser and NOT with IE or Chrome on Windows OS in 
> Kerberos mode.
> Error:-
> HTTP ERROR 403
> Problem accessing /index.html. Reason:
> GSSException: Defective token detected (Mechanism level: GSSHeader did not 
> find the right tag)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1206) Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.

2016-10-04 Thread Nixon Rodrigues (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-1206:
---
Fix Version/s: (was: 0.7-incubating)

> Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.
> --
>
> Key: ATLAS-1206
> URL: https://issues.apache.org/jira/browse/ATLAS-1206
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
> Fix For: 0.8-incubating
>
>
> Atlas UI works in Firefox browser and NOT with IE or Chrome on Windows OS in 
> Kerberos mode.
> Error:-
> HTTP ERROR 403
> Problem accessing /index.html. Reason:
> GSSException: Defective token detected (Mechanism level: GSSHeader did not 
> find the right tag)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-1206) Atlas UI not working with IE or Chrome on Windows OS in Kerberos mode.

2016-10-04 Thread Nixon Rodrigues (JIRA)
Nixon Rodrigues created ATLAS-1206:
--

 Summary: Atlas UI not working with IE or Chrome on Windows OS in 
Kerberos mode.
 Key: ATLAS-1206
 URL: https://issues.apache.org/jira/browse/ATLAS-1206
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues
 Fix For: 0.7-incubating, 0.8-incubating


Atlas UI works in Firefox browser and NOT with IE or Chrome on Windows OS in 
Kerberos mode.

Error:-
HTTP ERROR 403
Problem accessing /index.html. Reason:
GSSException: Defective token detected (Mechanism level: GSSHeader did not find 
the right tag)






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)