Re: Review Request 52585: Implementation of the new TypesREST API

2016-10-06 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52585/
---

(Updated Oct. 7, 2016, 5:58 a.m.)


Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha 
GS, and Suma Shivaprasad.


Repository: atlas


Description (updated)
---

TypesREST implementation

TODO: Add type validation before storing in the Graph


Diffs
-

  .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
a3fdbcc025bf5f56e7770015d55616ec83d2be64 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
096f061f16bba3ecb886d00ec66c98ad17c1e243 
  repository/pom.xml 7a34331ce2876d9d9e916f96f1141d3efa91e959 
  
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 
b342e2700d454b0d6fba595b5cc01cd0e06bbdac 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 263ea465fda0b445a952943def9a6f7c49834f25 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
1ce87c9d306faa43fb9d3fdc491c4bcbdd7b2bdb 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
 5c7cb2e8fa32b540f80beed40fb4f25a89d39c56 
  
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
 2e0414e2cee7ca3d5958650ac6abc8a290473545 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasClassificationDefMapper.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEntityDefMapper.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEnumDefMapper.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasStructDefMapper.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/factory/AtlasMapperFactory.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasClassificationDefMapperV1.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEntityDefMapperV1.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEnumDefMapperV1.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasStructDefMapperV1.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/instance/AbstractInstanceStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/instance/AtlasInstanceStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/instance/ClassificationStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/instance/EntityStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/instance/StructStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/typedef/AbstractAtlasStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/typedef/AtlasTypeDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/typedef/ClassificationDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/typedef/EntityDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/typedef/EnumDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/typedef/StructDefStore.java
 PRE-CREATION 
  webapp/pom.xml 8fe4b9bed7efefdcc623df2f8e9cfa6ef84d8514 
  webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 
a1d3187cea0422988500195191de37732c7df56f 
  webapp/src/main/java/org/apache/atlas/web/rest/InstancesREST.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/RestModule.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 
429df65a86aba1f5a40875e1554d09ec238fb9d2 
  webapp/src/main/resources/errorMessages.properties PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 
e2a85e9865e52cc86cf385eae1dd6f0e95687a8e 

Diff: https://reviews.apache.org/r/52585/diff/


Testing
---


Thanks,

Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

2016-10-06 Thread Apoorv Naik 


> On Oct. 7, 2016, 5:51 a.m., Shwetha GS wrote:
> > The jira mentioned in this request ATLAS-1098 is a different resolved bug. 
> > Can you create a new jira and link this request there?

Will do.


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52585/#review151761
---


On Oct. 6, 2016, 12:45 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52585/
> ---
> 
> (Updated Oct. 6, 2016, 12:45 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha 
> GS, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> TypesREST implementation
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> a3fdbcc025bf5f56e7770015d55616ec83d2be64 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 096f061f16bba3ecb886d00ec66c98ad17c1e243 
>   repository/pom.xml 7a34331ce2876d9d9e916f96f1141d3efa91e959 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java
>  b342e2700d454b0d6fba595b5cc01cd0e06bbdac 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea465fda0b445a952943def9a6f7c49834f25 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9d306faa43fb9d3fdc491c4bcbdd7b2bdb 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e8fa32b540f80beed40fb4f25a89d39c56 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e2cee7ca3d5958650ac6abc8a290473545 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasClassificationDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEntityDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEnumDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasStructDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/factory/AtlasMapperFactory.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasClassificationDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEntityDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEnumDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasStructDefMapperV1.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AbstractInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AtlasInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/ClassificationStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/EntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/StructStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AbstractAtlasStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AtlasTypeDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/ClassificationDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EntityDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EnumDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/StructDefStore.java
>  PRE-CREATION 
>   webapp/pom.xml 8fe4b9bed7efefdcc623df2f8e9cfa6ef84d8514 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 
> a1d3187cea0422988500195191de37732c7df56f 
>   webapp/src/main/java/org/apache/atlas/web/rest/InstancesREST.java 
> PRE-CREATION 
>

Re: Review Request 52585: Implementation of the new TypesREST API

2016-10-06 Thread Shwetha GS 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52585/#review151761
---



The jira mentioned in this request ATLAS-1098 is a different resolved bug. Can 
you create a new jira and link this request there?

- Shwetha GS


On Oct. 6, 2016, 12:45 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52585/
> ---
> 
> (Updated Oct. 6, 2016, 12:45 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha 
> GS, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> TypesREST implementation
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> a3fdbcc025bf5f56e7770015d55616ec83d2be64 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 096f061f16bba3ecb886d00ec66c98ad17c1e243 
>   repository/pom.xml 7a34331ce2876d9d9e916f96f1141d3efa91e959 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java
>  b342e2700d454b0d6fba595b5cc01cd0e06bbdac 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea465fda0b445a952943def9a6f7c49834f25 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9d306faa43fb9d3fdc491c4bcbdd7b2bdb 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e8fa32b540f80beed40fb4f25a89d39c56 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e2cee7ca3d5958650ac6abc8a290473545 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasClassificationDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEntityDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEnumDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasStructDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/factory/AtlasMapperFactory.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasClassificationDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEntityDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEnumDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasStructDefMapperV1.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AbstractInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AtlasInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/ClassificationStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/EntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/StructStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AbstractAtlasStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AtlasTypeDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/ClassificationDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EntityDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EnumDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/StructDefStore.java
>  PRE-CREATION 
>   webapp/pom.xml 8fe4b9bed7efefdcc623df2f8e9cfa6ef84d8514 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 
> a1d3187cea0422988500195191de37732c7df56f 
>   webapp/src/main/java/org/apache/atlas/web/rest/InstancesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/RestModule.java PRE-CREATION 
>

[jira] [Commented] (ATLAS-1182) Hive Column level lineage docs

2016-10-06 Thread Shwetha G S (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554214#comment-15554214
 ] 

Shwetha G S commented on ATLAS-1182:


Can you also add details of hive version that column level lineage works with 
(hive 1.2.x + hive patch)?

> Hive Column level lineage docs
> --
>
> Key: ATLAS-1182
> URL: https://issues.apache.org/jira/browse/ATLAS-1182
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1182.patch, column_lineage_ex1.png
>
>
> Add column level lineage details to Atlas documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-06 Thread Sarath Kumar Subramanian 


> On Oct. 5, 2016, 11:51 p.m., Shwetha GS wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java,
> >  line 232
> > 
> >
> > This is a minor backward compatible change. We should set it to 1.1

you are right, this is not a major change, updated version to 1.1. Thanks


- Sarath Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151632
---


On Oct. 6, 2016, 10:29 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 6, 2016, 10:29 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml 53b034f 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-06 Thread Sarath Kumar Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/
---

(Updated Oct. 6, 2016, 10:29 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Changes
---

made the new version to be 1.1 since its not a API breaking change and its 
minor and backward compatible


Bugs: ATLAS-1210
https://issues.apache.org/jira/browse/ATLAS-1210


Repository: atlas


Description
---

for clients who have not updated to latest code, this patch adds the "position" 
attribute to hive_column type and updates version to 2.0


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 28078f4 
  distro/src/main/assemblies/standalone-package.xml 53b034f 
  
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
c269c3a 
  src/main/patches/001-hive_column_add_position.json PRE-CREATION 

Diff: https://reviews.apache.org/r/52533/diff/


Testing
---

on older builds - updates the type by adding new attribute and updates version 
to 2.0
new builds - ignore the patch since version is already in 2.0


Thanks,

Sarath Kumar Subramanian

Re: Review Request 52585: Implementation of the new TypesREST API

2016-10-06 Thread Apoorv Naik 


> On Oct. 6, 2016, 4:33 p.m., Sarath Kumar Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java, 
> > line 36
> > 
> >
> > method names are too generic - create(), update(), delete(). This 
> > interface is used to implement types and instances, can rename to something 
> > relevant - createAtlasObject or something better.

Was trying to model it like spring data. 
http://docs.spring.io/spring-data/jpa/docs/1.11.0.M1/api/


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52585/#review151673
---


On Oct. 6, 2016, 12:45 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52585/
> ---
> 
> (Updated Oct. 6, 2016, 12:45 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha 
> GS, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> TypesREST implementation
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> a3fdbcc025bf5f56e7770015d55616ec83d2be64 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 096f061f16bba3ecb886d00ec66c98ad17c1e243 
>   repository/pom.xml 7a34331ce2876d9d9e916f96f1141d3efa91e959 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java
>  b342e2700d454b0d6fba595b5cc01cd0e06bbdac 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea465fda0b445a952943def9a6f7c49834f25 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9d306faa43fb9d3fdc491c4bcbdd7b2bdb 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e8fa32b540f80beed40fb4f25a89d39c56 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e2cee7ca3d5958650ac6abc8a290473545 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasClassificationDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEntityDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEnumDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasStructDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/factory/AtlasMapperFactory.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasClassificationDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEntityDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEnumDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasStructDefMapperV1.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AbstractInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AtlasInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/ClassificationStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/EntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/StructStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AbstractAtlasStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AtlasTypeDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/ClassificationDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EntityDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EnumDefStore.java
>  PRE-CREATION 
>   
>

Re: Review Request 52585: Implementation of the new TypesREST API

2016-10-06 Thread Sarath Kumar Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52585/#review151673
---




repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java 
(line 36)


method names are too generic - create(), update(), delete(). This interface 
is used to implement types and instances, can rename to something relevant - 
createAtlasObject or something better.


- Sarath Kumar Subramanian


On Oct. 5, 2016, 5:45 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52585/
> ---
> 
> (Updated Oct. 5, 2016, 5:45 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha 
> GS, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> TypesREST implementation
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> a3fdbcc025bf5f56e7770015d55616ec83d2be64 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 096f061f16bba3ecb886d00ec66c98ad17c1e243 
>   repository/pom.xml 7a34331ce2876d9d9e916f96f1141d3efa91e959 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java
>  b342e2700d454b0d6fba595b5cc01cd0e06bbdac 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  263ea465fda0b445a952943def9a6f7c49834f25 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ce87c9d306faa43fb9d3fdc491c4bcbdd7b2bdb 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  5c7cb2e8fa32b540f80beed40fb4f25a89d39c56 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  2e0414e2cee7ca3d5958650ac6abc8a290473545 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasClassificationDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEntityDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEnumDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasStructDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/factory/AtlasMapperFactory.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasClassificationDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEntityDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEnumDefMapperV1.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasStructDefMapperV1.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AbstractInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/AtlasInstanceStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/ClassificationStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/EntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/instance/StructStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AbstractAtlasStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/AtlasTypeDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/ClassificationDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EntityDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/EnumDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/typedef/StructDefStore.java
>  PRE-CREATION 
>   webapp/pom.xml 8fe4b9bed7efefdcc623df2f8e9cfa6ef84d8514 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 
>

Re: Rename trait to classification

2016-10-06 Thread David Radley 
Hi,
Great points Nigel!

I am looking to have a small checkin that does not impede the sort of 
enhancements you are talking of. 

Responding in order:

My thought was that we would use classification categories. Maybe one way 
to introduce ordering would be to have a 'has ordered children' flag on 
the category or a Ordered List container; then the children 
classifications would be expected to have a pointer to the next higher 
classification. If sub classification is important, it might be 
implemented using child categories, applying more than one simple 
classification or introducing inheritance classification.  My suggestion 
would be to deal with this in a follow on Jira to address a particular use 
case.. 

I see terms as top level elements in the current code because:
- there is a top level ResourceDefinition for Term at the same level as 
entity , taxonomy , tag etc. 
- the taxonomy API that returns terms as top level object. 
Internally terms do create a trait type and a trait instance. The traits 
are exposed in the API when an entity has a trait, which is what it knows 
the term as (maybe we could think of this in uml terms as an entity class, 
which has an attribute called trait of type term).  It seems to me that we 
could view a term as a semantic classification; so we could rename traits 
to classifications in the entity API. We do need to be able to apply 
governance classifications to terms; maybe not in the this initial Jira. 

If we police the uniqueness of classification names and existing traits 
are treated as classifications, that should be fine for migration use 
cases. If we then add in annotations which are not uniquely named- this 
gives us clear differentiations between classifications and annotations 
for the future. 
 
I agree we can do a follow on Jira to update the docs. 

all the best, David 




From:   Nigel L Jones/UK/IBM@IBMGB
To: dev@atlas.incubator.apache.org
Date:   04/10/2016 16:56
Subject:Re: Rename trait to classification



On 03/10/2016 11:35, David Radley wrote:

> I am not sure I follow your first point. The classification hierarchy I
> was thinking of is the classification scheme, which is not flat. Maybe 
we

* I'll try to clarify... Mandy pointed out in an earlier message that 
classifications may be ordered (for example going from unclassified to 
top secret) as well as contain subclassifications (the 
confidential/personal confidential example). We've not discussed 
ordering yet, but in a policy deployed in ranger I'd like to be 
logically able to have a condition like "confidentiality >= 
Confidential". Whilst this could be done (fudged?) with the name, or in 
the rule using "confidentiality in 
('Confidential','Sensitive','Restricted','Top Secret'), if the order is 
frequently used we need to add the notion of ordering to make rules 
easier to develop. See also my point below about flattening.. purely as 
an interim measure.


> should consider leaving term classification and term classification
> inheritance to a follow on Jira.

Agreed - I will open a new jira for my concern, though I was referring 
to classifications rather than business terms.

On another point, you refer in your proposal summary "top level elements 
like entity and terms" - but terms are implemented as traits today, 
whilst entities are .. entities.  I think we're suggesting 
classifications are also implemented as a specialization of annotations 
and thus as traits, so can traits have traits? - my familiarity with the 
data model/api isnt' developed enough yet... The distinction between 
entities and traits is getting more blurred - mostly it's the easy 
association & lack of guid yet in many ways terms may need to become 
first class entities in their own right?


> I agree that changing the existing Ranger tags to sync with Atlas
> classifications makes sense to not break existing Ranger integration.


Agreed - I suggest that the initial approach focusses on getting the 
model/api right in atlas, whilst considering that these classifications 
need to be used flexibly at the point of data access. Ranger initially 
preserves the simple "tag" approach used today (and must be part of any 
change in this area to avoid breakage) - perhaps flattening & label 
modification, and another JIRA is then opened (first here, then ranger) 
to explore better ways of providing more flexibility in the rules later.

Additionally:

  * Annotations - David you mentioned we may not wish to police 
uniqueness of annotations. In the existing implementation the name of a 
trait is unique. I think we would want to keep unique names, even for 
ad-hoc annotations - though to adopt a fully social model including 
commenting, voting we may also have to consider visibility of the 
annotations themselves (I'd be inclined to keep it simple though). I 
propose we open a social features JIRA to continue that longer termed 
discussion.

  * update the docs/wiki to add definitions for entity, term,

Build failed in Jenkins: apache-atlas-nightly #437

2016-10-06 Thread Apache Jenkins Server 
See 

Changes:

[kbhatt] ATLAS-1215 : Atlas UI not working in firefox due to fix in ATLAS-1199

--
[...truncated 9475 lines...]
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities/b9a89e38-1ec7-4309-aaf9-7bdbe4f9f5a3 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities/4d1221ea-450e-49b1-bb89-3cdc68f2e791 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities/c1a2dacc-13c3-412f-b884-0942157eb904 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities/c1a2dacc-13c3-412f-b884-0942157eb904 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableiqldc8in7o@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableiqldc8in7o@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:39 +] "GET 
/api/atlas/entities/4d1221ea-450e-49b1-bb89-3cdc68f2e791 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableiqldc8in7o@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableiqldc8in7o@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableiqldc8in7o@primary:1475761052000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableiqldc8in7o@primary:1475761052000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities/b9a89e38-1ec7-4309-aaf9-7bdbe4f9f5a3 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities/4d1221ea-450e-49b1-bb89-3cdc68f2e791 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities/c1a2dacc-13c3-412f-b884-0942157eb904 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:41 +] "GET 
/api/atlas/entities/c1a2dacc-13c3-412f-b884-0942157eb904 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableiqldc8in7o@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tableiqldc8in7o@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableiqldc8in7o@primary:1475761052000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tableiqldc8in7o@primary:1475761052000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities/b9a89e38-1ec7-4309-aaf9-7bdbe4f9f5a3 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities/4d1221ea-450e-49b1-bb89-3cdc68f2e791 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities/5c3ce8c2-9ae3-49fc-af42-dc33ac57c2ac HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET 
/api/atlas/entities/c1a2dacc-13c3-412f-b884-0942157eb904 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [06/Oct/2016:13:37:44 +] "GET

[jira] [Commented] (ATLAS-197) Add build instructions in top level dir

2016-10-06 Thread Shwetha G S (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551084#comment-15551084
 ] 

Shwetha G S commented on ATLAS-197:
---

Yes, makes sense to add local reference or give minimal build instructions at 
README and add link as well for detailed instructions

> Add build instructions in top level dir
> ---
>
> Key: ATLAS-197
> URL: https://issues.apache.org/jira/browse/ATLAS-197
> Project: Atlas
>  Issue Type: Wish
>Affects Versions: trunk
>Reporter: Nigel Jones
>Priority: Minor
>
> In early Atlas code we had a file (names something like Installation Steps) 
> in the top level directory which directed the developer who'd downloaded the 
> code from github as to how to build.
> However since the docs are now in twiki those build instructions are only 
> found  several layers deep, and with twiki markup
> jonesn@jonesn-ThinkPad-W530:~/atlas/incubator-atlas$ find . -type f -print | 
> xargs -n50 grep -y "mvn clean install"
> ./docs/src/site/twiki/InstallationSteps.twiki:export MAVEN_OPTS="-Xmx1024m 
> -XX:MaxPermSize=256m" && mvn clean install
> A pointer to the user to read this file, or a quick summary should be added 
> to the root



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (ATLAS-961) DataSetLineageJerseyResourceIT.setUp fails

2016-10-06 Thread Shwetha G S (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S resolved ATLAS-961.
---
Resolution: Duplicate

> DataSetLineageJerseyResourceIT.setUp fails
> --
>
> Key: ATLAS-961
> URL: https://issues.apache.org/jira/browse/ATLAS-961
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>
> mvn clean install -rf :atlas-webapp -Dit.test=DataSetLineageJerseyResourceIT 
> -DskipUTs
> {noformat}
> Tests run: 9, Failures: 1, Errors: 0, Skipped: 8, Time elapsed: 3.716 sec <<< 
> FAILURE! - in org.apache.atlas.web.resources.DataSetLineageJerseyResourceIT
> setUp(org.apache.atlas.web.resources.DataSetLineageJerseyResourceIT)  Time 
> elapsed: 3.666 sec  <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API CREATE_ENTITY 
> failed with status 400(Bad Request) Response Body ({"error":"Unknown 
> datatype: 
> Fact","stackTrace":"org.apache.atlas.typesystem.exception.TypeNotFoundException:
>  Unknown datatype: Fact\n\tat 
> org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:178)\n\tat
>  
> org.apache.atlas.typesystem.types.TypeSystem$TransientTypeSystem.getDataType(TypeSystem.java:649)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.createInstanceWithTraits(ClassType.java:182)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:125)\n\tat 
> org.apache.atlas.services.DefaultMetadataService.getTypedReferenceableInstance(DefaultMetadataService.java:374)\n\tat
>  
> org.apache.atlas.services.DefaultMetadataService.deserializeClassInstances(DefaultMetadataService.java:350)\n\tat
>  
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:331)\n\tat
>  
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:125)\n\tat
>  sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)\n\tat
>  
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
>  java.lang.reflect.Method.invoke(Method.java:606)\n\tat 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
>  javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat 
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>  
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
>  
> com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:182)\n\tat
>  
> com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)\n\tat
>  
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)\n\tat
>  org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:71)\n\tat 
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)\n\tat
>  
> com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:119)\n\tat
>  com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:133)\n\tat 
> com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:130)\n\tat 
> com.google.inject.servlet.GuiceFilter$Context.call(GuiceFilter.java:203)\n\tat
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-06 Thread Shwetha GS 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151632
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 (line 232)


This is a minor backward compatible change. We should set it to 1.1


- Shwetha GS


On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 4, 2016, 11:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

2016-10-06 Thread Vimal Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151631
---


Ship it!




Ship It!

- Vimal Sharma


On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 4, 2016, 11:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>