Review Request 48820: Create default taxonomy if required
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48820/ --- Review request for atlas and Hemanth Yamijala. Bugs: ATLAS-806 https://issues.apache.org/jira/browse/ATLAS-806 Repository: atlas Description --- Provide a default taxonomy unless a user created taxonomy already exists. Diffs - catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 3a5d9be catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java b833c6e distro/src/conf/atlas-application.properties cc0e4c1 Diff: https://reviews.apache.org/r/48820/diff/ Testing --- - Added new unit tests - All unit tests pass - Functional tests pass Thanks, John Speidel
[jira] [Updated] (ATLAS-806) Business Taxonomy related types should be registered one time on server startup.
[ https://issues.apache.org/jira/browse/ATLAS-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-806: --- Attachment: ATLAS-806.patch > Business Taxonomy related types should be registered one time on server > startup. > > > Key: ATLAS-806 > URL: https://issues.apache.org/jira/browse/ATLAS-806 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Hemanth Yamijala > Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-806.patch > > > The Taxonomy type is currently being registered on the first call to the API. > We have seen this could have issues if calls are made in parallel - as could > happen in a web situation. Atlas already has the necessary framework to > register types at startup time which was introduced as part of ATLAS-512. > This should be used here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 48533: Business Catalog Update
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/ --- (Updated June 13, 2016, 7:29 p.m.) Review request for atlas and Hemanth Yamijala. Changes --- New patch addresses 400 response when attempting to update taxonomy name Bugs: ATLAS-794 https://issues.apache.org/jira/browse/ATLAS-794 Repository: atlas Description --- Allows for updating of taxonomy and term property values, excluding the name property. Diffs (updated) - catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ad2f7f4 catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java b1be1ae catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java a28a32b catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java c8d6f68 catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java f73f80b catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 9c809c0 catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 0d63336 catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 0c72de6 catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java 32d6f30 catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java cf55f1f catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java f310c5a catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java a3fbdf1 catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java 19dd049 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java c24b99a catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java df216c0 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java af14697 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java b761dcc catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java 39ce11a catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java 0a2bace catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java 2f29103 catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 78204a6 catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java 5ccec02 catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java a714a8c catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 235bde4 catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java 64935a6 catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java 303e2ba catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java 954262f catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java bc6f74c catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java 52deadf catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 149134c webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 2a65538 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java f995198 webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java a967805 Diff: https://reviews.apache.org/r/48533/diff/ Testing --- Added new unit tests. All unit tests pass. Manual functional tests including create/update/delete/get of taxonomies/terms/tags. Thanks, John Speidel
[jira] [Comment Edited] (ATLAS-794) Business Catalog Update
[ https://issues.apache.org/jira/browse/ATLAS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328007#comment-15328007 ] John Speidel edited comment on ATLAS-794 at 6/13/16 7:29 PM: - New patch (ATLAS-794-3.patch) with changes to address 400 response when attempting to update taxonomy name. was (Author: jspeidel): Changes to address 400 response when attempting to update taxonomy name. > Business Catalog Update > --- > > Key: ATLAS-794 > URL: https://issues.apache.org/jira/browse/ATLAS-794 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-794-2.patch, ATLAS-794-3.patch, ATLAS-794.patch > > > Business Catalog should support Update of all fields of a Term -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-794) Business Catalog Update
[ https://issues.apache.org/jira/browse/ATLAS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-794: --- Attachment: ATLAS-794-3.patch Changes to address 400 response when attempting to update taxonomy name. > Business Catalog Update > --- > > Key: ATLAS-794 > URL: https://issues.apache.org/jira/browse/ATLAS-794 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-794-2.patch, ATLAS-794-3.patch, ATLAS-794.patch > > > Business Catalog should support Update of all fields of a Term -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 48533: Business Catalog Update
> On June 11, 2016, 6:38 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java, > > line 104 > > <https://reviews.apache.org/r/48533/diff/2/?file=1415325#file1415325line104> > > > > I don't know if this was intended, but here we are not using the > > InstanceRequest constructor that sends updateProperties separately. As a > > result, if a 'name' attribute of taxonomy is attempted to be modified, this > > silently passes through validation and returns back with a 200 without > > changing anything. Should we handle this? Yeah, this is a mistake. I had started to converge taxonomy and term updates but ran out of time and didn't notice that the validation check wouldn't work. I will fix taxonomy update to use the same mechanism as term updates. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/#review137108 ------- On June 10, 2016, 9:09 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48533/ > --- > > (Updated June 10, 2016, 9:09 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-794 > https://issues.apache.org/jira/browse/ATLAS-794 > > > Repository: atlas > > > Description > --- > > Allows for updating of taxonomy and term property values, excluding the name > property. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > ad2f7f4 > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > b1be1ae > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > a28a32b > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > c8d6f68 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > f73f80b > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 > catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 9c809c0 > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 0d63336 > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 0c72de6 > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > 32d6f30 > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > cf55f1f > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > f310c5a > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > a3fbdf1 > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > 19dd049 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > c24b99a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > df216c0 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java > af14697 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > b761dcc > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 > catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java > 39ce11a > catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java > 0a2bace > > catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java > 2f29103 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > 78204a6 > catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java > 5ccec02 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > a714a8c > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 235bde4 > catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java > 64935a6 > > catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java > 303e2ba > >
Re: Review Request 48533: Business Catalog Update
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/ --- (Updated June 10, 2016, 9:09 p.m.) Review request for atlas and Hemanth Yamijala. Bugs: ATLAS-794 https://issues.apache.org/jira/browse/ATLAS-794 Repository: atlas Description --- Allows for updating of taxonomy and term property values, excluding the name property. Diffs (updated) - catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ad2f7f4 catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java b1be1ae catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java a28a32b catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java c8d6f68 catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java f73f80b catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 9c809c0 catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 0d63336 catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 0c72de6 catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java 32d6f30 catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java cf55f1f catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java f310c5a catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java a3fbdf1 catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java 19dd049 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java c24b99a catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java df216c0 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java af14697 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java b761dcc catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java 39ce11a catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java 0a2bace catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java 2f29103 catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 78204a6 catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java 5ccec02 catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java a714a8c catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 235bde4 catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java 64935a6 catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java 303e2ba catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java 954262f catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java bc6f74c catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java 52deadf catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 149134c webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 2a65538 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java f995198 webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java a967805 Diff: https://reviews.apache.org/r/48533/diff/ Testing --- Added new unit tests. All unit tests pass. Manual functional tests including create/update/delete/get of taxonomies/terms/tags. Thanks, John Speidel
[jira] [Updated] (ATLAS-794) Business Catalog Update
[ https://issues.apache.org/jira/browse/ATLAS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-794: --- Attachment: ATLAS-794-2.patch patch v2 addresses issues raised in review > Business Catalog Update > --- > > Key: ATLAS-794 > URL: https://issues.apache.org/jira/browse/ATLAS-794 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-794-2.patch, ATLAS-794.patch > > > Business Catalog should support Update of all fields of a Term -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 48533: Business Catalog Update
> On June 10, 2016, 5:42 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java, line 42 > > <https://reviews.apache.org/r/48533/diff/1/?file=1414331#file1414331line42> > > > > Minor nit: the double braces seems like a typo (was there in earlier > > code as well). Yep, was the result of incomplete refactoring in an earlier patch. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/#review136966 --- On June 10, 2016, 3:38 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48533/ > --- > > (Updated June 10, 2016, 3:38 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-794 > https://issues.apache.org/jira/browse/ATLAS-794 > > > Repository: atlas > > > Description > --- > > Allows for updating of taxonomy and term property values, excluding the name > property. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > ad2f7f4 > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > b1be1ae > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > a28a32b > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > c8d6f68 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > f73f80b > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 > catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 9c809c0 > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 0d63336 > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 0c72de6 > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > 32d6f30 > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > cf55f1f > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > f310c5a > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > a3fbdf1 > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > 19dd049 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > c24b99a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > df216c0 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java > af14697 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > b761dcc > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 > catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java > 39ce11a > catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java > 0a2bace > > catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java > 2f29103 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > 78204a6 > catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java > 5ccec02 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > a714a8c > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 235bde4 > > catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java > 303e2ba > > catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java > 954262f > > catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java > bc6f74c > > catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java > 52deadf > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 149134c > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > 2a65538
Re: Review Request 48533: Business Catalog Update
> On June 10, 2016, 5:42 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java, > > line 134 > > <https://reviews.apache.org/r/48533/diff/1/?file=1414341#file1414341line134> > > > > If I understand correctly, we wouldn't update anything if it is not > > description. Should this then be indicated via a failure / exception etc? See above comment. Also, if an unknown property is set, a 400 response is returned to the caller indicating the invalid property names. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/#review136966 ------- On June 10, 2016, 3:38 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48533/ > --- > > (Updated June 10, 2016, 3:38 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-794 > https://issues.apache.org/jira/browse/ATLAS-794 > > > Repository: atlas > > > Description > --- > > Allows for updating of taxonomy and term property values, excluding the name > property. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > ad2f7f4 > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > b1be1ae > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > a28a32b > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > c8d6f68 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > f73f80b > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 > catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 9c809c0 > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 0d63336 > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 0c72de6 > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > 32d6f30 > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > cf55f1f > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > f310c5a > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > a3fbdf1 > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > 19dd049 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > c24b99a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > df216c0 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java > af14697 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > b761dcc > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 > catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java > 39ce11a > catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java > 0a2bace > > catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java > 2f29103 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > 78204a6 > catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java > 5ccec02 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > a714a8c > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 235bde4 > > catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java > 303e2ba > > catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java > 954262f > > catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java > bc6f74c > > catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java > 52deadf > > catalog/src/test/java/org/apache/a
Re: Review Request 48533: Business Catalog Update
> On June 10, 2016, 5:42 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java, > > line 122 > > <https://reviews.apache.org/r/48533/diff/1/?file=1414341#file1414341line122> > > > > If this condition does not hold, should we even execute the term query? > > IOW, can we move the check upwards before the term query as well. This is actually the correct behavior. Because the properties of a term are 'administrative' type properties, they are only set on the instance associated with the Taxonomy (singleton instance). The exception to this is the 'description' property which is also set on the tags(trait instances associated with entities) as it makes sense in the tag context. So, a user can update any property of a term such as "available_as_tag" and because tags only have the "name" and "description" properties set, the property should only be set on the Taxonomy instance. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/#review136966 ------- On June 10, 2016, 3:38 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48533/ > --- > > (Updated June 10, 2016, 3:38 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-794 > https://issues.apache.org/jira/browse/ATLAS-794 > > > Repository: atlas > > > Description > --- > > Allows for updating of taxonomy and term property values, excluding the name > property. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > ad2f7f4 > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > b1be1ae > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > a28a32b > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > c8d6f68 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > f73f80b > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 > catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 9c809c0 > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 0d63336 > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 0c72de6 > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > 32d6f30 > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > cf55f1f > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > f310c5a > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > a3fbdf1 > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > 19dd049 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > c24b99a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > df216c0 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java > af14697 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > b761dcc > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 > catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java > 39ce11a > catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java > 0a2bace > > catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java > 2f29103 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > 78204a6 > catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java > 5ccec02 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > a714a8c > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 235bde4 > > catalog/src/test/java/org/apache/atlas/catalog/definition/Ent
Re: Review Request 48533: Business Catalog Update
> On June 10, 2016, 5:42 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java, > > line 55 > > <https://reviews.apache.org/r/48533/diff/1/?file=1414332#file1414332line55> > > > > This method seems specific to Taxonomy, however BaseResourceProvider > > handles all types of entities. So, should this possibly be in a different > > place. If only few (but more than one) code paths need it and we want to > > avoid duplication - can we use some form of composition to address the > > issue? This method was originally in TaxonomyResourceProvider and pulled up into the base class when I needed the functionality in TermResourceProvider. The method is actually generic, except for the response variable name which I forgot to update after moving the method. After moving the method, I made changes in TermResoureProvider where I no longer need to call this method. Since it is currently only called from TaxonomyResourceProvider I will move it back. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/#review136966 ------- On June 10, 2016, 3:38 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48533/ > --- > > (Updated June 10, 2016, 3:38 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-794 > https://issues.apache.org/jira/browse/ATLAS-794 > > > Repository: atlas > > > Description > --- > > Allows for updating of taxonomy and term property values, excluding the name > property. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > ad2f7f4 > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > b1be1ae > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > a28a32b > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > c8d6f68 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > f73f80b > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 > catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 9c809c0 > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 0d63336 > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 0c72de6 > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > 32d6f30 > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > cf55f1f > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > f310c5a > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > a3fbdf1 > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > 19dd049 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > c24b99a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > df216c0 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java > af14697 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > b761dcc > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 > catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java > 39ce11a > catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java > 0a2bace > > catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java > 2f29103 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > 78204a6 > catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java > 5ccec02 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > a714a8c > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 235bde4 > > catalog/s
Re: Review Request 48533: Business Catalog Update
> On June 10, 2016, 5:51 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java, line 76 > > <https://reviews.apache.org/r/48533/diff/1/?file=1414352#file1414352line76> > > > > If executeQuery throws an exception here, we will miss rolling back the > > transaction / also exception will bubble up. Nice catch. Missed this when I moved the tx logic out of executeQuery(). - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/#review136968 --- On June 10, 2016, 3:38 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48533/ > --- > > (Updated June 10, 2016, 3:38 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-794 > https://issues.apache.org/jira/browse/ATLAS-794 > > > Repository: atlas > > > Description > --- > > Allows for updating of taxonomy and term property values, excluding the name > property. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > ad2f7f4 > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > b1be1ae > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > a28a32b > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > c8d6f68 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > f73f80b > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 > catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 9c809c0 > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 0d63336 > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 0c72de6 > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > 32d6f30 > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > cf55f1f > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > f310c5a > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > a3fbdf1 > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > 19dd049 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > c24b99a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > df216c0 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java > af14697 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > b761dcc > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 > catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java > 39ce11a > catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java > 0a2bace > > catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java > 2f29103 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > 78204a6 > catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java > 5ccec02 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > a714a8c > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 235bde4 > > catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java > 303e2ba > > catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java > 954262f > > catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java > bc6f74c > > catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java > 52deadf > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 149134c > webapp/src/main/java/org/apache/atlas/web
Re: Review Request 48551: HBase table name 'titan' to be configurable via Atlas properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48551/#review137000 --- Ship it! Ship It! - John Speidel On June 10, 2016, 1:08 p.m., Tom Beerbower wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48551/ > --- > > (Updated June 10, 2016, 1:08 p.m.) > > > Review request for atlas, John Speidel and Nate Cole. > > > Bugs: AMBARI-17166 and AMBARI-17167 > https://issues.apache.org/jira/browse/AMBARI-17166 > https://issues.apache.org/jira/browse/AMBARI-17167 > > > Repository: ambari > > > Description > --- > > Currently Atlas Hbase table name is 'titan' and there is no option to > configure the table name. > We can add a property in Atlas advanced configuration on Ambari UI to specify > the table name. > The following property in atlas-application.properties allows us to configure > Hbase table name > atlas.graph.storage.hbase.table : "atlas_titan" > > Also, default logging to info. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-log4j.xml > 640fce2 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml > 985b4cf > > Diff: https://reviews.apache.org/r/48551/diff/ > > > Testing > --- > > Manual test Atlas install. Verify HBase table for atlas titan with > configured name. > > > Thanks, > > Tom Beerbower > >
Review Request 48533: Business Catalog Update
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48533/ --- Review request for atlas and Hemanth Yamijala. Bugs: ATLAS-794 https://issues.apache.org/jira/browse/ATLAS-794 Repository: atlas Description --- Allows for updating of taxonomy and term property values, excluding the name property. Diffs - catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java 9ccb4e3 catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ad2f7f4 catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java b1be1ae catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java a28a32b catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java c8d6f68 catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java f73f80b catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java 01583c4 catalog/src/main/java/org/apache/atlas/catalog/Request.java 7dc781a catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 9c809c0 catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 0d63336 catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 0c72de6 catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 6e5d28e catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java 32d6f30 catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java cf55f1f catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java f310c5a catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java a3fbdf1 catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java 19dd049 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java c24b99a catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java df216c0 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java af14697 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java b761dcc catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ba8e0e7 catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java 39ce11a catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java 0a2bace catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java 2f29103 catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 78204a6 catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java 5ccec02 catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java a714a8c catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 235bde4 catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java 303e2ba catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java 954262f catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java bc6f74c catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java 52deadf catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 149134c webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 2a65538 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java f995198 webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java a967805 Diff: https://reviews.apache.org/r/48533/diff/ Testing --- Added new unit tests. All unit tests pass. Manual functional tests including create/update/delete/get of taxonomies/terms/tags. Thanks, John Speidel
[jira] [Comment Edited] (ATLAS-794) Business Catalog Update
[
https://issues.apache.org/jira/browse/ATLAS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323810#comment-15323810
]
John Speidel edited comment on ATLAS-794 at 6/10/16 3:35 AM:
-
Supports updating of taxonomy and term property values not including the 'name'
property. Only one taxonomy or term can be updated at a time with this patch.
Allowing for updates of multiple taxonomies/terms based on a query isn't
included in this patch and would be ~ 1 additional days work.
{code}
Usage: PUT api/v1/taxonomies/taxonomy1/terms/term1
{
"description" : "newValue"
}
{code}
was (Author: jspeidel):
Supports updating of taxonomy and term property values not including the 'name'
property. Only one taxonomy or term can be updated at a time with this patch.
Allowing for updates of multiple taxonomies/terms based on a query isn't
included in this patch and would be ~ 1 additional days work.
Usage: PUT api/v1/taxonomies/taxonomy1/terms/term1
{
"description" : "newValue"
}
> Business Catalog Update
> ---
>
> Key: ATLAS-794
> URL: https://issues.apache.org/jira/browse/ATLAS-794
> Project: Atlas
> Issue Type: Improvement
>Affects Versions: 0.7-incubating
> Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-794.patch
>
>
> Business Catalog should support Update of all fields of a Term
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ATLAS-794) Business Catalog Update
[
https://issues.apache.org/jira/browse/ATLAS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Speidel updated ATLAS-794:
---
Attachment: ATLAS-794.patch
Supports updating of taxonomy and term property values not including the 'name'
property. Only one taxonomy or term can be updated at a time with this patch.
Allowing for updates of multiple taxonomies/terms based on a query isn't
included in this patch and would be ~ 1 additional days work.
Usage: PUT api/v1/taxonomies/taxonomy1/terms/term1
{
"description" : "newValue"
}
> Business Catalog Update
> ---
>
> Key: ATLAS-794
> URL: https://issues.apache.org/jira/browse/ATLAS-794
> Project: Atlas
> Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-794.patch
>
>
> Business Catalog should support Update of all fields of a Term
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (ATLAS-794) Business Catalog Update
[
https://issues.apache.org/jira/browse/ATLAS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323810#comment-15323810
]
John Speidel edited comment on ATLAS-794 at 6/10/16 3:35 AM:
-
Supports updating of taxonomy and term property values not including the 'name'
property. Only one taxonomy or term can be updated at a time with this patch.
Allowing for updates of multiple taxonomies/terms based on a query isn't
included in this patch and would be ~ 1 additional days work.
USAGE:
{code}
PUT api/v1/taxonomies/taxonomy1/terms/term1
{
"description" : "newValue"
}
{code}
was (Author: jspeidel):
Supports updating of taxonomy and term property values not including the 'name'
property. Only one taxonomy or term can be updated at a time with this patch.
Allowing for updates of multiple taxonomies/terms based on a query isn't
included in this patch and would be ~ 1 additional days work.
{code}
Usage: PUT api/v1/taxonomies/taxonomy1/terms/term1
{
"description" : "newValue"
}
{code}
> Business Catalog Update
> ---
>
> Key: ATLAS-794
> URL: https://issues.apache.org/jira/browse/ATLAS-794
> Project: Atlas
> Issue Type: Improvement
>Affects Versions: 0.7-incubating
> Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-794.patch
>
>
> Business Catalog should support Update of all fields of a Term
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-858) Unable to delete terms via API which are 3 or more levels deep
[ https://issues.apache.org/jira/browse/ATLAS-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316952#comment-15316952 ] John Speidel commented on ATLAS-858: Yes, that also works, and is an acceptable use (shorter url's) but don't provide for an explicit hierarchy. The url's with the explicit hierarchy are the "official" url's which are returned by the api to the user. > Unable to delete terms via API which are 3 or more levels deep > -- > > Key: ATLAS-858 > URL: https://issues.apache.org/jira/browse/ATLAS-858 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: John Speidel >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-858.patch > > > Attempting to delete a term that is 3 or more levels deep results in an error > response: > DELETE > api/atlas/v1/taxonomies/taxonomy1/terms/term1/terms/term11/terms/term111 > 405 - Method Not Allowed > This is because I for got to add a service method for deleting sub terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-845) Atlas UI to delete terms using API
[ https://issues.apache.org/jira/browse/ATLAS-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314890#comment-15314890 ] John Speidel commented on ATLAS-845: The issue described above where deleting sub-terms fails with 405 status is being tracked by ATLAS-858. > Atlas UI to delete terms using API > -- > > Key: ATLAS-845 > URL: https://issues.apache.org/jira/browse/ATLAS-845 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Kalyani Kashikar > Fix For: 0.7-incubating > > Attachments: ATLAS-845.1.patch, ATLAS-845.patch > > > Providing delete term feature using delete term api. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 48231: Unable to delete terms via API which are 3 or more levels deep
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48231/ --- Review request for atlas and Hemanth Yamijala. Bugs: ATLAS-858 https://issues.apache.org/jira/browse/ATLAS-858 Repository: atlas Description --- Attempting to delete a term that is 3 or more levels deep results in an error response: DELETE api/atlas/v1/taxonomies/taxonomy1/terms/term1/terms/term11/terms/term111 405 - Method Not Allowed This is because I for got to add a service method for deleting sub terms. Diffs - webapp/pom.xml 6b0a927 webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 83bbd22 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 1ea8e14 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 04cabad webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java PRE-CREATION Diff: https://reviews.apache.org/r/48231/diff/ Testing --- - Added new tests for TaxonomyService including a test for the new delete method - All existing unit tests pass - All manual functional tests pass Thanks, John Speidel
[jira] [Commented] (ATLAS-858) Unable to delete terms via API which are 3 or more levels deep
[ https://issues.apache.org/jira/browse/ATLAS-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314878#comment-15314878 ] John Speidel commented on ATLAS-858: This issue was originally reported in ATLAS-845. > Unable to delete terms via API which are 3 or more levels deep > -- > > Key: ATLAS-858 > URL: https://issues.apache.org/jira/browse/ATLAS-858 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating > Reporter: John Speidel >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-858.patch > > > Attempting to delete a term that is 3 or more levels deep results in an error > response: > DELETE > api/atlas/v1/taxonomies/taxonomy1/terms/term1/terms/term11/terms/term111 > 405 - Method Not Allowed > This is because I for got to add a service method for deleting sub terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-858) Unable to delete terms via API which are 3 or more levels deep
[ https://issues.apache.org/jira/browse/ATLAS-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-858: --- Attachment: ATLAS-858.patch > Unable to delete terms via API which are 3 or more levels deep > -- > > Key: ATLAS-858 > URL: https://issues.apache.org/jira/browse/ATLAS-858 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating > Reporter: John Speidel >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-858.patch > > > Attempting to delete a term that is 3 or more levels deep results in an error > response: > DELETE > api/atlas/v1/taxonomies/taxonomy1/terms/term1/terms/term11/terms/term111 > 405 - Method Not Allowed > This is because I for got to add a service method for deleting sub terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-858) Unable to delete terms via API which are 3 or more levels deep
John Speidel created ATLAS-858: -- Summary: Unable to delete terms via API which are 3 or more levels deep Key: ATLAS-858 URL: https://issues.apache.org/jira/browse/ATLAS-858 Project: Atlas Issue Type: Bug Affects Versions: 0.7-incubating Reporter: John Speidel Assignee: John Speidel Fix For: 0.7-incubating Attempting to delete a term that is 3 or more levels deep results in an error response: DELETE api/atlas/v1/taxonomies/taxonomy1/terms/term1/terms/term11/terms/term111 405 - Method Not Allowed This is because I for got to add a service method for deleting sub terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-845) Atlas UI to delete terms using API
[ https://issues.apache.org/jira/browse/ATLAS-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312829#comment-15312829 ] John Speidel commented on ATLAS-845: The above comment was regarding deleting terms > 3 levels deep. > Atlas UI to delete terms using API > -- > > Key: ATLAS-845 > URL: https://issues.apache.org/jira/browse/ATLAS-845 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Kalyani Kashikar > Fix For: 0.7-incubating > > Attachments: ATLAS-845.patch > > > Providing delete term feature using delete term api. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-845) Atlas UI to delete terms using API
[ https://issues.apache.org/jira/browse/ATLAS-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312827#comment-15312827 ] John Speidel commented on ATLAS-845: I have reproduced this issue and understand the root cause. I should have a patch available either today or tomorrow. > Atlas UI to delete terms using API > -- > > Key: ATLAS-845 > URL: https://issues.apache.org/jira/browse/ATLAS-845 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Kalyani Kashikar > Fix For: 0.7-incubating > > Attachments: ATLAS-845.patch > > > Providing delete term feature using delete term api. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312390#comment-15312390 ] John Speidel commented on ATLAS-793: I agree with this approach [~yhemanth]. > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793-2.patch, ATLAS-793-3.patch, ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311174#comment-15311174 ] John Speidel commented on ATLAS-793: I finally reproduced this after many, many attempts today. In the case where I did reproduce it, I hadn't yet run quick start. I saw the message once, and couldn't cause the issue again. As I just reproduced this, and can't cause the issue again at the moment, I still haven't identified a root cause. This issue didn't noticeably affect the user requests meaning that all taxonomy and term creations where successful as were all UI interactions as well as api requests. > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793-2.patch, ATLAS-793-3.patch, ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310352#comment-15310352 ] John Speidel commented on ATLAS-793: Great, I will try your steps to see if I can reproduce. > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793-2.patch, ATLAS-793-3.patch, ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 47898: Implement Business Catalog Delete
> On May 27, 2016, 7:24 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java, line > > 47 > > <https://reviews.apache.org/r/47898/diff/1/?file=1395490#file1395490line47> > > > > Is this being done mainly as a defensive safeguard? If there is any > > exception, then I guess that transaction will remain open until any of > > these calls are made. I have seen long opened transactions cause problems > > and leaks in Titan. Preferable to ensure transactions are closed. > > John Speidel wrote: > Yes, this is a safeguard to ensure correct behavior in the case where a > thread is re-pooled with an active transaction. Because of the way that > transactions are implemented in Titan, this can easily happen. Even a simple > read will start a transaction that may mutate the database as well as > establish the point in time used for read object visibility. I did see > several cases recently where this did indeed happen and was unable to easily > figure out where we missed a commit/rollback so I added this code at this > time. Ideally, this would be done via a Jersey interceptor which was invoked > for all api requests. > > I absolutely agree that we should attempt to ensure proper transaction > demarcation in all code paths, but that being said, I think that it is a good > idea to have this "safety net" due to the likelihood that this will occur in > the future. Unfortunately, I didn't see a way to determine if an active > transaction is in place on the thread so that we could actually detect this > scenario and log a warning instead of just blindly rolling back. > > Let me know if you are ok with closing this issue as is or if you would > prefer that I resolve this issue another way. > > Hemanth Yamijala wrote: > I would prefer this is addressed in this JIRA. I don't see these warnings > without this patch, including when exercising existing add functionality of > business terms. I have been unable to reproduce this behavior after testing for over an hour. I will keep an eye out for the log warning that you provided in the associated Jira. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/#review135175 --- On May 27, 2016, 9:18 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47898/ > --- > > (Updated May 27, 2016, 9:18 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-793 > https://issues.apache.org/jira/browse/ATLAS-793 > > > Repository: atlas > > > Description > --- > > Provide support for deletion of taxonomies, terms and tags > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > 517eaf6 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > f71c061 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > dc4ab0d > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 4c4319c > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 7a46f5d > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 431b06d > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java > 5f59bea > catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java > a5e15c6 > > catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java > 5f11474 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > e2bc597 > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > 013bb8a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java > 787f734 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > 0065101 > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > a95b966 >
[jira] [Updated] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-793: --- Attachment: ATLAS-793-3.patch Latest patch (ATLAS-793-3.patch) addresses the warning about query not being indexed and doing a full vertex scan. This patch doesn't address the transaction timeout issue as I wasn't able to reproduce after more than one hour attempting to do so. > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793-2.patch, ATLAS-793-3.patch, ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-793: --- Attachment: ATLAS-793-2.patch Uploaded new patch 'ATLAS-793-2.patch' which contains changes for all review issues unless otherwise noted in the review. Also, doesn't address the comments included in this Jira as described in my comments. > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793-2.patch, ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 47898: Implement Business Catalog Delete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/ --- (Updated May 27, 2016, 9:18 p.m.) Review request for atlas and Hemanth Yamijala. Changes --- Uploaded new patch which contains fixes for all issue except those where I have noted otherwise in the comments. Bugs: ATLAS-793 https://issues.apache.org/jira/browse/ATLAS-793 Repository: atlas Description --- Provide support for deletion of taxonomies, terms and tags Diffs (updated) - catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 517eaf6 catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f71c061 catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java dc4ab0d catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 4c4319c catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 7a46f5d catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 431b06d catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java 5f59bea catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java a5e15c6 catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 5f11474 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java e2bc597 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 013bb8a catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 787f734 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 0065101 catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java a95b966 catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java 9cf3d12 catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 34222ca catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 838d4c1 server-api/src/main/java/org/apache/atlas/services/MetadataService.java 6bca3df webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 3982df8 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 0e3f4c4 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java ccd0b62 Diff: https://reviews.apache.org/r/47898/diff/ Testing --- - Added new unit tests - Ran all existing unit tests - Manual functional testing of all new functionality Thanks, John Speidel
Re: Review Request 47898: Implement Business Catalog Delete
> On May 27, 2016, 7:17 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java, > > line 28 > > <https://reviews.apache.org/r/47898/diff/1/?file=1395475#file1395475line28> > > > > Is it possible to fold this into the search criteria itself, so that we > > would not get these properties back. Yes, I agree that this would be better but is a bit involved and I would like to get this merged prior to making these changes if possible. The relation/projection query code is an area that I didn't really get cleaned up like I wanted to. Making this change will involve generating sub-pipelines instead of the current implementation of manually iterating across the vertices. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/#review135174 ------- On May 26, 2016, 3:52 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47898/ > --- > > (Updated May 26, 2016, 3:52 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-793 > https://issues.apache.org/jira/browse/ATLAS-793 > > > Repository: atlas > > > Description > --- > > Provide support for deletion of taxonomies, terms and tags > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > 517eaf6 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > f71c061 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > dc4ab0d > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 4c4319c > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 7a46f5d > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 431b06d > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java > 5f59bea > catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java > a5e15c6 > > catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java > 5f11474 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > e2bc597 > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > 013bb8a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java > 787f734 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > 0065101 > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > a95b966 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > 9cf3d12 > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 34222ca > > catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java > PRE-CREATION > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 838d4c1 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 6bca3df > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > 3982df8 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > 0e3f4c4 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > ccd0b62 > > Diff: https://reviews.apache.org/r/47898/diff/ > > > Testing > --- > > - Added new unit tests > - Ran all existing unit tests > - Manual functional testing of all new functionality > > > Thanks, > > John Speidel > >
[jira] [Commented] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304581#comment-15304581 ] John Speidel commented on ATLAS-793: [~yhemanth] At this time I don't know why the above transaction timeout message occurs. I will post a new patch with changes for the issues raised in the review and will then investigate this message. Perhaps we file a new Jira for this issue so that we can make the delete functionality available while I am investigating? > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304570#comment-15304570 ] John Speidel commented on ATLAS-793: [~yhemanth] The reason for this log message is because I added a clause to all queries to return only non-deleted (active) vertices. This clause is basically (Constants.STATE_PROPERTY_KEY:ACTIVE). At this time, this property isn't indexed by Atlas which results in a non-indexed vertex scan. This clause is required in the query to ensure that deleted vertices aren't returned. Let me know if you would like me to add this index in GraphBackedSearchIndexer.java. > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 47898: Implement Business Catalog Delete
> On May 27, 2016, 7:11 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java, > > line 130 > > <https://reviews.apache.org/r/47898/diff/1/?file=1395474#file1395474line130> > > > > Would it help if the term subtree is sorted from leaf nodes upwards, so > > that if there is a failure in the interim, at least we will not have > > dangling terms. Yeah, I had thought of this also but didn't implement it due to the added overhead for all delete calls. The real problem here is the inability for the catalog call to control transaction demarcation because of the way that transactions are handled in the Atlas Repository layer. The bottom line is that ordering of the terms bottom up is just a band-aid for the real transactional issue described above that would introduce overhead even for non failure scenarios. Let me know if you would still like me to make this change or whether we should file a Jira for a proper fix. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/#review135172 ------- On May 26, 2016, 3:52 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47898/ > --- > > (Updated May 26, 2016, 3:52 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-793 > https://issues.apache.org/jira/browse/ATLAS-793 > > > Repository: atlas > > > Description > --- > > Provide support for deletion of taxonomies, terms and tags > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > 517eaf6 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > f71c061 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > dc4ab0d > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 4c4319c > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 7a46f5d > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 431b06d > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java > 5f59bea > catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java > a5e15c6 > > catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java > 5f11474 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > e2bc597 > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > 013bb8a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java > 787f734 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > 0065101 > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > a95b966 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > 9cf3d12 > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 34222ca > > catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java > PRE-CREATION > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 838d4c1 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 6bca3df > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > 3982df8 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > 0e3f4c4 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > ccd0b62 > > Diff: https://reviews.apache.org/r/47898/diff/ > > > Testing > --- > > - Added new unit tests > - Ran all existing unit tests > - Manual functional testing of all new functionality > > > Thanks, > > John Speidel > >
Re: Review Request 47898: Implement Business Catalog Delete
> On May 27, 2016, 7:06 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java, > > line 32 > > <https://reviews.apache.org/r/47898/diff/1/?file=1395473#file1395473line32> > > > > Trying to understand why we are lazy-initializing this? It doesn't seem > > to be a costly resource to initialize at construction time, no? Would > > remove the need for synchronization. Yeah, lazy initialization is no longer beneficial. I will change. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/#review135171 ------- On May 26, 2016, 3:52 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47898/ > --- > > (Updated May 26, 2016, 3:52 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-793 > https://issues.apache.org/jira/browse/ATLAS-793 > > > Repository: atlas > > > Description > --- > > Provide support for deletion of taxonomies, terms and tags > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > 517eaf6 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > f71c061 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > dc4ab0d > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 4c4319c > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 7a46f5d > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 431b06d > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java > 5f59bea > catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java > a5e15c6 > > catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java > 5f11474 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > e2bc597 > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > 013bb8a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java > 787f734 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > 0065101 > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > a95b966 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > 9cf3d12 > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 34222ca > > catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java > PRE-CREATION > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 838d4c1 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 6bca3df > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > 3982df8 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > 0e3f4c4 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > ccd0b62 > > Diff: https://reviews.apache.org/r/47898/diff/ > > > Testing > --- > > - Added new unit tests > - Ran all existing unit tests > - Manual functional testing of all new functionality > > > Thanks, > > John Speidel > >
Re: Review Request 47898: Implement Business Catalog Delete
> On May 27, 2016, 7:01 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java, > > line 102 > > <https://reviews.apache.org/r/47898/diff/1/?file=1395471#file1395471line102> > > > > Do we need this call? The call to deleteTag seems to be throwing an > > EntityNotFoundException if the entity is not found. That can be caught and > > handled. This will help avoid an additional lookup call to the entity. Yeah, that would be better. It looks like I can catch TraitNotFoundException in DefaultTypeSystem.deleteTrait() and change the signature to throw ResourceNotFound and avoid this overhead as you stated. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/#review135170 ------- On May 26, 2016, 3:52 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47898/ > --- > > (Updated May 26, 2016, 3:52 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-793 > https://issues.apache.org/jira/browse/ATLAS-793 > > > Repository: atlas > > > Description > --- > > Provide support for deletion of taxonomies, terms and tags > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > 517eaf6 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > f71c061 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > dc4ab0d > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 4c4319c > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 7a46f5d > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 431b06d > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java > 5f59bea > catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java > a5e15c6 > > catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java > 5f11474 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > e2bc597 > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > 013bb8a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java > 787f734 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > 0065101 > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > a95b966 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > 9cf3d12 > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 34222ca > > catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java > PRE-CREATION > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 838d4c1 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 6bca3df > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > 3982df8 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > 0e3f4c4 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > ccd0b62 > > Diff: https://reviews.apache.org/r/47898/diff/ > > > Testing > --- > > - Added new unit tests > - Ran all existing unit tests > - Manual functional testing of all new functionality > > > Thanks, > > John Speidel > >
[jira] [Commented] (ATLAS-793) Business Catalog Delete
[ https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302306#comment-15302306 ] John Speidel commented on ATLAS-793: This patch doesn't delete term 'types' because this functionality isn't exposed in MetadataService or MetadataRepository. This doesn't effect business catalog but if users query /types after deleting terms in a taxonomy, the type will still exist. > Business Catalog Delete > --- > > Key: ATLAS-793 > URL: https://issues.apache.org/jira/browse/ATLAS-793 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: ATLAS-793.patch > > > Business Catalog API should support deletion of Terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 47898: Implement Business Catalog Delete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/ --- Review request for atlas and Hemanth Yamijala. Bugs: ATLAS-793 https://issues.apache.org/jira/browse/ATLAS-793 Repository: atlas Description --- Provide support for deletion of taxonomies, terms and tags Diffs - catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 517eaf6 catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f71c061 catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java dc4ab0d catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 4c4319c catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 7a46f5d catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 431b06d catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java 5f59bea catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java a5e15c6 catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 5f11474 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java e2bc597 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 013bb8a catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 787f734 catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 0065101 catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java a95b966 catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java 9cf3d12 catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 34222ca catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 838d4c1 server-api/src/main/java/org/apache/atlas/services/MetadataService.java 6bca3df webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 3982df8 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 0e3f4c4 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java ccd0b62 Diff: https://reviews.apache.org/r/47898/diff/ Testing --- - Added new unit tests - Ran all existing unit tests - Manual functional testing of all new functionality Thanks, John Speidel
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, > > line 37 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383456#file1383456line37> > > > > If I understood this correctly, the basepipe for the Gremlin search for > > entities begins by trying to identify all entity vertices (by virtue of > > using the full text search property that is common to all vertices). This > > would still be a huge result set to begin with, no? > > John Speidel wrote: > This is currently the only way to identify an entity vertex with the > current database model. It is a requirement to be able to search all entity > types and to be able to apply tags to entities across types. So, we need to > be able to get all of the entity vertices, which is the set that would be > returned from the base query. The biggest issue with using this field to > determine the entity set is that it isn't indexed. Also, the query starts > with V(), which is all vertices in the graph but this doesn't result in all > vertices being returned but instead adds them to the pipeline interator. > > That being said, there are lots of improvements that can be made to > improve query performance. This would include, changes to the database model > so that we knew the propery names ahead of time so that we could use an index > instead of a filter. Also, one optimization that I was going to add which > didn't make it in was to use the type if it was provided so that indexes > could be used as mentioned above. For now, I don't think that we can improve > on this. > > Hemanth Yamijala wrote: > I thought we do index the ENTITY_TEXT_PROPERTY_KEY. This is done in > GraphBackedSearchIndexer.createFullTextIndex. Please see comment below on > search and we can probably get this in and open follow-up JIRAs to fix. Being tracked by: https://issues.apache.org/jira/browse/ATLAS-807 - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review12 --- On May 17, 2016, 10:41 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 17, 2016, 10:41 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourcePr
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 8:04 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java, > > line 116 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383421#file1383421line116> > > > > Both these TODOs are kind of important, and we need to probably file > > follow-up JIRAs to address these. > > John Speidel wrote: > ok, I will create follow-up Jira's for these. https://issues.apache.org/jira/browse/ATLAS-808 - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review19 ------- On May 17, 2016, 10:41 p.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 17, 2016, 10:41 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/m
Review Request 47591: Quickstart fails to run after queries to the business taxonomy API
s.AtlasClient.callAPIWithResource(AtlasClient.java:1045) at org.apache.atlas.AtlasClient.callAPIWithRetries(AtlasClient.java:642) at org.apache.atlas.AtlasClient.callAPI(AtlasClient.java:1050) at org.apache.atlas.AtlasClient.createEntity(AtlasClient.java:558) at org.apache.atlas.AtlasClient.createEntity(AtlasClient.java:571) at org.apache.atlas.examples.QuickStart.createInstance(QuickStart.java:317) at org.apache.atlas.examples.QuickStart.database(QuickStart.java:334) at org.apache.atlas.examples.QuickStart.createEntities(QuickStart.java:232) at org.apache.atlas.examples.QuickStart.runQuickstart(QuickStart.java:97) at org.apache.atlas.examples.QuickStart.main(QuickStart.java:79) Diffs - catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java ac8ca6b catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47591/diff/ Testing --- Manually tested the above steps. Wrote new unit test. Ran all unit tests. Thanks, John Speidel
[jira] [Commented] (ATLAS-805) Quickstart is failing if run after queries to the business taxonomy API
[
https://issues.apache.org/jira/browse/ATLAS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289841#comment-15289841
]
John Speidel commented on ATLAS-805:
I have attached a patch for the issue where transactions weren't committed in
BaseQuery of the catalog module.
Also added a test that asserts that the transaction is committed.
Note: Although this does fix this issue in this exact case, we should really
consider intercepting each request and calling graph.rollback() to ensure that
the thread wasn't re-pooled without being committed or rolled back.
> Quickstart is failing if run after queries to the business taxonomy API
> ---
>
> Key: ATLAS-805
> URL: https://issues.apache.org/jira/browse/ATLAS-805
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: John Speidel
>Priority: Blocker
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-805.patch, application.log
>
>
> * On a fresh Atlas server, using a REST client like curl or Postman, make a
> call to the business taxonomy API. E.g.
> http://localhost:21000/api/atlas/v1/taxonomies
> * This will return an empty result set
> * Run quick_start.py.
> This fails with an exception as follows:
> {code}
> Exception in thread "main" org.apache.atlas.AtlasServiceException: Metadata
> service API CREATE_ENTITY failed with status 500(Internal Server Error)
> Response Body ({"error":"Could not commit transaction due to exception during
> persistence","stackTrace":"com.thinkaurelius.titan.core.TitanException: Could
> not commit transaction due to exception during persistence\n\tat
> com.thinkaurelius.titan.graphdb.transaction.StandardTitanTx.commit(StandardTitanTx.java:1348)\n\tat
>
> com.thinkaurelius.titan.graphdb.blueprints.TitanBlueprintsGraph.commit(TitanBlueprintsGraph.java:60)\n\tat
>
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:43)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:321)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:316)\n\tat
>
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:122)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)\n\tat
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
> java.lang.reflect.Method.invoke(Method.java:606)\n\tat
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
>
> com.google.inject.servlet.ServletDefinition.service(ServletDefi
[jira] [Updated] (ATLAS-805) Quickstart is failing if run after queries to the business taxonomy API
[
https://issues.apache.org/jira/browse/ATLAS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Speidel updated ATLAS-805:
---
Attachment: ATLAS-805.patch
> Quickstart is failing if run after queries to the business taxonomy API
> ---
>
> Key: ATLAS-805
> URL: https://issues.apache.org/jira/browse/ATLAS-805
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: John Speidel
>Priority: Blocker
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-805.patch, application.log
>
>
> * On a fresh Atlas server, using a REST client like curl or Postman, make a
> call to the business taxonomy API. E.g.
> http://localhost:21000/api/atlas/v1/taxonomies
> * This will return an empty result set
> * Run quick_start.py.
> This fails with an exception as follows:
> {code}
> Exception in thread "main" org.apache.atlas.AtlasServiceException: Metadata
> service API CREATE_ENTITY failed with status 500(Internal Server Error)
> Response Body ({"error":"Could not commit transaction due to exception during
> persistence","stackTrace":"com.thinkaurelius.titan.core.TitanException: Could
> not commit transaction due to exception during persistence\n\tat
> com.thinkaurelius.titan.graphdb.transaction.StandardTitanTx.commit(StandardTitanTx.java:1348)\n\tat
>
> com.thinkaurelius.titan.graphdb.blueprints.TitanBlueprintsGraph.commit(TitanBlueprintsGraph.java:60)\n\tat
>
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:43)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:321)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:316)\n\tat
>
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:122)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)\n\tat
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
> java.lang.reflect.Method.invoke(Method.java:606)\n\tat
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
>
> com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:182)\n\tat
>
> com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)\n\tat
>
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)\n\tat
> org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:71)\n\tat
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)\n\tat
[jira] [Commented] (ATLAS-805) Quickstart is failing if run after queries to the business taxonomy API
[
https://issues.apache.org/jira/browse/ATLAS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289335#comment-15289335
]
John Speidel commented on ATLAS-805:
oops, wrong Hemanth. Sorry.
I meant to specify: [~yhemanth]
> Quickstart is failing if run after queries to the business taxonomy API
> ---
>
> Key: ATLAS-805
> URL: https://issues.apache.org/jira/browse/ATLAS-805
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: John Speidel
>Priority: Blocker
> Fix For: 0.7-incubating
>
> Attachments: application.log
>
>
> * On a fresh Atlas server, using a REST client like curl or Postman, make a
> call to the business taxonomy API. E.g.
> http://localhost:21000/api/atlas/v1/taxonomies
> * This will return an empty result set
> * Run quick_start.py.
> This fails with an exception as follows:
> {code}
> Exception in thread "main" org.apache.atlas.AtlasServiceException: Metadata
> service API CREATE_ENTITY failed with status 500(Internal Server Error)
> Response Body ({"error":"Could not commit transaction due to exception during
> persistence","stackTrace":"com.thinkaurelius.titan.core.TitanException: Could
> not commit transaction due to exception during persistence\n\tat
> com.thinkaurelius.titan.graphdb.transaction.StandardTitanTx.commit(StandardTitanTx.java:1348)\n\tat
>
> com.thinkaurelius.titan.graphdb.blueprints.TitanBlueprintsGraph.commit(TitanBlueprintsGraph.java:60)\n\tat
>
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:43)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:321)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:316)\n\tat
>
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:122)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)\n\tat
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
> java.lang.reflect.Method.invoke(Method.java:606)\n\tat
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
>
> com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:182)\n\tat
>
> com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)\n\tat
>
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)\n\tat
> org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:71)\n\tat
> com.google.inject.servlet.FilterChainInvo
[jira] [Commented] (ATLAS-805) Quickstart is failing if run after queries to the business taxonomy API
[
https://issues.apache.org/jira/browse/ATLAS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289321#comment-15289321
]
John Speidel commented on ATLAS-805:
[~Hemanth] Adding @GraphTransaction to BaseQuery.execute() doesn't result in
the transaction interceptor being invoked because the catalog directory isn't
included in the repository metadata model where the interceptor is registered.
Explicitly calling commit in base query appears to fix this issue.
I need to do some more testing and want to look over a few more things before
providing a patch.
> Quickstart is failing if run after queries to the business taxonomy API
> ---
>
> Key: ATLAS-805
> URL: https://issues.apache.org/jira/browse/ATLAS-805
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: John Speidel
>Priority: Blocker
> Fix For: 0.7-incubating
>
> Attachments: application.log
>
>
> * On a fresh Atlas server, using a REST client like curl or Postman, make a
> call to the business taxonomy API. E.g.
> http://localhost:21000/api/atlas/v1/taxonomies
> * This will return an empty result set
> * Run quick_start.py.
> This fails with an exception as follows:
> {code}
> Exception in thread "main" org.apache.atlas.AtlasServiceException: Metadata
> service API CREATE_ENTITY failed with status 500(Internal Server Error)
> Response Body ({"error":"Could not commit transaction due to exception during
> persistence","stackTrace":"com.thinkaurelius.titan.core.TitanException: Could
> not commit transaction due to exception during persistence\n\tat
> com.thinkaurelius.titan.graphdb.transaction.StandardTitanTx.commit(StandardTitanTx.java:1348)\n\tat
>
> com.thinkaurelius.titan.graphdb.blueprints.TitanBlueprintsGraph.commit(TitanBlueprintsGraph.java:60)\n\tat
>
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:43)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:321)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:316)\n\tat
>
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:122)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)\n\tat
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
> java.lang.reflect.Method.invoke(Method.java:606)\n\tat
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
>
> com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:182)\n\tat
[jira] [Commented] (ATLAS-805) Quickstart is failing if run after queries to the business taxonomy API
[
https://issues.apache.org/jira/browse/ATLAS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289274#comment-15289274
]
John Speidel commented on ATLAS-805:
Typically in transactional systems, wrapping non-mutating queries in a
transaction isn't required.
But, after looking into this issue I discovered that Titan actually does
mutations to the graph behind the scenes during non-mutating queries. So, even
simple read operations need to be committed. As mentioned by Hemanth, the
catalog queries weren't being committed, which resulted in the implicit thread
scoped transaction started by the catalog query remaining active on the thread
after the catalog request completed.
Looking into implementing a solution now.
> Quickstart is failing if run after queries to the business taxonomy API
> ---
>
> Key: ATLAS-805
> URL: https://issues.apache.org/jira/browse/ATLAS-805
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: John Speidel
>Priority: Blocker
> Fix For: 0.7-incubating
>
>
> * On a fresh Atlas server, using a REST client like curl or Postman, make a
> call to the business taxonomy API. E.g.
> http://localhost:21000/api/atlas/v1/taxonomies
> * This will return an empty result set
> * Run quick_start.py.
> This fails with an exception as follows:
> {code}
> Exception in thread "main" org.apache.atlas.AtlasServiceException: Metadata
> service API CREATE_ENTITY failed with status 500(Internal Server Error)
> Response Body ({"error":"Could not commit transaction due to exception during
> persistence","stackTrace":"com.thinkaurelius.titan.core.TitanException: Could
> not commit transaction due to exception during persistence\n\tat
> com.thinkaurelius.titan.graphdb.transaction.StandardTitanTx.commit(StandardTitanTx.java:1348)\n\tat
>
> com.thinkaurelius.titan.graphdb.blueprints.TitanBlueprintsGraph.commit(TitanBlueprintsGraph.java:60)\n\tat
>
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:43)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:321)\n\tat
>
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:316)\n\tat
>
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:122)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)\n\tat
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
> java.lang.reflect.Method.invoke(Method.java:606)\n\tat
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
> javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>
> com.google.injec
[jira] [Updated] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-491: --- Attachment: ATLAS-491.patch > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: > 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch, > ATLAS-491.patch > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287815#comment-15287815 ] John Speidel commented on ATLAS-491: I am going to try to attach the latest patch to this Jira. If you don't see it, then the upload failed again. Attempting to upload the previous patch failed and it appears that it caused your network to be blacklisted. > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: > 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287810#comment-15287810 ] John Speidel commented on ATLAS-491: Regarding the question about Taxonomy results being returned with entity queries. To be clear, this observation is with DSL queries and not "v1/entities" queries which won't return taxonomy results. The reason for this is that taxonomies are implemented as entities under the covers. Terms are modeled as traits under the covers. To provide a 'singleton' term instance, each term(trait) is associated with its owning taxonomy. > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: > 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 47382: ATLAS-491 : Business Catalog API
/AtlasEntityQuery.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION distro/src/conf/policy-store.txt b072b49 pom.xml 5e2871e repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 webapp/pom.xml de48c15 webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml f0b606e webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47382/diff/ Testing --- Ran all existing unit tests and added new tests. Thanks, John Speidel
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57> > > > > This would be a problem if multiple threads are trying to define the > > type at the same time (as could happen if multiple clients are trying to > > create taxonomies / terms at the same time). We should move type > > registration to a one time activity as the rest of the framework. > > John Speidel wrote: > ok, I will investigate this but I didn't see a way to do this without > making changes to Atlas proper, which was a desing goal based on team input. > > Hemanth Yamijala wrote: > John, we do one time model registration of other models like Hive, Sqoop, > Storm etc. These are done one time when the (active) server starts up. The > method was introduced in ATLAS-512. Broadly it involves generating a model > definition and writing it out as a json file as part of the build process. > This is then packaged under the models directory and is picked up > automatically by the server at start up. If you could go through the patch in > ATLAS-512 and follow the same steps we should be good for fixing this. I would prefer to handle this in another patch if that is ok with you. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133328 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java
Re: Review Request 47382: ATLAS-491 : Business Catalog API
sourceProvider.java, > > line 47 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383420#file1383420line47> > > > > Would request have ID-property in all cases? If not, consider adding > > request.toString() to the exception message. AtlasQuery implementations > > should return appropriate value from toString(). Yes, the request would fail validation if the id isn't provided so the request will always contain the ID property at this point. I agree that it would be nice to provide a user friendly toString() implementation to AtlasQuery implementations, unfortunately the toString() provided by GremlinPipeline isn't very user friendly so a bit of work will be required to provide this. Would it be ok to handle this as a separate follow-up Jira? > On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote: > > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java, line > > 37 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383428#file1383428line37> > > > > Since this method requires ID to be given, consider renaming this to > > getResourceById(). > > > > Also consider if making the return type to "SingleResult" (a new class) > > would make it easier to read/understand. "Result" deals with a Collection > > of propertyMaps. ok, I will rename the method. Yes, it would probably be cleaner to return a result specific to single results. Due to time considerations, this patch is being offered for review in a state that isn't consistent with my normal standards for a patch being posted for review. So, there are many refactorings and other cleanup that I would like to do but just didn't/don't have the time. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133355 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/ja
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 8:04 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java, > > line 116 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383421#file1383421line116> > > > > Both these TODOs are kind of important, and we need to probably file > > follow-up JIRAs to address these. ok, I will create follow-up Jira's for these. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review19 ------- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java > PRE-CREATION > > catal
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57> > > > > This would be a problem if multiple threads are trying to define the > > type at the same time (as could happen if multiple clients are trying to > > create taxonomies / terms at the same time). We should move type > > registration to a one time activity as the rest of the framework. ok, I will investigate this but I didn't see a way to do this without making changes to Atlas proper, which was a desing goal based on team input. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133328 ------- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.j
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, > > line 37 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383456#file1383456line37> > > > > If I understood this correctly, the basepipe for the Gremlin search for > > entities begins by trying to identify all entity vertices (by virtue of > > using the full text search property that is common to all vertices). This > > would still be a huge result set to begin with, no? This is currently the only way to identify an entity vertex with the current database model. It is a requirement to be able to search all entity types and to be able to apply tags to entities across types. So, we need to be able to get all of the entity vertices, which is the set that would be returned from the base query. The biggest issue with using this field to determine the entity set is that it isn't indexed. Also, the query starts with V(), which is all vertices in the graph but this doesn't result in all vertices being returned but instead adds them to the pipeline interator. That being said, there are lots of improvements that can be made to improve query performance. This would include, changes to the database model so that we knew the propery names ahead of time so that we could use an index instead of a filter. Also, one optimization that I was going to add which didn't make it in was to use the type if it was provided so that indexes could be used as mentioned above. For now, I don't think that we can improve on this. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review12 ------- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVer
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 7:50 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, > > line 37 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383499#file1383499line37> > > > > When would the UI flows use this service as opposed to the original > > entity service? Are all methods here required? All of these methods are needed IMO. I don't know when the UI will use DSL queries vs these new queries. The service handles all of the requirements for querying entities for tags as well as tagging entities, which the current DSL doesn't. So, if the UI needs to make a query that is handled by the currentl DSL, then they can use a DSL query could be used. The service doesn't handle creation or modification of entities as this wasn't in scope. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review17 ------- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDef
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 5:17 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, > > line 35 > > <https://reviews.apache.org/r/47382/diff/1/?file=1383499#file1383499line35> > > > > Trying to access these resources with master is giving me this > > exception: > > > > == > > javax.servlet.ServletException: Unable to find Atlas Resource > > corresponding to : v1 > > at > > org.apache.atlas.authorize.AtlasAuthorizationUtils.getAtlasResourceType(AtlasAuthorizationUtils.java:112) > > > > == > > Changes are required in Atlas authorization module to allow these new > > resources. ok, I will look into what changes are needed in AtlasAuthorizationUtils. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133325 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definitio
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 2:27 p.m., Hemanth Yamijala wrote: > > Good catch Hemanth. This property is supposed to default to 'true' but at some point during cleanup/refactoring I broke this and didn't catch it because all of my functional tests set this value and there is no unit test for this. I will chage the default back to true and add a unit test to assert this. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133357 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.j
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 6:41 a.m., Hemanth Yamijala wrote: > > ok, I will use the other constructor along with calling of the necessary setters. But to be honest, why this constructor should be marked this way makes absolutely no sense to me. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review11 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 6:31 a.m., Hemanth Yamijala wrote: > > "id" is the "clean" form for the underlying "__guid" property. The mapping between clean and fully qualified property names is handled by the PropertyMapper implementation. The user only deals with the clean name which is then translated to the fully qualified name which is used in the back end operations. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review10 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/cata
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 5:17 a.m., Hemanth Yamijala wrote: > > ok - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133325 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java > PRE-CREATION > > catalog/src/main/
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 4:53 a.m., Hemanth Yamijala wrote: > > Actually this change shouldn't have been included in the patch. It was from an old local commit to fix the error message. I will revert back to the old msg. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133323 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java > PRE-CREATION &
Re: Review Request 47382: ATLAS-491 : Business Catalog API
> On May 16, 2016, 4:09 a.m., Hemanth Yamijala wrote: > > Yes, I was originally using this but no longer need to access this method. I will revert to private. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133322 --- On May 14, 2016, 12:58 a.m., John Speidel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47382/ > --- > > (Updated May 14, 2016, 12:58 a.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-491 > https://issues.apache.org/jira/browse/ATLAS-491 > > > Repository: atlas > > > Description > --- > > Initial implementation of Catalog API. > > Known Issues/Limitations: > - No update/delete support for taxonomies/terms > -- this will be added next week > - Some gaps in test coverage > - Need more in-depth test coverage that exercise the generated gremlin > pipeline > - some refactoring should still be done espcecially in the 'query' package > - need to add more logging > - need to finish some javadoc > > > Diffs > - > > catalog/pom.xml PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > PRE-CREATION > catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java > PRE-CREATION > > catalog/src/main/java/org/apache/atl
[jira] [Commented] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283406#comment-15283406 ] John Speidel commented on ATLAS-491: I have been unable to upload the patch to the jira but the latest patch is available at review board. > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: > 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-491: --- Attachment: test.txt > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: > 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch, test.txt > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-491: --- Attachment: ATLAS-491.patch > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: > 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch, > ATLAS-491.patch > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-491: --- Attachment: (was: business-catalog-WIP.patch) > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: > 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-491) Business Catalog / Taxonomy
[ https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-491: --- Attachment: business-catalog-WIP.patch Attached a WIP patch of the business catalog functionality. This code is still a work in progress and needs cleanup/refactoring and hardening and is therefore not ready to be considered for merging. Taxonomy and Term resources currently can't be updated or deleted. Unit tests are not yet included. > Business Catalog / Taxonomy > --- > > Key: ATLAS-491 > URL: https://issues.apache.org/jira/browse/ATLAS-491 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.7-incubating >Reporter: Erik Bergenholtz >Assignee: John Speidel > Fix For: 0.7-incubating > > Attachments: business-catalog-WIP.patch > > > s a Atlas UX user, I need to: > Browse business taxonomy hieracharlically through tree > Search by Tags > Search by combination of keyword, tag, free text in search field > All search from view context of taxonomy. If 3 levels deep, then the search > should be narrow to that scope. > expose search ordering capabilities available through SOLR. > As a Data Steward, I need to: > Manage the taxonomy of objects including > Objects Management: > Creating new objects > Modify the object details - annotations, external links, tags, acceptable use > policy, etc > Delete objects (in UI - changing status in backend,and versioning changes) > Relationship management: > creating relationship of objects as a parent or child > assigning tagging to taxonomy > verify tag inheritance > Verify tag impact on tag based policy - ranger API call > Tag Management: > List > Search > Edit > Delete (change state to archive) > All user should be able to comment on any business catalog entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-706) Unable to query for traits which contain a '.' character in their name
John Speidel created ATLAS-706: -- Summary: Unable to query for traits which contain a '.' character in their name Key: ATLAS-706 URL: https://issues.apache.org/jira/browse/ATLAS-706 Project: Atlas Issue Type: Bug Reporter: John Speidel For traits which contain a '.' character in their name, or most other non alpha-numeric characters, DSL queries using the 'isa' operator fail. This is because the atlas query lexer/parser treat these characters as token separators. So for a trait named "foo.bar" if you do a query for "isa foo.bar" this is parsed as "isa foo". This prevents querying of catalog terms which are modeled as traits and contain '.' characters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-20) Rename env variables from METADATA to ATLAS
[ https://issues.apache.org/jira/browse/ATLAS-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060370#comment-15060370 ] John Speidel commented on ATLAS-20: --- [~suma.shivaprasad] The changes to environment variable names in the patch will require changes in Ambari since Ambari sets these env vars such as "METADATA_CONF", etc. Without these Ambari changes, Ambari will be unable to start Atlas after the env var name changes. > Rename env variables from METADATA to ATLAS > --- > > Key: ATLAS-20 > URL: https://issues.apache.org/jira/browse/ATLAS-20 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.5-incubating >Reporter: Venkatesh Seetharam >Assignee: Rishabh Bhardwaj > Attachments: ATLAS-20.patch, ATLAS-20.v2.patch, ATLAS-20.v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-306) change javadoc generation from 'package' to 'site' phase
[ https://issues.apache.org/jira/browse/ATLAS-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-306: --- Attachment: ATLAS-306-2.patch > change javadoc generation from 'package' to 'site' phase > > > Key: ATLAS-306 > URL: https://issues.apache.org/jira/browse/ATLAS-306 > Project: Atlas > Issue Type: Task > Reporter: John Speidel > Assignee: John Speidel > Attachments: ATLAS-306-2.patch, ATLAS-306.patch > > > Currently the javadoc plugin is executed in the maven 'package' phase. This > causes issues when the project is build as a dependency from another project > which aggregates the javadoc aggregation. Also, generating javadoc in the > 'package' phase negatively affects the build time for developers. > It seems that the current 'standard' is to generate javadocs in the 'site' > phase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-306) change javadoc generation from 'package' to 'site' phase
[ https://issues.apache.org/jira/browse/ATLAS-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-306: --- Attachment: ATLAS-306.patch > change javadoc generation from 'package' to 'site' phase > > > Key: ATLAS-306 > URL: https://issues.apache.org/jira/browse/ATLAS-306 > Project: Atlas > Issue Type: Task > Reporter: John Speidel > Assignee: John Speidel > Attachments: ATLAS-306.patch > > > Currently the javadoc plugin is executed in the maven 'package' phase. This > causes issues when the project is build as a dependency from another project > which aggregates the javadoc aggregation. Also, generating javadoc in the > 'package' phase negatively affects the build time for developers. > It seems that the current 'standard' is to generate javadocs in the 'site' > phase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-298) Add unit test for TitanGraphProvider
John Speidel created ATLAS-298: -- Summary: Add unit test for TitanGraphProvider Key: ATLAS-298 URL: https://issues.apache.org/jira/browse/ATLAS-298 Project: Atlas Issue Type: Task Reporter: John Speidel Assignee: John Speidel Priority: Minor Currently there is no unit test for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-275) Improve error message when creating a trait and not specifying all required trait attributes
[ https://issues.apache.org/jira/browse/ATLAS-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-275: --- Attachment: ATLAS-275.patch > Improve error message when creating a trait and not specifying all required > trait attributes > > > Key: ATLAS-275 > URL: https://issues.apache.org/jira/browse/ATLAS-275 > Project: Atlas > Issue Type: Task > Reporter: John Speidel >Assignee: John Speidel > Attachments: ATLAS-275.patch > > > When an attempt is made to add a trait to an entity where not all of the > trait attributes are provided, the error msg returned to the user is: > "Error deserializing trait instance" > The user than needs to dig through the provided stack trace to see what the > actual problem is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-275) Improve error message when creating a trait and not specifying all required trait attributes
John Speidel created ATLAS-275: -- Summary: Improve error message when creating a trait and not specifying all required trait attributes Key: ATLAS-275 URL: https://issues.apache.org/jira/browse/ATLAS-275 Project: Atlas Issue Type: Task Reporter: John Speidel Assignee: John Speidel When an attempt is made to add a trait to an entity where not all of the trait attributes are provided, the error msg returned to the user is: "Error deserializing trait instance" The user than need to dig through the provided stack trace to see what the actual problem is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ATLAS-275) Improve error message when creating a trait and not specifying all required trait attributes
[
https://issues.apache.org/jira/browse/ATLAS-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985901#comment-14985901
]
John Speidel edited comment on ATLAS-275 at 11/2/15 7:55 PM:
-
Attached patch provides better error message when a required trait attribute is
missing:
{code}
error: "Invalid Trait specified. Field 'expiry_date' can't be null:
AttributeInfo{name='expiry_date',
dataType=org.apache.atlas.typesystem.types.DataTypes$DateType@70cfbe37,
multiplicity=Multiplicity{lower=1, upper=1, isUnique=false}, isComposite=false,
isUnique=false, isIndexable=true, reverseAttributeName='null'}"
{code}
was (Author: jspeidel):
Attached patch provides better error message when a required trait attribute is
missing:
error: "Invalid Trait specified. Field 'expiry_date' can't be null:
AttributeInfo{name='expiry_date',
dataType=org.apache.atlas.typesystem.types.DataTypes$DateType@70cfbe37,
multiplicity=Multiplicity{lower=1, upper=1, isUnique=false}, isComposite=false,
isUnique=false, isIndexable=true, reverseAttributeName='null'}"
> Improve error message when creating a trait and not specifying all required
> trait attributes
>
>
> Key: ATLAS-275
> URL: https://issues.apache.org/jira/browse/ATLAS-275
> Project: Atlas
> Issue Type: Task
> Reporter: John Speidel
>Assignee: John Speidel
> Attachments: ATLAS-275.patch
>
>
> When an attempt is made to add a trait to an entity where not all of the
> trait attributes are provided, the error msg returned to the user is:
> "Error deserializing trait instance"
> The user than needs to dig through the provided stack trace to see what the
> actual problem is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ATLAS-275) Improve error message when creating a trait and not specifying all required trait attributes
[ https://issues.apache.org/jira/browse/ATLAS-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Speidel updated ATLAS-275: --- Description: When an attempt is made to add a trait to an entity where not all of the trait attributes are provided, the error msg returned to the user is: "Error deserializing trait instance" The user than needs to dig through the provided stack trace to see what the actual problem is. was: When an attempt is made to add a trait to an entity where not all of the trait attributes are provided, the error msg returned to the user is: "Error deserializing trait instance" The user than need to dig through the provided stack trace to see what the actual problem is. > Improve error message when creating a trait and not specifying all required > trait attributes > > > Key: ATLAS-275 > URL: https://issues.apache.org/jira/browse/ATLAS-275 > Project: Atlas > Issue Type: Task > Reporter: John Speidel >Assignee: John Speidel > > When an attempt is made to add a trait to an entity where not all of the > trait attributes are provided, the error msg returned to the user is: > "Error deserializing trait instance" > The user than needs to dig through the provided stack trace to see what the > actual problem is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 39134: Remove test class usage of hive configuration property "atlas.rest.address"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39134/ --- Review request for atlas, Shwetha GS and Tom Beerbower. Bugs: ATLAS-212 https://issues.apache.org/jira/browse/ATLAS-212 Repository: atlas Description --- The property "atlas.rest.address" has been removed from hive-site configuration but is still referenced by the class HiveHookIT. Diffs - addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java f4b9350 Diff: https://reviews.apache.org/r/39134/diff/ Testing --- All existing unit tests pass. [INFO] Reactor Summary: [INFO] [INFO] apache-atlas ... SUCCESS [ 1.864 s] [INFO] Apache Atlas Typesystem SUCCESS [ 40.979 s] [INFO] Apache Atlas Common SUCCESS [ 1.325 s] [INFO] Apache Atlas Client SUCCESS [ 5.037 s] [INFO] Apache Atlas Notification .. SUCCESS [ 4.545 s] [INFO] Apache Atlas Repository SUCCESS [03:20 min] [INFO] Apache Atlas Web Application ... SUCCESS [ 28.044 s] [INFO] Apache Atlas Documentation . SUCCESS [ 11.518 s] [INFO] Apache Atlas Hive Bridge ... SUCCESS [ 7.604 s] [INFO] Apache Atlas Distribution .. SUCCESS [ 0.922 s] [INFO] [INFO] BUILD SUCCESS [INFO] Thanks, John Speidel
Re: Review Request 38341: Provide Entity Change Notification
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38341/#review98843
---
Ship it!
Looks good.
Not really an issue with this patch as much as the existing code, I am a little
concerned about the use of a single exception type "AtlasException" everywhere.
Using a single exception type results in the loss of context when an exception
occurs and will likely result in messy, incomplete or even incorrect error
handling in the future.
This was an issue in Ambari and would we should start thinking about this early
on in this project before we get to a point where we can't change it.
notification/src/main/java/org/apache/atlas/notification/entity/EntityChangeConsumer.java
(line 62)
<https://reviews.apache.org/r/38341/#comment155457>
description missing regarding when this exception will be thrown
notification/src/main/java/org/apache/atlas/notification/entity/EntityChangeConsumer.java
(line 136)
<https://reviews.apache.org/r/38341/#comment155459>
Consider using parameterized logging args which would allow for the removal
of the if(isLevel) check.
LOG.debug("Logging event for entity : guid={} : operation={} : values={}",
entity.getId(), operationType, values);
notification/src/main/java/org/apache/atlas/notification/entity/EntityChangeConsumer.java
(line 153)
<https://reviews.apache.org/r/38341/#comment155460>
default block with log message?
notification/src/main/java/org/apache/atlas/notification/entity/EntityImpl.java
(line 83)
<https://reviews.apache.org/r/38341/#comment155461>
Could any of these fields be null? If not, the constructor doesn't enforce
this invariant.
notification/src/main/java/org/apache/atlas/notification/entity/EntityImpl.java
(line 90)
<https://reviews.apache.org/r/38341/#comment155462>
could any of these fields be null?
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
(line 601)
<https://reviews.apache.org/r/38341/#comment155465>
seems odd that an exception is thrown from this method?
- John Speidel
On Sept. 14, 2015, 4:08 a.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38341/
> ---
>
> (Updated Sept. 14, 2015, 4:08 a.m.)
>
>
> Review request for atlas, John Speidel and Shwetha GS.
>
>
> Bugs: ATLAS-158
> https://issues.apache.org/jira/browse/ATLAS-158
>
>
> Repository: atlas
>
>
> Description
> ---
>
> Add entity change notification to Atlas based using the existing
> atlas-notification module.
>
> First cut at a patch for the Atlas entity change notification. Note that at
> a minimum additional unit tests are required. I'm putting up the review to
> get some initial feedback.
>
>
> Diffs
> -
>
> notification/src/main/java/org/apache/atlas/notification/entity/Entity.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityChangeConsumer.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityChangeListener.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityImpl.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java
> PRE-CREATION
> notification/src/main/java/org/apache/atlas/notification/entity/Trait.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/TraitImpl.java
> PRE-CREATION
>
> notification/src/test/java/org/apache/atlas/notification/entity/EntityImplTest.java
> PRE-CREATION
>
> notification/src/test/java/org/apache/atlas/notification/entity/TraitImplTest.java
> PRE-CREATION
> repository/pom.xml 8e4d0f3
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java
> fbd01de
>
> repository/src/main/java/org/apache/atlas/listener/EntityChangeListener.java
> f58d6de
>
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
> 56168db
>
> Diff: https://reviews.apache.org/r/38341/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
> All existing tests pass.
>
> New unit tests added (more required).
>
>
> Thanks,
>
> Tom Beerbower
>
>
