[jira] [Comment Edited] (ATLAS-159) UI generated files should be target
[ https://issues.apache.org/jira/browse/ATLAS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951908#comment-14951908 ] Sanjay Patel edited comment on ATLAS-159 at 10/10/15 4:31 PM: -- [~suma.shivaprasad] We need that empty overlay tag. Overlay works as per first win strategy and empty overlay tag represents current build. Current execution is like maven war plugin executed first then it will try to execute dashboard overlay at that time there is already index.html is present by maven war plugin and that index.html is not getting replaced by dashboard overlay[due to first win strategy]. dashboard overlay index.html must required as it part of out UI. Empty overlay tag represents current build.So now with empty overlay tag execution is like first dashboard overlay was getting executed and then maven war plugin will be executed so we have our dashboard overlay index.html there now. if you run a build without empty overlay tag you will not get our UI on 21000 port. was (Author: sanjayp): [~suma.shivaprasad] We need that empty overlay tag. Overlay works as per first win strategy and empty overlay tag represents current build. Current execution is like maven war plugin executed first then it will try to execute dashboard overlay at that time there is already index.html is present by maven war plugin and that index.html is not getting replaced by dashboard overlay[due to first win strategy]. dashboard overlay index.html must required as it part of out UI. Empty overlay tag represents current build.So now with empty overlay tag execution is like first dashboard overlay was getting executed and then maven war plugin will be executed so we have our dashboard overlay index.html there now. if you run a build without empty overlay you will not get our UI on 21000 port. > UI generated files should be target > --- > > Key: ATLAS-159 > URL: https://issues.apache.org/jira/browse/ATLAS-159 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Sanjay Patel >Priority: Blocker > Fix For: 0.6-incubating > > Attachments: ATLAS-159.v1.patch, ATLAS-159.v2.patch, > ATLAS-159.v3.patch > > > All the downloaded/generated files(like folders lib, node, node_modules etc) > from UI plugins should be in target so that mvn clean can clean up these > files. Build is broken because of this: > https://builds.apache.org/job/apache-atlas-nightly/72/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ATLAS-159) UI generated files should be target
[ https://issues.apache.org/jira/browse/ATLAS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951669#comment-14951669 ] Sanjay Patel edited comment on ATLAS-159 at 10/10/15 7:18 AM: -- [~suma.shivaprasad] We did moved bower cache, bower registry and other generated files to dashbaord/target directory. rat check fails due to file you have mentioned *createTag.html*. I did updated code and tested, now its working fine. I have attached updated patch ATLAS-159.v3.patch was (Author: sanjayp): [~suma.shivaprasad] We did moved bower cache, bower registry and other generated files to dashbaord/target directory. rat check fails due to file you have mentioned *createTag.html*. I have updated this file and tested, now its working fine. I have attached updated patch ATLAS-159.v3.patch > UI generated files should be target > --- > > Key: ATLAS-159 > URL: https://issues.apache.org/jira/browse/ATLAS-159 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Sanjay Patel >Priority: Blocker > Attachments: ATLAS-159.v1.patch, ATLAS-159.v2.patch, > ATLAS-159.v3.patch > > > All the downloaded/generated files(like folders lib, node, node_modules etc) > from UI plugins should be in target so that mvn clean can clean up these > files. Build is broken because of this: > https://builds.apache.org/job/apache-atlas-nightly/72/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ATLAS-159) UI generated files should be target
[ https://issues.apache.org/jira/browse/ATLAS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905728#comment-14905728 ] Sanjay Patel edited comment on ATLAS-159 at 9/24/15 3:01 AM: - Added dashboard as maven module. was (Author: sanjayp): Added dashboard as maven module > UI generated files should be target > --- > > Key: ATLAS-159 > URL: https://issues.apache.org/jira/browse/ATLAS-159 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Sanjay Patel >Priority: Blocker > Attachments: ATLAS-159.v1.patch > > > All the downloaded/generated files(like folders lib, node, node_modules etc) > from UI plugins should be in target so that mvn clean can clean up these > files. Build is broken because of this: > https://builds.apache.org/job/apache-atlas-nightly/72/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ATLAS-159) UI generated files should be target
[ https://issues.apache.org/jira/browse/ATLAS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746603#comment-14746603 ] Vishal Kadam edited comment on ATLAS-159 at 9/16/15 2:53 AM: - [~shwethags], we will take a look into intermittent failure. Regarding adding making dashboard as maven module, what kind of packaging you would like to have it? I will recommend to have *war* and then use war overlay in webapp. was (Author: vkadam): [~shwethags], we will take a look into intermittent failure. Regarding adding making dashboard as maven module, what kind of package you would like to have it? I will recommend to have *war* and then use war overlay in webapp. > UI generated files should be target > --- > > Key: ATLAS-159 > URL: https://issues.apache.org/jira/browse/ATLAS-159 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Sanjay Patel >Priority: Blocker > > All the downloaded/generated files(like folders lib, node, node_modules etc) > from UI plugins should be in target so that mvn clean can clean up these > files. Build is broken because of this: > https://builds.apache.org/job/apache-atlas-nightly/72/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ATLAS-159) UI generated files should be target
[
https://issues.apache.org/jira/browse/ATLAS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744836#comment-14744836
]
Shwetha G S edited comment on ATLAS-159 at 9/15/15 5:04 AM:
UI plugin fails sometimes and re-run goes through fine
{code}
[INFO] --- frontend-maven-plugin:0.0.23:grunt (grunt dist) @ atlas-webapp ---
[INFO] Running 'grunt build --no-color' in
/Users/sshivalingamurthy/git/atlas/dashboard
[INFO] Running "copy:dist" (copy) task
[INFO] Created 19 directories, copied 25 files
[INFO]
[INFO] Running "minify" task
[INFO]
[INFO] Running "shell:min" (shell) task
[ERROR] Error: Could not find or load main class
org.angularjs.closurerunner.NgClosureRunner
[INFO] Warning: Command failed: Error: Could not find or load main class
org.angularjs.closurerunner.NgClosureRunner
[INFO] Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Atlas Web Application ... FAILURE [ 32.434 s]
[INFO] Apache Atlas Documentation . SKIPPED
[INFO] Apache Atlas Hive Bridge ... SKIPPED
[INFO] Apache Atlas Distribution .. SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 33.691 s
[INFO] Finished at: 2015-09-15T10:30:23+05:30
[INFO] Final Memory: 69M/556M
[INFO]
[ERROR] Failed to execute goal
com.github.eirslett:frontend-maven-plugin:0.0.23:grunt (grunt dist) on project
atlas-webapp: Failed to run task: 'grunt build --no-color' failed. (error code
6) -> [Help 1]
[ERROR]
{code}
was (Author: shwethags):
UI plugin fails sometimes and re-run goes through fine
{nofomat}
[INFO] --- frontend-maven-plugin:0.0.23:grunt (grunt dist) @ atlas-webapp ---
[INFO] Running 'grunt build --no-color' in
/Users/sshivalingamurthy/git/atlas/dashboard
[INFO] Running "copy:dist" (copy) task
[INFO] Created 19 directories, copied 25 files
[INFO]
[INFO] Running "minify" task
[INFO]
[INFO] Running "shell:min" (shell) task
[ERROR] Error: Could not find or load main class
org.angularjs.closurerunner.NgClosureRunner
[INFO] Warning: Command failed: Error: Could not find or load main class
org.angularjs.closurerunner.NgClosureRunner
[INFO] Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Atlas Web Application ... FAILURE [ 32.434 s]
[INFO] Apache Atlas Documentation . SKIPPED
[INFO] Apache Atlas Hive Bridge ... SKIPPED
[INFO] Apache Atlas Distribution .. SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 33.691 s
[INFO] Finished at: 2015-09-15T10:30:23+05:30
[INFO] Final Memory: 69M/556M
[INFO]
[ERROR] Failed to execute goal
com.github.eirslett:frontend-maven-plugin:0.0.23:grunt (grunt dist) on project
atlas-webapp: Failed to run task: 'grunt build --no-color' failed. (error code
6) -> [Help 1]
[ERROR]
{noformat}
> UI generated files should be target
> ---
>
> Key: ATLAS-159
> URL: https://issues.apache.org/jira/browse/ATLAS-159
> Project: Atlas
> Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Sanjay Patel
>Priority: Blocker
>
> All the downloaded/generated files(like folders lib, node, node_modules etc)
> from UI plugins should be in target so that mvn clean can clean up these
> files. Build is broken because of this:
> https://builds.apache.org/job/apache-atlas-nightly/72/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
