[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495442#comment-15495442 ] Apoorv Naik commented on ATLAS-1098: Attaching the new patch with unit tests. They seem to be failing at the moment. Need a second pair of eyes to go through it. > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > Attachments: ATLAS-1098.patch, ATLAS-1098.patch > > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492435#comment-15492435 ] Suma Shivaprasad commented on ATLAS-1098: - Reopening issue to revert the earlier changes and reattach the patch after appling Shwetha's patch to address [~davidrad]'s review comments. [~apoorvnaik] Can you raise a patch for the same > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > Attachments: ATLAS-1098.patch > > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486193#comment-15486193 ] Apoorv Naik commented on ATLAS-1098: Yes I tried escaping the keywords and it still doesn't work. > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485324#comment-15485324 ] Suma Shivaprasad commented on ATLAS-1098: - [~apoorvnaik] Does the parser break even with an escaped keyword. For eg:Table where Table isA `isA` > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483587#comment-15483587 ] David Radley commented on ATLAS-1098: - Hello, I have just seen the commit going through for this. It looks like a tag of isa, clashed with a keyword in Gremlin and the fix was to police out these keywords. My feeling is that there should be no restrictions to tag names. If we want Atlas to be a widely used metadata server, I do not think it should have restrictions on the use of any metadata values (which I guess we would need to document) , based on restrictions passed through from the implementation. Without any restrictions metadata can be modelled intuitively without needing to be aware and needing to compensate for the "quirks" of Atlas. all the best, David. > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483468#comment-15483468 ] Shwetha G S commented on ATLAS-1098: Sorry for the late review as I was away last few days. I have added comments on reviewboard, can you address them? > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483078#comment-15483078 ] Shwetha G S commented on ATLAS-1098: [~apoorvnaik], please link the review board request to the jira for your future patches. Thanks > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478384#comment-15478384 ] Madhan Neethiraj commented on ATLAS-1098: - http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/96f2306f > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457431#comment-15457431 ] Apoorv Naik commented on ATLAS-1098: This behavior is independent of the case as well > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search
[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457367#comment-15457367 ] Apoorv Naik commented on ATLAS-1098: Initial analysis reveals that any tag/trait created with the exact same name as keywords that form the gremlin query would run into this issue. The solution would be to block creation of any such tags. > Atlas allows creation of tag with name "isa" which causes exceptions during > search > -- > > Key: ATLAS-1098 > URL: https://issues.apache.org/jira/browse/ATLAS-1098 > Project: Atlas > Issue Type: Bug >Reporter: Sharmadha Sainath >Assignee: Apoorv Naik > > Created a tag with name "isa". DSL query "Table where Table isa isa" throws > exception . Search in Tag tab also throws exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
