[jira] [Commented] (ATLAS-1129) Remove notification failed logs on retry and add sleep between retries
[ https://issues.apache.org/jira/browse/ATLAS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428573#comment-15428573 ] Madhan Neethiraj commented on ATLAS-1129: - +1 for ATLAS-1129-v3.patch. Thanks [~svimal2106] > Remove notification failed logs on retry and add sleep between retries > -- > > Key: ATLAS-1129 > URL: https://issues.apache.org/jira/browse/ATLAS-1129 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating >Reporter: Vimal Sharma >Assignee: Vimal Sharma > Fix For: 0.8-incubating > > Attachments: ATLAS-1129-v2.patch, ATLAS-1129-v3.patch, > ATLAS-1129.3.patch, ATLAS-1129.patch > > > Atlas notification interface logs the exception if it cannot send the message > successfully. Further, the retries are attempted immediately. > Remove the exception logs for individual retry and add sleep between retries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1129) Remove notification failed logs on retry and add sleep between retries
[
https://issues.apache.org/jira/browse/ATLAS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428468#comment-15428468
]
Madhan Neethiraj commented on ATLAS-1129:
-
Comments:
bq. notificationRetryInterval =
atlasProperties.getInt(ATLAS_NOTIFICATION_RETRY_INTERVAL, 100);
Default value of 100ms seems too low. I would suggest to use default value of
at least 2 seconds.
bq. LOG.error("Notification send retry failed");
It will help to add a little more information in the log message, like:
LOG.error("Failed to send notification - attempt #" + numRetries + "; error=" +
e.getMessage());
bq. LOG.info("Sleeping for {} ms before retry", notificationRetryInterval);
Consider using 'debug' log level for this message
> Remove notification failed logs on retry and add sleep between retries
> --
>
> Key: ATLAS-1129
> URL: https://issues.apache.org/jira/browse/ATLAS-1129
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1129-v2.patch, ATLAS-1129.patch
>
>
> Atlas notification interface logs the exception if it cannot send the message
> successfully. Further, the retries are attempted immediately.
> Remove the exception logs for individual retry and add sleep between retries
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-1129) Remove notification failed logs on retry and add sleep between retries
[ https://issues.apache.org/jira/browse/ATLAS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428174#comment-15428174 ] Vimal Sharma commented on ATLAS-1129: - Removed warning log from KafkaNotification as well > Remove notification failed logs on retry and add sleep between retries > -- > > Key: ATLAS-1129 > URL: https://issues.apache.org/jira/browse/ATLAS-1129 > Project: Atlas > Issue Type: Bug >Reporter: Vimal Sharma >Assignee: Vimal Sharma > Attachments: ATLAS-1129-v2.patch, ATLAS-1129.patch > > > Atlas notification interface logs the exception if it cannot send the message > successfully. Further, the retries are attempted immediately. > Remove the exception logs for individual retry and add sleep between retries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1129) Remove notification failed logs on retry and add sleep between retries
[ https://issues.apache.org/jira/browse/ATLAS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428129#comment-15428129 ] Shwetha G S commented on ATLAS-1129: The patch looks good otherwise > Remove notification failed logs on retry and add sleep between retries > -- > > Key: ATLAS-1129 > URL: https://issues.apache.org/jira/browse/ATLAS-1129 > Project: Atlas > Issue Type: Bug >Reporter: Vimal Sharma >Assignee: Vimal Sharma > Attachments: ATLAS-1129.patch > > > Atlas notification interface logs the exception if it cannot send the message > successfully. Further, the retries are attempted immediately. > Remove the exception logs for individual retry and add sleep between retries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1129) Remove notification failed logs on retry and add sleep between retries
[ https://issues.apache.org/jira/browse/ATLAS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427998#comment-15427998 ] Shwetha G S commented on ATLAS-1129: In NotificationHookConsumer, move log of sleeping before Thread.sleep > Remove notification failed logs on retry and add sleep between retries > -- > > Key: ATLAS-1129 > URL: https://issues.apache.org/jira/browse/ATLAS-1129 > Project: Atlas > Issue Type: Bug >Reporter: Vimal Sharma >Assignee: Vimal Sharma > Attachments: ATLAS-1129.patch > > > Atlas notification interface logs the exception if it cannot send the message > successfully. Further, the retries are attempted immediately. > Remove the exception logs for individual retry and add sleep between retries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
