[jira] [Commented] (ATLAS-1305) Fix potential NPEs in instance conversion code

2016-11-17 Thread Madhan Neethiraj (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675796#comment-15675796
 ] 

Madhan Neethiraj commented on ATLAS-1305:
-

+1 for the patch. One suggestion though: instead of adding to indent-level 
inside the loop, consider using a 'continue' as shown below. I think this will 
help in easier readability.

{code}
   if (attrType == null) {
   LOG.warn("{0}: invalid type for attribute {1}. Ignored", 
attrDef.getTypeName() attrDef.getName());
   continue;
   }
{code}

> Fix potential NPEs in instance conversion code
> --
>
> Key: ATLAS-1305
> URL: https://issues.apache.org/jira/browse/ATLAS-1305
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1305.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1305) Fix potential NPEs in instance conversion code

2016-11-18 Thread Suma Shivaprasad (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677401#comment-15677401
 ] 

Suma Shivaprasad commented on ATLAS-1305:
-

Addressed RC. 

> Fix potential NPEs in instance conversion code
> --
>
> Key: ATLAS-1305
> URL: https://issues.apache.org/jira/browse/ATLAS-1305
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1305.1.patch, ATLAS-1305.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1305) Fix potential NPEs in instance conversion code

2016-11-18 Thread Madhan Neethiraj (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677457#comment-15677457
 ] 

Madhan Neethiraj commented on ATLAS-1305:
-

+1

> Fix potential NPEs in instance conversion code
> --
>
> Key: ATLAS-1305
> URL: https://issues.apache.org/jira/browse/ATLAS-1305
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1305.1.patch, ATLAS-1305.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1305) Fix potential NPEs in instance conversion code

2016-11-28 Thread Qiang Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701397#comment-15701397
 ] 

Qiang Zhang commented on ATLAS-1305:


+1

> Fix potential NPEs in instance conversion code
> --
>
> Key: ATLAS-1305
> URL: https://issues.apache.org/jira/browse/ATLAS-1305
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1305.1.patch, ATLAS-1305.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)