[jira] [Commented] (ATLAS-674) Falcon Hook should use timestamps instead of long

2016-08-18 Thread Ayub Khan (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426260#comment-15426260
 ] 

Ayub Khan commented on ATLAS-674:
-

Tested by submitting falcon cluster, feed and process. No issues observed.

> Falcon Hook should use timestamps instead of long
> -
>
> Key: ATLAS-674
> URL: https://issues.apache.org/jira/browse/ATLAS-674
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-674-1.patch, ATLAS-674-2.patch, ATLAS-674.patch
>
>
> For eg: TIMESTAMP attribute is of type LONG. should be of type Date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-674) Falcon Hook should use timestamps instead of long

2016-08-18 Thread Ayub Khan (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426211#comment-15426211
 ] 

Ayub Khan commented on ATLAS-674:
-

Thanks [~shwethags]. I have updated the patch with the suggestion. Since this 
timestamp variable is not used in falcon model, I have verified that the UTs 
are working fine.

> Falcon Hook should use timestamps instead of long
> -
>
> Key: ATLAS-674
> URL: https://issues.apache.org/jira/browse/ATLAS-674
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-674-1.patch, ATLAS-674.patch
>
>
> For eg: TIMESTAMP attribute is of type LONG. should be of type Date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-674) Falcon Hook should use timestamps instead of long

2016-08-18 Thread Shwetha G S (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426111#comment-15426111
 ] 

Shwetha G S commented on ATLAS-674:
---

There are no timestamps in falcon model. The patch here changes an internal 
variable which is not used anywhere. Can you just remove the variable instead 
of changing the variable type.?

> Falcon Hook should use timestamps instead of long
> -
>
> Key: ATLAS-674
> URL: https://issues.apache.org/jira/browse/ATLAS-674
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-674-1.patch, ATLAS-674.patch
>
>
> For eg: TIMESTAMP attribute is of type LONG. should be of type Date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-674) Falcon Hook should use timestamps instead of long

2016-08-17 Thread Ayub Khan (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424805#comment-15424805
 ] 

Ayub Khan commented on ATLAS-674:
-

Thanks for the review [~suma.shivaprasad]. I have updated the patch with the 
comments.

> Falcon Hook should use timestamps instead of long
> -
>
> Key: ATLAS-674
> URL: https://issues.apache.org/jira/browse/ATLAS-674
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-674-1.patch, ATLAS-674.patch
>
>
> For eg: TIMESTAMP attribute is of type LONG. should be of type Date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-674) Falcon Hook should use timestamps instead of long

2016-08-17 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424798#comment-15424798
 ] 

Suma Shivaprasad commented on ATLAS-674:


+1

> Falcon Hook should use timestamps instead of long
> -
>
> Key: ATLAS-674
> URL: https://issues.apache.org/jira/browse/ATLAS-674
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-674-1.patch, ATLAS-674.patch
>
>
> For eg: TIMESTAMP attribute is of type LONG. should be of type Date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-674) Falcon Hook should use timestamps instead of long

2016-08-17 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424762#comment-15424762
 ] 

Suma Shivaprasad commented on ATLAS-674:


1.pls use new Date(System.currentTimeInMillis()) instead of Calender
2. Make changes in FalconDataModelGenerator

> Falcon Hook should use timestamps instead of long
> -
>
> Key: ATLAS-674
> URL: https://issues.apache.org/jira/browse/ATLAS-674
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-674.patch
>
>
> For eg: TIMESTAMP attribute is of type LONG. should be of type Date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-674) Falcon Hook should use timestamps instead of long

2016-08-17 Thread Ayub Khan (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424629#comment-15424629
 ] 

Ayub Khan commented on ATLAS-674:
-

Build was successful with the patch and the tests are passing.
[~madhan.neethiraj] / [~suma.shivaprasad] / [~shwethags] Please review the 
patch.

> Falcon Hook should use timestamps instead of long
> -
>
> Key: ATLAS-674
> URL: https://issues.apache.org/jira/browse/ATLAS-674
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-674.patch
>
>
> For eg: TIMESTAMP attribute is of type LONG. should be of type Date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)