[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322570#comment-15322570 ] Hemanth Yamijala commented on ATLAS-693: Just a quick note that atlas/graphdb/titan0/dependency-reduced-pom.xml is missing an Apache license and RAT check is failing. (haven't really looked at the patch - just trying to compile and see). > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322636#comment-15322636 ] Jeffrey Hagelberg commented on ATLAS-693: - oh - that file is not supposed to be in the patch. I'll remove it. It is generated by maven. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322639#comment-15322639 ] Jeffrey Hagelberg commented on ATLAS-693: - Actually, I don't think it is in the patch. I think for the other JIRA I ended up adding it to the rat excludes list. I'll investigate. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323672#comment-15323672 ] Hemanth Yamijala commented on ATLAS-693: I downloaded the latest patch from review board and tried to compile. While the RAT error is gone, I see this failure: {code} [ERROR] /Users/hyamijala/projects/hwx/atlas/src/atlas/webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java:157: error: cannot find symbol [ERROR] secretProvider = AuthenticationFilter.constructSecretProvider( [ERROR] ^ [ERROR] symbol: method constructSecretProvider(ServletContext,Properties,boolean) [ERROR] location: class AuthenticationFilter [ERROR] /Users/hyamijala/projects/hwx/atlas/src/atlas/webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java:145: error: method does not override or implement a method from a supertype [ERROR] @Override [ERROR] ^ [ERROR] Note: Some input files use or override a deprecated API. [ERROR] Note: Recompile with -Xlint:deprecation for details. [ERROR] Note: Some input files use unchecked or unsafe operations. [ERROR] Note: Recompile with -Xlint:unchecked for details. [ERROR] 2 errors [INFO] [INFO] Reactor Summary: [INFO] [INFO] apache-atlas ... SUCCESS [ 7.158 s] [INFO] Apache Atlas Common SUCCESS [ 8.431 s] [INFO] Apache Atlas Typesystem SUCCESS [ 31.761 s] [INFO] Apache Atlas Client SUCCESS [ 9.352 s] [INFO] Apache Atlas Server API SUCCESS [ 3.967 s] [INFO] Apache Atlas Notification .. SUCCESS [ 6.063 s] [INFO] Apache Atlas Graph Database Projects ... SUCCESS [ 0.113 s] [INFO] Apache Atlas Graph Database API SUCCESS [ 1.611 s] [INFO] Apache Atlas Titan 0.5.4 Graph DB Impl . SUCCESS [ 32.643 s] [INFO] Apache Atlas Repository SUCCESS [ 54.876 s] [INFO] Apache Atlas Authorization . SUCCESS [ 5.586 s] [INFO] Apache Atlas Business Catalog .. SUCCESS [ 9.000 s] [INFO] Apache Atlas UI SUCCESS [01:49 min] [INFO] Apache Atlas Web Application ... FAILURE [ 5.834 s] {code} I see it is totally unrelated. However, I did revert the patch once and build master and master seems to be building fine. Can you please investigate? Thanks! > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch, rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324483#comment-15324483 ] Jeffrey Hagelberg commented on ATLAS-693: - Sure. I'll investigate and upload another patch. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch, rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387016#comment-15387016 ] ATLAS QA commented on ATLAS-693: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12818680/rb47466.patch against master revision b73e62b. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/416//console This message is automatically generated. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406197#comment-15406197 ] David Kantor commented on ATLAS-693: [~shwethags] [~suma.shivaprasad] [~yhemanth] [~madhan.neethiraj] This JIRA has been awaiting review and committal for more than 2 months. It is purely additive, has been extensively tested here, and I have reviewed and voted for this change. I am planning on committing this patch by EOD tomorrow (Thursday 8/4). > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408288#comment-15408288 ] Jeffrey Hagelberg commented on ATLAS-693: - Changes has been rebased. Latest patch attached. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410165#comment-15410165 ] Jeffrey Hagelberg commented on ATLAS-693: - Fixed version in titan0\pom.xml > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410287#comment-15410287 ] David Kantor commented on ATLAS-693: Committed to master. Thanks [~jnhagelb] > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291930#comment-15291930 ] David Kantor commented on ATLAS-693: +1 > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295946#comment-15295946 ] ATLAS QA commented on ATLAS-693: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12804675/rb47466.patch against master revision 353ea96. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:red}-1 javac{color}. The applied patch generated 140 javac compiler warnings (more than the master's current 136 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 379 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Javac warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/241//console This message is automatically generated. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298356#comment-15298356 ] Jeffrey Hagelberg commented on ATLAS-693: - I discovered an issue with the updated patch. I'll upload a new one soon. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298388#comment-15298388 ] ATLAS QA commented on ATLAS-693: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12805906/rb47466.patch against master revision 74d9b3f. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:red}-1 javac{color}. The applied patch generated 140 javac compiler warnings (more than the master's current 136 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 380 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Javac warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/248//console This message is automatically generated. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298785#comment-15298785 ] ATLAS QA commented on ATLAS-693: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12805945/rb47466.patch against master revision 74d9b3f. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:red}-1 javac{color}. The applied patch generated 140 javac compiler warnings (more than the master's current 136 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 380 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Javac warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/249//console This message is automatically generated. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299089#comment-15299089 ] Jeffrey Hagelberg commented on ATLAS-693: - Looks like the build failure is because there are 4 checkstyle violations. I'll address those. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:check (checkstyle-check) on project atlas-common: You have 4 Checkstyle violations. -> [Help 1] > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300281#comment-15300281 ] ATLAS QA commented on ATLAS-693: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12806139/rb47466.patch against master revision 74d9b3f. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:red}-1 javac{color}. The applied patch generated 140 javac compiler warnings (more than the master's current 136 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 380 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Javac warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//console This message is automatically generated. > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304241#comment-15304241 ] Jeffrey Hagelberg commented on ATLAS-693: - Looks like I missed 2 checkstyle violations: /home/jenkins/jenkins-slave/workspace/PreCommit-ATLAS-Build/common/src/main/java/org/apache/atlas/repository/Constants.java:21: Missing a Javadoc comment. /home/jenkins/jenkins-slave/workspace/PreCommit-ATLAS-Build/common/src/main/java/org/apache/atlas/repository/Constants.java:46: First sentence should end with a period. I thought those were fixed... > Add titan 0.5.4 implemenation of graph database abstraction layer > - > > Key: ATLAS-693 > URL: https://issues.apache.org/jira/browse/ATLAS-693 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 0.6-incubating >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Fix For: trunk > > Attachments: rb47466.patch > > > In this task, we put in place the titan 0.5.4 implementation of the graph > database abstraction layer. As part of this effort, the existing "titan" > maven project will be merged into this new project, since it is specific to > titan 0.5.4. The maven projects in Atlas that depend on the "titan" will be > changed to depend on the new project. Direct dependencies on titan 0.5.4 > will be removed from all of the atlas projects. These projects will be > changed to depend on this new project instead. They will transitively obtain > the dependencies on titan 0.5.4 that they need. For this task, very little > of the existing Atlas java / scala code will be changed. The classes from in > the titan project will be moved verbatim into the new project. The only > other changes will be the addition of the new classes that implement the > abstraction layer interfaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)