[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563455#comment-15563455 ] Suma Shivaprasad commented on ATLAS-694: +1. Ran tests and the unit tests are all passing. > Update Atlas code to use abstraction layer > -- > > Key: ATLAS-694 > URL: https://issues.apache.org/jira/browse/ATLAS-694 > Project: Atlas > Issue Type: Sub-task >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Attachments: ATLAS-694.patch, rb47810.patch > > > In this task, we will update Atlas to replace the direct usage of titan > classes with usage of the equivalent interfaces in the abstraction layer. At > this point, there will be no options to configure the abstraction layer > implementation that gets used. Atlas will be hard-coded to use the titan > 0.5.4 implementation. It will also continue to have a compile time > dependency on the titan 0.5.4 graph database implementation. When this task > is complete, Atlas will only be accessing titan through the abstraction layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563448#comment-15563448 ] Jeffrey Hagelberg commented on ATLAS-694: - [~suma.shivaprasad] - Dave just called me, the patch attached here represents that latest version of the ATLAS-694 code. Please feel free to commit it, and definitely let me know if you find any problems. > Update Atlas code to use abstraction layer > -- > > Key: ATLAS-694 > URL: https://issues.apache.org/jira/browse/ATLAS-694 > Project: Atlas > Issue Type: Sub-task >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Attachments: ATLAS-694.patch, rb47810.patch > > > In this task, we will update Atlas to replace the direct usage of titan > classes with usage of the equivalent interfaces in the abstraction layer. At > this point, there will be no options to configure the abstraction layer > implementation that gets used. Atlas will be hard-coded to use the titan > 0.5.4 implementation. It will also continue to have a compile time > dependency on the titan 0.5.4 graph database implementation. When this task > is complete, Atlas will only be accessing titan through the abstraction layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532743#comment-15532743 ] Jeffrey Hagelberg commented on ATLAS-694: - Thanks. I'm still in the process updating the abstraction layer index creation methods and generally applying the changes from the other code review comments. Some urgent stuff has come up, and I've also been out sick, but I'm hoping to get back to that soon. > Update Atlas code to use abstraction layer > -- > > Key: ATLAS-694 > URL: https://issues.apache.org/jira/browse/ATLAS-694 > Project: Atlas > Issue Type: Sub-task >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Attachments: ATLAS-694.patch, rb47810.patch > > > In this task, we will update Atlas to replace the direct usage of titan > classes with usage of the equivalent interfaces in the abstraction layer. At > this point, there will be no options to configure the abstraction layer > implementation that gets used. Atlas will be hard-coded to use the titan > 0.5.4 implementation. It will also continue to have a compile time > dependency on the titan 0.5.4 graph database implementation. When this task > is complete, Atlas will only be accessing titan through the abstraction layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317230#comment-15317230 ] ATLAS QA commented on ATLAS-694: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12808454/rb47810.patch against master revision d661964. {color:red}-1 @author{color}. The patch appears to contain 1 @author tags which the Atlas community has agreed to not allow in code contributions. {color:green}+1 tests included{color}. The patch appears to include 35 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 383 new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 3 release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/291//console This message is automatically generated. > Update Atlas code to use abstraction layer > -- > > Key: ATLAS-694 > URL: https://issues.apache.org/jira/browse/ATLAS-694 > Project: Atlas > Issue Type: Sub-task >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Attachments: rb47810.patch > > > In this task, we will update Atlas to replace the direct usage of titan > classes with usage of the equivalent interfaces in the abstraction layer. At > this point, there will be no options to configure the abstraction layer > implementation that gets used. Atlas will be hard-coded to use the titan > 0.5.4 implementation. It will also continue to have a compile time > dependency on the titan 0.5.4 graph database implementation. When this task > is complete, Atlas will only be accessing titan through the abstraction layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317140#comment-15317140 ] ATLAS QA commented on ATLAS-694: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12808451/rb47810.patch against master revision d661964. {color:red}-1 @author{color}. The patch appears to contain 1 @author tags which the Atlas community has agreed to not allow in code contributions. {color:green}+1 tests included{color}. The patch appears to include 35 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 383 new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 3 release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/290//console This message is automatically generated. > Update Atlas code to use abstraction layer > -- > > Key: ATLAS-694 > URL: https://issues.apache.org/jira/browse/ATLAS-694 > Project: Atlas > Issue Type: Sub-task >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Attachments: rb47810.patch > > > In this task, we will update Atlas to replace the direct usage of titan > classes with usage of the equivalent interfaces in the abstraction layer. At > this point, there will be no options to configure the abstraction layer > implementation that gets used. Atlas will be hard-coded to use the titan > 0.5.4 implementation. It will also continue to have a compile time > dependency on the titan 0.5.4 graph database implementation. When this task > is complete, Atlas will only be accessing titan through the abstraction layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304592#comment-15304592 ] ATLAS QA commented on ATLAS-694: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12806681/rb47810.patch against master revision 0143486. {color:red}-1 @author{color}. The patch appears to contain 1 @author tags which the Atlas community has agreed to not allow in code contributions. {color:green}+1 tests included{color}. The patch appears to include 35 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 385 new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 3 release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//console This message is automatically generated. > Update Atlas code to use abstraction layer > -- > > Key: ATLAS-694 > URL: https://issues.apache.org/jira/browse/ATLAS-694 > Project: Atlas > Issue Type: Sub-task >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Attachments: rb47810.patch > > > In this task, we will update Atlas to replace the direct usage of titan > classes with usage of the equivalent interfaces in the abstraction layer. At > this point, there will be no options to configure the abstraction layer > implementation that gets used. Atlas will be hard-coded to use the titan > 0.5.4 implementation. It will also continue to have a compile time > dependency on the titan 0.5.4 graph database implementation. When this task > is complete, Atlas will only be accessing titan through the abstraction layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer
[ https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304323#comment-15304323 ] ATLAS QA commented on ATLAS-694: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12806654/rb47810.patch against master revision 0143486. {color:red}-1 @author{color}. The patch appears to contain 1 @author tags which the Atlas community has agreed to not allow in code contributions. {color:green}+1 tests included{color}. The patch appears to include 35 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 385 new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 3 release audit warnings. {color:red}-1 core tests{color}. The test build failed in Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningstitan0.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//console This message is automatically generated. > Update Atlas code to use abstraction layer > -- > > Key: ATLAS-694 > URL: https://issues.apache.org/jira/browse/ATLAS-694 > Project: Atlas > Issue Type: Sub-task >Reporter: Jeffrey Hagelberg >Assignee: Jeffrey Hagelberg > Attachments: rb47810.patch > > > In this task, we will update Atlas to replace the direct usage of titan > classes with usage of the equivalent interfaces in the abstraction layer. At > this point, there will be no options to configure the abstraction layer > implementation that gets used. Atlas will be hard-coded to use the titan > 0.5.4 implementation. It will also continue to have a compile time > dependency on the titan 0.5.4 graph database implementation. When this task > is complete, Atlas will only be accessing titan through the abstraction layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)