[jira] [Commented] (ATLAS-723) JSON deserialization regression
[
https://issues.apache.org/jira/browse/ATLAS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267169#comment-15267169
]
David Kantor commented on ATLAS-723:
+1
> JSON deserialization regression
> ---
>
> Key: ATLAS-723
> URL: https://issues.apache.org/jira/browse/ATLAS-723
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Jeffrey Hagelberg
>Assignee: Neeru Gupta
>Priority: Blocker
> Attachments: InstanceSerializationTest.scala, rb46849.patch
>
>
> Some json that could be deserialized prior to the implementation of soft
> delete can no longer be deserialized. This seems to be related to the
> addition of the "state" field in the id. Furthermore, it seems to be
> restricted to cases where the object has an array reference.
> Here's an example of a JSON object whose deserialization now fails:
> {noformat}
> {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6765f7c6-cc11-4575-8c13-8bab9b3d86a2",
> "version": 0,
> "typeName": "LoadProcess"
> },
> "typeName": "LoadProcess",
> "values": {
> "inputTables": [{
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "bacfa996-e88e-4d7e-9630-68c9829b10b4",
> "version": 0,
> "typeName": "Table"
> }, {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6da06805-3f56-446f-8831-672a65ac2199",
> "version": 0,
> "typeName": "Table"
> }
> ],
> "outputTable": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "d5c3d6d0-aa10-44c1-b05d-ed9400d2a5ac",
> "version": 0,
> "typeName": "Table"
> },
> "name": "loadSalesDaily"
> },
> "traitNames": [
> "ETL"
> ],
> "traits": {
> "ETL": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Struct",
> "typeName": "ETL",
> "values": {
> }
> }
> }
> }
> {noformat}
> (Note that this depends on the referenced Table objects having been
> previously saved into Atlas)
> I spent some time debugging this today, it seems to be a regression in the
> InstanceSerialization class. It seems to be related to
> InstanceJavaConversion.state and InstanceJavaConversion.convertId
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-723) JSON deserialization regression
[
https://issues.apache.org/jira/browse/ATLAS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267067#comment-15267067
]
Suma Shivaprasad commented on ATLAS-723:
+1
> JSON deserialization regression
> ---
>
> Key: ATLAS-723
> URL: https://issues.apache.org/jira/browse/ATLAS-723
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Jeffrey Hagelberg
>Assignee: Neeru Gupta
>Priority: Blocker
> Attachments: InstanceSerializationTest.scala, rb46849.patch
>
>
> Some json that could be deserialized prior to the implementation of soft
> delete can no longer be deserialized. This seems to be related to the
> addition of the "state" field in the id. Furthermore, it seems to be
> restricted to cases where the object has an array reference.
> Here's an example of a JSON object whose deserialization now fails:
> {noformat}
> {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6765f7c6-cc11-4575-8c13-8bab9b3d86a2",
> "version": 0,
> "typeName": "LoadProcess"
> },
> "typeName": "LoadProcess",
> "values": {
> "inputTables": [{
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "bacfa996-e88e-4d7e-9630-68c9829b10b4",
> "version": 0,
> "typeName": "Table"
> }, {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6da06805-3f56-446f-8831-672a65ac2199",
> "version": 0,
> "typeName": "Table"
> }
> ],
> "outputTable": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "d5c3d6d0-aa10-44c1-b05d-ed9400d2a5ac",
> "version": 0,
> "typeName": "Table"
> },
> "name": "loadSalesDaily"
> },
> "traitNames": [
> "ETL"
> ],
> "traits": {
> "ETL": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Struct",
> "typeName": "ETL",
> "values": {
> }
> }
> }
> }
> {noformat}
> (Note that this depends on the referenced Table objects having been
> previously saved into Atlas)
> I spent some time debugging this today, it seems to be a regression in the
> InstanceSerialization class. It seems to be related to
> InstanceJavaConversion.state and InstanceJavaConversion.convertId
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-723) JSON deserialization regression
[
https://issues.apache.org/jira/browse/ATLAS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264738#comment-15264738
]
ATLAS QA commented on ATLAS-723:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12801508/rb46849.patch
against master revision 7d040c5.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
+1 checkstyle. The patch generated 0 code style errors.
{color:red}-1 findbugs{color}. The patch appears to introduce 361 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.RexsterGraphJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.AdminJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.EntityJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.MetadataDiscoveryJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.TypesJerseyResourceIT
Test results:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/189//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/189//console
This message is automatically generated.
> JSON deserialization regression
> ---
>
> Key: ATLAS-723
> URL: https://issues.apache.org/jira/browse/ATLAS-723
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Jeffrey Hagelberg
>Assignee: Neeru Gupta
>Priority: Blocker
> Attachments: InstanceSerializationTest.scala, rb46849.patch
>
>
> Some json that could be deserialized prior to the implementation of soft
> delete can no longer be deserialized. This seems to be related to the
> addition of the "state" field in the id. Furthermore, it seems to be
> restricted to cases where the object has an array reference.
> Here's an example of a JSON object whose deserialization now fails:
> {noformat}
> {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6765f7c6-cc11-4575-8c13-8bab9b3d86a2",
> "version": 0,
> "typeName": "LoadProcess"
> },
> "typeName": "LoadProcess",
> "values": {
> "inputTables": [{
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "bacfa996-e88e-4d7e-9630-68c9829b10b4",
> "version": 0,
> "typeName": "Table"
> }, {
> "jsonClass":
> "org.apache.atlas.typesystem.j
[jira] [Commented] (ATLAS-723) JSON deserialization regression
[
https://issues.apache.org/jira/browse/ATLAS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264621#comment-15264621
]
Neeru Gupta commented on ATLAS-723:
---
This fix has been verified by rpeorter [~jnhagelb].
> JSON deserialization regression
> ---
>
> Key: ATLAS-723
> URL: https://issues.apache.org/jira/browse/ATLAS-723
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Jeffrey Hagelberg
>Assignee: Neeru Gupta
>Priority: Blocker
> Attachments: InstanceSerializationTest.scala, rb46849.patch
>
>
> Some json that could be deserialized prior to the implementation of soft
> delete can no longer be deserialized. This seems to be related to the
> addition of the "state" field in the id. Furthermore, it seems to be
> restricted to cases where the object has an array reference.
> Here's an example of a JSON object whose deserialization now fails:
> {noformat}
> {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6765f7c6-cc11-4575-8c13-8bab9b3d86a2",
> "version": 0,
> "typeName": "LoadProcess"
> },
> "typeName": "LoadProcess",
> "values": {
> "inputTables": [{
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "bacfa996-e88e-4d7e-9630-68c9829b10b4",
> "version": 0,
> "typeName": "Table"
> }, {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6da06805-3f56-446f-8831-672a65ac2199",
> "version": 0,
> "typeName": "Table"
> }
> ],
> "outputTable": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "d5c3d6d0-aa10-44c1-b05d-ed9400d2a5ac",
> "version": 0,
> "typeName": "Table"
> },
> "name": "loadSalesDaily"
> },
> "traitNames": [
> "ETL"
> ],
> "traits": {
> "ETL": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Struct",
> "typeName": "ETL",
> "values": {
> }
> }
> }
> }
> {noformat}
> (Note that this depends on the referenced Table objects having been
> previously saved into Atlas)
> I spent some time debugging this today, it seems to be a regression in the
> InstanceSerialization class. It seems to be related to
> InstanceJavaConversion.state and InstanceJavaConversion.convertId
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-723) JSON deserialization regression
[
https://issues.apache.org/jira/browse/ATLAS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263051#comment-15263051
]
Neeru Gupta commented on ATLAS-723:
---
org.apache.atlas.typesystem.types.ValueConversionException: Cannot convert
value 'org.apache.atlas.typesystem.Struct@71ae6bd6' to datatype PII
at
org.apache.atlas.typesystem.types.TypedStructHandler.convert(TypedStructHandler.java:57)
at
org.apache.atlas.typesystem.types.TraitType.convert(TraitType.java:58)
at
org.apache.atlas.typesystem.types.ClassType.createInstanceWithTraits(ClassType.java:184)
at
org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:124)
at
org.apache.atlas.services.DefaultMetadataService.deserializeClassInstances(DefaultMetadataService.java:339)
at
org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:313)
at
org.apache.atlas.service.DefaultMetadataServiceTest.createInstance(DefaultMetadataServiceTest.java:200)
> JSON deserialization regression
> ---
>
> Key: ATLAS-723
> URL: https://issues.apache.org/jira/browse/ATLAS-723
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Jeffrey Hagelberg
>Assignee: Neeru Gupta
>Priority: Blocker
>
> Some json that could be deserialized prior to the implementation of soft
> delete can no longer be deserialized. This seems to be related to the
> addition of the "state" field in the id. Furthermore, it seems to be
> restricted to cases where the object has an array reference.
> Here's an example of a JSON object whose deserialization now fails:
> {noformat}
> {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6765f7c6-cc11-4575-8c13-8bab9b3d86a2",
> "version": 0,
> "typeName": "LoadProcess"
> },
> "typeName": "LoadProcess",
> "values": {
> "inputTables": [{
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "bacfa996-e88e-4d7e-9630-68c9829b10b4",
> "version": 0,
> "typeName": "Table"
> }, {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "6da06805-3f56-446f-8831-672a65ac2199",
> "version": 0,
> "typeName": "Table"
> }
> ],
> "outputTable": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id": "d5c3d6d0-aa10-44c1-b05d-ed9400d2a5ac",
> "version": 0,
> "typeName": "Table"
> },
> "name": "loadSalesDaily"
> },
> "traitNames": [
> "ETL"
> ],
> "traits": {
> "ETL": {
> "jsonClass":
> "org.apache.atlas.typesystem.json.InstanceSerialization$_Struct",
> "typeName": "ETL",
> "values": {
> }
> }
> }
> }
> {noformat}
> (Note that this depends on the referenced Table objects having been
> previously saved into Atlas)
> I spent some time debugging this today, it seems to be a regression in the
> InstanceSerialization class. It seems to be related to
> InstanceJavaConversion.state and InstanceJavaConversion.convertId
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
