[jira] [Commented] (ATLAS-970) Remove glyphicon from login.jsp

2016-07-04 Thread Keval Bhatt (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361135#comment-15361135
 ] 

Keval Bhatt commented on ATLAS-970:
---

[~shwethags] Review comments are addressed and patch is updated.

> Remove glyphicon from login.jsp
> ---
>
> Key: ATLAS-970
> URL: https://issues.apache.org/jira/browse/ATLAS-970
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Blocker
> Attachments: ATLAS-970.1.patch, ATLAS-970.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-970) Remove glyphicon from login.jsp

2016-07-01 Thread Hemanth Yamijala (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359020#comment-15359020
 ] 

Hemanth Yamijala commented on ATLAS-970:


[~kevalbhatt18], I see two references to this here:

{code}
dashboardv2/public/css/scss/form.scss:.input-group-btn .glyphicon {
dashboardv2/public/css/scss/loader.scss:.glyphicon-spin {
{code}

Are these required, or can they also be removed?

Other than that, looks good to me.

> Remove glyphicon from login.jsp
> ---
>
> Key: ATLAS-970
> URL: https://issues.apache.org/jira/browse/ATLAS-970
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Blocker
> Attachments: ATLAS-970.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-970) Remove glyphicon from login.jsp

2016-07-01 Thread ATLAS QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358846#comment-15358846
 ] 

ATLAS QA commented on ATLAS-970:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12815721/ATLAS-970.patch
  against master revision 1486322.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 380 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/389//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/389//console

This message is automatically generated.

> Remove glyphicon from login.jsp
> ---
>
> Key: ATLAS-970
> URL: https://issues.apache.org/jira/browse/ATLAS-970
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Blocker
> Attachments: ATLAS-970.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)