subject:"Re\: Review Request 47225\: ATLAS\-713 Atlas UI is still showing the deleted column of a hive table \(Entity response of hive table does not have it\). \- with browser cache disabled."

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-17 Thread Shwetha GS


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/
---

(Updated May 18, 2016, 6:32 a.m.)


Review request for atlas.


Changes
---

re-based patch


Bugs: ATLAS-713
https://issues.apache.org/jira/browse/ATLAS-713


Repository: atlas


Description
---

Current lineage APIs work on the dataset name. With soft delete, there can be 
more than one entities for the given dataset name. 
1. Added new lineage APIs(input graph, output graph, schema) which work on 
entity id
2. Modified current lineage APIs to work on the active entity for the given 
dataset name
3. Modified UI to use the new APIs


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
  dashboardv2/public/js/models/VLineage.js e33488a 
  dashboardv2/public/js/models/VSchema.js 1f8e0bb 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js de558a7 
  distro/src/conf/atlas-application.properties 68a0021 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
8dae968 
  
repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
00905d7 
  repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 40f0d91 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 3b50dfb 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
6d5a15a 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
  server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
8dc36cd 
  typesystem/src/main/resources/atlas-application.properties aafad0f 
  
webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
9b3fbc9 
  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java
 PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
 0fb5ea2 

Diff: https://reviews.apache.org/r/47225/diff/


Testing
---

UTs, ITs and end to end test with hive cli


Thanks,

Shwetha GS

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-17 Thread Suma Shivaprasad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/#review133548
---


Ship it!




Ship It!

- Suma Shivaprasad


On May 17, 2016, 8:15 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47225/
> ---
> 
> (Updated May 17, 2016, 8:15 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-713
> https://issues.apache.org/jira/browse/ATLAS-713
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current lineage APIs work on the dataset name. With soft delete, there can be 
> more than one entities for the given dataset name. 
> 1. Added new lineage APIs(input graph, output graph, schema) which work on 
> entity id
> 2. Modified current lineage APIs to work on the active entity for the given 
> dataset name
> 3. Modified UI to use the new APIs
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
>   dashboardv2/public/js/models/VLineage.js e33488a 
>   dashboardv2/public/js/models/VSchema.js 1f8e0bb 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   distro/src/conf/atlas-application.properties 68a0021 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
> 8dae968 
>   
> repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
> 00905d7 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> 66e1365 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
> PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java
>  PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  3b50dfb 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  6d5a15a 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
>   server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
> 8dc36cd 
>   typesystem/src/main/resources/atlas-application.properties aafad0f 
>   
> webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java
>  PRE-CREATION 
>   
> webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
> 9b3fbc9 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java
>  PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
>  bc02f90 
> 
> Diff: https://reviews.apache.org/r/47225/diff/
> 
> 
> Testing
> ---
> 
> UTs, ITs and end to end test with hive cli
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-17 Thread Shwetha GS


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/
---

(Updated May 17, 2016, 8:15 a.m.)


Review request for atlas.


Bugs: ATLAS-713
https://issues.apache.org/jira/browse/ATLAS-713


Repository: atlas


Description
---

Current lineage APIs work on the dataset name. With soft delete, there can be 
more than one entities for the given dataset name. 
1. Added new lineage APIs(input graph, output graph, schema) which work on 
entity id
2. Modified current lineage APIs to work on the active entity for the given 
dataset name
3. Modified UI to use the new APIs


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
  dashboardv2/public/js/models/VLineage.js e33488a 
  dashboardv2/public/js/models/VSchema.js 1f8e0bb 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
  distro/src/conf/atlas-application.properties 68a0021 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
8dae968 
  
repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
00905d7 
  repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 66e1365 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 3b50dfb 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
6d5a15a 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
  server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
8dc36cd 
  typesystem/src/main/resources/atlas-application.properties aafad0f 
  
webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
9b3fbc9 
  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java
 PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
 bc02f90 

Diff: https://reviews.apache.org/r/47225/diff/


Testing
---

UTs, ITs and end to end test with hive cli


Thanks,

Shwetha GS

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-13 Thread Shwetha GS


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/
---

(Updated May 13, 2016, 9:19 a.m.)


Review request for atlas.


Changes
---

Rename of classes


Bugs: ATLAS-713
https://issues.apache.org/jira/browse/ATLAS-713


Repository: atlas


Description
---

Current lineage APIs work on the dataset name. With soft delete, there can be 
more than one entities for the given dataset name. 
1. Added new lineage APIs(input graph, output graph, schema) which work on 
entity id
2. Modified current lineage APIs to work on the active entity for the given 
dataset name
3. Modified UI to use the new APIs


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
  dashboardv2/public/js/models/VLineage.js e33488a 
  dashboardv2/public/js/models/VSchema.js 1f8e0bb 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
  distro/src/conf/atlas-application.properties 68a0021 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
8dae968 
  
repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
00905d7 
  repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 66e1365 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 3b50dfb 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
6d5a15a 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
  server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
8dc36cd 
  typesystem/src/main/resources/atlas-application.properties aafad0f 
  
webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
9b3fbc9 
  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java
 PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
 bc02f90 

Diff: https://reviews.apache.org/r/47225/diff/


Testing
---

UTs, ITs and end to end test with hive cli


Thanks,

Shwetha GS

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-13 Thread Hemanth Yamijala



> On May 12, 2016, 9:12 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java,
> >  lines 69-70
> > 
> >
> > while we are anyways doing this, should we rename HiveLineageService to 
> > DataSetLineageService
> 
> Hemanth Yamijala wrote:
> Change the class name and also the api? I know changing the API will be a 
> breaking change. But doing it now is better than later, no? The UI will be 
> the most impacted from an internal Atlas perspective. Other than that we will 
> need to intimate Atlas dev list. We could pre-announce on dev list *before* 
> the patch gets in, IMO.
> 
> Shwetha GS wrote:
> I will change the classname. 
> 
> I have changed the UI to use the new APIs. So, there are no internal 
> users for the olds APIs. We can probably check in the community and remove 
> the tablename based lineage APIs later (alternative is get id using tablename 
> and use new lineage APIs). So, I don't want to change the path of old lineage 
> APIs. Do you strongly feel for the change

Sounds ok to me. Essentially, it seems like we can deprecate and remove in next 
release.


- Hemanth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/#review132977
---


On May 11, 2016, 9:21 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47225/
> ---
> 
> (Updated May 11, 2016, 9:21 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-713
> https://issues.apache.org/jira/browse/ATLAS-713
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current lineage APIs work on the dataset name. With soft delete, there can be 
> more than one entities for the given dataset name. 
> 1. Added new lineage APIs(input graph, output graph, schema) which work on 
> entity id
> 2. Modified current lineage APIs to work on the active entity for the given 
> dataset name
> 3. Modified UI to use the new APIs
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
>   dashboardv2/public/js/models/VLineage.js e33488a 
>   dashboardv2/public/js/models/VSchema.js 1f8e0bb 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   distro/src/conf/atlas-application.properties 119865d 
>   repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
> 00905d7 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> 66e1365 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  6d5a15a 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
>   server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
> 8dc36cd 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 
> 330d1cb 
>   typesystem/src/main/resources/atlas-application.properties a343a20 
>   
> webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
> 9b3fbc9 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
>  bc02f90 
> 
> Diff: https://reviews.apache.org/r/47225/diff/
> 
> 
> Testing
> ---
> 
> UTs, ITs and end to end test with hive cli
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-13 Thread Shwetha GS



> On May 12, 2016, 9:12 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java,
> >  lines 69-70
> > 
> >
> > while we are anyways doing this, should we rename HiveLineageService to 
> > DataSetLineageService
> 
> Hemanth Yamijala wrote:
> Change the class name and also the api? I know changing the API will be a 
> breaking change. But doing it now is better than later, no? The UI will be 
> the most impacted from an internal Atlas perspective. Other than that we will 
> need to intimate Atlas dev list. We could pre-announce on dev list *before* 
> the patch gets in, IMO.

I will change the classname. 

I have changed the UI to use the new APIs. So, there are no internal users for 
the olds APIs. We can probably check in the community and remove the tablename 
based lineage APIs later (alternative is get id using tablename and use new 
lineage APIs). So, I don't want to change the path of old lineage APIs. Do you 
strongly feel for the change


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/#review132977
---


On May 11, 2016, 9:21 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47225/
> ---
> 
> (Updated May 11, 2016, 9:21 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-713
> https://issues.apache.org/jira/browse/ATLAS-713
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current lineage APIs work on the dataset name. With soft delete, there can be 
> more than one entities for the given dataset name. 
> 1. Added new lineage APIs(input graph, output graph, schema) which work on 
> entity id
> 2. Modified current lineage APIs to work on the active entity for the given 
> dataset name
> 3. Modified UI to use the new APIs
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
>   dashboardv2/public/js/models/VLineage.js e33488a 
>   dashboardv2/public/js/models/VSchema.js 1f8e0bb 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   distro/src/conf/atlas-application.properties 119865d 
>   repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
> 00905d7 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> 66e1365 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  6d5a15a 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
>   server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
> 8dc36cd 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 
> 330d1cb 
>   typesystem/src/main/resources/atlas-application.properties a343a20 
>   
> webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
> 9b3fbc9 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
>  bc02f90 
> 
> Diff: https://reviews.apache.org/r/47225/diff/
> 
> 
> Testing
> ---
> 
> UTs, ITs and end to end test with hive cli
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-12 Thread Hemanth Yamijala



> On May 12, 2016, 9:12 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java,
> >  lines 69-70
> > 
> >
> > while we are anyways doing this, should we rename HiveLineageService to 
> > DataSetLineageService

Change the class name and also the api? I know changing the API will be a 
breaking change. But doing it now is better than later, no? The UI will be the 
most impacted from an internal Atlas perspective. Other than that we will need 
to intimate Atlas dev list. We could pre-announce on dev list *before* the 
patch gets in, IMO.


- Hemanth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/#review132977
---


On May 11, 2016, 9:21 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47225/
> ---
> 
> (Updated May 11, 2016, 9:21 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-713
> https://issues.apache.org/jira/browse/ATLAS-713
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current lineage APIs work on the dataset name. With soft delete, there can be 
> more than one entities for the given dataset name. 
> 1. Added new lineage APIs(input graph, output graph, schema) which work on 
> entity id
> 2. Modified current lineage APIs to work on the active entity for the given 
> dataset name
> 3. Modified UI to use the new APIs
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
>   dashboardv2/public/js/models/VLineage.js e33488a 
>   dashboardv2/public/js/models/VSchema.js 1f8e0bb 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   distro/src/conf/atlas-application.properties 119865d 
>   repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
> 00905d7 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> 66e1365 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  6d5a15a 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
>   server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
> 8dc36cd 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 
> 330d1cb 
>   typesystem/src/main/resources/atlas-application.properties a343a20 
>   
> webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
> 9b3fbc9 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
>  bc02f90 
> 
> Diff: https://reviews.apache.org/r/47225/diff/
> 
> 
> Testing
> ---
> 
> UTs, ITs and end to end test with hive cli
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-12 Thread Suma Shivaprasad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/#review132978
---




repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
(line 146)


rename to DataSetLineageQuery and remove all hive specific references ?


- Suma Shivaprasad


On May 11, 2016, 9:21 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47225/
> ---
> 
> (Updated May 11, 2016, 9:21 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-713
> https://issues.apache.org/jira/browse/ATLAS-713
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current lineage APIs work on the dataset name. With soft delete, there can be 
> more than one entities for the given dataset name. 
> 1. Added new lineage APIs(input graph, output graph, schema) which work on 
> entity id
> 2. Modified current lineage APIs to work on the active entity for the given 
> dataset name
> 3. Modified UI to use the new APIs
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
>   dashboardv2/public/js/models/VLineage.js e33488a 
>   dashboardv2/public/js/models/VSchema.js 1f8e0bb 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   distro/src/conf/atlas-application.properties 119865d 
>   repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
> 00905d7 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> 66e1365 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  6d5a15a 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
>   server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
> 8dc36cd 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 
> 330d1cb 
>   typesystem/src/main/resources/atlas-application.properties a343a20 
>   
> webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
> 9b3fbc9 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
>  bc02f90 
> 
> Diff: https://reviews.apache.org/r/47225/diff/
> 
> 
> Testing
> ---
> 
> UTs, ITs and end to end test with hive cli
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-12 Thread Suma Shivaprasad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/#review132977
---




repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
(lines 65 - 66)


while we are anyways doing this, should we rename HiveLineageService to 
DataSetLineageService


- Suma Shivaprasad


On May 11, 2016, 9:21 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47225/
> ---
> 
> (Updated May 11, 2016, 9:21 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-713
> https://issues.apache.org/jira/browse/ATLAS-713
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current lineage APIs work on the dataset name. With soft delete, there can be 
> more than one entities for the given dataset name. 
> 1. Added new lineage APIs(input graph, output graph, schema) which work on 
> entity id
> 2. Modified current lineage APIs to work on the active entity for the given 
> dataset name
> 3. Modified UI to use the new APIs
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
>   dashboardv2/public/js/models/VLineage.js e33488a 
>   dashboardv2/public/js/models/VSchema.js 1f8e0bb 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   distro/src/conf/atlas-application.properties 119865d 
>   repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
> 00905d7 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> 66e1365 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  6d5a15a 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
>   server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
> 8dc36cd 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 
> 330d1cb 
>   typesystem/src/main/resources/atlas-application.properties a343a20 
>   
> webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
> 9b3fbc9 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
>  bc02f90 
> 
> Diff: https://reviews.apache.org/r/47225/diff/
> 
> 
> Testing
> ---
> 
> UTs, ITs and end to end test with hive cli
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

2016-05-11 Thread Shwetha GS


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47225/
---

(Updated May 11, 2016, 9:21 a.m.)


Review request for atlas.


Changes
---

This should be applied on top of ATLAS-738 patch


Bugs: ATLAS-713
https://issues.apache.org/jira/browse/ATLAS-713


Repository: atlas


Description
---

Current lineage APIs work on the dataset name. With soft delete, there can be 
more than one entities for the given dataset name. 
1. Added new lineage APIs(input graph, output graph, schema) which work on 
entity id
2. Modified current lineage APIs to work on the active entity for the given 
dataset name
3. Modified UI to use the new APIs


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c 
  dashboardv2/public/js/models/VLineage.js e33488a 
  dashboardv2/public/js/models/VSchema.js 1f8e0bb 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
  distro/src/conf/atlas-application.properties 119865d 
  repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 
00905d7 
  repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 66e1365 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
6d5a15a 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 
  server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 
8dc36cd 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 
330d1cb 
  typesystem/src/main/resources/atlas-application.properties a343a20 
  webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 
9b3fbc9 
  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
 bc02f90 

Diff: https://reviews.apache.org/r/47225/diff/


Testing
---

UTs, ITs and end to end test with hive cli


Thanks,

Shwetha GS

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

10 matches

Site Navigation

Mail list logo

Footer information