Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-10-05 Thread Shwetha GS 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/#review101477
---

Ship it!


Ship It!

- Shwetha GS


On Oct. 5, 2015, 9:02 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38179/
> ---
> 
> (Updated Oct. 5, 2015, 9:02 a.m.)
> 
> 
> Review request for atlas and Harish Butani.
> 
> 
> Bugs: ATLAS-128
> https://issues.apache.org/jira/browse/ATLAS-128
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Supporting equality matches on array type as array_type_col_name = [ List 
> of values ] where list of values is a comma separated list of literals which 
> are of primitive type like string, int, etc
> 
> 2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest 
> to use the DefaultGraphPersistenceStrategy instead of the inmemory one so 
> that the real code execution path is tested
> 3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to 
> validate expected test results
> 4. Fixed "typename has fieldname" queries where fieldname was not getting 
> fully qualified with typeName.
> 5. 5. Fixed "type is trait" queries - trait label did not have __
> 
> Could not complete load of list types due to issues with validation in DSL. 
> Will be covering this in a separate jira.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 589ef16 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
>  c446d15 
>   
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
> 97d1fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  b44ce60 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
>  6605ae7 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
>   
> repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
>  2cec503 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  c72ffb2 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  db51ae5 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  bec3067 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
>  20781db 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
>   repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
> c662847 
>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
> 0b4dd2b 
>   repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
>   repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
> 3c66da0 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
> e35453e 
> 
> Diff: https://reviews.apache.org/r/38179/diff/
> 
> 
> Testing
> ---
> 
> Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-10-05 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/
---

(Updated Oct. 5, 2015, 9:02 a.m.)


Review request for atlas and Harish Butani.


Changes
---

Fixed all review comments


Bugs: ATLAS-128
https://issues.apache.org/jira/browse/ATLAS-128


Repository: atlas


Description
---

1. Supporting equality matches on array type as array_type_col_name = [ List of 
values ] where list of values is a comma separated list of literals which are 
of primitive type like string, int, etc

2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest to 
use the DefaultGraphPersistenceStrategy instead of the inmemory one so that the 
real code execution path is tested
3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to validate 
expected test results
4. Fixed "typename has fieldname" queries where fieldname was not getting fully 
qualified with typeName.
5. 5. Fixed "type is trait" queries - trait label did not have __

Could not complete load of list types due to issues with validation in DSL. 
Will be covering this in a separate jira.


Diffs (updated)
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
589ef16 
  
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 c446d15 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
97d1fe2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 b44ce60 
  
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
 6605ae7 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
  
repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
 2cec503 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 c72ffb2 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
db51ae5 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 bec3067 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
 20781db 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
c662847 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
0b4dd2b 
  repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
3c66da0 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
e35453e 

Diff: https://reviews.apache.org/r/38179/diff/


Testing
---

Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest


Thanks,

Suma Shivaprasad

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-10-01 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/
---

(Updated Oct. 1, 2015, 6:42 a.m.)


Review request for atlas and Harish Butani.


Changes
---

Adding back BasHIveRepositoryTest class which was missed


Bugs: ATLAS-128
https://issues.apache.org/jira/browse/ATLAS-128


Repository: atlas


Description
---

1. Supporting equality matches on array type as array_type_col_name = [ List of 
values ] where list of values is a comma separated list of literals which are 
of primitive type like string, int, etc

2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest to 
use the DefaultGraphPersistenceStrategy instead of the inmemory one so that the 
real code execution path is tested
3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to validate 
expected test results
4. Fixed "typename has fieldname" queries where fieldname was not getting fully 
qualified with typeName.
5. 5. Fixed "type is trait" queries - trait label did not have __

Could not complete load of list types due to issues with validation in DSL. 
Will be covering this in a separate jira.


Diffs (updated)
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
589ef16 
  
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 c446d15 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
97d1fe2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 b44ce60 
  
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
 6605ae7 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
  
repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
 2cec503 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 c72ffb2 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
db51ae5 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 bec3067 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
 20781db 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
c662847 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
0b4dd2b 
  repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
3c66da0 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
e35453e 

Diff: https://reviews.apache.org/r/38179/diff/


Testing
---

Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest


Thanks,

Suma Shivaprasad

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-09-30 Thread Suma Shivaprasad 


> On Sept. 30, 2015, 10:57 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java,
> >  line 189
> > 
> >
> > add todo and break?

Removed comment. Will throw exception in these cases


> On Sept. 30, 2015, 10:57 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java,
> >  line 125
> > 
> >
> > It should use arrType.convert()

Its doing that in the constructInstance amd mapVertexToInstance?


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/#review101105
---


On Oct. 1, 2015, 6:36 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38179/
> ---
> 
> (Updated Oct. 1, 2015, 6:36 a.m.)
> 
> 
> Review request for atlas and Harish Butani.
> 
> 
> Bugs: ATLAS-128
> https://issues.apache.org/jira/browse/ATLAS-128
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Supporting equality matches on array type as array_type_col_name = [ List 
> of values ] where list of values is a comma separated list of literals which 
> are of primitive type like string, int, etc
> 
> 2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest 
> to use the DefaultGraphPersistenceStrategy instead of the inmemory one so 
> that the real code execution path is tested
> 3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to 
> validate expected test results
> 4. Fixed "typename has fieldname" queries where fieldname was not getting 
> fully qualified with typeName.
> 5. 5. Fixed "type is trait" queries - trait label did not have __
> 
> Could not complete load of list types due to issues with validation in DSL. 
> Will be covering this in a separate jira.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 589ef16 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
>  c446d15 
>   
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
> 97d1fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  b44ce60 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
>  6605ae7 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
>   
> repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
>  2cec503 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  c72ffb2 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  db51ae5 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  bec3067 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
>  20781db 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
>   repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
> c662847 
>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
> 0b4dd2b 
>   repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
>   repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
> 3c66da0 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
> e35453e 
> 
> Diff: https://reviews.apache.org/r/38179/diff/
> 
> 
> Testing
> ---
> 
> Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-09-30 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/
---

(Updated Oct. 1, 2015, 6:36 a.m.)


Review request for atlas and Harish Butani.


Changes
---

Fixed review comments


Bugs: ATLAS-128
https://issues.apache.org/jira/browse/ATLAS-128


Repository: atlas


Description
---

1. Supporting equality matches on array type as array_type_col_name = [ List of 
values ] where list of values is a comma separated list of literals which are 
of primitive type like string, int, etc

2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest to 
use the DefaultGraphPersistenceStrategy instead of the inmemory one so that the 
real code execution path is tested
3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to validate 
expected test results
4. Fixed "typename has fieldname" queries where fieldname was not getting fully 
qualified with typeName.
5. 5. Fixed "type is trait" queries - trait label did not have __

Could not complete load of list types due to issues with validation in DSL. 
Will be covering this in a separate jira.


Diffs (updated)
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
589ef16 
  
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 c446d15 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
97d1fe2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 b44ce60 
  
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
 6605ae7 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
  
repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
 2cec503 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 c72ffb2 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
db51ae5 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 bec3067 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
 20781db 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
c662847 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
0b4dd2b 
  repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
3c66da0 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
e35453e 

Diff: https://reviews.apache.org/r/38179/diff/


Testing
---

Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest


Thanks,

Suma Shivaprasad

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-09-30 Thread Shwetha GS 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/#review101105
---


Thanks for fixing those test


repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 (line 124)


It should use arrType.convert()



repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 (line 188)


add todo and break?



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 (line 120)


actually, edge and trait labels shouldn't have __ prefix. Should we fix it 
or leave it as is?



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 (line 1264)


referredType is already available and no need to get from type system


- Shwetha GS


On Sept. 23, 2015, 4:40 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38179/
> ---
> 
> (Updated Sept. 23, 2015, 4:40 p.m.)
> 
> 
> Review request for atlas and Harish Butani.
> 
> 
> Bugs: ATLAS-128
> https://issues.apache.org/jira/browse/ATLAS-128
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Supporting equality matches on array type as array_type_col_name = [ List 
> of values ] where list of values is a comma separated list of literals which 
> are of primitive type like string, int, etc
> 
> 2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest 
> to use the DefaultGraphPersistenceStrategy instead of the inmemory one so 
> that the real code execution path is tested
> 3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to 
> validate expected test results
> 4. Fixed "typename has fieldname" queries where fieldname was not getting 
> fully qualified with typeName.
> 5. 5. Fixed "type is trait" queries - trait label did not have __
> 
> Could not complete load of list types due to issues with validation in DSL. 
> Will be covering this in a separate jira.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 589ef16 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
>  c446d15 
>   
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
> 97d1fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  b44ce60 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
>  6605ae7 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
>   
> repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
>  2cec503 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
> PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  c72ffb2 
>   
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
>  db51ae5 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  bec3067 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
>  20781db 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
>   repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
> c662847 
>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
> 0b4dd2b 
>   repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
>   repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
> 3c66da0 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
> e35453e 
> 
> Diff: https://reviews.apache.org/r/38179/diff/
> 
> 
> Testing
> ---
> 
> Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-09-23 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/
---

(Updated Sept. 23, 2015, 4:40 p.m.)


Review request for atlas and Harish Butani.


Bugs: ATLAS-128
https://issues.apache.org/jira/browse/ATLAS-128


Repository: atlas


Description (updated)
---

1. Supporting equality matches on array type as array_type_col_name = [ List of 
values ] where list of values is a comma separated list of literals which are 
of primitive type like string, int, etc

2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest to 
use the DefaultGraphPersistenceStrategy instead of the inmemory one so that the 
real code execution path is tested
3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to validate 
expected test results
4. Fixed "typename has fieldname" queries where fieldname was not getting fully 
qualified with typeName.
5. 5. Fixed "type is trait" queries - trait label did not have __

Could not complete load of list types due to issues with validation in DSL. 
Will be covering this in a separate jira.


Diffs
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
589ef16 
  
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 c446d15 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
97d1fe2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 b44ce60 
  
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
 6605ae7 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
  
repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
 2cec503 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 c72ffb2 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
db51ae5 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 bec3067 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
 20781db 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
c662847 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
0b4dd2b 
  repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
3c66da0 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
e35453e 

Diff: https://reviews.apache.org/r/38179/diff/


Testing
---

Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest


Thanks,

Suma Shivaprasad

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-09-23 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/
---

(Updated Sept. 23, 2015, 6:50 a.m.)


Review request for atlas and Harish Butani.


Bugs: ATLAS-128
https://issues.apache.org/jira/browse/ATLAS-128


Repository: atlas


Description (updated)
---

1. Supporting equality matches on array type as array_type_col_name = [ List of 
values ] where list of values is a comma separated list of literals which are 
of primitive type like string, int, etc

2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest to 
use the DefaultGraphPersistenceStrategy instead of the inmemory one so that the 
real code execution path is tested
3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to validate 
expected test results
4. Fixed "typename has fieldname" queries where fieldname was not getting fully 
qualified with typeName.

Could not complete load of list types due to issues with validation in DSL. 
Will be covering this in a separate jira.


Diffs
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
589ef16 
  
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 c446d15 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
97d1fe2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 b44ce60 
  
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
 6605ae7 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
  
repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
 2cec503 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 c72ffb2 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
db51ae5 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 bec3067 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
 20781db 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
c662847 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
0b4dd2b 
  repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
3c66da0 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
e35453e 

Diff: https://reviews.apache.org/r/38179/diff/


Testing (updated)
---

Tests added in Parser, GremlinTest,  GraphBackedDiscoveryTest


Thanks,

Suma Shivaprasad

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

2015-09-22 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/
---

(Updated Sept. 22, 2015, 5:54 p.m.)


Review request for atlas and Harish Butani.


Changes
---

Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest to use 
the DefaultGraphPersistenceStrategy instead of the inmemory one so that the 
real code execution path is tested
Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to validate 
expected test results

Could not complete load of list types due to issues with validation in DSL. 
Will be covering this in a separate jira.


Bugs: ATLAS-128
https://issues.apache.org/jira/browse/ATLAS-128


Repository: atlas


Description
---

Supporting equality matches on array type as array_type_col_name = [ List of 
values ] where list of values is a comma separated list of literals which are 
of primitive type like string, int, etc

TODO - supporting loading of array of class types. Add tests for array of 
struct, class type loading


Diffs (updated)
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
589ef16 
  
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 c446d15 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
97d1fe2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 b44ce60 
  
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
 6605ae7 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
  
repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
 2cec503 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d 
  repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 c72ffb2 
  
repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 
db51ae5 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 bec3067 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
 20781db 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
c662847 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
0b4dd2b 
  repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
3c66da0 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
e35453e 

Diff: https://reviews.apache.org/r/38179/diff/


Testing
---

Tests added in GremlinTest


Thanks,

Suma Shivaprasad

Review Request 38179: ATLAS-128 - Equality matches on lists

2015-09-08 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38179/
---

Review request for atlas and Harish Butani.


Bugs: ATLAS-128
https://issues.apache.org/jira/browse/ATLAS-128


Repository: atlas


Description
---

Supporting equality matches on array type as array_type_col_name = [ List of 
values ] where list of values is a comma separated list of literals which are 
of primitive type like string, int, etc

TODO - supporting loading of array of class types. Add tests for array of 
struct, class type loading


Diffs
-

  addons/hive-bridge/pom.xml 914d8c6 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
2bf3aba 
  pom.xml a2b0b26 
  
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
 c446d15 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
1b0faa5 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 cc10ea3 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 
  
repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
 2cec503 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 
  repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala 
eef13df 
  repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 
  repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
ec21886 
  src/main/assemblies/src-package.xml ca03c7a 
  src/main/assemblies/standalone-package.xml 8c48b22 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
e35453e 
  webapp/pom.xml 65c7bde 

Diff: https://reviews.apache.org/r/38179/diff/


Testing
---

Tests added in GremlinTest


Thanks,

Suma Shivaprasad