Re: Review Request 48688: ATLAS-886 : Improve association of terms with entity (Show tree view)

2016-06-16 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48688/
---

(Updated June 16, 2016, 1:14 p.m.)


Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and 
Hemanth Yamijala.


Changes
---

Tree navigation issue fixed.


Bugs: ATLAS-886
https://issues.apache.org/jira/browse/ATLAS-886


Repository: atlas


Description
---

Currently, UI shows hierarchical name Terms in the popup, which might be 
confusing for end users if they have long list of terms. Need to improve 
association of terms with entity and Show tree view so that users can traverse 
through the tree of Terms to select a term.


Diffs (updated)
-

  dashboardv2/public/css/scss/business-catlog.scss 1b364af 
  dashboardv2/public/css/scss/main.scss 933bc19 
  dashboardv2/public/css/scss/override.scss 76edcb2 
  dashboardv2/public/css/scss/tag.scss fb10ed0 
  dashboardv2/public/css/scss/theme.scss 6f0ca41 
  dashboardv2/public/css/scss/tree.scss 139b1bb 
  dashboardv2/public/js/router/Router.js 64605bd 
  
dashboardv2/public/js/templates/business_catalog/AddTermToEntityLayoutView_tmpl.html
 f84f47d 
  
dashboardv2/public/js/templates/business_catalog/BusinessCatalogLayoutView_tmpl.html
 5923da9 
  dashboardv2/public/js/templates/business_catalog/TreeLayoutView_tmpl.html 
PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
8d7dd6e 
  dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 57836ed 
  dashboardv2/public/js/utils/CommonViewFunction.js 2b1ff4d 
  dashboardv2/public/js/utils/Messages.js 257d5e0 
  dashboardv2/public/js/utils/Overrides.js d46a94f 
  dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js 
a5356f2 
  
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js 
3cf3ec2 
  dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 7a3d9a1 
  dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js 
92fe48a 
  dashboardv2/public/js/views/business_catalog/TreeLayoutView.js PRE-CREATION 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 4cd8ccb 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 45ffa53 

Diff: https://reviews.apache.org/r/48688/diff/


Testing
---

**Verfied:** 
1) Association of terms with assets using tree genrerated on popup.
2) Fixed issue rased in ATLAS-893.
3) Also showing breadcrumb type of indication while showing associated Term and 
its hierarchy in search results table and schema table.


Thanks,

keval bhatt



Review Request 48688: ATLAS-886 : Improve association of terms with entity (Show tree view)

2016-06-14 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48688/
---

Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and 
Hemanth Yamijala.


Bugs: ATLAS-886
https://issues.apache.org/jira/browse/ATLAS-886


Repository: atlas


Description
---

Currently, UI shows hierarchical name Terms in the popup, which might be 
confusing for end users if they have long list of terms. Need to improve 
association of terms with entity and Show tree view so that users can traverse 
through the tree of Terms to select a term.


Diffs
-

  dashboardv2/public/css/scss/business-catlog.scss 1b364af 
  dashboardv2/public/css/scss/main.scss 933bc19 
  dashboardv2/public/css/scss/tag.scss fb10ed0 
  dashboardv2/public/css/scss/theme.scss 6f0ca41 
  dashboardv2/public/css/scss/tree.scss 139b1bb 
  dashboardv2/public/js/router/Router.js 64605bd 
  
dashboardv2/public/js/templates/business_catalog/AddTermToEntityLayoutView_tmpl.html
 f84f47d 
  
dashboardv2/public/js/templates/business_catalog/BusinessCatalogLayoutView_tmpl.html
 5923da9 
  dashboardv2/public/js/templates/business_catalog/TreeLayoutView_tmpl.html 
PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
8d7dd6e 
  dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 57836ed 
  dashboardv2/public/js/utils/CommonViewFunction.js 2b1ff4d 
  dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js 
a5356f2 
  dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 7a3d9a1 
  dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js 
92fe48a 
  dashboardv2/public/js/views/business_catalog/TreeLayoutView.js PRE-CREATION 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 4cd8ccb 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 45ffa53 

Diff: https://reviews.apache.org/r/48688/diff/


Testing
---

**Verfied:** 
1) Association of terms with assets using tree genrerated on popup.
2) Fixed issue rased in ATLAS-893.
3) Also showing breadcrumb type of indication while showing associated Term and 
its hierarchy in search results table and schema table.


Thanks,

keval bhatt