Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/#review166048
---


Ship it!




Ship It!

- Apoorv Naik


On Feb. 19, 2017, 7:09 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56818/
> ---
> 
> (Updated Feb. 19, 2017, 7:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1569
> https://issues.apache.org/jira/browse/ATLAS-1569
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - cleared the contents of RequestContextV2 at the end of each servlet request 
> and notification processing
> - updated notification processing to generate audit log only on the first 
> attempt (and not during retries)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  c16fd66 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 
> 
> Diff: https://reviews.apache.org/r/56818/diff/
> 
> 
> Testing
> ---
> 
> Verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/#review166038
---




webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 (line 259)


Good point. It makes sense to audit at the end of handling the message - 
whether it is successful or not. Similarly, the audit generated for the webapp 
should also be  done post-exec - so that the result (HTTP status code) can be 
recorded.

I would suggest this update be taken up in a seprate JIRA.


- Madhan Neethiraj


On Feb. 19, 2017, 7:09 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56818/
> ---
> 
> (Updated Feb. 19, 2017, 7:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1569
> https://issues.apache.org/jira/browse/ATLAS-1569
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - cleared the contents of RequestContextV2 at the end of each servlet request 
> and notification processing
> - updated notification processing to generate audit log only on the first 
> attempt (and not during retries)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  c16fd66 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 
> 
> Diff: https://reviews.apache.org/r/56818/diff/
> 
> 
> Testing
> ---
> 
> Verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/#review166037
---




webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 (line 259)


Does it make sense to record audit only after the entity 
creation/updation/deletion was successful


- Vimal Sharma


On Feb. 19, 2017, 7:09 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56818/
> ---
> 
> (Updated Feb. 19, 2017, 7:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1569
> https://issues.apache.org/jira/browse/ATLAS-1569
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - cleared the contents of RequestContextV2 at the end of each servlet request 
> and notification processing
> - updated notification processing to generate audit log only on the first 
> attempt (and not during retries)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  c16fd66 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 
> 
> Diff: https://reviews.apache.org/r/56818/diff/
> 
> 
> Testing
> ---
> 
> Verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/
---

Review request for atlas.


Bugs: ATLAS-1569
https://issues.apache.org/jira/browse/ATLAS-1569


Repository: atlas


Description
---

- cleared the contents of RequestContextV2 at the end of each servlet request 
and notification processing
- updated notification processing to generate audit log only on the first 
attempt (and not during retries)


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 c16fd66 
  webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 

Diff: https://reviews.apache.org/r/56818/diff/


Testing
---

Verified that the unit tests pass successfully


Thanks,

Madhan Neethiraj