Re: Review Request 56825: Taxonomy test failure fixes

2017-02-20 Thread Jeff Hagelberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/#review166106
---


Fix it, then Ship it!





webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 


Minor comment - now the transactionInitialized variable is unused and can 
be removed.


- Jeff Hagelberg


On Feb. 19, 2017, 7:26 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56825/
> ---
> 
> (Updated Feb. 19, 2017, 7:26 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1570
> https://issues.apache.org/jira/browse/ATLAS-1570
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Introduction of the StateTransactionCleanupFilter caused a side-effect that 
> led to test failures
> 
> 
> Diffs
> -
> 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 
> 45df9c7c 
> 
> Diff: https://reviews.apache.org/r/56825/diff/
> 
> 
> Testing
> ---
> 
> mvn clean install executes successfully with some regular IT failures
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 56825: Taxonomy test failure fixes

2017-02-19 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/#review166042
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 19, 2017, 7:26 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56825/
> ---
> 
> (Updated Feb. 19, 2017, 7:26 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1570
> https://issues.apache.org/jira/browse/ATLAS-1570
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Introduction of the StateTransactionCleanupFilter caused a side-effect that 
> led to test failures
> 
> 
> Diffs
> -
> 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 
> 45df9c7c 
> 
> Diff: https://reviews.apache.org/r/56825/diff/
> 
> 
> Testing
> ---
> 
> mvn clean install executes successfully with some regular IT failures
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Review Request 56825: Taxonomy test failure fixes

2017-02-19 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/
---

Review request for atlas.


Bugs: ATLAS-1570
https://issues.apache.org/jira/browse/ATLAS-1570


Repository: atlas


Description
---

Introduction of the StateTransactionCleanupFilter caused a side-effect that led 
to test failures


Diffs
-

  webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 
45df9c7c 

Diff: https://reviews.apache.org/r/56825/diff/


Testing
---

mvn clean install executes successfully with some regular IT failures


Thanks,

Apoorv Naik