[jira] [Commented] (AVRO-2035) default value for boolean field cannot be a string

[radai rosenblatt (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052670#comment-16052670
 ] 

radai rosenblatt commented on AVRO-2035:


Is there any reason why the schema parser shouldnt validate default values by 
default? given that such a schema, if it slips past the parser is not generally 
usable (any scenario where the default value come into play results in 
explosion) it seems this just leads to issues being discovered very late by 
users (as was the case for me).

Also, given that there are probably users out there with such schemas already 
out and about (again, me for example) - is there a reason not to at least try 
and accommodate and see if the string value happens to be parseable as a 
boolean? (maybe not do this by default, but configure the reader somehow ...)

> default value for boolean field cannot be a string
> --
>
> Key: AVRO-2035
> URL: https://issues.apache.org/jira/browse/AVRO-2035
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.1
>Reporter: radai rosenblatt
>
> suppose i have the following schema evolution:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
> {"name": "f1", "type": "int"}
>   ]
> }
> {code}
> and then:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
> {"name": "f1", "type": "int"},
> {"name": "f2", "type": "boolean", "default": "true"}
>   ]
> }
> {code}
> the default value for "f2" is specified as the _STRING_ "true" (and not the 
> literal boolean true). 
> if this default value is ever accessed (when reading a gen1-serialized object 
> as a gen2) we get this:
> {code}
> org.apache.avro.AvroTypeException: Non-boolean default for boolean: "true"
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.encode(ResolvingGrammarGenerator.java:408)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.getBinary(ResolvingGrammarGenerator.java:307)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.resolveRecords(ResolvingGrammarGenerator.java:285)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:118)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:50)
>   at org.apache.avro.io.ResolvingDecoder.resolve(ResolvingDecoder.java:85)
>   at org.apache.avro.io.ResolvingDecoder.(ResolvingDecoder.java:49)
>   at 
> org.apache.avro.io.DecoderFactory.resolvingDecoder(DecoderFactory.java:307)
>   at 
> org.apache.avro.generic.GenericDatumReader.getResolver(GenericDatumReader.java:127)
>   at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:142)
> {code}
> yet Schema.parse() passes for this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2035) default value for boolean field cannot be a string

[Doug Cutting (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052438#comment-16052438
 ] 

Doug Cutting commented on AVRO-2035:


Strings are not valid as the default value for a boolean.

The schema parser does not ordinarily validate default values, but this can be 
enabled if desired.

https://avro.apache.org/docs/1.8.1/api/java/org/apache/avro/Schema.Parser.html#setValidateDefaults(boolean)




> default value for boolean field cannot be a string
> --
>
> Key: AVRO-2035
> URL: https://issues.apache.org/jira/browse/AVRO-2035
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.1
>Reporter: radai rosenblatt
>
> suppose i have the following schema evolution:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
> {"name": "f1", "type": "int"}
>   ]
> }
> {code}
> and then:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
> {"name": "f1", "type": "int"},
> {"name": "f2", "type": "boolean", "default": "true"}
>   ]
> }
> {code}
> the default value for "f2" is specified as the _STRING_ "true" (and not the 
> literal boolean true). 
> if this default value is ever accessed (when reading a gen1-serialized object 
> as a gen2) we get this:
> {code}
> org.apache.avro.AvroTypeException: Non-boolean default for boolean: "true"
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.encode(ResolvingGrammarGenerator.java:408)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.getBinary(ResolvingGrammarGenerator.java:307)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.resolveRecords(ResolvingGrammarGenerator.java:285)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:118)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:50)
>   at org.apache.avro.io.ResolvingDecoder.resolve(ResolvingDecoder.java:85)
>   at org.apache.avro.io.ResolvingDecoder.(ResolvingDecoder.java:49)
>   at 
> org.apache.avro.io.DecoderFactory.resolvingDecoder(DecoderFactory.java:307)
>   at 
> org.apache.avro.generic.GenericDatumReader.getResolver(GenericDatumReader.java:127)
>   at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:142)
> {code}
> yet Schema.parse() passes for this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2035) default value for boolean field cannot be a string

[Sean Busbey (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052401#comment-16052401
 ] 

Sean Busbey commented on AVRO-2035:
---

Hi Radai! Any interest in putting up a fix for this?

> default value for boolean field cannot be a string
> --
>
> Key: AVRO-2035
> URL: https://issues.apache.org/jira/browse/AVRO-2035
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.1
>Reporter: radai rosenblatt
>
> suppose i have the following schema evolution:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
> {"name": "f1", "type": "int"}
>   ]
> }
> {code}
> and then:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
> {"name": "f1", "type": "int"},
> {"name": "f2", "type": "boolean", "default": "true"}
>   ]
> }
> {code}
> the default value for "f2" is specified as the _STRING_ "true" (and not the 
> literal boolean true). 
> if this default value is ever accessed (when reading a gen1-serialized object 
> as a gen2) we get this:
> {code}
> org.apache.avro.AvroTypeException: Non-boolean default for boolean: "true"
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.encode(ResolvingGrammarGenerator.java:408)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.getBinary(ResolvingGrammarGenerator.java:307)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.resolveRecords(ResolvingGrammarGenerator.java:285)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:118)
>   at 
> org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:50)
>   at org.apache.avro.io.ResolvingDecoder.resolve(ResolvingDecoder.java:85)
>   at org.apache.avro.io.ResolvingDecoder.(ResolvingDecoder.java:49)
>   at 
> org.apache.avro.io.DecoderFactory.resolvingDecoder(DecoderFactory.java:307)
>   at 
> org.apache.avro.generic.GenericDatumReader.getResolver(GenericDatumReader.java:127)
>   at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:142)
> {code}
> yet Schema.parse() passes for this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Moving to jdk7 or jdk8

[Sean Busbey]

Could we start enforcing Maven 3.0.5+ as well? Right now we require
2.2.1+ and Maven 2 hit EOL in May 2014 (its last release was Nov 2009)

On Fri, Jun 16, 2017 at 12:17 AM, Gabor Szadovszky  wrote:
> Created the JIRA AVRO-2043  
> to
> track this. Feel free to add anything I've missed.
>
> On Thu, Jun 15, 2017 at 8:14 PM, Ryan Blue 
> wrote:
>
>> Yeah, lets stick with 2.7.x instead of 3.x for now.
>>
>> I was talking about the 1.9 release line for updating the JDK version. I
>> agree we shouldn't move 1.8 or 1.7.
>>
>> On Thu, Jun 15, 2017 at 10:53 AM, Sean Busbey  wrote:
>>
>> > if we're talking about for the 1.9 release line, then I'm +1 on
>> > jumping to jdk8. I would prefer not to change the supported jdk
>> > version(s) for existing minor release lines.
>> >
>> > I don't think we should change the Hadoop version.
>> >
>> > On Wed, Jun 14, 2017 at 11:23 AM, Ryan Blue 
>> > wrote:
>> > > +1 for moving. I'm in favor of moving to Java 8 since Java 7 has been
>> end
>> > > of life for 2 years.
>> > >
>> > > https://www.infoq.com/news/2015/05/Oracle-Ends-Java-7Public-Updates
>> > >
>> > > rb
>> > >
>> > > On Wed, Jun 14, 2017 at 7:56 AM, suraj acharya 
>> > wrote:
>> > >
>> > >> Looking through jira. I dont see a plan as such. But I am all in for
>> the
>> > >> change.
>> > >> However, the changes will be backward incompatible and will need to be
>> > done
>> > >> on a major release like 1.9 as you mention.
>> > >> Also, the hadoop-client[1] version is 2.7.3 and if we are to bump that
>> > up
>> > >> to 3.X we will need to move the java to 1.8 since that is a
>> requirement
>> > for
>> > >> hadoop3[2].
>> > >>
>> > >> IMO, we should move the compile to 1.7 for the releases going forward
>> > for
>> > >> 1.8 and 1.9.0 as well as look at bumping the hadoop-client to 3 so
>> that
>> > we
>> > >> are ready for the upstream hadoop-3 release.
>> > >>
>> > >> [1]https://github.com/apache/avro/blob/master/lang/java/pom.xml#L46
>> > >> [2]http://hadoop.apache.org/docs/r3.0.0-alpha1/
>> > >>
>> > >> S
>> > >>
>> > >> -Suraj Acharya
>> > >>
>> > >> On Wed, Jun 14, 2017 at 7:12 AM, Gabor Szadovszky 
>> > >> wrote:
>> > >>
>> > >> > Hi All,
>> > >> >
>> > >> > Are we planning to move to a newer jdk in the next major release
>> > 1.9.0?
>> > >> > To be more precise:
>> > >> > - Upgrading build jdk from 7 to 8?
>> > >> > - Upgrading source/target version from 1.6 to 1.7 or 1.8?
>> > >> >
>> > >> > Thanks a lot,
>> > >> > Gabor
>> > >> >
>> > >>
>> > >
>> > >
>> > >
>> > > --
>> > > Ryan Blue
>> > > Software Engineer
>> > > Netflix
>> >
>> >
>> >
>> > --
>> > busbey
>> >
>>
>>
>>
>> --
>> Ryan Blue
>> Software Engineer
>> Netflix
>>



-- 
busbey

[jira] [Updated] (AVRO-2043) Move to java8

[Sean Busbey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated AVRO-2043:
--
Fix Version/s: 1.9.0

> Move to java8
> -
>
> Key: AVRO-2043
> URL: https://issues.apache.org/jira/browse/AVRO-2043
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Blocker
> Fix For: 1.9.0
>
>
> java6 is really old and java7 is already EOD for 2yrs. It is time to move to 
> java8 in the next major release (1.9.0):
> * update source/target to 1.8.0 in the pom.xml
> * update the Dockerfile to used jdk8
> * ensure that lang/java builds fine with jdk8
> * ensure that all unit tests pass in lang/java with jdk8
> * ensure that everything builds fine and tests pass by using the new docker 
> image



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-2043) Move to java8

[Sean Busbey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated AVRO-2043:
--
Priority: Blocker  (was: Major)

> Move to java8
> -
>
> Key: AVRO-2043
> URL: https://issues.apache.org/jira/browse/AVRO-2043
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Blocker
>
> java6 is really old and java7 is already EOD for 2yrs. It is time to move to 
> java8 in the next major release (1.9.0):
> * update source/target to 1.8.0 in the pom.xml
> * update the Dockerfile to used jdk8
> * ensure that lang/java builds fine with jdk8
> * ensure that all unit tests pass in lang/java with jdk8
> * ensure that everything builds fine and tests pass by using the new docker 
> image



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2043) Move to java8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051693#comment-16051693
 ] 

ASF GitHub Bot commented on AVRO-2043:
--

GitHub user gszadovszky opened a pull request:

https://github.com/apache/avro/pull/232

AVRO-2043: Move to java8



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gszadovszky/avro AVRO-2043

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit 475b83ab9e16de0d462b716e6eefbe4d20eda321
Author: Gabor Szadovszky 
Date:   2017-06-16T09:01:09Z

AVRO-2043: Move to java8




> Move to java8
> -
>
> Key: AVRO-2043
> URL: https://issues.apache.org/jira/browse/AVRO-2043
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>
> java6 is really old and java7 is already EOD for 2yrs. It is time to move to 
> java8 in the next major release (1.9.0):
> * update source/target to 1.8.0 in the pom.xml
> * update the Dockerfile to used jdk8
> * ensure that lang/java builds fine with jdk8
> * ensure that all unit tests pass in lang/java with jdk8
> * ensure that everything builds fine and tests pass by using the new docker 
> image



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] avro pull request #232: AVRO-2043: Move to java8

[gszadovszky]

GitHub user gszadovszky opened a pull request:

https://github.com/apache/avro/pull/232

AVRO-2043: Move to java8



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gszadovszky/avro AVRO-2043

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit 475b83ab9e16de0d462b716e6eefbe4d20eda321
Author: Gabor Szadovszky 
Date:   2017-06-16T09:01:09Z

AVRO-2043: Move to java8




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (AVRO-2043) Move to java8

[Gabor Szadovszky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabor Szadovszky updated AVRO-2043:
---
Description: 
java6 is really old and java7 is already EOD for 2yrs. It is time to move to 
java8 in the next major release (1.9.0):
* update source/target to 1.8.0 in the pom.xml
* update the Dockerfile to used jdk8
* ensure that lang/java builds fine with jdk8
* ensure that all unit tests pass in lang/java with jdk8
* ensure that everything builds fine and tests pass by using the new docker 
image

  was:
java6 is really old and java7 is already EOD since 2yrs. It is time to move to 
java8 in the next major release (1.9.0):
* update source/target to 1.8.0 in the pom.xml
* update the Dockerfile to used jdk8
* ensure that everything builds fine with jdk8
* ensure that all unit tests pass


> Move to java8
> -
>
> Key: AVRO-2043
> URL: https://issues.apache.org/jira/browse/AVRO-2043
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>
> java6 is really old and java7 is already EOD for 2yrs. It is time to move to 
> java8 in the next major release (1.9.0):
> * update source/target to 1.8.0 in the pom.xml
> * update the Dockerfile to used jdk8
> * ensure that lang/java builds fine with jdk8
> * ensure that all unit tests pass in lang/java with jdk8
> * ensure that everything builds fine and tests pass by using the new docker 
> image



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-1985) Unreleased resources

[Gabor Szadovszky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabor Szadovszky updated AVRO-1985:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Unreleased resources
> 
>
> Key: AVRO-1985
> URL: https://issues.apache.org/jira/browse/AVRO-1985
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
> Fix For: 1.9.0
>
>
> Static code analyzer tool found the following unreleased resources:
> - 
> [Json.java:59|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/data/Json.java#L59]
> - 
> [DataFileWriter.java:216|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/file/DataFileWriter.java#L205]
> - 
> [SpecificCompiler.java:275|https://github.com/apache/avro/blob/master/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java#L275]
> - 
> [AvroKeyOutputFormat.java:107|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyOutputFormat.java#L107]
> - 
> [AvroKeyValueOutputFormat.java:63|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyValueOutputFormat.java#L63]
> - 
> [IdlTool.java:62|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/IdlTool.java#L62]
> - 
> [Main.java:92|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L92]
> - 
> [Main.java:94|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L94]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1985) Unreleased resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051510#comment-16051510
 ] 

ASF GitHub Bot commented on AVRO-1985:
--

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/177


> Unreleased resources
> 
>
> Key: AVRO-1985
> URL: https://issues.apache.org/jira/browse/AVRO-1985
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
> Fix For: 1.9.0
>
>
> Static code analyzer tool found the following unreleased resources:
> - 
> [Json.java:59|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/data/Json.java#L59]
> - 
> [DataFileWriter.java:216|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/file/DataFileWriter.java#L205]
> - 
> [SpecificCompiler.java:275|https://github.com/apache/avro/blob/master/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java#L275]
> - 
> [AvroKeyOutputFormat.java:107|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyOutputFormat.java#L107]
> - 
> [AvroKeyValueOutputFormat.java:63|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyValueOutputFormat.java#L63]
> - 
> [IdlTool.java:62|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/IdlTool.java#L62]
> - 
> [Main.java:92|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L92]
> - 
> [Main.java:94|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L94]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1985) Unreleased resources

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051509#comment-16051509
 ] 

ASF subversion and git services commented on AVRO-1985:
---

Commit 528a1c8a997a0831e83b525173c6a70b08ee681a in avro's branch 
refs/heads/master from [~gszadovszky]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=528a1c8 ]

AVRO-1985: Unreleased resources

This closes #177


> Unreleased resources
> 
>
> Key: AVRO-1985
> URL: https://issues.apache.org/jira/browse/AVRO-1985
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
> Fix For: 1.9.0
>
>
> Static code analyzer tool found the following unreleased resources:
> - 
> [Json.java:59|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/data/Json.java#L59]
> - 
> [DataFileWriter.java:216|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/file/DataFileWriter.java#L205]
> - 
> [SpecificCompiler.java:275|https://github.com/apache/avro/blob/master/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java#L275]
> - 
> [AvroKeyOutputFormat.java:107|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyOutputFormat.java#L107]
> - 
> [AvroKeyValueOutputFormat.java:63|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyValueOutputFormat.java#L63]
> - 
> [IdlTool.java:62|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/IdlTool.java#L62]
> - 
> [Main.java:92|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L92]
> - 
> [Main.java:94|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L94]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] avro pull request #177: AVRO-1985: Unreleased resources

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/177


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Moving to jdk7 or jdk8

[Gabor Szadovszky]

Created the JIRA AVRO-2043  to
track this. Feel free to add anything I've missed.

On Thu, Jun 15, 2017 at 8:14 PM, Ryan Blue 
wrote:

> Yeah, lets stick with 2.7.x instead of 3.x for now.
>
> I was talking about the 1.9 release line for updating the JDK version. I
> agree we shouldn't move 1.8 or 1.7.
>
> On Thu, Jun 15, 2017 at 10:53 AM, Sean Busbey  wrote:
>
> > if we're talking about for the 1.9 release line, then I'm +1 on
> > jumping to jdk8. I would prefer not to change the supported jdk
> > version(s) for existing minor release lines.
> >
> > I don't think we should change the Hadoop version.
> >
> > On Wed, Jun 14, 2017 at 11:23 AM, Ryan Blue 
> > wrote:
> > > +1 for moving. I'm in favor of moving to Java 8 since Java 7 has been
> end
> > > of life for 2 years.
> > >
> > > https://www.infoq.com/news/2015/05/Oracle-Ends-Java-7Public-Updates
> > >
> > > rb
> > >
> > > On Wed, Jun 14, 2017 at 7:56 AM, suraj acharya 
> > wrote:
> > >
> > >> Looking through jira. I dont see a plan as such. But I am all in for
> the
> > >> change.
> > >> However, the changes will be backward incompatible and will need to be
> > done
> > >> on a major release like 1.9 as you mention.
> > >> Also, the hadoop-client[1] version is 2.7.3 and if we are to bump that
> > up
> > >> to 3.X we will need to move the java to 1.8 since that is a
> requirement
> > for
> > >> hadoop3[2].
> > >>
> > >> IMO, we should move the compile to 1.7 for the releases going forward
> > for
> > >> 1.8 and 1.9.0 as well as look at bumping the hadoop-client to 3 so
> that
> > we
> > >> are ready for the upstream hadoop-3 release.
> > >>
> > >> [1]https://github.com/apache/avro/blob/master/lang/java/pom.xml#L46
> > >> [2]http://hadoop.apache.org/docs/r3.0.0-alpha1/
> > >>
> > >> S
> > >>
> > >> -Suraj Acharya
> > >>
> > >> On Wed, Jun 14, 2017 at 7:12 AM, Gabor Szadovszky 
> > >> wrote:
> > >>
> > >> > Hi All,
> > >> >
> > >> > Are we planning to move to a newer jdk in the next major release
> > 1.9.0?
> > >> > To be more precise:
> > >> > - Upgrading build jdk from 7 to 8?
> > >> > - Upgrading source/target version from 1.6 to 1.7 or 1.8?
> > >> >
> > >> > Thanks a lot,
> > >> > Gabor
> > >> >
> > >>
> > >
> > >
> > >
> > > --
> > > Ryan Blue
> > > Software Engineer
> > > Netflix
> >
> >
> >
> > --
> > busbey
> >
>
>
>
> --
> Ryan Blue
> Software Engineer
> Netflix
>

[jira] [Created] (AVRO-2043) Move to java8

[Gabor Szadovszky (JIRA)]

Gabor Szadovszky created AVRO-2043:
--

 Summary: Move to java8
 Key: AVRO-2043
 URL: https://issues.apache.org/jira/browse/AVRO-2043
 Project: Avro
  Issue Type: Improvement
  Components: java
Affects Versions: 1.9.0
Reporter: Gabor Szadovszky
Assignee: Gabor Szadovszky


java6 is really old and java7 is already EOD since 2yrs. It is time to move to 
java8 in the next major release (1.9.0):
* update source/target to 1.8.0 in the pom.xml
* update the Dockerfile to used jdk8
* ensure that everything builds fine with jdk8
* ensure that all unit tests pass



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-1971) AvroAlias Annotation should work on field elements

[Gabor Szadovszky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabor Szadovszky updated AVRO-1971:
---
   Resolution: Fixed
Fix Version/s: 1.9.0
   Status: Resolved  (was: Patch Available)

> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
> Fix For: 1.9.0
>
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051492#comment-16051492
 ] 

ASF GitHub Bot commented on AVRO-1971:
--

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/175


> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] avro pull request #175: AVRO-1971: Allow alias annotation on fields

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051491#comment-16051491
 ] 

ASF subversion and git services commented on AVRO-1971:
---

Commit edd8edda0659f802e203e36bcb9d8ec51d821f26 in avro's branch 
refs/heads/master from [~baunz]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=edd8edd ]

AVRO-1971: Allow alias annotation on fields

This closes #175


> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)