[jira] [Commented] (AVRO-2252) I'd like to improve Avro .NET (C#) library (many points)
[ https://issues.apache.org/jira/browse/AVRO-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677387#comment-16677387 ] Raymie Stata commented on AVRO-2252: As annoying as bad style can be, large-scale changes to a code base for the sake of stylistic improvement makes it difficult to navigate the history of a code base, because diffs of post-change code against pre-change code show a lot of spurious changes not relevant to the problem you're trying to track down. My suggestion is to focus on substantive changes for now (bug fixes, performance improvements, new features, etc). Make your stylistic changes right after the new release is shipped. This way, if any of the new substantive changes causes regressions, it will be easier to debug them (and fix them both on the release branch and on master). > I'd like to improve Avro .NET (C#) library (many points) > > > Key: AVRO-2252 > URL: https://issues.apache.org/jira/browse/AVRO-2252 > Project: Avro > Issue Type: Wish > Components: csharp >Reporter: Anton Ryzhov >Priority: Major > > Hello all, > The company where I'm working as a .NET developer is actively using Avro > format. > I'd like to improve Avro .NET (C#) library: > 1) clean-up the code: > - remove trailing spaces, unused namespace usings, etc. > - remove unused dependency of log4net library > - replace dependency of json library from direct reference to Nuget package > 2) format the code to unify code style everywhere in the library > - possibly using the Microsoft recommended code style for C# > [https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/inside-a-program/coding-conventions] > 3) use the latest C# 7.0 language features to make the code more compact and > readable > 4) make .NET 4.5 and .NET standard 2.0 versions of the library, keeping the > existing compatibility with the .NET 3.5 > - add asynchronous API to the .NET 4.5 and .NET standard 2.0 versions (async > methods along with the synchronous ones). > What do you think? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AVRO-1126) Upgrade to Jackson 2+
[
https://issues.apache.org/jira/browse/AVRO-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Kollar resolved AVRO-1126.
-
Resolution: Fixed
Hadoop Flags: Incompatible change
> Upgrade to Jackson 2+
> -
>
> Key: AVRO-1126
> URL: https://issues.apache.org/jira/browse/AVRO-1126
> Project: Avro
> Issue Type: Task
> Components: java
>Reporter: James Tyrrell
>Assignee: Charles Honton
>Priority: Critical
> Fix For: 1.9.0
>
>
> Quite annoyingly with Jackson 2+ the base package name has changed from
> org.codehaus.jackson to com.fasterxml.jackson so in addition to changing the
> dependencies from:
> {code:xml}
>
> org.codehaus.jackson
> jackson-core-asl
> ${jackson.version}
>
>
> org.codehaus.jackson
> jackson-mapper-asl
> ${jackson.version}
>
> {code}
> to:
> {code:xml}
>
> com.fasterxml.jackson.core
> jackson-core
> ${jackson.version}
>
>
> com.fasterxml.jackson.core
> jackson-databind
> ${jackson.version}
>
> {code}
> the base package in the code needs to be updated. More info can be found
> [here|http://wiki.fasterxml.com/JacksonUpgradeFrom19To20], I am happy to do
> the work just let me know what is preferable i.e. should I just attach a
> patch to this issue?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AVRO-1605) Remove Jackson classes from public API
[ https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Kollar updated AVRO-1605: Resolution: Fixed Hadoop Flags: Incompatible change Status: Resolved (was: Patch Available) > Remove Jackson classes from public API > -- > > Key: AVRO-1605 > URL: https://issues.apache.org/jira/browse/AVRO-1605 > Project: Avro > Issue Type: Sub-task > Components: java >Affects Versions: 1.7.8 >Reporter: Tom White >Assignee: Gabor Szadovszky >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
