[jira] [Updated] (AVRO-2192) Remove paranamer dependency from Avro
[ https://issues.apache.org/jira/browse/AVRO-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Kollar updated AVRO-2192: Hadoop Flags: Incompatible change > Remove paranamer dependency from Avro > - > > Key: AVRO-2192 > URL: https://issues.apache.org/jira/browse/AVRO-2192 > Project: Apache Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.8.2 >Reporter: RAJKUMAR NATARAJAN >Assignee: Ismaël Mejía >Priority: Minor > Fix For: 1.9.0 > > > Hi, > > Avro seems to be depend upon the com.thoughtworks.paranamer. Avro 1.7.7 > depends upon 2.7 and 1.8. depends on 2.8 paranamer versions. > > Please remove this dependency in the future versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2155) Generate documentation for C# classes and enums
[ https://issues.apache.org/jira/browse/AVRO-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710147#comment-16710147 ] ASF subversion and git services commented on AVRO-2155: --- Commit 915cb4541fa0e7d3d96646947f449cbb4b75589a in avro's branch refs/heads/master from [~blachniet] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=915cb45 ] AVRO-2155: Include documentation for named schemas in generated code (#296) * AVRO-2155: Add `Documentation` property to `NamedSchema` * AVRO-2155: Add documentation to generated code > Generate documentation for C# classes and enums > --- > > Key: AVRO-2155 > URL: https://issues.apache.org/jira/browse/AVRO-2155 > Project: Apache Avro > Issue Type: New Feature > Components: csharp >Affects Versions: 1.8.2 >Reporter: Brian Lachniet >Priority: Minor > > Update the C# "avrogen" code generation to populate documentation for code > entities (classes and enums) that are generated from named schemas (record, > enum and fixed). At this time, it only generates documentation for Avro > fields (C# fields and properties). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2155) Generate documentation for C# classes and enums
[ https://issues.apache.org/jira/browse/AVRO-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710148#comment-16710148 ] ASF subversion and git services commented on AVRO-2155: --- Commit 915cb4541fa0e7d3d96646947f449cbb4b75589a in avro's branch refs/heads/master from [~blachniet] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=915cb45 ] AVRO-2155: Include documentation for named schemas in generated code (#296) * AVRO-2155: Add `Documentation` property to `NamedSchema` * AVRO-2155: Add documentation to generated code > Generate documentation for C# classes and enums > --- > > Key: AVRO-2155 > URL: https://issues.apache.org/jira/browse/AVRO-2155 > Project: Apache Avro > Issue Type: New Feature > Components: csharp >Affects Versions: 1.8.2 >Reporter: Brian Lachniet >Priority: Minor > > Update the C# "avrogen" code generation to populate documentation for code > entities (classes and enums) that are generated from named schemas (record, > enum and fixed). At this time, it only generates documentation for Avro > fields (C# fields and properties). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2155) Generate documentation for C# classes and enums
[
https://issues.apache.org/jira/browse/AVRO-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710146#comment-16710146
]
ASF GitHub Bot commented on AVRO-2155:
--
dkulp closed pull request #296: AVRO-2155: Include documentation for named
schemas in generated code
URL: https://github.com/apache/avro/pull/296
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lang/csharp/src/apache/main/CodeGen/CodeGen.cs
b/lang/csharp/src/apache/main/CodeGen/CodeGen.cs
index 7e70a02d5..2bcebabd9 100644
--- a/lang/csharp/src/apache/main/CodeGen/CodeGen.cs
+++ b/lang/csharp/src/apache/main/CodeGen/CodeGen.cs
@@ -260,6 +260,11 @@ protected virtual void processFixed(Schema schema)
ctd.Attributes = MemberAttributes.Public;
ctd.BaseTypes.Add("SpecificFixed");
+if (fixedSchema.Documentation != null)
+{
+ctd.Comments.Add(createDocComment(fixedSchema.Documentation));
+}
+
// create static schema field
createSchemaField(schema, ctd, true);
@@ -306,6 +311,11 @@ protected virtual void processEnum(Schema schema)
ctd.IsEnum = true;
ctd.Attributes = MemberAttributes.Public;
+if (enumschema.Documentation != null)
+{
+ctd.Comments.Add(createDocComment(enumschema.Documentation));
+}
+
foreach (string symbol in enumschema.Symbols)
{
if (CodeGenUtil.Instance.ReservedKeywords.Contains(symbol))
@@ -526,6 +536,11 @@ protected virtual CodeTypeDeclaration processRecord(Schema
schema)
ctd.IsClass = true;
ctd.IsPartial = true;
+if (recordSchema.Documentation != null)
+{
+ctd.Comments.Add(createDocComment(recordSchema.Documentation));
+}
+
createSchemaField(schema, ctd, isError);
// declare Get() to be used by the Writer classes
diff --git a/lang/csharp/src/apache/main/Schema/EnumSchema.cs
b/lang/csharp/src/apache/main/Schema/EnumSchema.cs
index fc21d14b7..93c36c7ef 100644
--- a/lang/csharp/src/apache/main/Schema/EnumSchema.cs
+++ b/lang/csharp/src/apache/main/Schema/EnumSchema.cs
@@ -70,7 +70,8 @@ internal static EnumSchema NewInstance(JToken jtok,
PropertyMap props, SchemaNam
symbolMap[s] = i++;
symbols.Add(s);
}
-return new EnumSchema(name, aliases, symbols, symbolMap, props,
names);
+return new EnumSchema(name, aliases, symbols, symbolMap, props,
names,
+JsonHelper.GetOptionalString(jtok, "doc"));
}
///
@@ -80,10 +81,13 @@ internal static EnumSchema NewInstance(JToken jtok,
PropertyMap props, SchemaNam
/// list of aliases for the name
/// list of enum symbols
/// map of enum symbols and value
+/// custom properties on this schema
/// list of named schema already read
+/// documentation for this named schema
private EnumSchema(SchemaName name, IList aliases,
List symbols,
-IDictionary symbolMap, PropertyMap
props, SchemaNames names)
-: base(Type.Enumeration, name, aliases, props,
names)
+IDictionary symbolMap, PropertyMap
props, SchemaNames names,
+string doc)
+: base(Type.Enumeration, name, aliases, props,
names, doc)
{
if (null == name.Name) throw new SchemaParseException("name cannot
be null for enum schema.");
this.Symbols = symbols;
diff --git a/lang/csharp/src/apache/main/Schema/FixedSchema.cs
b/lang/csharp/src/apache/main/Schema/FixedSchema.cs
index 67c843d9a..873992116 100644
--- a/lang/csharp/src/apache/main/Schema/FixedSchema.cs
+++ b/lang/csharp/src/apache/main/Schema/FixedSchema.cs
@@ -44,7 +44,8 @@ internal static FixedSchema NewInstance(JToken jtok,
PropertyMap props, SchemaNa
SchemaName name = NamedSchema.GetName(jtok, encspace);
var aliases = NamedSchema.GetAliases(jtok, name.Space,
name.EncSpace);
-return new FixedSchema(name, aliases,
JsonHelper.GetRequiredInteger(jtok, "size"), props, names);
+return new FixedSchema(name, aliases,
JsonHelper.GetRequiredInteger(jtok, "size"), props, names,
+JsonHelper.GetOptionalString(jtok, "doc"));
}
///
@@ -53,9 +54,12 @@ internal static FixedSchema NewInstance(JToken jtok,
PropertyMap props, SchemaNa
/// name of the fixed schema
/// list of aliases for the name
/// f
[jira] [Commented] (AVRO-2144) 404 - Not found - Invalid Url for CSharp documentation
[ https://issues.apache.org/jira/browse/AVRO-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710151#comment-16710151 ] ASF GitHub Bot commented on AVRO-2144: -- dkulp closed pull request #286: AVRO-2144: Fix for CSharp documentation Url URL: https://github.com/apache/avro/pull/286 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/doc/src/content/xdocs/site.xml b/doc/src/content/xdocs/site.xml index 30d0b4870..5aec50ca9 100644 --- a/doc/src/content/xdocs/site.xml +++ b/doc/src/content/xdocs/site.xml @@ -77,7 +77,7 @@ See http://forrest.apache.org/docs/linking.html for more info - + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > 404 - Not found - Invalid Url for CSharp documentation > -- > > Key: AVRO-2144 > URL: https://issues.apache.org/jira/browse/AVRO-2144 > Project: Apache Avro > Issue Type: Bug > Components: doc >Affects Versions: 1.8.2 >Reporter: Selva Chinnasamy >Assignee: Selva Chinnasamy >Priority: Minor > > Invalid Url for C# Api documentation > Selecting the below link > [C# API|http://avro.apache.org/docs/current/api/csharp/index.html] > leads to 404. Below is the current result: > h1. Not Found > The requested URL /docs/current/api/csharp/index.html was not found on this > server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2156) Allow custom namespace for C# generated code
[ https://issues.apache.org/jira/browse/AVRO-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710155#comment-16710155 ] ASF subversion and git services commented on AVRO-2156: --- Commit 602a2c5b5258d5e1f0f60f71506b16801cbdf156 in avro's branch refs/heads/master from [~blachniet] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=602a2c5 ] AVRO-2156: Map Avro namespace to C# namespaces during code generation > Allow custom namespace for C# generated code > > > Key: AVRO-2156 > URL: https://issues.apache.org/jira/browse/AVRO-2156 > Project: Apache Avro > Issue Type: New Feature > Components: csharp >Affects Versions: 1.8.2 >Reporter: Brian Lachniet >Priority: Major > > The namespace used in Avro schemas/protocols does not always map nicely to a > standard C# namespace. Avrogen (the C# code generator) currently uses the > Avro namespace as the C# namespace. I propose that we update the avrogen > utility to allow the user to override the namespace used in the generated > code via a command line parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2156) Allow custom namespace for C# generated code
[
https://issues.apache.org/jira/browse/AVRO-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710154#comment-16710154
]
ASF GitHub Bot commented on AVRO-2156:
--
dkulp closed pull request #297: AVRO-2156: Map Avro namespace to C# namespaces
during code generation
URL: https://github.com/apache/avro/pull/297
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lang/csharp/src/apache/codegen/AvroGen.cs
b/lang/csharp/src/apache/codegen/AvroGen.cs
index 033b8404b..465857f60 100644
--- a/lang/csharp/src/apache/codegen/AvroGen.cs
+++ b/lang/csharp/src/apache/codegen/AvroGen.cs
@@ -25,25 +25,111 @@ class AvroGen
{
static void Main(string[] args)
{
-if (args.Length != 3)
+// Print usage if no arguments provided or help requested
+if (args.Length == 0 || args[0] == "-h" || args[0] == "--help")
{
Usage();
return;
}
-if (args[0] == "-p")
-GenProtocol(args[1], args[2]);
-else if (args[0] == "-s")
-GenSchema(args[1], args[2]);
-else
+
+// Parse command line arguments
+bool? isProtocol = null;
+string inputFile = null;
+string outputDir = null;
+var namespaceMapping = new Dictionary();
+for (int i = 0; i < args.Length; ++i)
+{
+if (args[i] == "-p")
+{
+if (i + 1 >= args.Length)
+{
+Console.WriteLine("Missing path to protocol file");
+Usage();
+return;
+}
+
+isProtocol = true;
+inputFile = args[++i];
+}
+else if (args[i] == "-s")
+{
+if (i + 1 >= args.Length)
+{
+Console.WriteLine("Missing path to schema file");
+Usage();
+return;
+}
+
+isProtocol = false;
+inputFile = args[++i];
+}
+else if (args[i] == "--namespace")
+{
+if (i + 1 >= args.Length)
+{
+Console.WriteLine("Missing namespace mapping");
+Usage();
+return;
+}
+
+var parts = args[++i].Split(new char[] { ':' },
StringSplitOptions.RemoveEmptyEntries);
+if (parts.Length != 2)
+{
+Console.WriteLine("Malformed namespace mapping.
Required format is \"avro.namespace:csharp.namespace\"");
+Usage();
+return;
+}
+
+namespaceMapping[parts[0]] = parts[1];
+}
+else if (outputDir == null)
+{
+outputDir = args[i];
+}
+else
+{
+Console.WriteLine("Unexpected command line argument: {0}",
args[i]);
+Usage();
+}
+}
+
+// Ensure we got all the command line arguments we need
+bool isValid = true;
+if (!isProtocol.HasValue || inputFile == null)
+{
+Console.WriteLine("Must provide either '-p ' or
'-s '");
+isValid = false;
+}
+else if (outputDir == null)
+{
+Console.WriteLine("Must provide 'outputdir'");
+isValid = false;
+}
+
+if (!isValid)
Usage();
+else if (isProtocol.Value)
+GenProtocol(inputFile, outputDir, namespaceMapping);
+else
+GenSchema(inputFile, outputDir, namespaceMapping);
}
static void Usage()
{
-Console.WriteLine("Usage:\navrogen -p
\navrogen -s ");
+Console.WriteLine("{0}\n\n" +
+"Usage:\n" +
+" avrogen -p [--namespace
]\n" +
+" avrogen -s [--namespace
]\n\n" +
+"Options:\n" +
+" -h --help Show this screen.\n" +
+" --namespace Map an Avro schema/protocol namespace to a C#
namespace.\n" +
+" The format is
\"my.avro.namespace:my.csharp.namespace\".\n" +
+" May be specified
[jira] [Commented] (AVRO-2155) Generate documentation for C# classes and enums
[ https://issues.apache.org/jira/browse/AVRO-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710149#comment-16710149 ] ASF subversion and git services commented on AVRO-2155: --- Commit 915cb4541fa0e7d3d96646947f449cbb4b75589a in avro's branch refs/heads/master from [~blachniet] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=915cb45 ] AVRO-2155: Include documentation for named schemas in generated code (#296) * AVRO-2155: Add `Documentation` property to `NamedSchema` * AVRO-2155: Add documentation to generated code > Generate documentation for C# classes and enums > --- > > Key: AVRO-2155 > URL: https://issues.apache.org/jira/browse/AVRO-2155 > Project: Apache Avro > Issue Type: New Feature > Components: csharp >Affects Versions: 1.8.2 >Reporter: Brian Lachniet >Priority: Minor > > Update the C# "avrogen" code generation to populate documentation for code > entities (classes and enums) that are generated from named schemas (record, > enum and fixed). At this time, it only generates documentation for Avro > fields (C# fields and properties). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2144) 404 - Not found - Invalid Url for CSharp documentation
[ https://issues.apache.org/jira/browse/AVRO-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710152#comment-16710152 ] ASF subversion and git services commented on AVRO-2144: --- Commit eaa7cca922b916ab7ad0fac6e109330197f8c75f in avro's branch refs/heads/master from [~vishelma] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=eaa7cca ] AVRO-2144: Fix for CSharp documentation Url > 404 - Not found - Invalid Url for CSharp documentation > -- > > Key: AVRO-2144 > URL: https://issues.apache.org/jira/browse/AVRO-2144 > Project: Apache Avro > Issue Type: Bug > Components: doc >Affects Versions: 1.8.2 >Reporter: Selva Chinnasamy >Assignee: Selva Chinnasamy >Priority: Minor > > Invalid Url for C# Api documentation > Selecting the below link > [C# API|http://avro.apache.org/docs/current/api/csharp/index.html] > leads to 404. Below is the current result: > h1. Not Found > The requested URL /docs/current/api/csharp/index.html was not found on this > server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1363) C# UnionSchema fails to parse the the unions with same type names with different namespaces
[
https://issues.apache.org/jira/browse/AVRO-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710271#comment-16710271
]
ASF GitHub Bot commented on AVRO-1363:
--
dkulp closed pull request #156: AVRO-1363 Fix the C# parsing of a union schema
URL: https://github.com/apache/avro/pull/156
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lang/csharp/src/apache/main/Schema/NamedSchema.cs
b/lang/csharp/src/apache/main/Schema/NamedSchema.cs
index 02beb7984..b75483f84 100644
--- a/lang/csharp/src/apache/main/Schema/NamedSchema.cs
+++ b/lang/csharp/src/apache/main/Schema/NamedSchema.cs
@@ -52,7 +52,7 @@ public string Namespace
///
/// Namespace.Name of the schema
///
-public string Fullname
+public override string Fullname
{
get { return SchemaName.Fullname; }
}
diff --git a/lang/csharp/src/apache/main/Schema/Schema.cs
b/lang/csharp/src/apache/main/Schema/Schema.cs
index fc0e23792..d2d2f079c 100644
--- a/lang/csharp/src/apache/main/Schema/Schema.cs
+++ b/lang/csharp/src/apache/main/Schema/Schema.cs
@@ -70,12 +70,20 @@ protected Schema(Type type, PropertyMap props)
this.Props = props;
}
+///
+/// If this is a record, enum or fixed, returns its name, otherwise
the name the primitive type.
+///
+public abstract string Name { get; }
+
///
/// The name of this schema. If this is a named schema such as an
enum, it returns the fully qualified
/// name for the schema. For other schemas, it returns the type of the
schema.
///
-public abstract string Name { get; }
-
+public virtual string Fullname
+{
+get { return Name; }
+}
+
///
/// Static class to return new instance of schema object
///
diff --git a/lang/csharp/src/apache/main/Schema/UnionSchema.cs
b/lang/csharp/src/apache/main/Schema/UnionSchema.cs
index df2c37fce..bc2ab5b9b 100644
--- a/lang/csharp/src/apache/main/Schema/UnionSchema.cs
+++ b/lang/csharp/src/apache/main/Schema/UnionSchema.cs
@@ -56,7 +56,7 @@ internal static UnionSchema NewInstance(JArray jarr,
PropertyMap props, SchemaNa
if (null == unionType)
throw new SchemaParseException("Invalid JSON in union" +
jvalue.ToString());
-string name = unionType.Name;
+string name = unionType.Fullname;
if (uniqueSchemas.ContainsKey(name))
throw new SchemaParseException("Duplicate type in union: "
+ name);
diff --git a/lang/csharp/src/apache/test/Schema/SchemaTests.cs
b/lang/csharp/src/apache/test/Schema/SchemaTests.cs
index b12483187..885b5a40b 100644
--- a/lang/csharp/src/apache/test/Schema/SchemaTests.cs
+++ b/lang/csharp/src/apache/test/Schema/SchemaTests.cs
@@ -69,7 +69,8 @@ public class SchemaTests
Description = "No fields", ExpectedException =
typeof(SchemaParseException))]
[TestCase("{\"type\":\"record\",\"name\":\"LongList\", \"fields\":
\"hi\"}",
Description = "Fields not an array", ExpectedException =
typeof(SchemaParseException))]
-
+[TestCase("[{\"type\": \"record\",\"name\":
\"Test\",\"namespace\":\"ns1\",\"fields\": [{\"name\": \"f\",\"type\":
\"long\"}]}," +
+ "{\"type\": \"record\",\"name\":
\"Test\",\"namespace\":\"ns2\",\"fields\": [{\"name\": \"f\",\"type\":
\"long\"}]}]")]
// Enum
[TestCase("{\"type\": \"enum\", \"name\": \"Test\", \"symbols\":
[\"A\", \"B\"]}")]
[TestCase("{\"type\": \"enum\", \"name\": \"Status\", \"symbols\":
\"Normal Caution Critical\"}",
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C# UnionSchema fails to parse the the unions with same type names with
> different namespaces
> ---
>
> Key: AVRO-1363
> URL: https://issues.apache.org/jira/browse/AVRO-1363
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
>Affects Versions: 1.7.4
>Reporter: Ramana Suvarapu
>Priority: Major
> Attachments: reader.avpr
>
>
> C# Union schema is unable to handle same type names with different
> namespaces. It's throwing "SchemaParseExc
[jira] [Resolved] (AVRO-2193) Migrate to velocity 2.x
[ https://issues.apache.org/jira/browse/AVRO-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía resolved AVRO-2193. Resolution: Duplicate > Migrate to velocity 2.x > --- > > Key: AVRO-2193 > URL: https://issues.apache.org/jira/browse/AVRO-2193 > Project: Apache Avro > Issue Type: Improvement > Components: java >Reporter: Peter Janssen >Priority: Minor > > The latest 1.x release from velocity is from 2010. It contains some security > findings which should not be present in version 2.x (for example > [#VELOCITY-853]). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2156) Allow custom namespace for C# generated code
[ https://issues.apache.org/jira/browse/AVRO-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kulp updated AVRO-2156: -- Resolution: Fixed Assignee: Daniel Kulp Fix Version/s: 1.9.0 Status: Resolved (was: Patch Available) > Allow custom namespace for C# generated code > > > Key: AVRO-2156 > URL: https://issues.apache.org/jira/browse/AVRO-2156 > Project: Apache Avro > Issue Type: New Feature > Components: csharp >Affects Versions: 1.8.2 >Reporter: Brian Lachniet >Assignee: Daniel Kulp >Priority: Major > Fix For: 1.9.0 > > > The namespace used in Avro schemas/protocols does not always map nicely to a > standard C# namespace. Avrogen (the C# code generator) currently uses the > Avro namespace as the C# namespace. I propose that we update the avrogen > utility to allow the user to override the namespace used in the generated > code via a command line parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2155) Generate documentation for C# classes and enums
[ https://issues.apache.org/jira/browse/AVRO-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kulp updated AVRO-2155: -- Resolution: Fixed Assignee: Daniel Kulp Fix Version/s: 1.9.0 Status: Resolved (was: Patch Available) > Generate documentation for C# classes and enums > --- > > Key: AVRO-2155 > URL: https://issues.apache.org/jira/browse/AVRO-2155 > Project: Apache Avro > Issue Type: New Feature > Components: csharp >Affects Versions: 1.8.2 >Reporter: Brian Lachniet >Assignee: Daniel Kulp >Priority: Minor > Fix For: 1.9.0 > > > Update the C# "avrogen" code generation to populate documentation for code > entities (classes and enums) that are generated from named schemas (record, > enum and fixed). At this time, it only generates documentation for Avro > fields (C# fields and properties). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AVRO-1363) C# UnionSchema fails to parse the the unions with same type names with different namespaces
[
https://issues.apache.org/jira/browse/AVRO-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Kulp resolved AVRO-1363.
---
Resolution: Fixed
Assignee: Daniel Kulp
Fix Version/s: 1.9.0
> C# UnionSchema fails to parse the the unions with same type names with
> different namespaces
> ---
>
> Key: AVRO-1363
> URL: https://issues.apache.org/jira/browse/AVRO-1363
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
>Affects Versions: 1.7.4
>Reporter: Ramana Suvarapu
>Assignee: Daniel Kulp
>Priority: Major
> Fix For: 1.9.0
>
> Attachments: reader.avpr
>
>
> C# Union schema is unable to handle same type names with different
> namespaces. It's throwing "SchemaParseException("Duplicate type in union:
> "...) exception.
> In the below code, key of uniqueSchemas should be FullName of the type which
> is similar to Java implementation.
> internal static UnionSchema NewInstance(JArray jarr, PropertyMap props,
> SchemaNames names, string encspace)
> {
> List schemas = new List();
> IDictionary uniqueSchemas = new
> Dictionary();
> foreach (JToken jvalue in jarr)
> {
> Schema unionType = Schema.ParseJson(jvalue, names, encspace);
> if (null == unionType)
> throw new SchemaParseException("Invalid JSON in union" +
> jvalue.ToString());
> string name = unionType.Name;
> if (uniqueSchemas.ContainsKey(name))
> throw new SchemaParseException("Duplicate type in union:
> " + name);
> uniqueSchemas.Add(name, name);
> schemas.Add(unionType);
> }
> return new UnionSchema(schemas, props);
> }
> See the attachement to recreate the issue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2162) Add Zstandard compression to avro file format
[ https://issues.apache.org/jira/browse/AVRO-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710363#comment-16710363 ] ASF GitHub Bot commented on AVRO-2162: -- iemejia commented on issue #303: AVRO-2162 Adds Zstandard compression to the Avro File Format (Java) URL: https://github.com/apache/avro/pull/303#issuecomment-444567917 Is there something considerable being missing to get this one merged? I think it would be great to have it for the 1.9.0 release. Backporting this looks like a lot of extra work, and can be done if someone really really needs/want to, otherwise we should encourage moving upwards. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Zstandard compression to avro file format > - > > Key: AVRO-2162 > URL: https://issues.apache.org/jira/browse/AVRO-2162 > Project: Apache Avro > Issue Type: Improvement > Components: java >Reporter: Scott Carey >Priority: Major > > I'd like to add Zstandard compression for Avro. > At compression level 1 It is almost as fast as Snappy at compression, with > compression ratios more like gzip. At higher levels of compression, it is > more compact than gzip -9 with much lower CPU when compressing and roughly 3x > faster decompression. > > Adding it to Java is fairly easy. We'll need to say something about it in > the spec however, as an 'optinal' codec. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Tagging PRs in github
Good idea Michael, it seems we can automate this via https://github.com/probot/autolabeler I created a ticket in INFRA, let's hope it can be easily setup. https://issues.apache.org/jira/browse/INFRA-17367 I will keep you updated when ready. On Tue, Dec 4, 2018 at 10:12 PM Driesprong, Fokko wrote: > > Definitely, thanks a lot Ismaël! > > Op za 1 dec. 2018 om 00:21 schreef Michael A. Smith : > > > Thanks for doing that. It was very needed. > > > > Can we automate doing this somehow. > > > > On Thu, Nov 29, 2018 at 17:52 Ismaël Mejía wrote: > > > > > Hello, > > > > > > I tagged all open PRs in github using the Label feature and the > > > respective languages as part of the effort to get more reviews done. > > > Hopefully people and committers can filter quickly their favorite > > > language and this encourages them to help review. > > > > > > Sorry for taking this initiative without contacting dev@ first and for > > > the additional email spam that some of you guys involved in the > > > reviews probably received. > > > > > > I hope other committers agree with this idea so we can keep this > > > tagging in the future (of course as well as the equivalent > > > "Components" tag in Jira too. > > > > > > Regards, > > > Ismaël > > > > >
[jira] [Commented] (AVRO-2162) Add Zstandard compression to avro file format
[ https://issues.apache.org/jira/browse/AVRO-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710433#comment-16710433 ] ASF GitHub Bot commented on AVRO-2162: -- nandorKollar commented on issue #303: AVRO-2162 Adds Zstandard compression to the Avro File Format (Java) URL: https://github.com/apache/avro/pull/303#issuecomment-444584524 I believe a Zstandard codec was already merged: https://github.com/apache/avro/commit/cf2f30336efe0ecc3debc7bede86fde6d23f7c79 I think this is a duplicate. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Zstandard compression to avro file format > - > > Key: AVRO-2162 > URL: https://issues.apache.org/jira/browse/AVRO-2162 > Project: Apache Avro > Issue Type: Improvement > Components: java >Reporter: Scott Carey >Priority: Major > > I'd like to add Zstandard compression for Avro. > At compression level 1 It is almost as fast as Snappy at compression, with > compression ratios more like gzip. At higher levels of compression, it is > more compact than gzip -9 with much lower CPU when compressing and roughly 3x > faster decompression. > > Adding it to Java is fairly easy. We'll need to say something about it in > the spec however, as an 'optinal' codec. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
