Re: [VOTE] Release Apache Avro 1.9.0 RC3

[Ismaël Mejía]

I did a quick review on the JIRA issues included and extracted some
extra interesting info worth of addint to the release notes. Up to you
to choose which matter or not to be added.

* Remove Jackson classes from public API
* Avro is built by default with Java 8
* Avro is compiled and tested too with Java 11 to guarantee compatibility
* Avro MapReduce is also compiled and tested with Hadoop 3
* Avro is now leaner, multiple dependencies were removed: guava,
paranamer, commons-codec and commons-logging
* Introduce JMH Performance Testing Framework
* Add Snappy support for C++ DataFile

On Tue, Apr 30, 2019 at 4:50 PM Ismaël Mejía  wrote:
>
> Sorry, playing the killjoy again.
>
> It seems the files (and more critical the poms) still have the -SNAPSHOT 
> suffix.
> Also the comment of Dan Kulp about the extra directory structure in
> the main file  build/avro-1.9.0 directory would be a nice extra thing
> to fix.
>
> On Tue, Apr 30, 2019 at 12:54 PM Driesprong, Fokko  
> wrote:
> >
> > Hi everyone,
> >
> > Since the last release of Apache Avro 1.8.2 on May 31, 2017. Two years
> > later,
> > I'm thrilled to propose the following RC to be released as official Apache
> > Avro 1.9.0 release.
> >
> > The commit id is 24ff48c32d8d13433a1e31e485ef2af187d1eb62
> > * This corresponds to the tag: release-1.9.0-rc3
> > * https://github.com/apache/avro/releases/tag/release-1.9.0-rc3/
> >
> > The release tarball, signature, and checksums are here:
> > * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc3/
> >
> > You can find the KEYS file here:
> > * https://dist.apache.org/repos/dist/dev/avro/KEYS
> >
> > Binary artifacts for Java are staged in Nexus here:
> > *
> > https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.0/
> >
> > This release includes 272 Jira issues:
> > https://issues.apache.org/jira/projects/AVRO/versions/1294
> > * Deprecate Joda-Time in favor of Java8 JSR310 and setting it as default
> > * Remove support for Hadoop 1.x
> > * Move from Jackson 1.x to 2.9
> > * Add ZStandard Codec
> > * Lots of updates on the dependencies to fix CVE's
> > * and many, many more!
> >
> > Since RC1, two commits have been added:
> > * https://jira.apache.org/jira/browse/AVRO-2381
> > * https://jira.apache.org/jira/browse/AVRO-2383
> >
> > Since RC2 the SHA1/MD5 checksums have been replaced with SHA512
> >
> > Please download, verify, and test. This vote will remain open for at least
> > 72 hours. Given sufficient votes, I would like to close it on or about
> > midnight
> > on Saturday, 4th of May 2019.
> >
> > [ ] +1 Release this as Apache Avro 1.9.0
> > [ ] +0
> > [ ] -1 Do not release this because...
> >
> > Consider this a +1 (non-binding) from my side:
> > * Compiled the new version of Parquet against the Divolte collector and
> > Apache Parquet
> >
> > Cheers, Fokko Driesprong

Re: [VOTE] Release Apache Avro 1.9.0 RC3

[Ismaël Mejía]

Sorry, playing the killjoy again.

It seems the files (and more critical the poms) still have the -SNAPSHOT suffix.
Also the comment of Dan Kulp about the extra directory structure in
the main file  build/avro-1.9.0 directory would be a nice extra thing
to fix.

On Tue, Apr 30, 2019 at 12:54 PM Driesprong, Fokko  wrote:
>
> Hi everyone,
>
> Since the last release of Apache Avro 1.8.2 on May 31, 2017. Two years
> later,
> I'm thrilled to propose the following RC to be released as official Apache
> Avro 1.9.0 release.
>
> The commit id is 24ff48c32d8d13433a1e31e485ef2af187d1eb62
> * This corresponds to the tag: release-1.9.0-rc3
> * https://github.com/apache/avro/releases/tag/release-1.9.0-rc3/
>
> The release tarball, signature, and checksums are here:
> * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc3/
>
> You can find the KEYS file here:
> * https://dist.apache.org/repos/dist/dev/avro/KEYS
>
> Binary artifacts for Java are staged in Nexus here:
> *
> https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.0/
>
> This release includes 272 Jira issues:
> https://issues.apache.org/jira/projects/AVRO/versions/1294
> * Deprecate Joda-Time in favor of Java8 JSR310 and setting it as default
> * Remove support for Hadoop 1.x
> * Move from Jackson 1.x to 2.9
> * Add ZStandard Codec
> * Lots of updates on the dependencies to fix CVE's
> * and many, many more!
>
> Since RC1, two commits have been added:
> * https://jira.apache.org/jira/browse/AVRO-2381
> * https://jira.apache.org/jira/browse/AVRO-2383
>
> Since RC2 the SHA1/MD5 checksums have been replaced with SHA512
>
> Please download, verify, and test. This vote will remain open for at least
> 72 hours. Given sufficient votes, I would like to close it on or about
> midnight
> on Saturday, 4th of May 2019.
>
> [ ] +1 Release this as Apache Avro 1.9.0
> [ ] +0
> [ ] -1 Do not release this because...
>
> Consider this a +1 (non-binding) from my side:
> * Compiled the new version of Parquet against the Divolte collector and
> Apache Parquet
>
> Cheers, Fokko Driesprong

[jira] [Updated] (AVRO-2385) Uppercase fields do not generate proper getter/setters in Java

[Andrew (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew updated AVRO-2385:
-
Description: 
Steps to reproduce:

Create an Avro schema with an uppercase field:

{
 {{  "type": "record",}}
 {{  "name": "example",}}
 {{  "namespace": "issue",}}
 {{  "fields": [}}
 {{    {}}
 {{      "name": "THERE_IS_NO_INDICATION_OF_WORDS",}}
 {{      "type": "string"}}
         }
 {{  ]}}
 {{}}}

Use the avro-maven-plugin to generate Java code for this schema.

Expected result:

The generate getters and setters use camel casing ThereIsNoIndicationOfWords.

Actual result:

The generated getters and setters are in all uppercase:

/**
 * Gets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 * @return The value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 */
 public java.lang.CharSequence getTHEREISNOINDICATIONOFWORDS() \{   return 
THERE_IS_NO_INDICATION_OF_WORDS; }

/**
 * Sets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 * @param value the value to set.
 */
 public void setTHEREISNOINDICATIONOFWORDS(java.lang.CharSequence value) \{   
this.THERE_IS_NO_INDICATION_OF_WORDS = value; }

 

  was:
Steps to reproduce:

Create an Avro schema with an uppercase field:

{{{}}
{{  "type": "record",}}
{{  "name": "example",}}
{{  "namespace": "issue",}}
{{  "fields": [}}
{{    {}}
{{      "name": "THERE_IS_NO_INDICATION_OF_WORDS",}}
{{      "type": "string"}}
{{    }}}
{{  ]}}
{{}}}

Use the avro-maven-plugin to generate Java code for this schema.

Expected result:

The generate getters and setters use camel casing ThereIsNoIndicationIfWords.

Actual result:

The generated getters and setters are in all uppercase:

/**
 * Gets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 * @return The value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 */
public java.lang.CharSequence getTHEREISNOINDICATIONOFWORDS() {
  return THERE_IS_NO_INDICATION_OF_WORDS;
}

/**
 * Sets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 * @param value the value to set.
 */
public void setTHEREISNOINDICATIONOFWORDS(java.lang.CharSequence value) {
  this.THERE_IS_NO_INDICATION_OF_WORDS = value;
}

 


> Uppercase fields do not generate proper getter/setters in Java
> --
>
> Key: AVRO-2385
> URL: https://issues.apache.org/jira/browse/AVRO-2385
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.2
> Environment: Using Maven plugin with Java 8:
> {{ }}
> {{  org.apache.avro}}
> {{  avro-maven-plugin}}
> {{  1.8.2}}
> {{  }}
> {{    }}
> {{      generate-sources}}
> {{      }}
> {{        schema}}
> {{      }}
> {{      }}
> {{        
> ${project.basedir}/src/main/resources}}
> {{      }}
> {{    }}
> {{  }}
> {{ }}
>Reporter: Andrew
>Priority: Major
>
> Steps to reproduce:
> Create an Avro schema with an uppercase field:
> {
>  {{  "type": "record",}}
>  {{  "name": "example",}}
>  {{  "namespace": "issue",}}
>  {{  "fields": [}}
>  {{    {}}
>  {{      "name": "THERE_IS_NO_INDICATION_OF_WORDS",}}
>  {{      "type": "string"}}
>          }
>  {{  ]}}
>  {{}}}
> Use the avro-maven-plugin to generate Java code for this schema.
> Expected result:
> The generate getters and setters use camel casing ThereIsNoIndicationOfWords.
> Actual result:
> The generated getters and setters are in all uppercase:
> /**
>  * Gets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
>  * @return The value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
>  */
>  public java.lang.CharSequence getTHEREISNOINDICATIONOFWORDS() \{   return 
> THERE_IS_NO_INDICATION_OF_WORDS; }
> /**
>  * Sets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
>  * @param value the value to set.
>  */
>  public void setTHEREISNOINDICATIONOFWORDS(java.lang.CharSequence value) \{   
> this.THERE_IS_NO_INDICATION_OF_WORDS = value; }
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (AVRO-2385) Uppercase fields do not generate proper getter/setters in Java

[Andrew (JIRA)]

Andrew created AVRO-2385:


 Summary: Uppercase fields do not generate proper getter/setters in 
Java
 Key: AVRO-2385
 URL: https://issues.apache.org/jira/browse/AVRO-2385
 Project: Apache Avro
  Issue Type: Bug
  Components: java
Affects Versions: 1.8.2
 Environment: Using Maven plugin with Java 8:

{{ }}
{{  org.apache.avro}}
{{  avro-maven-plugin}}
{{  1.8.2}}
{{  }}
{{    }}
{{      generate-sources}}
{{      }}
{{        schema}}
{{      }}
{{      }}
{{        
${project.basedir}/src/main/resources}}
{{      }}
{{    }}
{{  }}
{{ }}
Reporter: Andrew


Steps to reproduce:

Create an Avro schema with an uppercase field:

{{{}}
{{  "type": "record",}}
{{  "name": "example",}}
{{  "namespace": "issue",}}
{{  "fields": [}}
{{    {}}
{{      "name": "THERE_IS_NO_INDICATION_OF_WORDS",}}
{{      "type": "string"}}
{{    }}}
{{  ]}}
{{}}}

Use the avro-maven-plugin to generate Java code for this schema.

Expected result:

The generate getters and setters use camel casing ThereIsNoIndicationIfWords.

Actual result:

The generated getters and setters are in all uppercase:

/**
 * Gets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 * @return The value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 */
public java.lang.CharSequence getTHEREISNOINDICATIONOFWORDS() {
  return THERE_IS_NO_INDICATION_OF_WORDS;
}

/**
 * Sets the value of the 'THERE_IS_NO_INDICATION_OF_WORDS' field.
 * @param value the value to set.
 */
public void setTHEREISNOINDICATIONOFWORDS(java.lang.CharSequence value) {
  this.THERE_IS_NO_INDICATION_OF_WORDS = value;
}

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE] Release Apache Avro 1.9.0 RC3

[Driesprong, Fokko]

Hi everyone,

Since the last release of Apache Avro 1.8.2 on May 31, 2017. Two years
later,
I'm thrilled to propose the following RC to be released as official Apache
Avro 1.9.0 release.

The commit id is 24ff48c32d8d13433a1e31e485ef2af187d1eb62
* This corresponds to the tag: release-1.9.0-rc3
* https://github.com/apache/avro/releases/tag/release-1.9.0-rc3/

The release tarball, signature, and checksums are here:
* https://dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc3/

You can find the KEYS file here:
* https://dist.apache.org/repos/dist/dev/avro/KEYS

Binary artifacts for Java are staged in Nexus here:
*
https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.0/

This release includes 272 Jira issues:
https://issues.apache.org/jira/projects/AVRO/versions/1294
* Deprecate Joda-Time in favor of Java8 JSR310 and setting it as default
* Remove support for Hadoop 1.x
* Move from Jackson 1.x to 2.9
* Add ZStandard Codec
* Lots of updates on the dependencies to fix CVE's
* and many, many more!

Since RC1, two commits have been added:
* https://jira.apache.org/jira/browse/AVRO-2381
* https://jira.apache.org/jira/browse/AVRO-2383

Since RC2 the SHA1/MD5 checksums have been replaced with SHA512

Please download, verify, and test. This vote will remain open for at least
72 hours. Given sufficient votes, I would like to close it on or about
midnight
on Saturday, 4th of May 2019.

[ ] +1 Release this as Apache Avro 1.9.0
[ ] +0
[ ] -1 Do not release this because...

Consider this a +1 (non-binding) from my side:
* Compiled the new version of Parquet against the Divolte collector and
Apache Parquet

Cheers, Fokko Driesprong

Re: [VOTE] Release Apache Avro 1.9.0 RC2

[Driesprong, Fokko]

Thanks Daniel for updating the build scripts. Canceling the vote due to
SHA1/MD5 checksums.

Cheers, Fokko

Op ma 29 apr. 2019 om 20:14 schreef Driesprong, Fokko :

> Thanks for bringing this up Ismaël. Let me update the checksums.
>
> Cheers, Fokko
>
> Op ma 29 apr. 2019 om 19:49 schreef Daniel Kulp :
>
>> This should be easily fixed by just adding the relevant sha512, no need
>> to completely rebuild unless something else pops up.
>>
>> I’ve updated the Avro build.sh to generate the sha512 instead of the
>> md5/sha1files so if we do need to rebuild, that should be take care of
>> now.
>>
>> Dan
>>
>>
>> > On Apr 29, 2019, at 11:01 AM, Ismaël Mejía  wrote:
>> >
>> > Thanks a lot Fokko for putting this out, I don't know if this is a
>> reason to -1
>> > the vote but we should not supply MD5 or SHA1 checksums, and we should
>> add
>> > SHA-256 and/or SHA-512 following the Apache distribution policy.
>> >
>> > https://www.apache.org/dev/release-distribution.html#sigs-and-sums
>> >
>> > This is a change that happened probably like 1y ago but since it has
>> been long
>> > since Avro's latest release we need to upgrade the scripts to produce
>> the
>> > suggested checksums.
>> >
>> > On Mon, Apr 29, 2019 at 12:57 PM Driesprong, Fokko 
>> wrote:
>> >>
>> >> Hi everyone,
>> >>
>> >> Since the last release of Apache Avro 1.8.2 on May 31, 2017. Two years
>> >> later,
>> >> I'm thrilled to propose the following RC to be released as official
>> Apache
>> >> Avro 1.9.0 release.
>> >>
>> >> The commit id is 8dbe05a17363a1281482e8611cfead4c04645f47
>> >> * This corresponds to the tag: release-1.9.0-rc2
>> >> * https://github.com/apache/avro/releases/tag/release-1.9.0-rc2/
>> >>
>> >> The release tarball, signature, and checksums are here:
>> >> * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc2/
>> >>
>> >> You can find the KEYS file here:
>> >> * https://dist.apache.org/repos/dist/dev/avro/KEYS
>> >>
>> >> Binary artifacts for Java are staged in Nexus here:
>> >> *
>> >>
>> https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.0/
>> >>
>> >> This release includes 272 Jira issues:
>> >> https://issues.apache.org/jira/projects/AVRO/versions/1294
>> >> * Deprecate Joda-Time in favor of Java8 JSR310 and setting it as
>> default
>> >> * Remove support for Hadoop 1.x
>> >> * Move from Jackson 1.x to 2.9
>> >> * Add ZStandard Codec
>> >> * Lots of updates on the dependencies to fix CVE's
>> >> * and many, many more!
>> >>
>> >> Since RC1, two commits have been added:
>> >> * https://jira.apache.org/jira/browse/AVRO-2381
>> >> * https://jira.apache.org/jira/browse/AVRO-2383
>> >>
>> >> Please download, verify, and test. This vote will remain open for at
>> least
>> >> 72 hours. Given sufficient votes, I would like to close it on or about
>> >> midnight
>> >> on Thursday, 2nd of May 2019.
>> >>
>> >> [ ] +1 Release this as Apache Avro 1.9.0
>> >> [ ] +0
>> >> [ ] -1 Do not release this because...
>> >>
>> >> Consider this a +1 (non-binding) from my side:
>> >> * Compiled the new version of Parquet against the Divolte collector and
>> >> Apache Parquet
>> >>
>> >> Cheers, Fokko Driesprong
>>
>> --
>> Daniel Kulp
>> dk...@apache.org  - http://dankulp.com/blog <
>> http://dankulp.com/blog>
>> Talend Community Coder - http://talend.com 
>>
>

[jira] [Resolved] (AVRO-2384) Generate SHA512 checksums instead of SHA1/MD5

[Fokko Driesprong (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong resolved AVRO-2384.

Resolution: Fixed

> Generate SHA512 checksums instead of SHA1/MD5
> -
>
> Key: AVRO-2384
> URL: https://issues.apache.org/jira/browse/AVRO-2384
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Assignee: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (AVRO-2384) Generate SHA512 checksums instead of SHA1/MD5

[Fokko Driesprong (JIRA)]

Fokko Driesprong created AVRO-2384:
--

 Summary: Generate SHA512 checksums instead of SHA1/MD5
 Key: AVRO-2384
 URL: https://issues.apache.org/jira/browse/AVRO-2384
 Project: Apache Avro
  Issue Type: Improvement
  Components: build
Affects Versions: 1.8.2
Reporter: Fokko Driesprong
Assignee: Fokko Driesprong
 Fix For: 1.9.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)