[jira] [Commented] (AVRO-2665) Move to Ruby 2.4
[ https://issues.apache.org/jira/browse/AVRO-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088067#comment-17088067 ] Ismaël Mejía commented on AVRO-2665: Shouldn't this be Ruby 2.5 ? with Ruby 2.4 already EOL it seems to make no sense. https://www.ruby-lang.org/en/downloads/branches/ > Move to Ruby 2.4 > > > Key: AVRO-2665 > URL: https://issues.apache.org/jira/browse/AVRO-2665 > Project: Apache Avro > Issue Type: Bug > Components: ruby >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > > Drop Ruby 2.3 support in favor of Ruby 2.4. Support for ruby 2.3 ended in > March 2019, and support for ruby 2.4 will end March 2020. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2806) Upgrade Netty to 4.x
[ https://issues.apache.org/jira/browse/AVRO-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087701#comment-17087701 ] Gabor Szadovszky commented on AVRO-2806: [~zeshuai007], thanks for pointing to this version. I know that it requires significant efforts as it is a major version upgrade. A while ago I've tried to upgrade to a 4.x version but failed. I don't have any experience on Netty. What I know is 3.x is not maintained any more while has some CVEs reported. I hoped that someone might find my jira and fix it who have more experience. :) > Upgrade Netty to 4.x > > > Key: AVRO-2806 > URL: https://issues.apache.org/jira/browse/AVRO-2806 > Project: Apache Avro > Issue Type: Task > Components: java >Affects Versions: 1.9.2 >Reporter: Gabor Szadovszky >Priority: Major > > ipc-netty still uses the 3.x line which is ended almost 4 years ago. We have > a couple of CVEs which won't be fixed in 3.x so it is important to migrate to > the 4.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AVRO-2807) Pin RuboCop to <=0.81
[
https://issues.apache.org/jira/browse/AVRO-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba updated AVRO-2807:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Pin RuboCop to <=0.81
> -
>
> Key: AVRO-2807
> URL: https://issues.apache.org/jira/browse/AVRO-2807
> Project: Apache Avro
> Issue Type: Bug
> Components: build, docker
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Major
> Fix For: 1.10.0
>
>
> RuboCop 0.82 has been released, which drops Ruby 2.3 support.
> https://github.com/rubocop-hq/rubocop/releases/tag/v0.82.0
> We are still using Ruby 2.3 in the Docker image, so creating container fails
> as follows. It have to be pinned to 0.81, just like AVRO-2664.
> {code}
> $ ./build.sh docker
> (snip)
> Step 16/27 : RUN bundle install --gemfile=/tmp/Gemfile
> ---> Running in 79407933cb02
> Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
> installing your bundle as root will break this application for all non-root
> users on this machine.
> Fetching gem metadata from https://rubygems.org/.
> Fetching version metadata from https://rubygems.org/.
> Resolving dependencies...
> rubocop-0.82.0 requires ruby version >= 2.4.0, which is incompatible with the
> current version, ruby 2.3.3p222
> The command '/bin/sh -c bundle install --gemfile=/tmp/Gemfile' returned a
> non-zero code: 5
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AVRO-2807) Pin RuboCop to <=0.81
[
https://issues.apache.org/jira/browse/AVRO-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba updated AVRO-2807:
--
Fix Version/s: 1.10.0
> Pin RuboCop to <=0.81
> -
>
> Key: AVRO-2807
> URL: https://issues.apache.org/jira/browse/AVRO-2807
> Project: Apache Avro
> Issue Type: Bug
> Components: build, docker
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Major
> Fix For: 1.10.0
>
>
> RuboCop 0.82 has been released, which drops Ruby 2.3 support.
> https://github.com/rubocop-hq/rubocop/releases/tag/v0.82.0
> We are still using Ruby 2.3 in the Docker image, so creating container fails
> as follows. It have to be pinned to 0.81, just like AVRO-2664.
> {code}
> $ ./build.sh docker
> (snip)
> Step 16/27 : RUN bundle install --gemfile=/tmp/Gemfile
> ---> Running in 79407933cb02
> Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
> installing your bundle as root will break this application for all non-root
> users on this machine.
> Fetching gem metadata from https://rubygems.org/.
> Fetching version metadata from https://rubygems.org/.
> Resolving dependencies...
> rubocop-0.82.0 requires ruby version >= 2.4.0, which is incompatible with the
> current version, ruby 2.3.3p222
> The command '/bin/sh -c bundle install --gemfile=/tmp/Gemfile' returned a
> non-zero code: 5
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2807) Pin RuboCop to <=0.81
[
https://issues.apache.org/jira/browse/AVRO-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087560#comment-17087560
]
Hudson commented on AVRO-2807:
--
SUCCESS: Integrated in Jenkins build AvroJava #844 (See
[https://builds.apache.org/job/AvroJava/844/])
AVRO-2807: Pin RuboCop to <=0.81 (#860) (github:
[https://github.com/apache/avro/commit/6b0d470a79b4c4e10d9890183d6c913608a2a225])
* (edit) lang/ruby/Gemfile
> Pin RuboCop to <=0.81
> -
>
> Key: AVRO-2807
> URL: https://issues.apache.org/jira/browse/AVRO-2807
> Project: Apache Avro
> Issue Type: Bug
> Components: build, docker
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Major
>
> RuboCop 0.82 has been released, which drops Ruby 2.3 support.
> https://github.com/rubocop-hq/rubocop/releases/tag/v0.82.0
> We are still using Ruby 2.3 in the Docker image, so creating container fails
> as follows. It have to be pinned to 0.81, just like AVRO-2664.
> {code}
> $ ./build.sh docker
> (snip)
> Step 16/27 : RUN bundle install --gemfile=/tmp/Gemfile
> ---> Running in 79407933cb02
> Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
> installing your bundle as root will break this application for all non-root
> users on this machine.
> Fetching gem metadata from https://rubygems.org/.
> Fetching version metadata from https://rubygems.org/.
> Resolving dependencies...
> rubocop-0.82.0 requires ruby version >= 2.4.0, which is incompatible with the
> current version, ruby 2.3.3p222
> The command '/bin/sh -c bundle install --gemfile=/tmp/Gemfile' returned a
> non-zero code: 5
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [avro] anhldbk opened a new pull request #842: AVRO-2723: Refactor ReflectData to allow derived classes to customize default values for fields
anhldbk opened a new pull request #842:
URL: https://github.com/apache/avro/pull/842
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following
[Avro-2723](https://issues.apache.org/jira/browse/AVRO-2723)
### Tests
No new tests are needed. I just refactor the code base.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (AVRO-2807) Pin RuboCop to <=0.81
[
https://issues.apache.org/jira/browse/AVRO-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087511#comment-17087511
]
ASF subversion and git services commented on AVRO-2807:
---
Commit 6b0d470a79b4c4e10d9890183d6c913608a2a225 in avro's branch
refs/heads/master from Kengo Seki
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=6b0d470 ]
AVRO-2807: Pin RuboCop to <=0.81 (#860)
> Pin RuboCop to <=0.81
> -
>
> Key: AVRO-2807
> URL: https://issues.apache.org/jira/browse/AVRO-2807
> Project: Apache Avro
> Issue Type: Bug
> Components: build, docker
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Major
>
> RuboCop 0.82 has been released, which drops Ruby 2.3 support.
> https://github.com/rubocop-hq/rubocop/releases/tag/v0.82.0
> We are still using Ruby 2.3 in the Docker image, so creating container fails
> as follows. It have to be pinned to 0.81, just like AVRO-2664.
> {code}
> $ ./build.sh docker
> (snip)
> Step 16/27 : RUN bundle install --gemfile=/tmp/Gemfile
> ---> Running in 79407933cb02
> Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
> installing your bundle as root will break this application for all non-root
> users on this machine.
> Fetching gem metadata from https://rubygems.org/.
> Fetching version metadata from https://rubygems.org/.
> Resolving dependencies...
> rubocop-0.82.0 requires ruby version >= 2.4.0, which is incompatible with the
> current version, ruby 2.3.3p222
> The command '/bin/sh -c bundle install --gemfile=/tmp/Gemfile' returned a
> non-zero code: 5
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [avro] RyanSkraba commented on issue #860: AVRO-2807: Pin RuboCop to <=0.81
RyanSkraba commented on issue #860: URL: https://github.com/apache/avro/pull/860#issuecomment-616410170 Thanks! It looks like we could no longer build a new docker images locally either and this fixes the immediate problem. I linked this issue to https://issues.apache.org/jira/browse/AVRO-2665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
