[jira] [Created] (AVRO-2811) Upgrade grpc 1.26 to 1.28

2020-04-21 Thread Zezeng Wang (Jira)
Zezeng Wang created AVRO-2811:
-

 Summary: Upgrade grpc 1.26 to 1.28
 Key: AVRO-2811
 URL: https://issues.apache.org/jira/browse/AVRO-2811
 Project: Apache Avro
  Issue Type: Task
Affects Versions: 1.9.2
Reporter: Zezeng Wang
 Fix For: 1.9.3


In netty 1.26 there are bugs that need attention.
Eg: [Deadlock on start gRPC 
server|https://github.com/grpc/grpc-java/issues/6601]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2723) Avro Java: Obtaining default field values for POJO objects with ReflectData

2020-04-21 Thread Andy Le (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089264#comment-17089264
 ] 

Andy Le commented on AVRO-2723:
---

[~cutting] Sorry for this late reply

 

> Is there a reason not to use the default value from the Java class as the 
> default value in the schema? 

No actually. But the developer experience is much better (nice to have)

 

> Would this break existing applications?

May be. (Although I ran `mvn test` successfully). I suggest we should gather 
RFC for Avro 2.x to include this feature.

 

> Avro Java: Obtaining default field values for POJO objects with ReflectData
> ---
>
> Key: AVRO-2723
> URL: https://issues.apache.org/jira/browse/AVRO-2723
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.9.1
>Reporter: Andy Le
>Priority: Critical
> Attachments: Screen Shot 2020-03-08 at 16.13.29.png
>
>
> Hi guys,
>  
> I've got a simple app using Avro Reflection:
>  
> {code:java}
> public class App {
>   public static void main(String[] args) {
> testReflection();
>   }
>   static class User {
> public String first = "Andy";
> public String last = "Le";
>   }
>   static void testReflection(){
> // get the reflected schema for packets
> Schema schema = ReflectData.AllowNull.get().getSchema(User.class);
> System.out.println(schema.toString(true));
>   }
> {code}
> The output on console will be:
> {noformat}
> {
>   "type" : "record",
>   "name" : "User",
>   "namespace" : "App",
>   "fields" : [ {
> "name" : "first",
> "type" : [ "null", "string" ],
> "default" : null
>   }, {
> "name" : "last",
> "type" : [ "null", "string" ],
> "default" : null
>   } ]
> }
> {noformat}
>  
> As you can see, there's no default values for fields. Would you please tell 
> me how to obtain such values?
> Thank you.
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2806) Upgrade Netty to 4.x

2020-04-21 Thread Zezeng Wang (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089256#comment-17089256
 ] 

Zezeng Wang commented on AVRO-2806:
---

I noticed the previous ticket, https://issues.apache.org/jira/browse/AVRO-1973, 
and I saw your efforts to this end. (y)
But netty-codec-http2 is already using 4.1.45.Final, which has troubled me, why 
both 3.x and 4.x are supported, is it because 3.x and 4.x are not forward 
compatible, forgive I have so many questions.

> Upgrade Netty to 4.x
> 
>
> Key: AVRO-2806
> URL: https://issues.apache.org/jira/browse/AVRO-2806
> Project: Apache Avro
>  Issue Type: Task
>  Components: java
>Affects Versions: 1.9.2
>Reporter: Gabor Szadovszky
>Priority: Major
>
> ipc-netty still uses the 3.x line which is ended almost 4 years ago. We have 
> a couple of CVEs which won't be fixed in 3.x so it is important to migrate to 
> the 4.x.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2806) Upgrade Netty to 4.x

2020-04-21 Thread Zezeng Wang (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089207#comment-17089207
 ] 

Zezeng Wang commented on AVRO-2806:
---

[~gszadovszky],thank you for your reply,
Netty has many major API changes from 3.x to 4.x, and even 5.x is deprecated. 
If you want to quickly understand the historical changes of various versions, 
it is very troublesome. Forgive me for your curiosity. What is the difficulty, 
is it a netty modularity problem?:D

> Upgrade Netty to 4.x
> 
>
> Key: AVRO-2806
> URL: https://issues.apache.org/jira/browse/AVRO-2806
> Project: Apache Avro
>  Issue Type: Task
>  Components: java
>Affects Versions: 1.9.2
>Reporter: Gabor Szadovszky
>Priority: Major
>
> ipc-netty still uses the 3.x line which is ended almost 4 years ago. We have 
> a couple of CVEs which won't be fixed in 3.x so it is important to migrate to 
> the 4.x.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [avro] cutting commented on issue #842: AVRO-2723: Refactor ReflectData to allow derived classes to customize default values for fields

2020-04-21 Thread GitBox


cutting commented on issue #842:
URL: https://github.com/apache/avro/pull/842#issuecomment-617319686


   New public & protected methods need javadoc comments.  Also, the new fields 
should probably be private, not protected.
   
   Might the cache be better as WeakHashMap?
   
   I don't see where isFieldInitialized is called.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (AVRO-2810) AvroGen created invalid .cs file for nullable decimal type field

2020-04-21 Thread Alex Xu (Jira)


 [ 
https://issues.apache.org/jira/browse/AVRO-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Xu updated AVRO-2810:
--
Description: 
I was using the apache avro 1.9.2 dotnet tool to generate the cs files. There 
is a nullable logical type 'decimal' in my schema file. The cs file generated 
has an error as follows.

 

My schema file is like this:
{
"name": "Previous",
"type":
[
{
"type": "bytes",
"logicalType": "decimal",
"precision": 19,
"scale": 4
},
"null"
]
}
The cs file created has an error:
case 1: this.Previous = (System.Nullable`1[Avro.AvroDecimal])fieldValue; break;

  was:I was using the apache avro 1.9.2 dotnet tool to generate the cs files. 
There is a nullable logical type 'decimal' in my schema file. The cs file 
generated has an error as follows.


> AvroGen created invalid .cs file for nullable decimal type field
> 
>
> Key: AVRO-2810
> URL: https://issues.apache.org/jira/browse/AVRO-2810
> Project: Apache Avro
>  Issue Type: Bug
>  Components: csharp
>Affects Versions: 1.9.2
> Environment: My schema file is like this:
> {
> "name": "Previous",
> "type":
> [
> {
> "type": "bytes",
> "logicalType": "decimal",
> "precision": 19,
> "scale": 4
> },
> "null"
> ]
> }
> The cs file created has an error:
> case 1: this.Previous = (System.Nullable`1[Avro.AvroDecimal])fieldValue; 
> break;
>Reporter: Alex Xu
>Priority: Major
>
> I was using the apache avro 1.9.2 dotnet tool to generate the cs files. There 
> is a nullable logical type 'decimal' in my schema file. The cs file generated 
> has an error as follows.
>  
> My schema file is like this:
> {
> "name": "Previous",
> "type":
> [
> {
> "type": "bytes",
> "logicalType": "decimal",
> "precision": 19,
> "scale": 4
> },
> "null"
> ]
> }
> The cs file created has an error:
> case 1: this.Previous = (System.Nullable`1[Avro.AvroDecimal])fieldValue; 
> break;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (AVRO-2810) AvroGen created invalid .cs file for nullable decimal type field

2020-04-21 Thread Alex Xu (Jira)
Alex Xu created AVRO-2810:
-

 Summary: AvroGen created invalid .cs file for nullable decimal 
type field
 Key: AVRO-2810
 URL: https://issues.apache.org/jira/browse/AVRO-2810
 Project: Apache Avro
  Issue Type: Bug
  Components: csharp
Affects Versions: 1.9.2
 Environment: My schema file is like this:
{
"name": "Previous",
"type":
[
{
"type": "bytes",
"logicalType": "decimal",
"precision": 19,
"scale": 4
},
"null"
]
}
The cs file created has an error:
case 1: this.Previous = (System.Nullable`1[Avro.AvroDecimal])fieldValue; break;
Reporter: Alex Xu


I was using the apache avro 1.9.2 dotnet tool to generate the cs files. There 
is a nullable logical type 'decimal' in my schema file. The cs file generated 
has an error as follows.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [avro] anhldbk commented on issue #842: AVRO-2723: Refactor ReflectData to allow derived classes to customize default values for fields

2020-04-21 Thread GitBox


anhldbk commented on issue #842:
URL: https://github.com/apache/avro/pull/842#issuecomment-617120834


   @cutting @Fokko my code is clean now. PTAL.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [avro] sekikn commented on issue #644: AVRO-2554: Fix Ruby interop test to read all supported codecs

2020-04-21 Thread GitBox


sekikn commented on issue #644:
URL: https://github.com/apache/avro/pull/644#issuecomment-617094497


   I forgot to add snappy to the codecs to be validated at the first commit, so 
I've just added it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org