[GitHub] [avro] maxromanovsky opened a new pull request #931: Docs: Fixed map spec example

2020-07-11 Thread GitBox


maxromanovsky opened a new pull request #931:
URL: https://github.com/apache/avro/pull/931


   Replaced "items" with proper key "values"
   
   Just a small fix, so apologies for not following the whole process.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro 
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them 
in the PR title. For example, "AVRO-1234: My Avro PR"
 - https://issues.apache.org/jira/browse/AVRO-XXX
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](https://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [avro] maxromanovsky closed pull request #931: Docs: Fixed map spec example

2020-07-11 Thread GitBox


maxromanovsky closed pull request #931:
URL: https://github.com/apache/avro/pull/931


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [avro] kojiromike opened a new pull request #932: ### Jira

2020-07-11 Thread GitBox


kojiromike opened a new pull request #932:
URL: https://github.com/apache/avro/pull/932


   - [x] My PR addresses 
[AVRO-2889](https://issues.apache.org/jira/browse/AVRO-2889)
   - [x] Adds no dependencies
   
   ### Tests
   
   - [x] My PR fixes a race condition in a test.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines.
   
   ### Documentation
   
   - [x] N/A



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (AVRO-2892) Avro should provide codec implementations for Python

2020-07-11 Thread Michael A. Smith (Jira)
Michael A. Smith created AVRO-2892:
--

 Summary: Avro should provide codec implementations for Python
 Key: AVRO-2892
 URL: https://issues.apache.org/jira/browse/AVRO-2892
 Project: Apache Avro
  Issue Type: New Feature
  Components: python
Reporter: Michael A. Smith


Registered [Python codecs|https://docs.python.org/3/library/codecs.html] 
provide a fluent and natural way to convert between object and serialized 
(particularly as-binary) data. Avro should provide two codec implementations:

# Static encode and decode, that encodes native Python objects (lists, dicts, 
and primitive scalars) and infer the schema from the data itself, producing a 
binary string containing the schema and the encoded data.
# A solution for registering a Schema into the Python codec registry, so that 
codec.encode/decode can convert objects into Avro binary for that schema.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: When and how should we remove lang/py3?

2020-07-11 Thread Michael A. Smith
Bringing this back up: I think avro and avro-python3 are mostly compatible,
so we really just need to invent a way to make people switch automatically.
We could almost have py3 install avro as a dependency. The thing is, both
packages are under the root namespace `avro`, so you can't trivially have
them both installed. Maybe we can publish both packages from the same
codebase, but have the py3 one give a deprecation warning.

WDYT?

On Sun, May 3, 2020 at 03:45 Driesprong, Fokko  wrote:

> Hi Mchael,
>
> Thank you for bringing this up. I agree, but I'm not sure how we're going
> to migrate the users to the avro package.
>
> Rijprojectnum_downloads
> 1
> avro
> 885838
> 2
> avro-python3
> 147313
>
> A quick query on bigquery, that contains all the pypi downloads shows that
> the python3 package is more popular. Maybe we should add a deprecation
> warning in 1.10.0?
>
> Cheers,
> Fokko
>
> The query:
> SELECT file.project, COUNT(*) AS num_downloads
> FROM `the-psf.pypi.downloads*`
> WHERE file.project IN ('avro-python3', 'avro')
>   -- Only query the last 30 days of history
>   AND _TABLE_SUFFIX
> BETWEEN FORMAT_DATE(
>   '%Y%m%d', DATE_SUB(CURRENT_DATE(), INTERVAL 30 DAY))
> AND FORMAT_DATE('%Y%m%d', CURRENT_DATE())
> GROUP BY file.project
>
>
>
>
>
> Op do 30 apr. 2020 om 14:20 schreef Michael Smith :
>
> >  Previous emails on this list have discussed the "why" questions. But
> when
> > and how should we go about it? Could 1.10 be the last avro release to
> > include avro-python3? This would allow us to play a little less ticket
> > tennis with folks reporting bugs (can you reproduce this in "the other"
> > python library?) and focus all our effort into one python implementation.
> >
> > What do you think?
> >
>