[jira] [Work logged] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?focusedWorklogId=771695=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771695 ] ASF GitHub Bot logged work on AVRO-3522: Author: ASF GitHub Bot Created on: 18/May/22 03:17 Start Date: 18/May/22 03:17 Worklog Time Spent: 10m Work Description: jklamer commented on PR #1690: URL: https://github.com/apache/avro/pull/1690#issuecomment-1129523346 nice! Ill have to pull this locally and break some stuff! Issue Time Tracking --- Worklog Id: (was: 771695) Time Spent: 20m (was: 10m) > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Data Engineering Track at ApacheCon (October 3-6, New Orleans) - CFP ends 23/05
Hello, ApacheCon North America is back in person this year in October. https://apachecon.com/acna2022/ Together with Jarek Potiuk, we are organizing for the first time a Data Engineering Track as part of ApacheCon. You might be wondering why a different track if we already have the Big Data track. Simple, this new track covers the ‘other’ open-source projects we use to clean data, orchestrate workloads, do observability, visualization, governance, data lineage and many other tasks that are part of data engineering and that are usually not covered by the data processing / database tracks. If you are curious you can find more details here: https://s.apache.org/apacheconna-2022-dataeng-track So why are you getting this message? Well it could be that (1) you are already a contributor to a project in the data engineering space and you might be interested in sending your proposal, or (2) you are interested in integrations of these tools with your existing data tools/projects. If you are interested you can submit a proposal using the CfP link below. Don’t forget to choose the Data Engineering Track. https://apachecon.com/acna2022/cfp.html The Call for Presentations (CfP) closes in less than one week on May 23th, 2022. We are looking forward to receiving your submissions and hopefully seeing you in New Orleans in October. Thanks, Ismaël and Jarek ps. Excuses if you already received this email by a different channel/ML
[jira] [Commented] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538422#comment-17538422 ] ASF subversion and git services commented on AVRO-3522: --- Commit 9e54be7bcbc537a22a9144aacc0b904278161b69 in avro's branch refs/heads/avro-3522-better-logging-in-tests from Martin Tzvetanov Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=9e54be7bc ] AVRO-3522: Use pretty_assertions for better diffs when assertions fail Signed-off-by: Martin Tzvetanov Grigorov > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538412#comment-17538412 ] ASF subversion and git services commented on AVRO-3522: --- Commit 3578c15df389a9d0ad849093083417db157747f8 in avro's branch refs/heads/avro-3522-better-logging-in-tests from Martin Tzvetanov Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=3578c15df ] AVRO-3522: Add ASL2 to the new files Signed-off-by: Martin Tzvetanov Grigorov > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538411#comment-17538411 ] ASF subversion and git services commented on AVRO-3522: --- Commit 021db196a34b55ae3b69116254970388b39aaa32 in avro's branch refs/heads/avro-3522-better-logging-in-tests from Martin Tzvetanov Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=021db196a ] AVRO-3522: Make LOG_MESSAGES module-private Signed-off-by: Martin Tzvetanov Grigorov > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[
https://issues.apache.org/jira/browse/AVRO-3522?focusedWorklogId=771522=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771522
]
ASF GitHub Bot logged work on AVRO-3522:
Author: ASF GitHub Bot
Created on: 17/May/22 18:53
Start Date: 17/May/22 18:53
Worklog Time Spent: 10m
Work Description: martin-g opened a new pull request, #1690:
URL: https://github.com/apache/avro/pull/1690
### Jira
- [X] https://issues.apache.org/jira/browse/AVRO-3522
### Tests
- [X] My PR improves some unit and IT tests
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] The new module is documented in its README.md
Issue Time Tracking
---
Worklog Id: (was: 771522)
Remaining Estimate: 0h
Time Spent: 10m
> Rust: Setup better logging and colored stacktraces for the tests
>
>
> Key: AVRO-3522
> URL: https://issues.apache.org/jira/browse/AVRO-3522
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Extract the custom TestLogger (that collects and asserts on the logs) used in
> types.rs into a new module/crate so that it could be reused everywhere.
> An additional improvement that could be made is to add env_logger as a
> delegate to it so that it also logs to stderr.
>
> Use ctor crate to simulate before_all/after_all.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AVRO-3522: - Labels: pull-request-available (was: ) > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [avro] martin-g opened a new pull request, #1690: AVRO-3522: Better logging in tests
martin-g opened a new pull request, #1690:
URL: https://github.com/apache/avro/pull/1690
### Jira
- [X] https://issues.apache.org/jira/browse/AVRO-3522
### Tests
- [X] My PR improves some unit and IT tests
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] The new module is documented in its README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538408#comment-17538408 ] ASF subversion and git services commented on AVRO-3522: --- Commit 22b1a2abf03eef2732eca1af51455a4844649922 in avro's branch refs/heads/avro-3522-better-logging-in-tests from Martin Tzvetanov Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=22b1a2abf ] AVRO-3522: Give better names to some methods Signed-off-by: Martin Tzvetanov Grigorov > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538402#comment-17538402 ] ASF subversion and git services commented on AVRO-3522: --- Commit b2b05c38a5d7355620c585fb9bb0896891941a8e in avro's branch refs/heads/avro-3522-better-logging-in-tests from Martin Tzvetanov Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=b2b05c38a ] AVRO-3522: Improve the README Signed-off-by: Martin Tzvetanov Grigorov > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
[ https://issues.apache.org/jira/browse/AVRO-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538398#comment-17538398 ] ASF subversion and git services commented on AVRO-3522: --- Commit fdbfd6f11df5db7bd105f773d9f33a5221bd5405 in avro's branch refs/heads/avro-3522-better-logging-in-tests from Martin Tzvetanov Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=fdbfd6f11 ] AVRO-3522: Use ctor crate to setup/teardown tests Use TestLogger for all tests. Now it delegates to env_logger too Signed-off-by: Martin Tzvetanov Grigorov > Rust: Setup better logging and colored stacktraces for the tests > > > Key: AVRO-3522 > URL: https://issues.apache.org/jira/browse/AVRO-3522 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Minor > > Extract the custom TestLogger (that collects and asserts on the logs) used in > types.rs into a new module/crate so that it could be reused everywhere. > An additional improvement that could be made is to add env_logger as a > delegate to it so that it also logs to stderr. > > Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (AVRO-3522) Rust: Setup better logging and colored stacktraces for the tests
Martin Tzvetanov Grigorov created AVRO-3522: --- Summary: Rust: Setup better logging and colored stacktraces for the tests Key: AVRO-3522 URL: https://issues.apache.org/jira/browse/AVRO-3522 Project: Apache Avro Issue Type: Improvement Components: rust Reporter: Martin Tzvetanov Grigorov Assignee: Martin Tzvetanov Grigorov Extract the custom TestLogger (that collects and asserts on the logs) used in types.rs into a new module/crate so that it could be reused everywhere. An additional improvement that could be made is to add env_logger as a delegate to it so that it also logs to stderr. Use ctor crate to simulate before_all/after_all. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (AVRO-3521) "Scale" property from decimal object
[ https://issues.apache.org/jira/browse/AVRO-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Izvekov updated AVRO-3521: --- Description: >From [https://avro.apache.org/docs/current/spec.html:] - scale, a JSON integer representing the scale (optional). If not specified the scale is 0. In the "datafile.py" scale greater than or *equal* to 0, but "DatumReader" and "DatumWriter" reads/writes values greater than 0 (not equal 0). was: >From [https://avro.apache.org/docs/current/spec.html:] - scale, a JSON integer representing the scale (optional). If not specified the scale is 0. In the "datafile.py" scale greater than or *equal* to 0 0, but "DatumReader" and "DatumWriter" reads/writes values greater than 0 (not equal 0). > "Scale" property from decimal object > > > Key: AVRO-3521 > URL: https://issues.apache.org/jira/browse/AVRO-3521 > Project: Apache Avro > Issue Type: Bug > Components: python >Affects Versions: 1.10.2 >Reporter: Igor Izvekov >Priority: Major > Labels: pull-request-available > Fix For: 1.11.1 > > Time Spent: 10m > Remaining Estimate: 0h > > From [https://avro.apache.org/docs/current/spec.html:] > - scale, a JSON integer representing the scale (optional). If not > specified the scale is 0. > In the "datafile.py" scale greater than or *equal* to 0, but "DatumReader" > and "DatumWriter" reads/writes values greater than 0 (not equal 0). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (AVRO-3521) "Scale" property from decimal object
[ https://issues.apache.org/jira/browse/AVRO-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Izvekov updated AVRO-3521: --- Description: >From [https://avro.apache.org/docs/current/spec.html:] - scale, a JSON integer representing the scale (optional). If not specified the scale is 0. In the "datafile.py" scale greater than or *equal* to 0 0, but "DatumReader" and "DatumWriter" reads/writes values greater than 0 (not equal 0). was: >From [https://avro.apache.org/docs/current/spec.html:] - scale, a JSON integer representing the scale (optional). If not specified the scale is 0. In the "datafile.py" scale more or *equal* 0, but "DatumReader" and "DatumWriter" reads/writes values more 0 (not equal 0). > "Scale" property from decimal object > > > Key: AVRO-3521 > URL: https://issues.apache.org/jira/browse/AVRO-3521 > Project: Apache Avro > Issue Type: Bug > Components: python >Affects Versions: 1.10.2 >Reporter: Igor Izvekov >Priority: Major > Labels: pull-request-available > Fix For: 1.11.1 > > Time Spent: 10m > Remaining Estimate: 0h > > From [https://avro.apache.org/docs/current/spec.html:] > - scale, a JSON integer representing the scale (optional). If not > specified the scale is 0. > In the "datafile.py" scale greater than or *equal* to 0 0, but "DatumReader" > and "DatumWriter" reads/writes values greater than 0 (not equal 0). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (AVRO-3521) "Scale" property from decimal object
[ https://issues.apache.org/jira/browse/AVRO-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AVRO-3521: - Labels: pull-request-available (was: ) > "Scale" property from decimal object > > > Key: AVRO-3521 > URL: https://issues.apache.org/jira/browse/AVRO-3521 > Project: Apache Avro > Issue Type: Bug > Components: python >Affects Versions: 1.10.2 >Reporter: Igor Izvekov >Priority: Major > Labels: pull-request-available > Fix For: 1.11.1 > > Time Spent: 10m > Remaining Estimate: 0h > > From [https://avro.apache.org/docs/current/spec.html:] > - scale, a JSON integer representing the scale (optional). If not > specified the scale is 0. > In the "datafile.py" scale more or *equal* 0, but "DatumReader" and > "DatumWriter" reads/writes values more 0 (not equal 0). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (AVRO-3521) "Scale" property from decimal object
[
https://issues.apache.org/jira/browse/AVRO-3521?focusedWorklogId=771475=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771475
]
ASF GitHub Bot logged work on AVRO-3521:
Author: ASF GitHub Bot
Created on: 17/May/22 17:08
Start Date: 17/May/22 17:08
Worklog Time Spent: 10m
Work Description: izveigor opened a new pull request, #1689:
URL: https://github.com/apache/avro/pull/1689
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
Issue Time Tracking
---
Worklog Id: (was: 771475)
Remaining Estimate: 0h
Time Spent: 10m
> "Scale" property from decimal object
>
>
> Key: AVRO-3521
> URL: https://issues.apache.org/jira/browse/AVRO-3521
> Project: Apache Avro
> Issue Type: Bug
> Components: python
>Affects Versions: 1.10.2
>Reporter: Igor Izvekov
>Priority: Major
> Fix For: 1.11.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> From [https://avro.apache.org/docs/current/spec.html:]
> - scale, a JSON integer representing the scale (optional). If not
> specified the scale is 0.
> In the "datafile.py" scale more or *equal* 0, but "DatumReader" and
> "DatumWriter" reads/writes values more 0 (not equal 0).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [avro] izveigor opened a new pull request, #1689: AVRO-3521: "Scale" property from decimal object
izveigor opened a new pull request, #1689:
URL: https://github.com/apache/avro/pull/1689
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (AVRO-3521) "Scale" property from decimal object
Igor Izvekov created AVRO-3521: -- Summary: "Scale" property from decimal object Key: AVRO-3521 URL: https://issues.apache.org/jira/browse/AVRO-3521 Project: Apache Avro Issue Type: Bug Components: python Affects Versions: 1.10.2 Reporter: Igor Izvekov Fix For: 1.11.1 >From [https://avro.apache.org/docs/current/spec.html:] - scale, a JSON integer representing the scale (optional). If not specified the scale is 0. In the "datafile.py" scale more or *equal* 0, but "DatumReader" and "DatumWriter" reads/writes values more 0 (not equal 0). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (AVRO-3374) [Java] Fully qualified type reference "ns.int" loses namespace.
[
https://issues.apache.org/jira/browse/AVRO-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538178#comment-17538178
]
Christophe Le Saec commented on AVRO-3374:
--
Good question indeed.
[For first part of
sentence|https://avro.apache.org/docs/current/spec.html#names] "Primitive type
names have no namespace", it's OK as in example, "ns.int" is a define a record.
For second part : "their names may not be defined in any namespace", it's not
entirely clear to me. If it means that names of primitive may not be used to
define other types as record; then the json shouldn't be parsed correctly in
Java (and it should throw an exception). If it means that a new primitive type
cannot be defined in a schema (said 'positive integer' for instance), the
example is fine with it.
> [Java] Fully qualified type reference "ns.int" loses namespace.
> ---
>
> Key: AVRO-3374
> URL: https://issues.apache.org/jira/browse/AVRO-3374
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.11.0
>Reporter: Ryan Skraba
>Assignee: Christophe Le Saec
>Priority: Minor
> Labels: pull-requests-available
> Attachments: AVRO-3374.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While brainstorming for AVRO-3370, I came across this special case where a
> type-reference could be considered ambiguous if the SDK is not careful when
> simplifying inherited namespaces:
> {code:json}
> {
> "type" : "record",
> "name" : "ns.int",
> "fields" : [
> {"name" : "value", "type" : "int"},
> {"name" : "next", "type" : [ "null", "ns.int" ]}
> ]
> }
> {code}
> In Java, if this code is parsed, it works as expected (as a linked list).
> If the schema is turned to a String using toString(), the namespace is
> dropped off the last {*}{{ns.int}}{*}, turning it into the primitive. That
> string can still be parsed into a Schema, but the "round-trip" modifies the
> schema in an incompatible way.
> That namespace shouldn't be dropped when producing the JSON string
> representing the Schema in Java.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (AVRO-3374) [Java] Fully qualified type reference "ns.int" loses namespace.
[
https://issues.apache.org/jira/browse/AVRO-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538178#comment-17538178
]
Christophe Le Saec edited comment on AVRO-3374 at 5/17/22 1:08 PM:
---
Good question indeed.
[For first part of
sentence|https://avro.apache.org/docs/current/spec.html#names] "Primitive type
names have no namespace", it's OK as in example, "ns.int" define a record.
For second part : "their names may not be defined in any namespace", it's not
entirely clear to me. If it means that names of primitive may not be used to
define other types as record; then the json shouldn't be parsed correctly in
Java (and it should throw an exception). If it means that a new primitive type
cannot be defined in a schema (said 'positive integer' for instance), the
example is fine with it.
was (Author: JIRAUSER289541):
Good question indeed.
[For first part of
sentence|https://avro.apache.org/docs/current/spec.html#names] "Primitive type
names have no namespace", it's OK as in example, "ns.int" is a define a record.
For second part : "their names may not be defined in any namespace", it's not
entirely clear to me. If it means that names of primitive may not be used to
define other types as record; then the json shouldn't be parsed correctly in
Java (and it should throw an exception). If it means that a new primitive type
cannot be defined in a schema (said 'positive integer' for instance), the
example is fine with it.
> [Java] Fully qualified type reference "ns.int" loses namespace.
> ---
>
> Key: AVRO-3374
> URL: https://issues.apache.org/jira/browse/AVRO-3374
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.11.0
>Reporter: Ryan Skraba
>Assignee: Christophe Le Saec
>Priority: Minor
> Labels: pull-requests-available
> Attachments: AVRO-3374.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While brainstorming for AVRO-3370, I came across this special case where a
> type-reference could be considered ambiguous if the SDK is not careful when
> simplifying inherited namespaces:
> {code:json}
> {
> "type" : "record",
> "name" : "ns.int",
> "fields" : [
> {"name" : "value", "type" : "int"},
> {"name" : "next", "type" : [ "null", "ns.int" ]}
> ]
> }
> {code}
> In Java, if this code is parsed, it works as expected (as a linked list).
> If the schema is turned to a String using toString(), the namespace is
> dropped off the last {*}{{ns.int}}{*}, turning it into the primitive. That
> string can still be parsed into a Schema, but the "round-trip" modifies the
> schema in an incompatible way.
> That namespace shouldn't be dropped when producing the JSON string
> representing the Schema in Java.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (AVRO-3374) [Java] Fully qualified type reference "ns.int" loses namespace.
[
https://issues.apache.org/jira/browse/AVRO-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christophe Le Saec updated AVRO-3374:
-
Labels: pull-requests-available (was: pull-request-available)
> [Java] Fully qualified type reference "ns.int" loses namespace.
> ---
>
> Key: AVRO-3374
> URL: https://issues.apache.org/jira/browse/AVRO-3374
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.11.0
>Reporter: Ryan Skraba
>Assignee: Christophe Le Saec
>Priority: Minor
> Labels: pull-requests-available
> Attachments: AVRO-3374.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While brainstorming for AVRO-3370, I came across this special case where a
> type-reference could be considered ambiguous if the SDK is not careful when
> simplifying inherited namespaces:
> {code:json}
> {
> "type" : "record",
> "name" : "ns.int",
> "fields" : [
> {"name" : "value", "type" : "int"},
> {"name" : "next", "type" : [ "null", "ns.int" ]}
> ]
> }
> {code}
> In Java, if this code is parsed, it works as expected (as a linked list).
> If the schema is turned to a String using toString(), the namespace is
> dropped off the last {*}{{ns.int}}{*}, turning it into the primitive. That
> string can still be parsed into a Schema, but the "round-trip" modifies the
> schema in an incompatible way.
> That namespace shouldn't be dropped when producing the JSON string
> representing the Schema in Java.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (AVRO-3374) [Java] Fully qualified type reference "ns.int" loses namespace.
[
https://issues.apache.org/jira/browse/AVRO-3374?focusedWorklogId=771299=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771299
]
ASF GitHub Bot logged work on AVRO-3374:
Author: ASF GitHub Bot
Created on: 17/May/22 12:37
Start Date: 17/May/22 12:37
Worklog Time Spent: 10m
Work Description: clesaec opened a new pull request, #1688:
URL: https://github.com/apache/avro/pull/1688
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests
TestSchema.testParseRecordWithNameAsType and TestSchema.testQualifiedName
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does (no adding functionality nor modified public classes)
Issue Time Tracking
---
Worklog Id: (was: 771299)
Remaining Estimate: 0h
Time Spent: 10m
> [Java] Fully qualified type reference "ns.int" loses namespace.
> ---
>
> Key: AVRO-3374
> URL: https://issues.apache.org/jira/browse/AVRO-3374
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.11.0
>Reporter: Ryan Skraba
>Assignee: Christophe Le Saec
>Priority: Minor
> Attachments: AVRO-3374.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While brainstorming for AVRO-3370, I came across this special case where a
> type-reference could be considered ambiguous if the SDK is not careful when
> simplifying inherited namespaces:
> {code:json}
> {
> "type" : "record",
> "name" : "ns.int",
> "fields" : [
> {"name" : "value", "type" : "int"},
> {"name" : "next", "type" : [ "null", "ns.int" ]}
> ]
> }
> {code}
> In Java, if this code is parsed, it works as expected (as a linked list).
> If the schema is turned to a String using toString(), the namespace is
> dropped off the last {*}{{ns.int}}{*}, turning it into the primitive. That
> string can still be parsed into a Schema, but the "round-trip" modifies the
> schema in an incompatible way.
> That namespace shouldn't be dropped when producing the JSON string
> representing the Schema in Java.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (AVRO-3374) [Java] Fully qualified type reference "ns.int" loses namespace.
[
https://issues.apache.org/jira/browse/AVRO-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AVRO-3374:
-
Labels: pull-request-available (was: )
> [Java] Fully qualified type reference "ns.int" loses namespace.
> ---
>
> Key: AVRO-3374
> URL: https://issues.apache.org/jira/browse/AVRO-3374
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.11.0
>Reporter: Ryan Skraba
>Assignee: Christophe Le Saec
>Priority: Minor
> Labels: pull-request-available
> Attachments: AVRO-3374.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While brainstorming for AVRO-3370, I came across this special case where a
> type-reference could be considered ambiguous if the SDK is not careful when
> simplifying inherited namespaces:
> {code:json}
> {
> "type" : "record",
> "name" : "ns.int",
> "fields" : [
> {"name" : "value", "type" : "int"},
> {"name" : "next", "type" : [ "null", "ns.int" ]}
> ]
> }
> {code}
> In Java, if this code is parsed, it works as expected (as a linked list).
> If the schema is turned to a String using toString(), the namespace is
> dropped off the last {*}{{ns.int}}{*}, turning it into the primitive. That
> string can still be parsed into a Schema, but the "round-trip" modifies the
> schema in an incompatible way.
> That namespace shouldn't be dropped when producing the JSON string
> representing the Schema in Java.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [avro] clesaec opened a new pull request, #1688: AVRO-3374: special cases for qualified name
clesaec opened a new pull request, #1688:
URL: https://github.com/apache/avro/pull/1688
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests
TestSchema.testParseRecordWithNameAsType and TestSchema.testQualifiedName
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does (no adding functionality nor modified public classes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (AVRO-3374) [Java] Fully qualified type reference "ns.int" loses namespace.
[
https://issues.apache.org/jira/browse/AVRO-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christophe Le Saec updated AVRO-3374:
-
Attachment: AVRO-3374.patch
> [Java] Fully qualified type reference "ns.int" loses namespace.
> ---
>
> Key: AVRO-3374
> URL: https://issues.apache.org/jira/browse/AVRO-3374
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.11.0
>Reporter: Ryan Skraba
>Assignee: Christophe Le Saec
>Priority: Minor
> Attachments: AVRO-3374.patch
>
>
> While brainstorming for AVRO-3370, I came across this special case where a
> type-reference could be considered ambiguous if the SDK is not careful when
> simplifying inherited namespaces:
> {code:json}
> {
> "type" : "record",
> "name" : "ns.int",
> "fields" : [
> {"name" : "value", "type" : "int"},
> {"name" : "next", "type" : [ "null", "ns.int" ]}
> ]
> }
> {code}
> In Java, if this code is parsed, it works as expected (as a linked list).
> If the schema is turned to a String using toString(), the namespace is
> dropped off the last {*}{{ns.int}}{*}, turning it into the primitive. That
> string can still be parsed into a Schema, but the "round-trip" modifies the
> schema in an incompatible way.
> That namespace shouldn't be dropped when producing the JSON string
> representing the Schema in Java.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (AVRO-3518) Rust: Represent aliases as Name instead of String
[ https://issues.apache.org/jira/browse/AVRO-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Tzvetanov Grigorov resolved AVRO-3518. - Fix Version/s: 1.11.1 1.12.0 Resolution: Fixed > Rust: Represent aliases as Name instead of String > - > > Key: AVRO-3518 > URL: https://issues.apache.org/jira/browse/AVRO-3518 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Major > Labels: pull-request-available > Fix For: 1.11.1, 1.12.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently Aliases is an Option>. > Since an alias could have a namespace it would be better to use > apache_avro::schema::Name for it instead of String. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (AVRO-3518) Rust: Represent aliases as Name instead of String
[ https://issues.apache.org/jira/browse/AVRO-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537959#comment-17537959 ] ASF subversion and git services commented on AVRO-3518: --- Commit 0c769f94515cc13ae2130a818bf566cb09f27774 in avro's branch refs/heads/master from Martin Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=0c769f945 ] AVRO-3518: Introduce a new type 'Alias' (#1686) It uses Newtype pattern and wraps Name. This way it is easier to control how it is being (de)serialized Until now only Schema::Record serialized its aliases to JSON. Now this is being done for all named schemata (Schema::Enum and Schema::Fixed) Signed-off-by: Martin Tzvetanov Grigorov > Rust: Represent aliases as Name instead of String > - > > Key: AVRO-3518 > URL: https://issues.apache.org/jira/browse/AVRO-3518 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently Aliases is an Option>. > Since an alias could have a namespace it would be better to use > apache_avro::schema::Name for it instead of String. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (AVRO-3518) Rust: Represent aliases as Name instead of String
[ https://issues.apache.org/jira/browse/AVRO-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537960#comment-17537960 ] ASF subversion and git services commented on AVRO-3518: --- Commit 2f441fd1a5e4c64c77e83da2c1fef11312bf5097 in avro's branch refs/heads/branch-1.11 from Martin Grigorov [ https://gitbox.apache.org/repos/asf?p=avro.git;h=2f441fd1a ] AVRO-3518: Introduce a new type 'Alias' (#1686) It uses Newtype pattern and wraps Name. This way it is easier to control how it is being (de)serialized Until now only Schema::Record serialized its aliases to JSON. Now this is being done for all named schemata (Schema::Enum and Schema::Fixed) Signed-off-by: Martin Tzvetanov Grigorov (cherry picked from commit 0c769f94515cc13ae2130a818bf566cb09f27774) > Rust: Represent aliases as Name instead of String > - > > Key: AVRO-3518 > URL: https://issues.apache.org/jira/browse/AVRO-3518 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently Aliases is an Option>. > Since an alias could have a namespace it would be better to use > apache_avro::schema::Name for it instead of String. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (AVRO-3518) Rust: Represent aliases as Name instead of String
[ https://issues.apache.org/jira/browse/AVRO-3518?focusedWorklogId=771152=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771152 ] ASF GitHub Bot logged work on AVRO-3518: Author: ASF GitHub Bot Created on: 17/May/22 06:15 Start Date: 17/May/22 06:15 Worklog Time Spent: 10m Work Description: martin-g merged PR #1686: URL: https://github.com/apache/avro/pull/1686 Issue Time Tracking --- Worklog Id: (was: 771152) Time Spent: 20m (was: 10m) > Rust: Represent aliases as Name instead of String > - > > Key: AVRO-3518 > URL: https://issues.apache.org/jira/browse/AVRO-3518 > Project: Apache Avro > Issue Type: Improvement > Components: rust >Reporter: Martin Tzvetanov Grigorov >Assignee: Martin Tzvetanov Grigorov >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently Aliases is an Option>. > Since an alias could have a namespace it would be better to use > apache_avro::schema::Name for it instead of String. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [avro] martin-g merged pull request #1686: AVRO-3518: Introduce a new type 'Alias'
martin-g merged PR #1686: URL: https://github.com/apache/avro/pull/1686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
