[jira] [Commented] (AVRO-3597) Recent changes in GenericDatumReader.java break compatibility

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599120#comment-17599120
 ] 

ASF subversion and git services commented on AVRO-3597:
---

Commit 6aed213831b8d67cd74c8b40497e97a11b113768 in avro's branch 
refs/heads/branch-1.11 from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=6aed21383 ]

AVRO-3597: Allow custom readers to override string creation (#1847)

* AVRO-3597: recall method newInstanceFromString for backward compatibility

* AVRO-3597: add licence

> Recent changes in GenericDatumReader.java break compatibility
> -
>
> Key: AVRO-3597
> URL: https://issues.apache.org/jira/browse/AVRO-3597
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.11.1
>Reporter: Viktor Dvoretskii
>Assignee: Christophe Le Saec
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We use a custom SpecificDatumReader which overrides the string creation 
> logic. It looks like this:
> {code:java}
> class CustomSpecificDatumReader extends SpecificDatumReader {
> @Override
> protected Object newInstanceFromString(Class c, String s) {
> // custom logic
> }
> } {code}
> With [this 
> commit|https://github.com/apache/avro/commit/820ed6e5ea4417b5735078bfd26c99f1305ea363],
>  the newInstanceFromString() method is no longer called. Instead, strings are 
> created with the hard-coded logic within GenericDatumReader.ReaderCache.
> It would be appreciated if you made it possible to override the string 
> creation logic used by GenericDatumReader.ReaderCache. Preferably make use of 
> the newInstanceFromString() method again to maintain backward compatibility.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3597) Recent changes in GenericDatumReader.java break compatibility

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599119#comment-17599119
 ] 

ASF subversion and git services commented on AVRO-3597:
---

Commit 0066daff46b66c0bd28b5525ba3d2f32f26046e3 in avro's branch 
refs/heads/master from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0066daff4 ]

AVRO-3597: Allow custom readers to override string creation (#1847)

* AVRO-3597: recall method newInstanceFromString for backward compatibility

* AVRO-3597: add licence

> Recent changes in GenericDatumReader.java break compatibility
> -
>
> Key: AVRO-3597
> URL: https://issues.apache.org/jira/browse/AVRO-3597
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.11.1
>Reporter: Viktor Dvoretskii
>Assignee: Christophe Le Saec
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We use a custom SpecificDatumReader which overrides the string creation 
> logic. It looks like this:
> {code:java}
> class CustomSpecificDatumReader extends SpecificDatumReader {
> @Override
> protected Object newInstanceFromString(Class c, String s) {
> // custom logic
> }
> } {code}
> With [this 
> commit|https://github.com/apache/avro/commit/820ed6e5ea4417b5735078bfd26c99f1305ea363],
>  the newInstanceFromString() method is no longer called. Instead, strings are 
> created with the hard-coded logic within GenericDatumReader.ReaderCache.
> It would be appreciated if you made it possible to override the string 
> creation logic used by GenericDatumReader.ReaderCache. Preferably make use of 
> the newInstanceFromString() method again to maintain backward compatibility.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3001) JsonEncode Decode support for C#

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597827#comment-17597827
 ] 

ASF subversion and git services commented on AVRO-3001:
---

Commit a60b748c1694dcf3fd2b617e75fcc9c1634fd150 in avro's branch 
refs/heads/branch-1.11 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a60b748c1 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C#

Remove Encoder#Flush() method for backward compatibility

Signed-off-by: Martin Tzvetanov Grigorov 


> JsonEncode Decode support for C#
> 
>
> Key: AVRO-3001
> URL: https://issues.apache.org/jira/browse/AVRO-3001
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Affects Versions: 1.10.0, 1.11.0
>Reporter: Krishnan Unni
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> The C# library for avro currently supports only the Binary encoding and also 
> with compile time types (Generic support only). As part of a project I am 
> doing I need to validate the avro schema against the incoming json data on 
> the fly without a predefined type (generated class). So basically comparing 
> an avro schema (string/json representation) against a raw json string. It is 
> possible with the Java library since it supports both non generic types and 
> streams as well as json encoding. With C# currently this is not possible. Is 
> there a plan to extend the C# library to provide these features? If yes, is 
> there a timeline? If not is there any alternative to achieve this? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3613) Unions cannot have more than one logical type in C#

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597830#comment-17597830
 ] 

ASF subversion and git services commented on AVRO-3613:
---

Commit a60b748c1694dcf3fd2b617e75fcc9c1634fd150 in avro's branch 
refs/heads/branch-1.11 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a60b748c1 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C#

Remove Encoder#Flush() method for backward compatibility

Signed-off-by: Martin Tzvetanov Grigorov 


> Unions cannot have more than one logical type in C#
> ---
>
> Key: AVRO-3613
> URL: https://issues.apache.org/jira/browse/AVRO-3613
> Project: Apache Avro
>  Issue Type: Bug
>  Components: csharp
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Major
> Fix For: 1.12.0
>
>
> Unions cannot have more than one logical type in C#.
> The following code fails:
> {code:java}
> Schema schema = Schema.Parse(
> "[\"null\",\n" +
> " { \"type\": \"int\", \"logicalType\": \"date\" },\n" +
> " { \"type\": \"long\", \"logicalType\": \"timestamp-millis\" }\n" +
> "]");{code}
>  
> The error is
> {code:java}
>  Avro.SchemaParseException : Duplicate type in union: logical at '[2]'{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3568) C# ToParsingForm normalizes logical type to "logical" rather than base type

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597829#comment-17597829
 ] 

ASF subversion and git services commented on AVRO-3568:
---

Commit a60b748c1694dcf3fd2b617e75fcc9c1634fd150 in avro's branch 
refs/heads/branch-1.11 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a60b748c1 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C#

Remove Encoder#Flush() method for backward compatibility

Signed-off-by: Martin Tzvetanov Grigorov 


> C# ToParsingForm normalizes logical type to "logical" rather than base type
> ---
>
> Key: AVRO-3568
> URL: https://issues.apache.org/jira/browse/AVRO-3568
> Project: Apache Avro
>  Issue Type: Bug
>  Components: csharp, logical types
>Affects Versions: 1.11.0
>Reporter: Kalle Niemitalo
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> In the Avro C# library, if Avro.SchemaNormalization.ToParsingForm(Schema) is 
> given a schema that includes a logical type, then it normalizes that just to 
> "logical" and not to the base type. The resulting JSON cannot even be parsed 
> by Avro.Schema.Parse(string). This also makes 
> SchemaNormalization.ParsingFingerprint return an incorrect fingerprint for 
> schemas that include logical types.
> h2. To reproduce
> {code:C#}
> using System;
> class Program
> {
> static void Main()
> {
> var schema = Avro.Schema.Parse(
> @"[""int"", {""type"": ""string"", ""logicalType"": ""uuid""}]");
> string pcf = Avro.SchemaNormalization.ToParsingForm(schema);
> Console.WriteLine(pcf);
> Avro.Schema.Parse(pcf);
> }
> }
> {code}
> h2. Expected result
> {noformat}
> ["int","string"]
> {noformat}
> h2. Actual result
> {noformat}
> ["int","logical"]
> Unhandled exception. Avro.SchemaParseException: Undefined name: logical at 
> '[1]'
>at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace)
>at Avro.UnionSchema.NewInstance(JArray jarr, PropertyMap props, 
> SchemaNames names, String encspace)
>at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace)
>at Avro.Schema.Parse(String json, SchemaNames names, String encspace)
>at Avro.Schema.Parse(String json)
>at Program.Main()
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3274) Request for C# API to implement a JSON Encoder

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597828#comment-17597828
 ] 

ASF subversion and git services commented on AVRO-3274:
---

Commit a60b748c1694dcf3fd2b617e75fcc9c1634fd150 in avro's branch 
refs/heads/branch-1.11 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a60b748c1 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C#

Remove Encoder#Flush() method for backward compatibility

Signed-off-by: Martin Tzvetanov Grigorov 


> Request for C# API to implement a JSON Encoder
> --
>
> Key: AVRO-3274
> URL: https://issues.apache.org/jira/browse/AVRO-3274
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Affects Versions: 1.10.2
>Reporter: Andrew Benedek
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> This is a request or improvement.
> I have a .NET Core application that needs to publish AVRO JSON encoded 
> messages to our Confluent Kafka REST API.  I can see that the Java and C++ 
> API's have a JSON encoder, but I couldn't tell from the documentation whether 
> the C# API has it, or at least it doesn't seem to.  The documentation for the 
> C# API is a little light on for details.  The Kafka REST API supports JSON, 
> and AVRO JSON, but not binary AVRO from what I understand.
> The main problem facing the plain JSON we are currently publishing is that 
> when using an AVRO schema and the union type, we hit the problem described 
> here https://issues.apache.org/jira/browse/AVRO-2899.  We need to generate 
> the type information in the JSON in order to satisfy the validation in the 
> Kafka REST API.  Hence, the need for an AVRO JSON encoder.
> I can't re-write the .NET application, so I'm faced with the prospect of 
> using either the Java or C++ API's with some sort of wrappers or 
> interoperability framework, which I'm desperately trying to avoid.
> Any assistance or suggestions would be much appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3001) JsonEncode Decode support for C#

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597806#comment-17597806
 ] 

ASF subversion and git services commented on AVRO-3001:
---

Commit 1841ff115d52727094998b80798d52210b8addb6 in avro's branch 
refs/heads/master from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1841ff115 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 

> JsonEncode Decode support for C#
> 
>
> Key: AVRO-3001
> URL: https://issues.apache.org/jira/browse/AVRO-3001
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Affects Versions: 1.10.0, 1.11.0
>Reporter: Krishnan Unni
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> The C# library for avro currently supports only the Binary encoding and also 
> with compile time types (Generic support only). As part of a project I am 
> doing I need to validate the avro schema against the incoming json data on 
> the fly without a predefined type (generated class). So basically comparing 
> an avro schema (string/json representation) against a raw json string. It is 
> possible with the Java library since it supports both non generic types and 
> streams as well as json encoding. With C# currently this is not possible. Is 
> there a plan to extend the C# library to provide these features? If yes, is 
> there a timeline? If not is there any alternative to achieve this? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3274) Request for C# API to implement a JSON Encoder

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597811#comment-17597811
 ] 

ASF subversion and git services commented on AVRO-3274:
---

Commit bc5d76e4785716814d258e7d38410782aede97a5 in avro's branch 
refs/heads/branch-1.11 from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=bc5d76e47 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 
(cherry picked from commit 1841ff115d52727094998b80798d52210b8addb6)


> Request for C# API to implement a JSON Encoder
> --
>
> Key: AVRO-3274
> URL: https://issues.apache.org/jira/browse/AVRO-3274
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Affects Versions: 1.10.2
>Reporter: Andrew Benedek
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> This is a request or improvement.
> I have a .NET Core application that needs to publish AVRO JSON encoded 
> messages to our Confluent Kafka REST API.  I can see that the Java and C++ 
> API's have a JSON encoder, but I couldn't tell from the documentation whether 
> the C# API has it, or at least it doesn't seem to.  The documentation for the 
> C# API is a little light on for details.  The Kafka REST API supports JSON, 
> and AVRO JSON, but not binary AVRO from what I understand.
> The main problem facing the plain JSON we are currently publishing is that 
> when using an AVRO schema and the union type, we hit the problem described 
> here https://issues.apache.org/jira/browse/AVRO-2899.  We need to generate 
> the type information in the JSON in order to satisfy the validation in the 
> Kafka REST API.  Hence, the need for an AVRO JSON encoder.
> I can't re-write the .NET application, so I'm faced with the prospect of 
> using either the Java or C++ API's with some sort of wrappers or 
> interoperability framework, which I'm desperately trying to avoid.
> Any assistance or suggestions would be much appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3613) Unions cannot have more than one logical type in C#

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597809#comment-17597809
 ] 

ASF subversion and git services commented on AVRO-3613:
---

Commit 1841ff115d52727094998b80798d52210b8addb6 in avro's branch 
refs/heads/master from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1841ff115 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 

> Unions cannot have more than one logical type in C#
> ---
>
> Key: AVRO-3613
> URL: https://issues.apache.org/jira/browse/AVRO-3613
> Project: Apache Avro
>  Issue Type: Bug
>  Components: csharp
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Major
> Fix For: 1.12.0
>
>
> Unions cannot have more than one logical type in C#.
> The following code fails:
> {code:java}
> Schema schema = Schema.Parse(
> "[\"null\",\n" +
> " { \"type\": \"int\", \"logicalType\": \"date\" },\n" +
> " { \"type\": \"long\", \"logicalType\": \"timestamp-millis\" }\n" +
> "]");{code}
>  
> The error is
> {code:java}
>  Avro.SchemaParseException : Duplicate type in union: logical at '[2]'{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3274) Request for C# API to implement a JSON Encoder

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597807#comment-17597807
 ] 

ASF subversion and git services commented on AVRO-3274:
---

Commit 1841ff115d52727094998b80798d52210b8addb6 in avro's branch 
refs/heads/master from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1841ff115 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 

> Request for C# API to implement a JSON Encoder
> --
>
> Key: AVRO-3274
> URL: https://issues.apache.org/jira/browse/AVRO-3274
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Affects Versions: 1.10.2
>Reporter: Andrew Benedek
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> This is a request or improvement.
> I have a .NET Core application that needs to publish AVRO JSON encoded 
> messages to our Confluent Kafka REST API.  I can see that the Java and C++ 
> API's have a JSON encoder, but I couldn't tell from the documentation whether 
> the C# API has it, or at least it doesn't seem to.  The documentation for the 
> C# API is a little light on for details.  The Kafka REST API supports JSON, 
> and AVRO JSON, but not binary AVRO from what I understand.
> The main problem facing the plain JSON we are currently publishing is that 
> when using an AVRO schema and the union type, we hit the problem described 
> here https://issues.apache.org/jira/browse/AVRO-2899.  We need to generate 
> the type information in the JSON in order to satisfy the validation in the 
> Kafka REST API.  Hence, the need for an AVRO JSON encoder.
> I can't re-write the .NET application, so I'm faced with the prospect of 
> using either the Java or C++ API's with some sort of wrappers or 
> interoperability framework, which I'm desperately trying to avoid.
> Any assistance or suggestions would be much appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3613) Unions cannot have more than one logical type in C#

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597813#comment-17597813
 ] 

ASF subversion and git services commented on AVRO-3613:
---

Commit bc5d76e4785716814d258e7d38410782aede97a5 in avro's branch 
refs/heads/branch-1.11 from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=bc5d76e47 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 
(cherry picked from commit 1841ff115d52727094998b80798d52210b8addb6)


> Unions cannot have more than one logical type in C#
> ---
>
> Key: AVRO-3613
> URL: https://issues.apache.org/jira/browse/AVRO-3613
> Project: Apache Avro
>  Issue Type: Bug
>  Components: csharp
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Major
> Fix For: 1.12.0
>
>
> Unions cannot have more than one logical type in C#.
> The following code fails:
> {code:java}
> Schema schema = Schema.Parse(
> "[\"null\",\n" +
> " { \"type\": \"int\", \"logicalType\": \"date\" },\n" +
> " { \"type\": \"long\", \"logicalType\": \"timestamp-millis\" }\n" +
> "]");{code}
>  
> The error is
> {code:java}
>  Avro.SchemaParseException : Duplicate type in union: logical at '[2]'{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3001) JsonEncode Decode support for C#

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597810#comment-17597810
 ] 

ASF subversion and git services commented on AVRO-3001:
---

Commit bc5d76e4785716814d258e7d38410782aede97a5 in avro's branch 
refs/heads/branch-1.11 from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=bc5d76e47 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 
(cherry picked from commit 1841ff115d52727094998b80798d52210b8addb6)


> JsonEncode Decode support for C#
> 
>
> Key: AVRO-3001
> URL: https://issues.apache.org/jira/browse/AVRO-3001
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Affects Versions: 1.10.0, 1.11.0
>Reporter: Krishnan Unni
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> The C# library for avro currently supports only the Binary encoding and also 
> with compile time types (Generic support only). As part of a project I am 
> doing I need to validate the avro schema against the incoming json data on 
> the fly without a predefined type (generated class). So basically comparing 
> an avro schema (string/json representation) against a raw json string. It is 
> possible with the Java library since it supports both non generic types and 
> streams as well as json encoding. With C# currently this is not possible. Is 
> there a plan to extend the C# library to provide these features? If yes, is 
> there a timeline? If not is there any alternative to achieve this? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3568) C# ToParsingForm normalizes logical type to "logical" rather than base type

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597812#comment-17597812
 ] 

ASF subversion and git services commented on AVRO-3568:
---

Commit bc5d76e4785716814d258e7d38410782aede97a5 in avro's branch 
refs/heads/branch-1.11 from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=bc5d76e47 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 
(cherry picked from commit 1841ff115d52727094998b80798d52210b8addb6)


> C# ToParsingForm normalizes logical type to "logical" rather than base type
> ---
>
> Key: AVRO-3568
> URL: https://issues.apache.org/jira/browse/AVRO-3568
> Project: Apache Avro
>  Issue Type: Bug
>  Components: csharp, logical types
>Affects Versions: 1.11.0
>Reporter: Kalle Niemitalo
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> In the Avro C# library, if Avro.SchemaNormalization.ToParsingForm(Schema) is 
> given a schema that includes a logical type, then it normalizes that just to 
> "logical" and not to the base type. The resulting JSON cannot even be parsed 
> by Avro.Schema.Parse(string). This also makes 
> SchemaNormalization.ParsingFingerprint return an incorrect fingerprint for 
> schemas that include logical types.
> h2. To reproduce
> {code:C#}
> using System;
> class Program
> {
> static void Main()
> {
> var schema = Avro.Schema.Parse(
> @"[""int"", {""type"": ""string"", ""logicalType"": ""uuid""}]");
> string pcf = Avro.SchemaNormalization.ToParsingForm(schema);
> Console.WriteLine(pcf);
> Avro.Schema.Parse(pcf);
> }
> }
> {code}
> h2. Expected result
> {noformat}
> ["int","string"]
> {noformat}
> h2. Actual result
> {noformat}
> ["int","logical"]
> Unhandled exception. Avro.SchemaParseException: Undefined name: logical at 
> '[1]'
>at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace)
>at Avro.UnionSchema.NewInstance(JArray jarr, PropertyMap props, 
> SchemaNames names, String encspace)
>at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace)
>at Avro.Schema.Parse(String json, SchemaNames names, String encspace)
>at Avro.Schema.Parse(String json)
>at Program.Main()
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3568) C# ToParsingForm normalizes logical type to "logical" rather than base type

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597808#comment-17597808
 ] 

ASF subversion and git services commented on AVRO-3568:
---

Commit 1841ff115d52727094998b80798d52210b8addb6 in avro's branch 
refs/heads/master from Robert Yokota
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1841ff115 ]

AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C# (#1833)

* AVRO-3001 AVRO-3274: Add JSON encoder/decoder for C#

* Add more comments for public/protected members

* Make CodeQL happy

* Make CodeQL happy again

* Minor optimization

* Fix cosmetic issues

* Fix JsonEncoder.StartItem accessibility

* Minor doc fix

* Add fixes and test for JSON encoding/decoding logical types

* Fix fullname calculation for logical schemas

* Fix for AVRO-3613

* Fix for AVRO-3568

* Add union with record test

* Fix test

* Incorporate review feedback

* Incorporate review feedback

* More cleanup

* Revert previous cleanup in favor of recommended cleanup

* Incorporate more review feedback

* Incorporate latest review feedback

* Add more unit tests

* Simplify string constant

* Simplify string constant

* Simplify string constant

* Simplify string constant

Co-authored-by: Martin Grigorov 

> C# ToParsingForm normalizes logical type to "logical" rather than base type
> ---
>
> Key: AVRO-3568
> URL: https://issues.apache.org/jira/browse/AVRO-3568
> Project: Apache Avro
>  Issue Type: Bug
>  Components: csharp, logical types
>Affects Versions: 1.11.0
>Reporter: Kalle Niemitalo
>Assignee: Robert Yokota
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>
> In the Avro C# library, if Avro.SchemaNormalization.ToParsingForm(Schema) is 
> given a schema that includes a logical type, then it normalizes that just to 
> "logical" and not to the base type. The resulting JSON cannot even be parsed 
> by Avro.Schema.Parse(string). This also makes 
> SchemaNormalization.ParsingFingerprint return an incorrect fingerprint for 
> schemas that include logical types.
> h2. To reproduce
> {code:C#}
> using System;
> class Program
> {
> static void Main()
> {
> var schema = Avro.Schema.Parse(
> @"[""int"", {""type"": ""string"", ""logicalType"": ""uuid""}]");
> string pcf = Avro.SchemaNormalization.ToParsingForm(schema);
> Console.WriteLine(pcf);
> Avro.Schema.Parse(pcf);
> }
> }
> {code}
> h2. Expected result
> {noformat}
> ["int","string"]
> {noformat}
> h2. Actual result
> {noformat}
> ["int","logical"]
> Unhandled exception. Avro.SchemaParseException: Undefined name: logical at 
> '[1]'
>at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace)
>at Avro.UnionSchema.NewInstance(JArray jarr, PropertyMap props, 
> SchemaNames names, String encspace)
>at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace)
>at Avro.Schema.Parse(String json, SchemaNames names, String encspace)
>at Avro.Schema.Parse(String json)
>at Program.Main()
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3621) [Rust] Improved resolution of nullable record fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597001#comment-17597001
 ] 

ASF subversion and git services commented on AVRO-3621:
---

Commit 09041facad0a4c2c131b7ffde6497d7580b964b9 in avro's branch 
refs/heads/master from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=09041faca ]

AVRO-3621: Check the argument of assert_not_logged() against the last logged 
message before panicing

Signed-off-by: Martin Tzvetanov Grigorov 


> [Rust] Improved resolution of nullable record fields
> 
>
> Key: AVRO-3621
> URL: https://issues.apache.org/jira/browse/AVRO-3621
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Shaeq Ahmed
>Assignee: Shaeq Ahmed
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently a nested record cannot be resolved to a corresponding schema where 
> the fields are stored as nullable variants. This PR adds support for 
> upcasting the values to a Union type to allow for this. This should improve 
> support for reading and writing from compatible schemas, where some fields 
> are listed as nullable in the destination.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3621) [Rust] Improved resolution of nullable record fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585335#comment-17585335
 ] 

ASF subversion and git services commented on AVRO-3621:
---

Commit 308e4e125ad1d124f52fd5332f338a78b0129f6d in avro's branch 
refs/heads/branch-1.11 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=308e4e125 ]

AVRO-3621: Check the argument of assert_not_logged() against the last logged 
message before panicing

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit 02e6b5c92cedc592a4020cecfdbdb9afff7e784f)


> [Rust] Improved resolution of nullable record fields
> 
>
> Key: AVRO-3621
> URL: https://issues.apache.org/jira/browse/AVRO-3621
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Shaeq Ahmed
>Assignee: Shaeq Ahmed
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently a nested record cannot be resolved to a corresponding schema where 
> the fields are stored as nullable variants. This PR adds support for 
> upcasting the values to a Union type to allow for this. This should improve 
> support for reading and writing from compatible schemas, where some fields 
> are listed as nullable in the destination.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3621) [Rust] Improved resolution of nullable record fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585319#comment-17585319
 ] 

ASF subversion and git services commented on AVRO-3621:
---

Commit 25a83f547af675edf79aad2620281fdb8bbd12bc in avro's branch 
refs/heads/branch-1.11 from Shaeq Ahmed
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=25a83f547 ]

AVRO-3621: [Rust] do not log each error while validating against union variants 
(#1839)

AVRO-3621: do not log each error while validating against union variants

AVRO-3621: Improve the panic message for the new assert_not_logged() helper 
method

Signed-off-by: Martin Tzvetanov Grigorov 
Co-authored-by: Martin Tzvetanov Grigorov 
(cherry picked from commit ae31eb12a06b5387f56261283344fdbaaeca2f02)


> [Rust] Improved resolution of nullable record fields
> 
>
> Key: AVRO-3621
> URL: https://issues.apache.org/jira/browse/AVRO-3621
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Shaeq Ahmed
>Assignee: Shaeq Ahmed
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently a nested record cannot be resolved to a corresponding schema where 
> the fields are stored as nullable variants. This PR adds support for 
> upcasting the values to a Union type to allow for this. This should improve 
> support for reading and writing from compatible schemas, where some fields 
> are listed as nullable in the destination.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3621) [Rust] Improved resolution of nullable record fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585317#comment-17585317
 ] 

ASF subversion and git services commented on AVRO-3621:
---

Commit ae31eb12a06b5387f56261283344fdbaaeca2f02 in avro's branch 
refs/heads/master from Shaeq Ahmed
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ae31eb12a ]

AVRO-3621: [Rust] do not log each error while validating against union variants 
(#1839)

AVRO-3621: do not log each error while validating against union variants

AVRO-3621: Improve the panic message for the new assert_not_logged() helper 
method

Signed-off-by: Martin Tzvetanov Grigorov 
Co-authored-by: Martin Tzvetanov Grigorov 

> [Rust] Improved resolution of nullable record fields
> 
>
> Key: AVRO-3621
> URL: https://issues.apache.org/jira/browse/AVRO-3621
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Shaeq Ahmed
>Assignee: Shaeq Ahmed
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently a nested record cannot be resolved to a corresponding schema where 
> the fields are stored as nullable variants. This PR adds support for 
> upcasting the values to a Union type to allow for this. This should improve 
> support for reading and writing from compatible schemas, where some fields 
> are listed as nullable in the destination.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3602) Support Map(with non-String keys) and Set in ReflectDatumReader

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585293#comment-17585293
 ] 

ASF subversion and git services commented on AVRO-3602:
---

Commit 7049217f970b369afcd45b4174c1f088b01d4793 in avro's branch 
refs/heads/branch-1.11 from Yury Bubonv
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7049217f9 ]

AVRO-3602 Support Map(with non-String keys) and Set in ReflectDatumReader 
(#1818)

Co-authored-by: Yury Bubnov 
(cherry picked from commit f1c04f7e4d664a976e0f525ac1e1726321aa11ad)


> Support Map(with non-String keys) and Set in ReflectDatumReader 
> 
>
> Key: AVRO-3602
> URL: https://issues.apache.org/jira/browse/AVRO-3602
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.11.1
>Reporter: Yury Bubnov
>Assignee: Yury Bubnov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> At the moment, {{ReflectDatumReader}} supports only {{List}} interface 
> fields. Attempt to use {{Map}} or {{Set}} throws an exception. 
> Since the Map and Set other two major collection interfaces, it would be nice 
> if Avro {{ReflectDatumReader }}supported them too.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3621) [Rust] Improved resolution of nullable record fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585240#comment-17585240
 ] 

ASF subversion and git services commented on AVRO-3621:
---

Commit a3d120f3750677d1e6ab1b29384de5e8eaf38ac5 in avro's branch 
refs/heads/branch-1.11 from Shaeq Ahmed
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a3d120f37 ]

AVRO: [Rust] Improved resolution of nullable record fields. (#1837)

* AVRO: [Rust] Improved resolution of nullable record fields.

* AVRO: [Rust] Update to improvements for nullable record fields PR.

* AVRO-3621: Improve test method name

* AVRO-3621: Revert non-related change

Signed-off-by: Martin Tzvetanov Grigorov 
Co-authored-by: Martin Tzvetanov Grigorov 
(cherry picked from commit ddf10bd17f591638f12128c4fff2b4681b245ac0)


> [Rust] Improved resolution of nullable record fields
> 
>
> Key: AVRO-3621
> URL: https://issues.apache.org/jira/browse/AVRO-3621
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Shaeq Ahmed
>Priority: Major
>
> Currently a nested record cannot be resolved to a corresponding schema where 
> the fields are stored as nullable variants. This PR adds support for 
> upcasting the values to a Union type to allow for this. This should improve 
> support for reading and writing from compatible schemas, where some fields 
> are listed as nullable in the destination.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3621) [Rust] Improved resolution of nullable record fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585238#comment-17585238
 ] 

ASF subversion and git services commented on AVRO-3621:
---

Commit ddf10bd17f591638f12128c4fff2b4681b245ac0 in avro's branch 
refs/heads/master from Shaeq Ahmed
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ddf10bd17 ]

AVRO: [Rust] Improved resolution of nullable record fields. (#1837)

* AVRO: [Rust] Improved resolution of nullable record fields.

* AVRO: [Rust] Update to improvements for nullable record fields PR.

* AVRO-3621: Improve test method name

* AVRO-3621: Revert non-related change

Signed-off-by: Martin Tzvetanov Grigorov 
Co-authored-by: Martin Tzvetanov Grigorov 

> [Rust] Improved resolution of nullable record fields
> 
>
> Key: AVRO-3621
> URL: https://issues.apache.org/jira/browse/AVRO-3621
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Shaeq Ahmed
>Priority: Major
>
> Currently a nested record cannot be resolved to a corresponding schema where 
> the fields are stored as nullable variants. This PR adds support for 
> upcasting the values to a Union type to allow for this. This should improve 
> support for reading and writing from compatible schemas, where some fields 
> are listed as nullable in the destination.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3602) Support Map(with non-String keys) and Set in ReflectDatumReader

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584732#comment-17584732
 ] 

ASF subversion and git services commented on AVRO-3602:
---

Commit f1c04f7e4d664a976e0f525ac1e1726321aa11ad in avro's branch 
refs/heads/master from Yury Bubonv
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=f1c04f7e4 ]

AVRO-3602 Support Map(with non-String keys) and Set in ReflectDatumReader 
(#1818)

Co-authored-by: Yury Bubnov 

> Support Map(with non-String keys) and Set in ReflectDatumReader 
> 
>
> Key: AVRO-3602
> URL: https://issues.apache.org/jira/browse/AVRO-3602
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.11.1
>Reporter: Yury Bubnov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> At the moment, {{ReflectDatumReader}} supports only {{List}} interface 
> fields. Attempt to use {{Map}} or {{Set}} throws an exception. 
> Since the Map and Set other two major collection interfaces, it would be nice 
> if Avro {{ReflectDatumReader }}supported them too.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3616) [C++]: Fix compilation warnings

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584086#comment-17584086
 ] 

ASF subversion and git services commented on AVRO-3616:
---

Commit a053fc026392d7675a351c0a6938d2bec892642c in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a053fc026 ]

AVRO-3616: C++ Fix compilation warnings (#1836)

* AVRO-3616: [C++]: Fix compilation warnings

Replace  include with 


Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3616: [C++]: Fix compilation warnings

Fix the order of constructor parameters

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3616: Enable -pedantic and -Werror for compiler flags

Those should prevent from introducing new warnings.

-Wextra reports "unused method arguments" and those could not be fixed
without API break.

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3616: Use size_t consistently for node->leaves()

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit d336c6c7b91f9f39de2a5e34ae55c1d7c118507b)


> [C++]: Fix compilation warnings
> ---
>
> Key: AVRO-3616
> URL: https://issues.apache.org/jira/browse/AVRO-3616
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Building the C++ SDK prints two types of warnings:
>  
> 1. Usage of deprecated Boost test related import
> {code:java}
>  In file included from /usr/include/boost/config/header_deprecated.hpp:18,
> from /usr/include/boost/test/included/unit_test_framework.hpp:12,
> from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19:
> 
> /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: 
> #pragma message: This header is deprecated. Use This header is deprecated. 
> Please use  instead. instead.
>   13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use 
>  instead." )
>   | ^~~{code}
> 2. Wrong order of constructor arguments
> {code:java}
> In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const 
> char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: 
> warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: 
> warning:   when initialized here [-Wreorder]  262 | 
> DataFileReaderBase::DataFileReaderBase(const char *filename) : 
> filename_(filename), stream_(fileSeekableInputStream(filename)), 
> codec_(NULL_CODEC),  | ^~In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor 
> ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11:
>  warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: 
> warning:   when initialized here [-Wreorder]  268 | 
> DataFileReaderBase::DataFileReaderBase(std::unique_ptr 
> inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code}
> Full example could be seen at 
> https://github.com/apache/avro/runs/7959849252?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3616) [C++]: Fix compilation warnings

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584084#comment-17584084
 ] 

ASF subversion and git services commented on AVRO-3616:
---

Commit d336c6c7b91f9f39de2a5e34ae55c1d7c118507b in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d336c6c7b ]

AVRO-3616: C++ Fix compilation warnings (#1836)

* AVRO-3616: [C++]: Fix compilation warnings

Replace  include with 


Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3616: [C++]: Fix compilation warnings

Fix the order of constructor parameters

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3616: Enable -pedantic and -Werror for compiler flags

Those should prevent from introducing new warnings.

-Wextra reports "unused method arguments" and those could not be fixed
without API break.

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3616: Use size_t consistently for node->leaves()

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 

> [C++]: Fix compilation warnings
> ---
>
> Key: AVRO-3616
> URL: https://issues.apache.org/jira/browse/AVRO-3616
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Building the C++ SDK prints two types of warnings:
>  
> 1. Usage of deprecated Boost test related import
> {code:java}
>  In file included from /usr/include/boost/config/header_deprecated.hpp:18,
> from /usr/include/boost/test/included/unit_test_framework.hpp:12,
> from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19:
> 
> /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: 
> #pragma message: This header is deprecated. Use This header is deprecated. 
> Please use  instead. instead.
>   13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use 
>  instead." )
>   | ^~~{code}
> 2. Wrong order of constructor arguments
> {code:java}
> In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const 
> char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: 
> warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: 
> warning:   when initialized here [-Wreorder]  262 | 
> DataFileReaderBase::DataFileReaderBase(const char *filename) : 
> filename_(filename), stream_(fileSeekableInputStream(filename)), 
> codec_(NULL_CODEC),  | ^~In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor 
> ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11:
>  warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: 
> warning:   when initialized here [-Wreorder]  268 | 
> DataFileReaderBase::DataFileReaderBase(std::unique_ptr 
> inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code}
> Full example could be seen at 
> https://github.com/apache/avro/runs/7959849252?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3616) [C++]: Fix compilation warnings

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584040#comment-17584040
 ] 

ASF subversion and git services commented on AVRO-3616:
---

Commit e632e652f3b5805609647827b9f4611e79185c6e in avro's branch 
refs/heads/avro-3616-c++-fix-compilation-warnings from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=e632e652f ]

AVRO-3616: Use size_t consistently for node->leaves()

Signed-off-by: Martin Tzvetanov Grigorov 


> [C++]: Fix compilation warnings
> ---
>
> Key: AVRO-3616
> URL: https://issues.apache.org/jira/browse/AVRO-3616
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Building the C++ SDK prints two types of warnings:
>  
> 1. Usage of deprecated Boost test related import
> {code:java}
>  In file included from /usr/include/boost/config/header_deprecated.hpp:18,
> from /usr/include/boost/test/included/unit_test_framework.hpp:12,
> from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19:
> 
> /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: 
> #pragma message: This header is deprecated. Use This header is deprecated. 
> Please use  instead. instead.
>   13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use 
>  instead." )
>   | ^~~{code}
> 2. Wrong order of constructor arguments
> {code:java}
> In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const 
> char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: 
> warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: 
> warning:   when initialized here [-Wreorder]  262 | 
> DataFileReaderBase::DataFileReaderBase(const char *filename) : 
> filename_(filename), stream_(fileSeekableInputStream(filename)), 
> codec_(NULL_CODEC),  | ^~In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor 
> ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11:
>  warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: 
> warning:   when initialized here [-Wreorder]  268 | 
> DataFileReaderBase::DataFileReaderBase(std::unique_ptr 
> inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code}
> Full example could be seen at 
> https://github.com/apache/avro/runs/7959849252?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3616) [C++]: Fix compilation warnings

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583618#comment-17583618
 ] 

ASF subversion and git services commented on AVRO-3616:
---

Commit dd4f1d4202ac0ae02c8bc77feca457ae35e54345 in avro's branch 
refs/heads/avro-3616-c++-fix-compilation-warnings from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=dd4f1d420 ]

AVRO-3616: Enable -pedantic and -Werror for compiler flags

Those should prevent from introducing new warnings.

-Wextra reports "unused method arguments" and those could not be fixed
without API break.

Signed-off-by: Martin Tzvetanov Grigorov 


> [C++]: Fix compilation warnings
> ---
>
> Key: AVRO-3616
> URL: https://issues.apache.org/jira/browse/AVRO-3616
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Building the C++ SDK prints two types of warnings:
>  
> 1. Usage of deprecated Boost test related import
> {code:java}
>  In file included from /usr/include/boost/config/header_deprecated.hpp:18,
> from /usr/include/boost/test/included/unit_test_framework.hpp:12,
> from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19:
> 
> /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: 
> #pragma message: This header is deprecated. Use This header is deprecated. 
> Please use  instead. instead.
>   13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use 
>  instead." )
>   | ^~~{code}
> 2. Wrong order of constructor arguments
> {code:java}
> In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const 
> char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: 
> warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: 
> warning:   when initialized here [-Wreorder]  262 | 
> DataFileReaderBase::DataFileReaderBase(const char *filename) : 
> filename_(filename), stream_(fileSeekableInputStream(filename)), 
> codec_(NULL_CODEC),  | ^~In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor 
> ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11:
>  warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: 
> warning:   when initialized here [-Wreorder]  268 | 
> DataFileReaderBase::DataFileReaderBase(std::unique_ptr 
> inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code}
> Full example could be seen at 
> https://github.com/apache/avro/runs/7959849252?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3616) [C++]: Fix compilation warnings

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583580#comment-17583580
 ] 

ASF subversion and git services commented on AVRO-3616:
---

Commit 91f7a1dc14c7f881d76cbe2e7d39bcda1109575b in avro's branch 
refs/heads/avro-3616-c++-fix-compilation-warnings from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=91f7a1dc1 ]

AVRO-3616: [C++]: Fix compilation warnings

Fix the order of constructor parameters

Signed-off-by: Martin Tzvetanov Grigorov 


> [C++]: Fix compilation warnings
> ---
>
> Key: AVRO-3616
> URL: https://issues.apache.org/jira/browse/AVRO-3616
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> Building the C++ SDK prints two types of warnings:
>  
> 1. Usage of deprecated Boost test related import
> {code:java}
>  In file included from /usr/include/boost/config/header_deprecated.hpp:18,
> from /usr/include/boost/test/included/unit_test_framework.hpp:12,
> from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19:
> 
> /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: 
> #pragma message: This header is deprecated. Use This header is deprecated. 
> Please use  instead. instead.
>   13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use 
>  instead." )
>   | ^~~{code}
> 2. Wrong order of constructor arguments
> {code:java}
> In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const 
> char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: 
> warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: 
> warning:   when initialized here [-Wreorder]  262 | 
> DataFileReaderBase::DataFileReaderBase(const char *filename) : 
> filename_(filename), stream_(fileSeekableInputStream(filename)), 
> codec_(NULL_CODEC),  | ^~In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor 
> ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11:
>  warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: 
> warning:   when initialized here [-Wreorder]  268 | 
> DataFileReaderBase::DataFileReaderBase(std::unique_ptr 
> inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code}
> Full example could be seen at 
> https://github.com/apache/avro/runs/7959849252?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3616) [C++]: Fix compilation warnings

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583579#comment-17583579
 ] 

ASF subversion and git services commented on AVRO-3616:
---

Commit 262c703079c8f88b72fedfbaf690a87aa0002267 in avro's branch 
refs/heads/avro-3616-c++-fix-compilation-warnings from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=262c70307 ]

AVRO-3616: [C++]: Fix compilation warnings

Replace  include with 


Signed-off-by: Martin Tzvetanov Grigorov 


> [C++]: Fix compilation warnings
> ---
>
> Key: AVRO-3616
> URL: https://issues.apache.org/jira/browse/AVRO-3616
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> Building the C++ SDK prints two types of warnings:
>  
> 1. Usage of deprecated Boost test related import
> {code:java}
>  In file included from /usr/include/boost/config/header_deprecated.hpp:18,
> from /usr/include/boost/test/included/unit_test_framework.hpp:12,
> from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19:
> 
> /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: 
> #pragma message: This header is deprecated. Use This header is deprecated. 
> Please use  instead. instead.
>   13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use 
>  instead." )
>   | ^~~{code}
> 2. Wrong order of constructor arguments
> {code:java}
> In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const 
> char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: 
> warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: 
> warning:   when initialized here [-Wreorder]  262 | 
> DataFileReaderBase::DataFileReaderBase(const char *filename) : 
> filename_(filename), stream_(fileSeekableInputStream(filename)), 
> codec_(NULL_CODEC),  | ^~In file included from 
> /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:
>  In constructor 
> ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11:
>  warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after 
> [-Wreorder]  200 | Codec codec_;  |   
> ^~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:  
>  ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 | 
> const DecoderPtr decoder_;  |  
> ^~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: 
> warning:   when initialized here [-Wreorder]  268 | 
> DataFileReaderBase::DataFileReaderBase(std::unique_ptr 
> inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code}
> Full example could be seen at 
> https://github.com/apache/avro/runs/7959849252?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580733#comment-17580733
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit c6cad7e7f56dbd0e29900f3b4f1dc94bef2b75b5 in avro's branch 
refs/heads/branch-1.11 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=c6cad7e7f ]

AVRO-3609: [Rust] Minor cleanup of the new unit tests

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit f6e45907726db2ed30b9eb6831cddce195ea193a)


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580732#comment-17580732
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit f6e45907726db2ed30b9eb6831cddce195ea193a in avro's branch 
refs/heads/master from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=f6e459077 ]

AVRO-3609: [Rust] Minor cleanup of the new unit tests

Signed-off-by: Martin Tzvetanov Grigorov 


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580725#comment-17580725
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit 39063ccc26f6dece1511c3a1f23f7b4261e075e5 in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=39063ccc2 ]

AVRO-3609: [Rust] Add support for custom attributes (#1829)

* AVRO-3609: [Rust] Add custom attributes field to Record, Enum and Fixed 
schemata

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3609: [Rust] Add support for custom attributes

Support parsing custom attributes for Record, Enum and Fixed schemata.

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3609: [Rust] Add support for parsing custom attributes in RecordField

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3609: Fix the build and formatting

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit 63c58f3b29d20ba94a6c68d9e4c09816d448bf34)


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580724#comment-17580724
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit 63c58f3b29d20ba94a6c68d9e4c09816d448bf34 in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=63c58f3b2 ]

AVRO-3609: [Rust] Add support for custom attributes (#1829)

* AVRO-3609: [Rust] Add custom attributes field to Record, Enum and Fixed 
schemata

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3609: [Rust] Add support for custom attributes

Support parsing custom attributes for Record, Enum and Fixed schemata.

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3609: [Rust] Add support for parsing custom attributes in RecordField

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3609: Fix the build and formatting

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 

> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580319#comment-17580319
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit 0373e6c2cdf060e5dc4b83c17368a27838d75b16 in avro's branch 
refs/heads/avro-3609-rust-support-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0373e6c2c ]

AVRO-3609: Fix the build and formatting

Signed-off-by: Martin Tzvetanov Grigorov 


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580310#comment-17580310
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit d970e62be41044a545f7b4d3e6447861cf0c0cf4 in avro's branch 
refs/heads/avro-3609-rust-support-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d970e62be ]

AVRO-3609: [Rust] Add support for parsing custom attributes in RecordField

Signed-off-by: Martin Tzvetanov Grigorov 


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580300#comment-17580300
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit aa2f6433242bc37b8f6fdf84a27c9199f8e0acbc in avro's branch 
refs/heads/avro-3609-rust-support-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=aa2f64332 ]

AVRO-3609: [Rust] Add support for custom attributes

Support parsing custom attributes for Record, Enum and Fixed schemata.

Signed-off-by: Martin Tzvetanov Grigorov 


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580299#comment-17580299
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit 0fee1296446eee64e85646653d93f306852ee906 in avro's branch 
refs/heads/avro-3609-rust-support-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0fee12964 ]

AVRO-3609: [Rust] Add support for custom attributes

Support parsing custom attributes for Record, Enum and Fixed schemata.

Signed-off-by: Martin Tzvetanov Grigorov 


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Priority: Major
> Fix For: 1.11.1, 1.12.0
>
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3609) support custom attributes

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580298#comment-17580298
 ] 

ASF subversion and git services commented on AVRO-3609:
---

Commit a9cedd0355efee6a7b97c3d34c9d3b057cd0714d in avro's branch 
refs/heads/avro-3609-rust-support-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a9cedd035 ]

AVRO-3609: [Rust] Add custom attributes field to Record, Enum and Fixed schemata

Signed-off-by: Martin Tzvetanov Grigorov 


> support custom attributes
> -
>
> Key: AVRO-3609
> URL: https://issues.apache.org/jira/browse/AVRO-3609
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: lionel untereiner
>Priority: Major
> Fix For: 1.11.1, 1.12.0
>
>
> Custom attributes are allowed as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> They are allowed at schema objects and field level.
> But Avro rust implementation does not support custom attributes at all.
> Update implementation to support custom attributes at schema level and field 
> level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579559#comment-17579559
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit 734222e8c76c46502cb900c7a4d850f5a249152f in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=734222e8c ]

AVRO-3601: CustomAttributes#getAttribute() now returns boost::optional (#1826)

* AVRO-3601: CustomAttributes#getAttribute() now returns boost::optional

Add unit tests for CustomAttributes#getAttribute(string)

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3601: Add unit tests for writing CustomAttributes's values as JSON 
strings

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit d70b8470ba81c563e7fc82cc99b00d8a4de29560)


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579558#comment-17579558
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit 32aa94d7e26b477bacf26ac92561ccb1ee486174 in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=32aa94d7e ]

AVRO-3601: C++ API header contains breaking include (#1821)

* AVRO-3601: C++ API header contains breaking include

Rename CustomFields to CustomAttributes.
Rework CustomAttributes to keep a map of string name with a string
value. The user application may parse the string to JSON if needed.
Add a new step to the CI workflow to prevent problems like this in the
future

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3601: Do not try to install

Just build in Release mode

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit 864774b473202d11544cb869e9323de01c5ffe5c)


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579556#comment-17579556
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit d70b8470ba81c563e7fc82cc99b00d8a4de29560 in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d70b8470b ]

AVRO-3601: CustomAttributes#getAttribute() now returns boost::optional (#1826)

* AVRO-3601: CustomAttributes#getAttribute() now returns boost::optional

Add unit tests for CustomAttributes#getAttribute(string)

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3601: Add unit tests for writing CustomAttributes's values as JSON 
strings

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 

> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3608) Rust: Fix clippy errors in Rust 1.63.0

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579549#comment-17579549
 ] 

ASF subversion and git services commented on AVRO-3608:
---

Commit 98dd55411fd4ceeb21354dff425e6d3efd50a78e in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=98dd55411 ]

AVRO-3608: Rust: Fix clippy errors in Rust 1.63.0 (#1825)

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit bce7ad409a26e16255839363d7596f8a3bca3d70)


> Rust: Fix clippy errors in Rust 1.63.0
> --
>
> Key: AVRO-3608
> URL: https://issues.apache.org/jira/browse/AVRO-3608
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Rust clippy (lint) checks fail after the release of Rust 1.63.0.
>  
> {code:java}
>  error: you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/codec.rs:37:30
>    |
> 37 | #[derive(Clone, Copy, Debug, PartialEq, EnumIter, EnumString, 
> IntoStaticStr)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D 
> clippy::all`
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:30:30
>    |
> 30 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:57:30
>    |
> 57 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:84:30
>    |
> 84 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  deref on an immutable reference
>    --> avro/src/encode.rs:153:33
>     |
> 153 |                 encode_internal(&*item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 ^^
>     |
>     = note: `-D clippy::borrow-deref-ref` implied by `-D clippy::all`
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
> help: if you would like to reborrow, try removing `&*`
>     |
> 153 |                 encode_internal(item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 
> help: if you would like to deref, try using `&**`
>     |
> 153 |                 encode_internal(&**item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 ~~~error: you are deriving 
> `PartialEq` and can implement `Eq`
>    --> avro/src/schema.rs:581:24
>     |
> 581 | #[derive(Clone, Debug, PartialEq, EnumString)]
>     |                        ^ help: consider deriving `Eq` as well: 
> `PartialEq, Eq`
>     |
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  unneeded `return` statement
>    --> avro/src/types.rs:372:21
>     |
> 372 | /                     return Some(format!(
> 373 | |                         "Unresolved schema reference: '{}'. Parsed 
> names: {:?}",
> 374 | |                         name,
> 375 | |                         names.keys()
> 376 | |                     ));
>     | |___^
>     |
>     = note: `-D clippy::needless-return` implied by `-D clippy::all`
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
> help: remove `return`
>     |
> 372 ~                     Some(format!(
> 373 +                         "Unresolved schema reference: '{}'. Parsed 
> names: {:?}",
> 374 +             

[jira] [Commented] (AVRO-3608) Rust: Fix clippy errors in Rust 1.63.0

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579548#comment-17579548
 ] 

ASF subversion and git services commented on AVRO-3608:
---

Commit bce7ad409a26e16255839363d7596f8a3bca3d70 in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=bce7ad409 ]

AVRO-3608: Rust: Fix clippy errors in Rust 1.63.0 (#1825)

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 

> Rust: Fix clippy errors in Rust 1.63.0
> --
>
> Key: AVRO-3608
> URL: https://issues.apache.org/jira/browse/AVRO-3608
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Rust clippy (lint) checks fail after the release of Rust 1.63.0.
>  
> {code:java}
>  error: you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/codec.rs:37:30
>    |
> 37 | #[derive(Clone, Copy, Debug, PartialEq, EnumIter, EnumString, 
> IntoStaticStr)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D 
> clippy::all`
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:30:30
>    |
> 30 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:57:30
>    |
> 57 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:84:30
>    |
> 84 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  deref on an immutable reference
>    --> avro/src/encode.rs:153:33
>     |
> 153 |                 encode_internal(&*item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 ^^
>     |
>     = note: `-D clippy::borrow-deref-ref` implied by `-D clippy::all`
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
> help: if you would like to reborrow, try removing `&*`
>     |
> 153 |                 encode_internal(item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 
> help: if you would like to deref, try using `&**`
>     |
> 153 |                 encode_internal(&**item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 ~~~error: you are deriving 
> `PartialEq` and can implement `Eq`
>    --> avro/src/schema.rs:581:24
>     |
> 581 | #[derive(Clone, Debug, PartialEq, EnumString)]
>     |                        ^ help: consider deriving `Eq` as well: 
> `PartialEq, Eq`
>     |
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  unneeded `return` statement
>    --> avro/src/types.rs:372:21
>     |
> 372 | /                     return Some(format!(
> 373 | |                         "Unresolved schema reference: '{}'. Parsed 
> names: {:?}",
> 374 | |                         name,
> 375 | |                         names.keys()
> 376 | |                     ));
>     | |___^
>     |
>     = note: `-D clippy::needless-return` implied by `-D clippy::all`
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
> help: remove `return`
>     |
> 372 ~                     Some(format!(
> 373 +                         "Unresolved schema reference: '{}'. Parsed 
> names: {:?}",
> 374 +                         name,
> 375 +                         names.keys()
> 376 +     

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578881#comment-17578881
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit 074eef4272bf563a334e42a1027890f0c34d in avro's branch 
refs/heads/avro-3601-c++-simplify-custom-attributes-2 from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=074eef427 ]

AVRO-3601: Add unit tests for writing CustomAttributes's values as JSON strings

Signed-off-by: Martin Tzvetanov Grigorov 


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578865#comment-17578865
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit 49bed31807e14cbb4b040f4000af96a991101c3d in avro's branch 
refs/heads/avro-3601-c++-simplify-custom-attributes-2 from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=49bed3180 ]

AVRO-3601: CustomAttributes#getAttribute() now returns boost::optional

Add unit tests for CustomAttributes#getAttribute(string)

Signed-off-by: Martin Tzvetanov Grigorov 


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3608) Rust: Fix clippy errors in Rust 1.63.0

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578843#comment-17578843
 ] 

ASF subversion and git services commented on AVRO-3608:
---

Commit 0886c2153b8b2d89e25ce8bb2dc6cc3adb3e5f13 in avro's branch 
refs/heads/avro-3608-fix-clippy-errors-rust-1.63.0 from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0886c2153 ]

AVRO-3608: Rust: Fix clippy errors in Rust 1.63.0

Signed-off-by: Martin Tzvetanov Grigorov 


> Rust: Fix clippy errors in Rust 1.63.0
> --
>
> Key: AVRO-3608
> URL: https://issues.apache.org/jira/browse/AVRO-3608
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> Rust clippy (lint) checks fail after the release of Rust 1.63.0.
>  
> {code:java}
>  error: you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/codec.rs:37:30
>    |
> 37 | #[derive(Clone, Copy, Debug, PartialEq, EnumIter, EnumString, 
> IntoStaticStr)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D 
> clippy::all`
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:30:30
>    |
> 30 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:57:30
>    |
> 57 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  you are deriving `PartialEq` and can implement `Eq`
>   --> avro/src/duration.rs:84:30
>    |
> 84 | #[derive(Debug, Copy, Clone, PartialEq)]
>    |                              ^ help: consider deriving `Eq` as 
> well: `PartialEq, Eq`
>    |
>    = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  deref on an immutable reference
>    --> avro/src/encode.rs:153:33
>     |
> 153 |                 encode_internal(&*item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 ^^
>     |
>     = note: `-D clippy::borrow-deref-ref` implied by `-D clippy::all`
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
> help: if you would like to reborrow, try removing `&*`
>     |
> 153 |                 encode_internal(item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 
> help: if you would like to deref, try using `&**`
>     |
> 153 |                 encode_internal(&**item, inner_schema, names, 
> enclosing_namespace, buffer)?;
>     |                                 ~~~error: you are deriving 
> `PartialEq` and can implement `Eq`
>    --> avro/src/schema.rs:581:24
>     |
> 581 | #[derive(Clone, Debug, PartialEq, EnumString)]
>     |                        ^ help: consider deriving `Eq` as well: 
> `PartialEq, Eq`
>     |
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqerror:
>  unneeded `return` statement
>    --> avro/src/types.rs:372:21
>     |
> 372 | /                     return Some(format!(
> 373 | |                         "Unresolved schema reference: '{}'. Parsed 
> names: {:?}",
> 374 | |                         name,
> 375 | |                         names.keys()
> 376 | |                     ));
>     | |___^
>     |
>     = note: `-D clippy::needless-return` implied by `-D clippy::all`
>     = help: for further information visit 
> https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
> help: remove `return`
>     |
> 372 ~                     Some(format!(
> 373 +                         "Unresolved schema reference: '{}'. Parsed 
> names: {:?}",
> 374 +                         name,
> 375 +                         names.keys()
> 376 +                     ))
>     |error: could not compile `apache-avro` due to 7 previous errors
> warning: buil

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578491#comment-17578491
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit 864774b473202d11544cb869e9323de01c5ffe5c in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=864774b47 ]

AVRO-3601: C++ API header contains breaking include (#1821)

* AVRO-3601: C++ API header contains breaking include

Rename CustomFields to CustomAttributes.
Rework CustomAttributes to keep a map of string name with a string
value. The user application may parse the string to JSON if needed.
Add a new step to the CI workflow to prevent problems like this in the
future

Signed-off-by: Martin Tzvetanov Grigorov 

* AVRO-3601: Do not try to install

Just build in Release mode

Signed-off-by: Martin Tzvetanov Grigorov 

Signed-off-by: Martin Tzvetanov Grigorov 

> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578448#comment-17578448
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit c9d0f6d31dd70b6fb54f0cb2a2271447ec92fd0f in avro's branch 
refs/heads/avro-3601-c++-simplify-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=c9d0f6d31 ]

AVRO-3601: Do not try to install

Just build in Release mode

Signed-off-by: Martin Tzvetanov Grigorov 


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578445#comment-17578445
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit ee2986ea4129c559259c483209472780125ae520 in avro's branch 
refs/heads/avro-3601-c++-simplify-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ee2986ea4 ]

AVRO-3601: C++ API header contains breaking include

Rename CustomFields to CustomAttributes.
Rework CustomAttributes to keep a map of string name with a string
value. The user application may parse the string to JSON if needed.
Add a new step to the CI workflow to prevent problems like this in the
future

Signed-off-by: Martin Tzvetanov Grigorov 


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578439#comment-17578439
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit a4821eff448f069a299f0ec9c47e249f43c15757 in avro's branch 
refs/heads/avro-3601-c++-simplify-custom-attributes from Martin Tzvetanov 
Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a4821eff4 ]

AVRO-3601: C++ API header contains breaking include

Rename CustomFields to CustomAttributes.
Rework CustomAttributes to keep a map of string name with a string
value. The user application may parse the string to JSON if needed.
Add a new step to the CI workflow to prevent problems like this in the
future

Signed-off-by: Martin Tzvetanov Grigorov 


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3601) C++ API header contains breaking include

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578314#comment-17578314
 ] 

ASF subversion and git services commented on AVRO-3601:
---

Commit 56eea3331a3aedb4a5889faf8799b6a5f36af9e8 in avro's branch 
refs/heads/avro-3601-c++-api-include from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=56eea3331 ]

AVRO-3601: C++ API header contains breaking include

Move impl/json/JsonDom.hh to api/json/

https://github.com/apache/avro/blob/ce2439d7a7669a5c7f2fa555c661770fbe67493a/lang/c%2B%2B/CMakeLists.txt#L97
includes the 'api/' folder, CMAKE_CURRENT_BINARY_DIR and Boost's
include dirs

Signed-off-by: Martin Tzvetanov Grigorov 


> C++ API header contains breaking include
> 
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Mike Ruffing
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>
> Problem file/line: 
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists 
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3600) [Rust] UnionSchema::new method should be public

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577883#comment-17577883
 ] 

ASF subversion and git services commented on AVRO-3600:
---

Commit ce2439d7a7669a5c7f2fa555c661770fbe67493a in avro's branch 
refs/heads/master from Marko Milenković
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ce2439d7a ]

AVRO-3600: UnionSchema::new method should be public (#1817)

* AVRO-3600: UnionSchema::new method should be public

UnionSchema::new method should be public to facility programmatic schema
creation. Visibility of the method changed.

* AVRO-3600: Add rustdoc to a method that has been promoted to be public

Signed-off-by: Martin Tzvetanov Grigorov 

Co-authored-by: Martin Tzvetanov Grigorov 

> [Rust] UnionSchema::new method should be public
> ---
>
> Key: AVRO-3600
> URL: https://issues.apache.org/jira/browse/AVRO-3600
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Marko Milenkovic
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> UnionSchema::new method should be public to facilitate programmatic schema 
> cration 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3600) [Rust] UnionSchema::new method should be public

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577884#comment-17577884
 ] 

ASF subversion and git services commented on AVRO-3600:
---

Commit a3eea396ed93ac1752d8e42a1da9e31c48d0beb0 in avro's branch 
refs/heads/branch-1.11 from Marko Milenković
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a3eea396e ]

AVRO-3600: UnionSchema::new method should be public (#1817)

* AVRO-3600: UnionSchema::new method should be public

UnionSchema::new method should be public to facility programmatic schema
creation. Visibility of the method changed.

* AVRO-3600: Add rustdoc to a method that has been promoted to be public

Signed-off-by: Martin Tzvetanov Grigorov 

Co-authored-by: Martin Tzvetanov Grigorov 
(cherry picked from commit ce2439d7a7669a5c7f2fa555c661770fbe67493a)


> [Rust] UnionSchema::new method should be public
> ---
>
> Key: AVRO-3600
> URL: https://issues.apache.org/jira/browse/AVRO-3600
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Reporter: Marko Milenkovic
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> UnionSchema::new method should be public to facilitate programmatic schema 
> cration 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3434) .NET/#C: Support LogicalSchema for ReflectReader/Writer

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577259#comment-17577259
 ] 

ASF subversion and git services commented on AVRO-3434:
---

Commit 82ee7eacec1a77f82bd65494d7b35f65bfca2b6d in avro's branch 
refs/heads/branch-1.11 from KhrystynaPopadyuk
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=82ee7eace ]

AVRO-3434: support logical schemas in reflect reader and writer (#1718)

* avro-3434 support logical schemas in reflect reader and writer

* avro-3434 add apache licence to files

* avro-3434 update unit tests

(cherry picked from commit 7fd454e4a0880e928d7fbc417895a4ab4e4ad3cf)


> .NET/#C: Support LogicalSchema for ReflectReader/Writer
> ---
>
> Key: AVRO-3434
> URL: https://issues.apache.org/jira/browse/AVRO-3434
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Reporter: Khrystyna Popadyuk
>Assignee: Khrystyna Popadyuk
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Hi,
> I am working on a .NET/C# project that uses Kafka with Avro 
> serialization/deserialization in an event streaming platform.
> .NET Apache.Avro nuget package contains two different set of classes for 
> serialization/deserialization:   - SpecificReader, SpecificWriter   - 
> ReflectReader, ReflectWriter. We have chosen ReflectReader/Writer 
> ([https://avro.apache.org/docs/current/api/csharp/html/md_src_apache_main_Reflect_README.html])
>  so we can use POCO classes to represent a message.
> I noticed that ReflectReader/Writer does not support LogicalSchema. There are 
> default converters and Avro field attribute instead (they are extendable and 
> flexible).
> My questions are:
>  * is it intentional to not support LogicalSchema for ReflectReader/Writer?
>  * does it mean that we should not mix services that use LogicalSchema (third 
> party or just written on Java, Python or other languages) with ones that use 
> ReflectReader/Writer?  
>  
> Thanks,
> Khrystyna



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3434) .NET/#C: Support LogicalSchema for ReflectReader/Writer

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577214#comment-17577214
 ] 

ASF subversion and git services commented on AVRO-3434:
---

Commit 7fd454e4a0880e928d7fbc417895a4ab4e4ad3cf in avro's branch 
refs/heads/master from KhrystynaPopadyuk
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7fd454e4a ]

AVRO-3434: support logical schemas in reflect reader and writer (#1718)

* avro-3434 support logical schemas in reflect reader and writer

* avro-3434 add apache licence to files

* avro-3434 update unit tests

> .NET/#C: Support LogicalSchema for ReflectReader/Writer
> ---
>
> Key: AVRO-3434
> URL: https://issues.apache.org/jira/browse/AVRO-3434
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Reporter: Khrystyna Popadyuk
>Assignee: Khrystyna Popadyuk
>Priority: Blocker
>  Labels: pull-request-available
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> Hi,
> I am working on a .NET/C# project that uses Kafka with Avro 
> serialization/deserialization in an event streaming platform.
> .NET Apache.Avro nuget package contains two different set of classes for 
> serialization/deserialization:   - SpecificReader, SpecificWriter   - 
> ReflectReader, ReflectWriter. We have chosen ReflectReader/Writer 
> ([https://avro.apache.org/docs/current/api/csharp/html/md_src_apache_main_Reflect_README.html])
>  so we can use POCO classes to represent a message.
> I noticed that ReflectReader/Writer does not support LogicalSchema. There are 
> default converters and Avro field attribute instead (they are extendable and 
> flexible).
> My questions are:
>  * is it intentional to not support LogicalSchema for ReflectReader/Writer?
>  * does it mean that we should not mix services that use LogicalSchema (third 
> party or just written on Java, Python or other languages) with ones that use 
> ReflectReader/Writer?  
>  
> Thanks,
> Khrystyna



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3599) Rust: Make apache-avro-test-helper releasable

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576935#comment-17576935
 ] 

ASF subversion and git services commented on AVRO-3599:
---

Commit 4f72bba8c180a4ec4bb19ce242336076984bc33c in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=4f72bba8c ]

AVRO-3599: Rust: Make apache-avro-test-helper releasable (#1815)

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit 089e40f9ca0253962009fd277995a627a65620eb)


> Rust: Make apache-avro-test-helper releasable
> -
>
> Key: AVRO-3599
> URL: https://issues.apache.org/jira/browse/AVRO-3599
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As a dev-dependency of apache-avro crate apache-avro-test-helper crate should 
> also be available at https://crates.io



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3599) Rust: Make apache-avro-test-helper releasable

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576934#comment-17576934
 ] 

ASF subversion and git services commented on AVRO-3599:
---

Commit 089e40f9ca0253962009fd277995a627a65620eb in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=089e40f9c ]

AVRO-3599: Rust: Make apache-avro-test-helper releasable (#1815)

Signed-off-by: Martin Tzvetanov Grigorov 

> Rust: Make apache-avro-test-helper releasable
> -
>
> Key: AVRO-3599
> URL: https://issues.apache.org/jira/browse/AVRO-3599
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As a dev-dependency of apache-avro crate apache-avro-test-helper crate should 
> also be available at https://crates.io



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3599) Rust: Make apache-avro-test-helper releasable

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576931#comment-17576931
 ] 

ASF subversion and git services commented on AVRO-3599:
---

Commit 2c222e18f4ecace04a87b096410c9fba553b3be2 in avro's branch 
refs/heads/avro-3599-make-apache-avro-test-helper-releasable from Martin 
Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=2c222e18f ]

AVRO-3599: Rust: Make apache-avro-test-helper releasable

Signed-off-by: Martin Tzvetanov Grigorov 


> Rust: Make apache-avro-test-helper releasable
> -
>
> Key: AVRO-3599
> URL: https://issues.apache.org/jira/browse/AVRO-3599
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: rust
>Affects Versions: 1.11.1
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> As a dev-dependency of apache-avro crate apache-avro-test-helper crate should 
> also be available at https://crates.io



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3598) Disable offline search on the new Avro website

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576910#comment-17576910
 ] 

ASF subversion and git services commented on AVRO-3598:
---

Commit 6b010379decde2fa42af23f1ced556a588dafbee in avro's branch 
refs/heads/branch-1.11 from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=6b010379d ]

AVRO-3598: Disable offline search on the site (#1812)



> Disable offline search on the new Avro website
> --
>
> Key: AVRO-3598
> URL: https://issues.apache.org/jira/browse/AVRO-3598
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.11.1
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The offline search generates a JSON file with a unique name that is 
> referenced on every page in the website.
> This causes significant a significant diff whenever the website is generated, 
> but doesn't have many advantages over using an online search engine. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3598) Disable offline search on the new Avro website

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576908#comment-17576908
 ] 

ASF subversion and git services commented on AVRO-3598:
---

Commit 9c91c4450643b2ae03f645977105bcc2a49ad0e1 in avro's branch 
refs/heads/master from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=9c91c4450 ]

AVRO-3598: Disable offline search on the site (#1812)



> Disable offline search on the new Avro website
> --
>
> Key: AVRO-3598
> URL: https://issues.apache.org/jira/browse/AVRO-3598
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.11.1
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The offline search generates a JSON file with a unique name that is 
> referenced on every page in the website.
> This causes significant a significant diff whenever the website is generated, 
> but doesn't have many advantages over using an online search engine. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3595) Release Notes missing for 1.11.1

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576369#comment-17576369
 ] 

ASF subversion and git services commented on AVRO-3595:
---

Commit ab34819eb0c02741c0e4940372ab0212ae4b5cc9 in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ab34819eb ]

AVRO-3595: [Website] Add release notes for 1.11.1 (#1809)

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit 68baaaefc16aac47d32c230f0240045087b4bc99)


> Release Notes missing for 1.11.1
> 
>
> Key: AVRO-3595
> URL: https://issues.apache.org/jira/browse/AVRO-3595
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.11.1
>Reporter: Jeremy Norris
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When will release notes be published for the new 1.11.1 release?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3595) Release Notes missing for 1.11.1

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576368#comment-17576368
 ] 

ASF subversion and git services commented on AVRO-3595:
---

Commit 68baaaefc16aac47d32c230f0240045087b4bc99 in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=68baaaefc ]

AVRO-3595: [Website] Add release notes for 1.11.1 (#1809)

Signed-off-by: Martin Tzvetanov Grigorov 

> Release Notes missing for 1.11.1
> 
>
> Key: AVRO-3595
> URL: https://issues.apache.org/jira/browse/AVRO-3595
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.11.1
>Reporter: Jeremy Norris
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When will release notes be published for the new 1.11.1 release?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3595) Release Notes missing for 1.11.1

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575805#comment-17575805
 ] 

ASF subversion and git services commented on AVRO-3595:
---

Commit 0887a99f0e0d1554c6fe15965d11387f76e9d4ab in avro's branch 
refs/heads/avro-3595-release-notes-1.11.1 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0887a99f0 ]

AVRO-3595: [Website] Add release notes for 1.11.1

Signed-off-by: Martin Tzvetanov Grigorov 


> Release Notes missing for 1.11.1
> 
>
> Key: AVRO-3595
> URL: https://issues.apache.org/jira/browse/AVRO-3595
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.11.1
>Reporter: Jeremy Norris
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> When will release notes be published for the new 1.11.1 release?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3592) [C#] New packages are not included in the build distribution

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575090#comment-17575090
 ] 

ASF subversion and git services commented on AVRO-3592:
---

Commit c3c64a1bf8bd7f641327cca0b7f329ed01dedf58 in avro's branch 
refs/heads/dependabot/cargo/lang/rust/master/quote-1.0.21 from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=c3c64a1bf ]

AVRO-3592: Add the codec packages to the tar (#1796)



> [C#] New packages are not included in the build distribution
> 
>
> Key: AVRO-3592
> URL: https://issues.apache.org/jira/browse/AVRO-3592
> Project: Apache Avro
>  Issue Type: New Feature
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We correctly create the {{codec/* }}packages, but they aren't included in the 
> binary distribution.
> For release 1.11.1, I'll uploaded the binary artifacts manually from the 
> local build I used to create the release, but they won't be in the [binary 
> artifacts|https://dist.apache.org/repos/dist/release/avro/avro-1.11.1/csharp/]
>  we voted on with the release.  This is likely acceptable since an Apache 
> release is for the source, and the uploaded artifacts are considered for 
> convenience (IIUC).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3592) [C#] New packages are not included in the build distribution

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575091#comment-17575091
 ] 

ASF subversion and git services commented on AVRO-3592:
---

Commit c3c64a1bf8bd7f641327cca0b7f329ed01dedf58 in avro's branch 
refs/heads/dependabot/cargo/lang/rust/master/serde_json-1.0.83 from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=c3c64a1bf ]

AVRO-3592: Add the codec packages to the tar (#1796)



> [C#] New packages are not included in the build distribution
> 
>
> Key: AVRO-3592
> URL: https://issues.apache.org/jira/browse/AVRO-3592
> Project: Apache Avro
>  Issue Type: New Feature
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We correctly create the {{codec/* }}packages, but they aren't included in the 
> binary distribution.
> For release 1.11.1, I'll uploaded the binary artifacts manually from the 
> local build I used to create the release, but they won't be in the [binary 
> artifacts|https://dist.apache.org/repos/dist/release/avro/avro-1.11.1/csharp/]
>  we voted on with the release.  This is likely acceptable since an Apache 
> release is for the source, and the uploaded artifacts are considered for 
> convenience (IIUC).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3592) [C#] New packages are not included in the build distribution

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575082#comment-17575082
 ] 

ASF subversion and git services commented on AVRO-3592:
---

Commit c3c64a1bf8bd7f641327cca0b7f329ed01dedf58 in avro's branch 
refs/heads/dependabot/cargo/lang/rust/master/syn-1.0.99 from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=c3c64a1bf ]

AVRO-3592: Add the codec packages to the tar (#1796)



> [C#] New packages are not included in the build distribution
> 
>
> Key: AVRO-3592
> URL: https://issues.apache.org/jira/browse/AVRO-3592
> Project: Apache Avro
>  Issue Type: New Feature
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We correctly create the {{codec/* }}packages, but they aren't included in the 
> binary distribution.
> For release 1.11.1, I'll uploaded the binary artifacts manually from the 
> local build I used to create the release, but they won't be in the [binary 
> artifacts|https://dist.apache.org/repos/dist/release/avro/avro-1.11.1/csharp/]
>  we voted on with the release.  This is likely acceptable since an Apache 
> release is for the source, and the uploaded artifacts are considered for 
> convenience (IIUC).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3592) [C#] New packages are not included in the build distribution

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575079#comment-17575079
 ] 

ASF subversion and git services commented on AVRO-3592:
---

Commit c3c64a1bf8bd7f641327cca0b7f329ed01dedf58 in avro's branch 
refs/heads/master from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=c3c64a1bf ]

AVRO-3592: Add the codec packages to the tar (#1796)



> [C#] New packages are not included in the build distribution
> 
>
> Key: AVRO-3592
> URL: https://issues.apache.org/jira/browse/AVRO-3592
> Project: Apache Avro
>  Issue Type: New Feature
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We correctly create the {{codec/* }}packages, but they aren't included in the 
> binary distribution.
> For release 1.11.1, I'll uploaded the binary artifacts manually from the 
> local build I used to create the release, but they won't be in the [binary 
> artifacts|https://dist.apache.org/repos/dist/release/avro/avro-1.11.1/csharp/]
>  we voted on with the release.  This is likely acceptable since an Apache 
> release is for the source, and the uploaded artifacts are considered for 
> convenience (IIUC).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3592) [C#] New packages are not included in the build distribution

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575080#comment-17575080
 ] 

ASF subversion and git services commented on AVRO-3592:
---

Commit a7a39c1edf0bf92fce3ea3e9a8415eef025f830d in avro's branch 
refs/heads/branch-1.11 from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a7a39c1ed ]

AVRO-3592: Add the codec packages to the tar (#1796)

(cherry picked from commit c3c64a1bf8bd7f641327cca0b7f329ed01dedf58)


> [C#] New packages are not included in the build distribution
> 
>
> Key: AVRO-3592
> URL: https://issues.apache.org/jira/browse/AVRO-3592
> Project: Apache Avro
>  Issue Type: New Feature
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We correctly create the {{codec/* }}packages, but they aren't included in the 
> binary distribution.
> For release 1.11.1, I'll uploaded the binary artifacts manually from the 
> local build I used to create the release, but they won't be in the [binary 
> artifacts|https://dist.apache.org/repos/dist/release/avro/avro-1.11.1/csharp/]
>  we voted on with the release.  This is likely acceptable since an Apache 
> release is for the source, and the uploaded artifacts are considered for 
> convenience (IIUC).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3589) Update github actions versions

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572360#comment-17572360
 ] 

ASF subversion and git services commented on AVRO-3589:
---

Commit 2c80b563a323dc24bd684385f0b2d95c3a066bd2 in avro's branch 
refs/heads/master from Ismaël Mejía
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=2c80b563a ]

AVRO-3589: Update github actions versions (#1789)

* AVRO-3589: Update github actions versions

* AVRO-3589: Add github actions dependency updates with dependabot

> Update github actions versions
> --
>
> Key: AVRO-3589
> URL: https://issues.apache.org/jira/browse/AVRO-3589
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: build
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Github Actions Runner updated their main Node version and with this most of 
> the actions moved into a new version. We should update this to keep up to 
> date with upstream github actions fixes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3547) support custom attribute at field level

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571072#comment-17571072
 ] 

ASF subversion and git services commented on AVRO-3547:
---

Commit 0e89c57b9884d25b47136a3f344a96539c05337e in avro's branch 
refs/heads/branch-1.11 from nileyadav
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0e89c57b9 ]

AVRO-3547: Add support for custom attributes in Avro Schema (#1736)

* Add support for custom attributes in Avro Schema

Custom attributes are allowed at field level as per Avro specification : 
https://avro.apache.org/docs/current/spec.html#schemas

But Avro c++ implementation does not support custom attribute at field level.
Update implementation to support custom attribute at field level.

* Add unit tests

* Avro-3547: Apply suggestions from code review

Co-authored-by: Martin Grigorov 

* Avro-3547: Fix build errors

* Update lang/c++/impl/CustomFields.cc

Co-authored-by: Martin Grigorov 

* Avro-3547: remove unused method

* AVRO-3547: fix build errors and unit test data

* AVRO-3547: Add documentation for CustomFields

Co-authored-by: nileyadav 
Co-authored-by: Martin Grigorov 
(cherry picked from commit 61a1cdcd500356726d4995c19c8a4d5d89989b13)


> support custom attribute at field level
> ---
>
> Key: AVRO-3547
> URL: https://issues.apache.org/jira/browse/AVRO-3547
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Reporter: Nilesh Yadav
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> Custom attributes are allowed at field level as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> But Avro c++ implementation does not support custom attribute at field level.
> e.g. following schema cannot be parsed correctly due to presence of "sqlName" 
> attribute.
> {
>     'doc': 'weather warning',
>     'name': 'weather',
>     'type': 'record',
>     'fields': [
>     {
>         'name': 'station',
>         'type':'string',
>         'sqlName':'abc-@12'
>     },
>     {
>         'name': 'time',
>         'type':'long',
>         'sqlName': '用户名'
>     }]
> }
> Update implementation to support custom attribute at field level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3547) support custom attribute at field level

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571071#comment-17571071
 ] 

ASF subversion and git services commented on AVRO-3547:
---

Commit 61a1cdcd500356726d4995c19c8a4d5d89989b13 in avro's branch 
refs/heads/master from nileyadav
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=61a1cdcd5 ]

AVRO-3547: Add support for custom attributes in Avro Schema (#1736)

* Add support for custom attributes in Avro Schema

Custom attributes are allowed at field level as per Avro specification : 
https://avro.apache.org/docs/current/spec.html#schemas

But Avro c++ implementation does not support custom attribute at field level.
Update implementation to support custom attribute at field level.

* Add unit tests

* Avro-3547: Apply suggestions from code review

Co-authored-by: Martin Grigorov 

* Avro-3547: Fix build errors

* Update lang/c++/impl/CustomFields.cc

Co-authored-by: Martin Grigorov 

* Avro-3547: remove unused method

* AVRO-3547: fix build errors and unit test data

* AVRO-3547: Add documentation for CustomFields

Co-authored-by: nileyadav 
Co-authored-by: Martin Grigorov 

> support custom attribute at field level
> ---
>
> Key: AVRO-3547
> URL: https://issues.apache.org/jira/browse/AVRO-3547
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: c++
>Reporter: Nilesh Yadav
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> Custom attributes are allowed at field level as per Avro specification : 
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>  
> But Avro c++ implementation does not support custom attribute at field level.
> e.g. following schema cannot be parsed correctly due to presence of "sqlName" 
> attribute.
> {
>     'doc': 'weather warning',
>     'name': 'weather',
>     'type': 'record',
>     'fields': [
>     {
>         'name': 'station',
>         'type':'string',
>         'sqlName':'abc-@12'
>     },
>     {
>         'name': 'time',
>         'type':'long',
>         'sqlName': '用户名'
>     }]
> }
> Update implementation to support custom attribute at field level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3586) Make Avro Build Reproducible

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570812#comment-17570812
 ] 

ASF subversion and git services commented on AVRO-3586:
---

Commit d6a0d0a790274de27b2cfde07d14151a4a327a96 in avro's branch 
refs/heads/branch-1.11 from Ismaël Mejía
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d6a0d0a79 ]

AVRO-3586: Pin output timestamp to make the Java build reproducible (#1783)

* AVRO-3586: Update maven plugins and fix checkstyle issue

* AVRO-3586: Pin output timestamp to make the Java build reproducible

> Make Avro Build Reproducible
> 
>
> Key: AVRO-3586
> URL: https://issues.apache.org/jira/browse/AVRO-3586
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: build, java
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Avro is one important dependency of many projects, with the recent interest 
> in security and initiatives like spdx having a [reproducible 
> build|https://reproducible-builds.org/] matters.
> Also now [maven supports reproducible 
> builds|https://maven.apache.org/guides/mini/guide-reproducible-builds.html] 
> so we don't need more dependencies out of the box to do it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3586) Make Avro Build Reproducible

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570811#comment-17570811
 ] 

ASF subversion and git services commented on AVRO-3586:
---

Commit 39480d6b67345c7d7d6d2de4447cae7215991b1c in avro's branch 
refs/heads/master from Ismaël Mejía
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=39480d6b6 ]

AVRO-3586: Pin output timestamp to make the Java build reproducible (#1783)

* AVRO-3586: Update maven plugins and fix checkstyle issue

* AVRO-3586: Pin output timestamp to make the Java build reproducible

> Make Avro Build Reproducible
> 
>
> Key: AVRO-3586
> URL: https://issues.apache.org/jira/browse/AVRO-3586
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: build, java
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Avro is one important dependency of many projects, with the recent interest 
> in security and initiatives like spdx having a [reproducible 
> build|https://reproducible-builds.org/] matters.
> Also now [maven supports reproducible 
> builds|https://maven.apache.org/guides/mini/guide-reproducible-builds.html] 
> so we don't need more dependencies out of the box to do it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3585) Unable to encode Value::String as Schema::UUID

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570767#comment-17570767
 ] 

ASF subversion and git services commented on AVRO-3585:
---

Commit fa3d83ae9502341c321edbe368552badd26af4ac in avro's branch 
refs/heads/branch-1.11 from Rik Heijdens
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=fa3d83ae9 ]

AVRO-3585: Add support for encoding Value::String as Schema::Uuid (#1778)

* AVRO-3585: Add test-case to confirm UUID handling

Added a test-case to confirm encoding UUIDs that are provided as
Value::String works as expected.

* AVRO-3585: Add Uuid as a supported encoding

Added Schema::Uuid as supported encoding for Value::String.

In some cases Uuids may be presented as a Value::String to the Avro
encoder, previously, the encoder would reject these values. This has
been fixed by this commit.

* AVRO-3585: Simplify match statement

Removed a duplicate branch for matching Schema::Uuid by collapsing
it into the branch for matching Schema::String.

Co-authored-by: gabriel 
(cherry picked from commit 945820a9ce5a4ad67fb9a9cdacbddbaacfd2e5db)


> Unable to encode Value::String as Schema::UUID
> --
>
> Key: AVRO-3585
> URL: https://issues.apache.org/jira/browse/AVRO-3585
> Project: Apache Avro
>  Issue Type: Bug
>  Components: rust
>Reporter: Rik Heijdens
>Priority: Blocker
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, `apache_avro::encode::encode()` fails to encode a Value::String as 
> UUID. This failure can be reproduced using the following minimal test-case:
>  
> {code:java}
>     #[test]
>     fn test_encode_uuid() {
>         let value = 
> Value::String(String::from("----"));
>         let schema = Schema::Uuid;
>         let mut buffer = Vec::new();
>         let encoded = encode(&value, &schema, &mut buffer);
>         assert!(encoded.is_ok());
>     } {code}
>  
>  
> I believe it should be possible to encode UUIDs in this manner, and support 
> can be trivially added by extending the match statement in 
> `apache_avro::encode::encode_internal`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3585) Unable to encode Value::String as Schema::UUID

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570766#comment-17570766
 ] 

ASF subversion and git services commented on AVRO-3585:
---

Commit 945820a9ce5a4ad67fb9a9cdacbddbaacfd2e5db in avro's branch 
refs/heads/master from Rik Heijdens
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=945820a9c ]

AVRO-3585: Add support for encoding Value::String as Schema::Uuid (#1778)

* AVRO-3585: Add test-case to confirm UUID handling

Added a test-case to confirm encoding UUIDs that are provided as
Value::String works as expected.

* AVRO-3585: Add Uuid as a supported encoding

Added Schema::Uuid as supported encoding for Value::String.

In some cases Uuids may be presented as a Value::String to the Avro
encoder, previously, the encoder would reject these values. This has
been fixed by this commit.

* AVRO-3585: Simplify match statement

Removed a duplicate branch for matching Schema::Uuid by collapsing
it into the branch for matching Schema::String.

Co-authored-by: gabriel 

> Unable to encode Value::String as Schema::UUID
> --
>
> Key: AVRO-3585
> URL: https://issues.apache.org/jira/browse/AVRO-3585
> Project: Apache Avro
>  Issue Type: Bug
>  Components: rust
>Reporter: Rik Heijdens
>Priority: Blocker
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, `apache_avro::encode::encode()` fails to encode a Value::String as 
> UUID. This failure can be reproduced using the following minimal test-case:
>  
> {code:java}
>     #[test]
>     fn test_encode_uuid() {
>         let value = 
> Value::String(String::from("----"));
>         let schema = Schema::Uuid;
>         let mut buffer = Vec::new();
>         let encoded = encode(&value, &schema, &mut buffer);
>         assert!(encoded.is_ok());
>     } {code}
>  
>  
> I believe it should be possible to encode UUIDs in this manner, and support 
> can be trivially added by extending the match statement in 
> `apache_avro::encode::encode_internal`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3584) allow for mutual recursion in type definitions for all languages

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569387#comment-17569387
 ] 

ASF subversion and git services commented on AVRO-3584:
---

Commit 18c9b4afb53f6216eca1fb464afaa1082781bf11 in avro's branch 
refs/heads/master from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=18c9b4afb ]

Avro 3584 rust unit test (#1775)

AVRO-3584 : add unit test for recursion type

> allow for mutual recursion in type definitions for all languages
> 
>
> Key: AVRO-3584
> URL: https://issues.apache.org/jira/browse/AVRO-3584
> Project: Apache Avro
>  Issue Type: Wish
>Reporter: Christophe Le Saec
>Priority: Major
>
> This idea is to allow AVRO to load schemas with recursion described like this:
> {code:json}
> {"name": "User", "type": "record", "fields": [{"name": "current_status", 
> "type": "Status"}]}
> {"name": "Status", "type": "record", "fields": [{"name": "author", "type": 
> "User"}]}
> {code}
> - Java : [AVRO-530|https://issues.apache.org/jira/browse/AVRO-530] is ready 
> to checked (PR ready).
> - Rust : Unit test show that it already works (May be better to add a unit 
> test in a PR).
> For others languages (C, C++, C#, Python ...); 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3584) allow for mutual recursion in type definitions for all languages

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569389#comment-17569389
 ] 

ASF subversion and git services commented on AVRO-3584:
---

Commit fe5f2f07917053a5bbf4c9527b6e751e72bb05c6 in avro's branch 
refs/heads/branch-1.11 from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=fe5f2f079 ]

Avro 3584 rust unit test (#1775)

AVRO-3584 : add unit test for recursion type
(cherry picked from commit 18c9b4afb53f6216eca1fb464afaa1082781bf11)


> allow for mutual recursion in type definitions for all languages
> 
>
> Key: AVRO-3584
> URL: https://issues.apache.org/jira/browse/AVRO-3584
> Project: Apache Avro
>  Issue Type: Wish
>Reporter: Christophe Le Saec
>Priority: Major
>
> This idea is to allow AVRO to load schemas with recursion described like this:
> {code:json}
> {"name": "User", "type": "record", "fields": [{"name": "current_status", 
> "type": "Status"}]}
> {"name": "Status", "type": "record", "fields": [{"name": "author", "type": 
> "User"}]}
> {code}
> - Java : [AVRO-530|https://issues.apache.org/jira/browse/AVRO-530] is ready 
> to checked (PR ready).
> - Rust : Unit test show that it already works (May be better to add a unit 
> test in a PR).
> For others languages (C, C++, C#, Python ...); 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3581) Usage of deprecated configuration properties in Velocity

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569292#comment-17569292
 ] 

ASF subversion and git services commented on AVRO-3581:
---

Commit 9c144131f1887a69221e5b30101ed890c214c277 in avro's branch 
refs/heads/master from Luan Kevin Ferreira
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=9c144131f ]

AVRO-3581: Fix Velocity configuration warnings by changing to new cofigs since 
the old ones were deprecated. (#1773)



> Usage of deprecated configuration properties in Velocity
> 
>
> Key: AVRO-3581
> URL: https://issues.apache.org/jira/browse/AVRO-3581
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.11.0
>Reporter: Luan Kevin Ferreira
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> After upgrading to version 1.11.0, I still see these warnings as described in 
> https://issues.apache.org/jira/browse/AVRO-2798
> {noformat}
> configuration key 'resource.loader' has been deprecated in favor of 
> 'resource.loaders'
> configuration key 'class.resource.loader.class' has been deprecated in favor 
> of 'resource.loader.class.class'
> configuration key 'file.resource.loader.class' has been deprecated in favor 
> of 'resource.loader.file.class'
> configuration key 'file.resource.loader.path' has been deprecated in favor of 
> 'resource.loader.file.path'
> configuration key 'runtime.references.strict' has been deprecated in favor of 
> 'runtime.strict_mode.enable'
> configuration key 'space.gobbling' has been deprecated in favor of 
> 'parser.space_gobbling'{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3581) Usage of deprecated configuration properties in Velocity

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569293#comment-17569293
 ] 

ASF subversion and git services commented on AVRO-3581:
---

Commit d9710c7cc01dbd0ec8af19306da67f11e355aee9 in avro's branch 
refs/heads/branch-1.11 from Luan Kevin Ferreira
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d9710c7cc ]

AVRO-3581: Fix Velocity configuration warnings by changing to new cofigs since 
the old ones were deprecated. (#1773)

(cherry picked from commit 9c144131f1887a69221e5b30101ed890c214c277)


> Usage of deprecated configuration properties in Velocity
> 
>
> Key: AVRO-3581
> URL: https://issues.apache.org/jira/browse/AVRO-3581
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.11.0
>Reporter: Luan Kevin Ferreira
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> After upgrading to version 1.11.0, I still see these warnings as described in 
> https://issues.apache.org/jira/browse/AVRO-2798
> {noformat}
> configuration key 'resource.loader' has been deprecated in favor of 
> 'resource.loaders'
> configuration key 'class.resource.loader.class' has been deprecated in favor 
> of 'resource.loader.class.class'
> configuration key 'file.resource.loader.class' has been deprecated in favor 
> of 'resource.loader.file.class'
> configuration key 'file.resource.loader.path' has been deprecated in favor of 
> 'resource.loader.file.path'
> configuration key 'runtime.references.strict' has been deprecated in favor of 
> 'runtime.strict_mode.enable'
> configuration key 'space.gobbling' has been deprecated in favor of 
> 'parser.space_gobbling'{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3579) Java Test : From Junit4 to JUnit5

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568880#comment-17568880
 ] 

ASF subversion and git services commented on AVRO-3579:
---

Commit b897fb5e9bac0b7109bd7761ba213d8bdfd519f4 in avro's branch 
refs/heads/branch-1.11 from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=b897fb5e9 ]

AVRO-3579 : insert JUnit5 (#1769)

Co-authored-by: Martin Grigorov 
(cherry picked from commit 2a7e85185e92f5ccb7f36b7cfab1d96e76b2bd12)


> Java Test : From Junit4 to JUnit5
> -
>
> Key: AVRO-3579
> URL: https://issues.apache.org/jira/browse/AVRO-3579
> Project: Apache Avro
>  Issue Type: Improvement
>Reporter: Christophe Le Saec
>Assignee: Christophe Le Saec
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Progressively pass from JUnit4 to JUnit5



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3579) Java Test : From Junit4 to JUnit5

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568878#comment-17568878
 ] 

ASF subversion and git services commented on AVRO-3579:
---

Commit 2a7e85185e92f5ccb7f36b7cfab1d96e76b2bd12 in avro's branch 
refs/heads/master from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=2a7e85185 ]

AVRO-3579 : insert JUnit5 (#1769)

Co-authored-by: Martin Grigorov 

> Java Test : From Junit4 to JUnit5
> -
>
> Key: AVRO-3579
> URL: https://issues.apache.org/jira/browse/AVRO-3579
> Project: Apache Avro
>  Issue Type: Improvement
>Reporter: Christophe Le Saec
>Assignee: Christophe Le Saec
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Progressively pass from JUnit4 to JUnit5



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3575) Rust: Add a module for fuzzy testing

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565372#comment-17565372
 ] 

ASF subversion and git services commented on AVRO-3575:
---

Commit eb2477555d32d25ec1e8f5469d52ff76beaf33b6 in avro's branch 
refs/heads/dependabot/cargo/lang/rust/master/regex-1.6.0 from Evan Richter
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=eb2477555 ]

AVRO-3575: Rust: add fuzz harness (#1761)

* AVRO-3575: Rust: cargo fuzz harness

* AVRO-3575: Rust: Fuzzing fixes

* AVRO-3575: Add ASLv2 licences and mark other test related modules as publish 
= false

Signed-off-by: Martin Tzvetanov Grigorov 

Co-authored-by: Martin Tzvetanov Grigorov 

> Rust: Add a module for fuzzy testing
> 
>
> Key: AVRO-3575
> URL: https://issues.apache.org/jira/browse/AVRO-3575
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It would be nice to fuzzy test the Rust module for memory handling issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3575) Rust: Add a module for fuzzy testing

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565373#comment-17565373
 ] 

ASF subversion and git services commented on AVRO-3575:
---

Commit eb2477555d32d25ec1e8f5469d52ff76beaf33b6 in avro's branch 
refs/heads/dependabot/cargo/lang/rust/master/strum_macros-0.24.2 from Evan 
Richter
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=eb2477555 ]

AVRO-3575: Rust: add fuzz harness (#1761)

* AVRO-3575: Rust: cargo fuzz harness

* AVRO-3575: Rust: Fuzzing fixes

* AVRO-3575: Add ASLv2 licences and mark other test related modules as publish 
= false

Signed-off-by: Martin Tzvetanov Grigorov 

Co-authored-by: Martin Tzvetanov Grigorov 

> Rust: Add a module for fuzzy testing
> 
>
> Key: AVRO-3575
> URL: https://issues.apache.org/jira/browse/AVRO-3575
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It would be nice to fuzzy test the Rust module for memory handling issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3575) Rust: Add a module for fuzzy testing

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565345#comment-17565345
 ] 

ASF subversion and git services commented on AVRO-3575:
---

Commit eb2477555d32d25ec1e8f5469d52ff76beaf33b6 in avro's branch 
refs/heads/dependabot/cargo/lang/rust/master/serde-1.0.139 from Evan Richter
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=eb2477555 ]

AVRO-3575: Rust: add fuzz harness (#1761)

* AVRO-3575: Rust: cargo fuzz harness

* AVRO-3575: Rust: Fuzzing fixes

* AVRO-3575: Add ASLv2 licences and mark other test related modules as publish 
= false

Signed-off-by: Martin Tzvetanov Grigorov 

Co-authored-by: Martin Tzvetanov Grigorov 

> Rust: Add a module for fuzzy testing
> 
>
> Key: AVRO-3575
> URL: https://issues.apache.org/jira/browse/AVRO-3575
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It would be nice to fuzzy test the Rust module for memory handling issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3575) Rust: Add a module for fuzzy testing

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565344#comment-17565344
 ] 

ASF subversion and git services commented on AVRO-3575:
---

Commit b8463f21db3088690e6b1ce267966d8c57f1b706 in avro's branch 
refs/heads/branch-1.11 from Evan Richter
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=b8463f21d ]

AVRO-3575: Rust: add fuzz harness (#1761)

* AVRO-3575: Rust: cargo fuzz harness

* AVRO-3575: Rust: Fuzzing fixes

* AVRO-3575: Add ASLv2 licences and mark other test related modules as publish 
= false

Signed-off-by: Martin Tzvetanov Grigorov 

Co-authored-by: Martin Tzvetanov Grigorov 
(cherry picked from commit eb2477555d32d25ec1e8f5469d52ff76beaf33b6)


> Rust: Add a module for fuzzy testing
> 
>
> Key: AVRO-3575
> URL: https://issues.apache.org/jira/browse/AVRO-3575
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It would be nice to fuzzy test the Rust module for memory handling issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3575) Rust: Add a module for fuzzy testing

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565343#comment-17565343
 ] 

ASF subversion and git services commented on AVRO-3575:
---

Commit eb2477555d32d25ec1e8f5469d52ff76beaf33b6 in avro's branch 
refs/heads/master from Evan Richter
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=eb2477555 ]

AVRO-3575: Rust: add fuzz harness (#1761)

* AVRO-3575: Rust: cargo fuzz harness

* AVRO-3575: Rust: Fuzzing fixes

* AVRO-3575: Add ASLv2 licences and mark other test related modules as publish 
= false

Signed-off-by: Martin Tzvetanov Grigorov 

Co-authored-by: Martin Tzvetanov Grigorov 

> Rust: Add a module for fuzzy testing
> 
>
> Key: AVRO-3575
> URL: https://issues.apache.org/jira/browse/AVRO-3575
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It would be nice to fuzzy test the Rust module for memory handling issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3574) Rust: Add Cargo.lock to Git

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565041#comment-17565041
 ] 

ASF subversion and git services commented on AVRO-3574:
---

Commit 27dc094a54b5c73336f355649ddd5e70d04ae6d6 in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=27dc094a5 ]

AVRO-3574: Add Cargo.lock to Git (#1762)

This is needed to avoid unexpected transitive dependencies updates like
plotters 0.3.1 -> 0.3.2 that breaks with Rust 1.54.0 (MSRV at the moment)

https://github.com/apache/avro/runs/7283175532?check_suite_focus=true

Signed-off-by: Martin Tzvetanov Grigorov 
(cherry picked from commit d4f7d57b43c798fd236020fe422072682cfdc67e)


> Rust: Add Cargo.lock to Git
> ---
>
> Key: AVRO-3574
> URL: https://issues.apache.org/jira/browse/AVRO-3574
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is needed to avoid unexpected transitive dependencies updates like 
> plotters 0.3.1 -> 0.3.2 that breaks with Rust 1.54.0 (MSRV at the moment)
> [https://github.com/apache/avro/runs/7283175532?check_suite_focus=true]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3574) Rust: Add Cargo.lock to Git

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565039#comment-17565039
 ] 

ASF subversion and git services commented on AVRO-3574:
---

Commit d4f7d57b43c798fd236020fe422072682cfdc67e in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d4f7d57b4 ]

AVRO-3574: Add Cargo.lock to Git (#1762)

This is needed to avoid unexpected transitive dependencies updates like
plotters 0.3.1 -> 0.3.2 that breaks with Rust 1.54.0 (MSRV at the moment)

https://github.com/apache/avro/runs/7283175532?check_suite_focus=true

Signed-off-by: Martin Tzvetanov Grigorov 

> Rust: Add Cargo.lock to Git
> ---
>
> Key: AVRO-3574
> URL: https://issues.apache.org/jira/browse/AVRO-3574
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is needed to avoid unexpected transitive dependencies updates like 
> plotters 0.3.1 -> 0.3.2 that breaks with Rust 1.54.0 (MSRV at the moment)
> [https://github.com/apache/avro/runs/7283175532?check_suite_focus=true]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3574) Rust: Add Cargo.lock to Git

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565032#comment-17565032
 ] 

ASF subversion and git services commented on AVRO-3574:
---

Commit 74f6c3d06944724b8772fc720de1bd737decccac in avro's branch 
refs/heads/avro-3574-add-Cargo.lock-to-git from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=74f6c3d06 ]

AVRO-3574: Add Cargo.lock to Git

This is needed to avoid unexpected transitive dependencies updates like
plotters 0.3.1 -> 0.3.2 that breaks with Rust 1.54.0 (MSRV at the moment)

https://github.com/apache/avro/runs/7283175532?check_suite_focus=true

Signed-off-by: Martin Tzvetanov Grigorov 


> Rust: Add Cargo.lock to Git
> ---
>
> Key: AVRO-3574
> URL: https://issues.apache.org/jira/browse/AVRO-3574
> Project: Apache Avro
>  Issue Type: Task
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>
> This is needed to avoid unexpected transitive dependencies updates like 
> plotters 0.3.1 -> 0.3.2 that breaks with Rust 1.54.0 (MSRV at the moment)
> [https://github.com/apache/avro/runs/7283175532?check_suite_focus=true]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-2774) missing @Override annotations in generated code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563998#comment-17563998
 ] 

ASF subversion and git services commented on AVRO-2774:
---

Commit 4d82fb5dd8ea28594248cc1ac44b8519781f66dd in avro's branch 
refs/heads/branch-1.11 from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=4d82fb5dd ]

AVRO-2774: Generate @Overrides annotations (#1755)

* AVRO-2774 : add override and test it

* AVRO-2774 : remove sun deps for java17

> missing @Override annotations in generated code
> ---
>
> Key: AVRO-2774
> URL: https://issues.apache.org/jira/browse/AVRO-2774
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.1, 1.9.2
> Environment: openjdk version "11.0.6" 2020-01-14 LTS
> avro 1.9.2
> gradle avro plugin
>Reporter: Tim Spriggs
>Priority: Major
>  Labels: pull-request-available
>   Original Estimate: 24h
>  Time Spent: 10m
>  Remaining Estimate: 23h 50m
>
> When applying errorProne to my project, I get errors from the MissingOverride 
> rule. eg:
> error: [MissingOverride] getSpecificData overrides method in 
> SpecificRecordBase
> error: [MissingOverride] getSchema implements method in SpecificRecordBase
> error: [MissingOverride] get implements method in SpecificRecordBase
> error: [MissingOverride] put implements method in SpecificRecordBase
>  
> If these are always tagged with @Override then static analysis and IDE hints 
> perform better.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-2774) missing @Override annotations in generated code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563997#comment-17563997
 ] 

ASF subversion and git services commented on AVRO-2774:
---

Commit d5621e9f8da61c02e4339c11b6852ad059dd72b3 in avro's branch 
refs/heads/master from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d5621e9f8 ]

AVRO-2774: Generate @Overrides annotations (#1755)

* AVRO-2774 : add override and test it

* AVRO-2774 : remove sun deps for java17

> missing @Override annotations in generated code
> ---
>
> Key: AVRO-2774
> URL: https://issues.apache.org/jira/browse/AVRO-2774
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.1, 1.9.2
> Environment: openjdk version "11.0.6" 2020-01-14 LTS
> avro 1.9.2
> gradle avro plugin
>Reporter: Tim Spriggs
>Priority: Major
>  Labels: pull-request-available
>   Original Estimate: 24h
>  Time Spent: 10m
>  Remaining Estimate: 23h 50m
>
> When applying errorProne to my project, I get errors from the MissingOverride 
> rule. eg:
> error: [MissingOverride] getSpecificData overrides method in 
> SpecificRecordBase
> error: [MissingOverride] getSchema implements method in SpecificRecordBase
> error: [MissingOverride] get implements method in SpecificRecordBase
> error: [MissingOverride] put implements method in SpecificRecordBase
>  
> If these are always tagged with @Override then static analysis and IDE hints 
> perform better.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3219) Not support for nullable enum type fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563492#comment-17563492
 ] 

ASF subversion and git services commented on AVRO-3219:
---

Commit 6cf169a4b02de5b36fa3fb1396c42e0fd3358bad in avro's branch 
refs/heads/branch-1.11 from Zike Yang
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=6cf169a4b ]

AVRO-3219: Add nullable enum type field support in Avro.Reflect (#1348)

* AVRO-3219: Add nullable enum type field support.

Signed-off-by: Zike Yang 

* Apply comments.

Signed-off-by: Zike Yang 

* Fix mistakenly removed the enum type check.

Signed-off-by: Zike Yang 

> Not support for nullable enum type fields
> -
>
> Key: AVRO-3219
> URL: https://issues.apache.org/jira/browse/AVRO-3219
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: csharp
>Affects Versions: 1.10.2
>Reporter: Zike Yang
>Assignee: Zike Yang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1
>
> Attachments: AVRO-3219.patch
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Currently, when the schema contain nullable enum type, it will throw 
> Exception`Couldnot find enumeration for avro full name ...` while writing or 
> reading.
>  
> We need to add support for the nullable enum type.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3563) Ensure current/spec.html points to the current version of the spec.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563491#comment-17563491
 ] 

ASF subversion and git services commented on AVRO-3563:
---

Commit 31f3800fbcc55bd33552ea0d2aedf8dd7e22d7df in avro's branch 
refs/heads/branch-1.11 from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=31f3800fb ]

AVRO-3563: Ensure docs/current/spec.html remains viable (#1750)

* AVRO-3563: Ensure docs/current/spec.html remains viable

* Fix typo with symbolic link directory

> Ensure current/spec.html points to the current version of the spec.
> ---
>
> Key: AVRO-3563
> URL: https://issues.apache.org/jira/browse/AVRO-3563
> Project: Apache Avro
>  Issue Type: Sub-task
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It's probably the single most used link in the avro website, and the top 
> search result for "Avro spec".  We use it internally in the project 
> constantly.
> https://avro.apache.org/docs/current/spec.html
> It probably isn't as important to retain the anchor texts for now, as long as 
> we get to the correct web page.
> Note that pointing *{{current}}* to the actual current version is part of the 
> release process!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3219) Not support for nullable enum type fields

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563490#comment-17563490
 ] 

ASF subversion and git services commented on AVRO-3219:
---

Commit 2a46a61b65697706e2277921c3bf5ccb819c311f in avro's branch 
refs/heads/master from Zike Yang
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=2a46a61b6 ]

AVRO-3219: Add nullable enum type field support in Avro.Reflect (#1348)

* AVRO-3219: Add nullable enum type field support.

Signed-off-by: Zike Yang 

* Apply comments.

Signed-off-by: Zike Yang 

* Fix mistakenly removed the enum type check.

Signed-off-by: Zike Yang 

> Not support for nullable enum type fields
> -
>
> Key: AVRO-3219
> URL: https://issues.apache.org/jira/browse/AVRO-3219
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: csharp
>Affects Versions: 1.10.2
>Reporter: Zike Yang
>Assignee: Zike Yang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1
>
> Attachments: AVRO-3219.patch
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Currently, when the schema contain nullable enum type, it will throw 
> Exception`Couldnot find enumeration for avro full name ...` while writing or 
> reading.
>  
> We need to add support for the nullable enum type.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3563) Ensure current/spec.html points to the current version of the spec.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562239#comment-17562239
 ] 

ASF subversion and git services commented on AVRO-3563:
---

Commit 80c04a32dcbc0165c4e7f15f79c83afc6937193a in avro's branch 
refs/heads/master from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=80c04a32d ]

AVRO-3563: Ensure docs/current/spec.html remains viable (#1750)

* AVRO-3563: Ensure docs/current/spec.html remains viable

* Fix typo with symbolic link directory

> Ensure current/spec.html points to the current version of the spec.
> ---
>
> Key: AVRO-3563
> URL: https://issues.apache.org/jira/browse/AVRO-3563
> Project: Apache Avro
>  Issue Type: Sub-task
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It's probably the single most used link in the avro website, and the top 
> search result for "Avro spec".  We use it internally in the project 
> constantly.
> https://avro.apache.org/docs/current/spec.html
> It probably isn't as important to retain the anchor texts for now, as long as 
> we get to the correct web page.
> Note that pointing *{{current}}* to the actual current version is part of the 
> release process!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3531) GenericDatumReader in multithread lead to infinite loop cause misused of IdentityHashMap

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562236#comment-17562236
 ] 

ASF subversion and git services commented on AVRO-3531:
---

Commit 42787b7926631b0a6dff4388ec66116373fc2365 in avro's branch 
refs/heads/branch-1.11 from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=42787b792 ]

AVRO-3531: Improve thread safety in GenericDatumReader (#1719)

* avro-3531 : make generic datum reader thread safe

* avro3531: use reentrant lock

* avro-3531: spotless modif

* AVRO-3531:use Conccurent hashmap

* AVRO-3531: reput newInstanceFromString method for backward compatibility

* Reduce visibility of the getReaderCache() method.

* Fix typo from github editor

Co-authored-by: Ryan Skraba 

> GenericDatumReader in multithread lead to infinite loop cause misused of 
> IdentityHashMap
> 
>
> Key: AVRO-3531
> URL: https://issues.apache.org/jira/browse/AVRO-3531
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.11.0
>Reporter: tansion
>Assignee: Christophe Le Saec
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Hi, 
> I am working on a java project that uses Kafka with Avro 
> serialization/deserialization in an messaging platform.
> In production enrionment, we meet a serious issue on the deserialization 
> processs. The GenericDatumReader process some how get into a infinite loop 
> status, and it is happened accationally.
> When the issue happens, The thread stack is like this:
>  
> {code:java}
> "DmqFixedRateConsumer-Thread-17" #453 daemon prio=5 os_prio=0 
> tid=0x7f2ae1832800 nid=0xef49 runnable [0x7f2a743fc000]
>    java.lang.Thread.State: RUNNABLE
>     at java.util.IdentityHashMap.get(IdentityHashMap.java:337)
>     at 
> org.apache.avro.generic.GenericDatumReader.getStringClass(GenericDatumReader.java:503)
>     at 
> org.apache.avro.generic.GenericDatumReader.readString(GenericDatumReader.java:454)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:191)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org

[jira] [Commented] (AVRO-3531) GenericDatumReader in multithread lead to infinite loop cause misused of IdentityHashMap

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562235#comment-17562235
 ] 

ASF subversion and git services commented on AVRO-3531:
---

Commit 820ed6e5ea4417b5735078bfd26c99f1305ea363 in avro's branch 
refs/heads/master from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=820ed6e5e ]

AVRO-3531: Improve thread safety in GenericDatumReader (#1719)

* avro-3531 : make generic datum reader thread safe

* avro3531: use reentrant lock

* avro-3531: spotless modif

* AVRO-3531:use Conccurent hashmap

* AVRO-3531: reput newInstanceFromString method for backward compatibility

* Reduce visibility of the getReaderCache() method.

* Fix typo from github editor

Co-authored-by: Ryan Skraba 

> GenericDatumReader in multithread lead to infinite loop cause misused of 
> IdentityHashMap
> 
>
> Key: AVRO-3531
> URL: https://issues.apache.org/jira/browse/AVRO-3531
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.11.0
>Reporter: tansion
>Assignee: Christophe Le Saec
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Hi, 
> I am working on a java project that uses Kafka with Avro 
> serialization/deserialization in an messaging platform.
> In production enrionment, we meet a serious issue on the deserialization 
> processs. The GenericDatumReader process some how get into a infinite loop 
> status, and it is happened accationally.
> When the issue happens, The thread stack is like this:
>  
> {code:java}
> "DmqFixedRateConsumer-Thread-17" #453 daemon prio=5 os_prio=0 
> tid=0x7f2ae1832800 nid=0xef49 runnable [0x7f2a743fc000]
>    java.lang.Thread.State: RUNNABLE
>     at java.util.IdentityHashMap.get(IdentityHashMap.java:337)
>     at 
> org.apache.avro.generic.GenericDatumReader.getStringClass(GenericDatumReader.java:503)
>     at 
> org.apache.avro.generic.GenericDatumReader.readString(GenericDatumReader.java:454)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:191)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apache.avro.reflect.ReflectDatumReader.readField(ReflectDatumReader.java:291)
>     at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>     at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>     at 
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:160)
>     at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:187)
>     at 
> org.apac

[jira] [Commented] (AVRO-3564) [Rust][branch-1.11] Build fails on bumpalo

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562145#comment-17562145
 ] 

ASF subversion and git services commented on AVRO-3564:
---

Commit 161387ce6570abbcffc4cc227739a68fc766fbab in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=161387ce6 ]

AVRO-3564: Update minimal supported Rust version in Docker to 1.54.0 (#1751)

Related-to: AVRO-3558

Signed-off-by: Martin Tzvetanov Grigorov 

> [Rust][branch-1.11] Build fails on bumpalo
> --
>
> Key: AVRO-3564
> URL: https://issues.apache.org/jira/browse/AVRO-3564
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Ryan Skraba
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:java}
>    Compiling bumpalo v3.10.0
>    Compiling hex-literal v0.3.4
>    Compiling wasm-bindgen v0.2.81
> error[E0658]: arbitrary expressions in key-value attributes are unstable
>  --> 
> /home/ryan.skraba/.cargo/registry/src/github.com-1ecc6299db9ec823/bumpalo-3.10.0/src/lib.rs:1:10
>   |
> 1 | #![doc = include_str!("../README.md")]
>   |          
>   |
>   = note: see issue #78835  
> for more information    Checking quick-error v2.0.1
>     Checking scoped-tls v1.0.0
> error: aborting due to previous errorFor more information about this error, 
> try `rustc --explain E0658`.
> error: could not compile `bumpalo`To learn more, run the command again with 
> --verbose.
> warning: build failed, waiting for other jobs to finish...
> error: build failed
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3558) Rust: Add a demo crate that shows usage as WebAssembly

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562146#comment-17562146
 ] 

ASF subversion and git services commented on AVRO-3558:
---

Commit 161387ce6570abbcffc4cc227739a68fc766fbab in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=161387ce6 ]

AVRO-3564: Update minimal supported Rust version in Docker to 1.54.0 (#1751)

Related-to: AVRO-3558

Signed-off-by: Martin Tzvetanov Grigorov 

> Rust: Add a demo crate that shows usage as WebAssembly
> --
>
> Key: AVRO-3558
> URL: https://issues.apache.org/jira/browse/AVRO-3558
> Project: Apache Avro
>  Issue Type: Test
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a new crate/package that shows usage of apache_avro crate as a web 
> assembly in a browser environment.
> The new crate won't be published!
> It will be used only for testing purposes to avoid regressions!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3558) Rust: Add a demo crate that shows usage as WebAssembly

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562144#comment-17562144
 ] 

ASF subversion and git services commented on AVRO-3558:
---

Commit 1d72182fd6afc149d33b5de8e2c68492c116732f in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1d72182fd ]

AVRO-3564: Update minimal supported Rust version in Docker to 1.54.0 (#1751)

Related-to: AVRO-3558

Signed-off-by: Martin Tzvetanov Grigorov 

> Rust: Add a demo crate that shows usage as WebAssembly
> --
>
> Key: AVRO-3558
> URL: https://issues.apache.org/jira/browse/AVRO-3558
> Project: Apache Avro
>  Issue Type: Test
>  Components: rust
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a new crate/package that shows usage of apache_avro crate as a web 
> assembly in a browser environment.
> The new crate won't be published!
> It will be used only for testing purposes to avoid regressions!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3564) [Rust][branch-1.11] Build fails on bumpalo

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AVRO-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562143#comment-17562143
 ] 

ASF subversion and git services commented on AVRO-3564:
---

Commit 1d72182fd6afc149d33b5de8e2c68492c116732f in avro's branch 
refs/heads/master from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1d72182fd ]

AVRO-3564: Update minimal supported Rust version in Docker to 1.54.0 (#1751)

Related-to: AVRO-3558

Signed-off-by: Martin Tzvetanov Grigorov 

> [Rust][branch-1.11] Build fails on bumpalo
> --
>
> Key: AVRO-3564
> URL: https://issues.apache.org/jira/browse/AVRO-3564
> Project: Apache Avro
>  Issue Type: Bug
>Reporter: Ryan Skraba
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:java}
>    Compiling bumpalo v3.10.0
>    Compiling hex-literal v0.3.4
>    Compiling wasm-bindgen v0.2.81
> error[E0658]: arbitrary expressions in key-value attributes are unstable
>  --> 
> /home/ryan.skraba/.cargo/registry/src/github.com-1ecc6299db9ec823/bumpalo-3.10.0/src/lib.rs:1:10
>   |
> 1 | #![doc = include_str!("../README.md")]
>   |          
>   |
>   = note: see issue #78835  
> for more information    Checking quick-error v2.0.1
>     Checking scoped-tls v1.0.0
> error: aborting due to previous errorFor more information about this error, 
> try `rustc --explain E0658`.
> error: could not compile `bumpalo`To learn more, run the command again with 
> --verbose.
> warning: build failed, waiting for other jobs to finish...
> error: build failed
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)