[jira] [Commented] (AVRO-1536) Remove monkeypatching of Enumerable
[
https://issues.apache.org/jira/browse/AVRO-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051590#comment-14051590
]
Hudson commented on AVRO-1536:
--
SUCCESS: Integrated in AvroJava #462 (See
[https://builds.apache.org/job/AvroJava/462/])
AVRO-1536. Ruby: Remove monkeypatching of Enumerable. Contributed by Willem van
Bergen. (martinkl: rev 1607665)
* /avro/trunk/CHANGES.txt
* /avro/trunk/lang/ruby/Manifest
* /avro/trunk/lang/ruby/lib/avro.rb
* /avro/trunk/lang/ruby/lib/avro/collect_hash.rb
* /avro/trunk/lang/ruby/lib/avro/protocol.rb
> Remove monkeypatching of Enumerable
> ---
>
> Key: AVRO-1536
> URL: https://issues.apache.org/jira/browse/AVRO-1536
> Project: Avro
> Issue Type: Improvement
> Components: ruby
>Affects Versions: 1.7.6
>Reporter: Martin Kleppmann
>Assignee: Martin Kleppmann
> Fix For: 1.7.7
>
> Attachments: AVRO-1536.patch
>
>
> The Avro Ruby gem adds a method {{collect_hash}} to the core module
> {{Enumerable}}. It's bad form for a library to extend core modules like this,
> and it's also unnecessary (stdlib methods can do the job perfectly well).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (AVRO-1536) Remove monkeypatching of Enumerable
[
https://issues.apache.org/jira/browse/AVRO-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051550#comment-14051550
]
ASF subversion and git services commented on AVRO-1536:
---
Commit 1607665 from [~martinkl] in branch 'avro/trunk'
[ https://svn.apache.org/r1607665 ]
AVRO-1536. Ruby: Remove monkeypatching of Enumerable. Contributed by Willem van
Bergen.
> Remove monkeypatching of Enumerable
> ---
>
> Key: AVRO-1536
> URL: https://issues.apache.org/jira/browse/AVRO-1536
> Project: Avro
> Issue Type: Improvement
> Components: ruby
>Affects Versions: 1.7.6
>Reporter: Martin Kleppmann
>Assignee: Martin Kleppmann
> Fix For: 1.7.7
>
> Attachments: AVRO-1536.patch
>
>
> The Avro Ruby gem adds a method {{collect_hash}} to the core module
> {{Enumerable}}. It's bad form for a library to extend core modules like this,
> and it's also unnecessary (stdlib methods can do the job perfectly well).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (AVRO-1536) Remove monkeypatching of Enumerable
[
https://issues.apache.org/jira/browse/AVRO-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050222#comment-14050222
]
Willem van Bergen commented on AVRO-1536:
-
Looks good!
> Remove monkeypatching of Enumerable
> ---
>
> Key: AVRO-1536
> URL: https://issues.apache.org/jira/browse/AVRO-1536
> Project: Avro
> Issue Type: Improvement
> Components: ruby
>Affects Versions: 1.7.6
>Reporter: Martin Kleppmann
>Assignee: Martin Kleppmann
> Fix For: 1.7.7
>
> Attachments: AVRO-1536.patch
>
>
> The Avro Ruby gem adds a method {{collect_hash}} to the core module
> {{Enumerable}}. It's bad form for a library to extend core modules like this,
> and it's also unnecessary (stdlib methods can do the job perfectly well).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
