[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965321#comment-15965321
]
ASF subversion and git services commented on AVRO-1688:
---
Commit ff2c83f4406a8c00f9848d6897aec58cfd9e9851 in avro's branch
refs/heads/branch-1.7 from [~twhite]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=ff2c83f ]
AVRO-1688. Ruby test_union(TestIO) is failing.
git-svn-id: https://svn.apache.org/repos/asf/avro/trunk@1690745
13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 74b444929bfdbdd0bcdf45a80dec7b507f805428)
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch, AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624913#comment-14624913
]
Hudson commented on AVRO-1688:
--
SUCCESS: Integrated in AvroJava #531 (See
[https://builds.apache.org/job/AvroJava/531/])
AVRO-1688. Ruby test_union(TestIO) is failing. (tomwhite: rev 1690745)
* /avro/trunk/CHANGES.txt
* /avro/trunk/lang/ruby/test/test_io.rb
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch, AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624877#comment-14624877
]
ASF subversion and git services commented on AVRO-1688:
---
Commit 1690745 from tomwh...@apache.org in branch 'avro/trunk'
[ https://svn.apache.org/r1690745 ]
AVRO-1688. Ruby test_union(TestIO) is failing.
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch, AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624824#comment-14624824
]
Sean Busbey commented on AVRO-1688:
---
+1 LGTM.
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch, AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623245#comment-14623245
]
Sean Busbey commented on AVRO-1688:
---
{quote}
I'm not sure exactly which version it changed in, but it's a problem in later
versions of Ruby (which we should support).
{quote}
it changed in 1.9.1 (which is early in the 1.9 line). agreed that we should be
handling this.
{quote}
Users will only get unexpected results with unions of double and long if they
do equality tests. The semantics of equality between Bignum and Float changed
in Ruby itself, so I don't think we need to make any changes in Avro.
{quote}
I'm not sure I follow. The test looks like it declares a default value for the
union to be an instance of the double type. It then makes a record that relies
on that default and finds that the values are not equal. Shouldn't both of them
be Float?
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623242#comment-14623242
]
Tom White commented on AVRO-1688:
-
Users will only get unexpected results with unions of double and long if they
do equality tests. The semantics of equality between Bignum and Float changed
in Ruby itself, so I don't think we need to make any changes in Avro.
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623240#comment-14623240
]
Tom White commented on AVRO-1688:
-
I'm not sure exactly which version it changed in, but it's a problem in later
versions of Ruby (which we should support).
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623239#comment-14623239
]
Sean Busbey commented on AVRO-1688:
---
the updated test passes, but doesn't this mask a problem we still have in the
ruby impl for Ruby 1.9.1+? That is, won't users who have unions of double long
still get unexpected results?
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623238#comment-14623238
]
Sean Busbey commented on AVRO-1688:
---
is this still a problem after we went back to ruby 1.8+?
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620629#comment-14620629
]
Tom White commented on AVRO-1688:
-
[~busbey] would you be able to have a look at this one please?
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616783#comment-14616783
]
Tom White commented on AVRO-1688:
-
With this fix all tests are passing in the Docker container.
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing
[
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601284#comment-14601284
]
Tom White commented on AVRO-1688:
-
This occurs when testing a {{\["double", "long"\]}} union with random data.
> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Tom White
> Fix For: 1.7.8
>
>
> The failure message is
> {noformat}
> 1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
