[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051492#comment-16051492
 ] 

ASF GitHub Bot commented on AVRO-1971:
--

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/175


> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051491#comment-16051491
 ] 

ASF subversion and git services commented on AVRO-1971:
---

Commit edd8edda0659f802e203e36bcb9d8ec51d821f26 in avro's branch 
refs/heads/master from [~baunz]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=edd8edd ]

AVRO-1971: Allow alias annotation on fields

This closes #175


> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[Gabor Szadovszky (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050112#comment-16050112
 ] 

Gabor Szadovszky commented on AVRO-1971:


Thanks a lot, [~baunz]. It looks great.
I have some minor comments in the PR. I'll try to commit it tomorrow if there 
are no more objections.

> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[Johannes Schulte (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049657#comment-16049657
 ] 

Johannes Schulte commented on AVRO-1971:


I added this functionality and a corresponding test case

> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[Gabor Szadovszky (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048807#comment-16048807
 ] 

Gabor Szadovszky commented on AVRO-1971:


Thanks [~baunz] for taking care of this issue.
I agree that based on the spec namespaces for field aliases shall not be 
allowed. Therefore, I would expect some error handling for the case of the 
space is specified.

> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[Johannes Schulte (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864384#comment-15864384
 ] 

Johannes Schulte commented on AVRO-1971:


Does anybody have an opinion or objection? One thing I am thinking about is if 
an error should be thrown when the namespace field of the annotation is used - 
field aliases are not allowed to contain a namespace quaifier if I understand 
the specification correctly.

> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Assignee: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762183#comment-15762183
 ] 

ASF GitHub Bot commented on AVRO-1971:
--

GitHub user baunz opened a pull request:

https://github.com/apache/avro/pull/175

Allow alias annotation on fields

Sorry for the confusion, here's the f(fow now) final pul request to this 
issue I created:

https://issues.apache.org/jira/browse/AVRO-1971

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baunz/avro AVRO-1971-AvroAlias-On-Fields

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #175


commit ea94c703e6df801d6832cf1167a9b326a87af83a
Author: baunz 
Date:   2016-12-18T20:48:33Z

Allow alias annotation on fields




> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762174#comment-15762174
 ] 

ASF GitHub Bot commented on AVRO-1971:
--

Github user baunz closed the pull request at:

https://github.com/apache/avro/pull/174


> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1971) AvroAlias Annotation should work on field elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762171#comment-15762171
 ] 

ASF GitHub Bot commented on AVRO-1971:
--

GitHub user baunz opened a pull request:

https://github.com/apache/avro/pull/174

Allow alias annotation on fields

See https://issues.apache.org/jira/browse/AVRO-1971

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baunz/avro AVRO-1971-AvroAlias-On-Fields

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #174


commit fdbf13551ddebd6fd814d6cd4d3cb3645663a21a
Author: baunz 
Date:   2016-12-18T20:48:33Z

Allow alias annotation on fields




> AvroAlias Annotation should work on field elements
> --
>
> Key: AVRO-1971
> URL: https://issues.apache.org/jira/browse/AVRO-1971
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Johannes Schulte
>Priority: Minor
>
> @AvroAlias annotation works only for records / classes but not for fields 
> when using ReflectData-generated schemas. The specification allows aliases 
> for comple types AND for fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)