[jira] [Commented] (AVRO-2189) Missing closing quotation in SchemaBuilder docstring

2018-06-13 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511634#comment-16511634
 ] 

ASF GitHub Bot commented on AVRO-2189:
--

a-hacker opened a new pull request #315: AVRO-2189: Fix typo in SchemaBuilder 
example
URL: https://github.com/apache/avro/pull/315
 
 
   Added missing quotation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Missing closing quotation in SchemaBuilder docstring
> 
>
> Key: AVRO-2189
> URL: https://issues.apache.org/jira/browse/AVRO-2189
> Project: Avro
>  Issue Type: Bug
>Reporter: Austin Hacker
>Priority: Trivial
>
> org.apache.avro.SchemaBuilder has a typo in its docstring.
> {noformat}
> .namespace("org.apache.avro.ipc){noformat}
> should be
> {noformat}
> .namespace("org.apache.avro.ipc"){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AVRO-2189) Missing closing quotation in SchemaBuilder docstring

2018-06-15 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513691#comment-16513691
 ] 

ASF GitHub Bot commented on AVRO-2189:
--

nandorKollar closed pull request #315: AVRO-2189: Fix typo in SchemaBuilder 
example
URL: https://github.com/apache/avro/pull/315
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java 
b/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java
index 579ecd0b5..b8b11539b 100644
--- a/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java
+++ b/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java
@@ -62,7 +62,7 @@
  *
  * 
  *   Schema schema = SchemaBuilder
- *   .record("HandshakeRequest").namespace("org.apache.avro.ipc)
+ *   .record("HandshakeRequest").namespace("org.apache.avro.ipc")
  *   .fields()
  * .name("clientHash").type().fixed("MD5").size(16).noDefault()
  * .name("clientProtocol").type().nullable().stringType().noDefault()


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Missing closing quotation in SchemaBuilder docstring
> 
>
> Key: AVRO-2189
> URL: https://issues.apache.org/jira/browse/AVRO-2189
> Project: Avro
>  Issue Type: Bug
>Reporter: Austin Hacker
>Priority: Trivial
>
> org.apache.avro.SchemaBuilder has a typo in its docstring.
> {noformat}
> .namespace("org.apache.avro.ipc){noformat}
> should be
> {noformat}
> .namespace("org.apache.avro.ipc"){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AVRO-2189) Missing closing quotation in SchemaBuilder docstring

2018-06-15 Thread Nandor Kollar (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513711#comment-16513711
 ] 

Nandor Kollar commented on AVRO-2189:
-

Merged to master, thanks for fixing this!

> Missing closing quotation in SchemaBuilder docstring
> 
>
> Key: AVRO-2189
> URL: https://issues.apache.org/jira/browse/AVRO-2189
> Project: Avro
>  Issue Type: Bug
>Reporter: Austin Hacker
>Assignee: Austin Hacker
>Priority: Trivial
> Fix For: 1.9.0
>
>
> org.apache.avro.SchemaBuilder has a typo in its docstring.
> {noformat}
> .namespace("org.apache.avro.ipc){noformat}
> should be
> {noformat}
> .namespace("org.apache.avro.ipc"){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)