[jira] [Commented] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint

2021-09-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414533#comment-17414533
 ] 

ASF subversion and git services commented on AVRO-3150:
---

Commit 79a1ae9dc81873cfd767a23003846bea0f51c936 in avro's branch 
refs/heads/dependabot/nuget/lang/csharp/System.Reflection.Emit.Lightweight-4.7.0
 from Daniel Kulp
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=79a1ae9 ]

[AVRO-3150] Allow different lf styles.


> Checkstyle requires LF line endings: add .gitattributes hint
> 
>
> Key: AVRO-3150
> URL: https://issues.apache.org/jira/browse/AVRO-3150
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.10.2
>Reporter: Ryan
>Assignee: Daniel Kulp
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Running the Java unit tests on a Windows machine with the commonly configured 
> git line ending configuration:
> {quote}{{git config --global core.autocrlf true}}
> {quote}
> Results in test failure of:
> {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but 
> CRLF(\r\n) is detected.}}
> {quote}
> This is due to a checkstyle rule.   If the unit tests require LF line endings 
> then it would be helpful to add a .gitattributes file to automatically ensure 
> the correct line endings are used on git clone.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint

2021-09-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414531#comment-17414531
 ] 

ASF subversion and git services commented on AVRO-3150:
---

Commit 79a1ae9dc81873cfd767a23003846bea0f51c936 in avro's branch 
refs/heads/dependabot/nuget/lang/csharp/System.Reflection.Emit.ILGeneration-4.7.0
 from Daniel Kulp
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=79a1ae9 ]

[AVRO-3150] Allow different lf styles.


> Checkstyle requires LF line endings: add .gitattributes hint
> 
>
> Key: AVRO-3150
> URL: https://issues.apache.org/jira/browse/AVRO-3150
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.10.2
>Reporter: Ryan
>Assignee: Daniel Kulp
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Running the Java unit tests on a Windows machine with the commonly configured 
> git line ending configuration:
> {quote}{{git config --global core.autocrlf true}}
> {quote}
> Results in test failure of:
> {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but 
> CRLF(\r\n) is detected.}}
> {quote}
> This is due to a checkstyle rule.   If the unit tests require LF line endings 
> then it would be helpful to add a .gitattributes file to automatically ensure 
> the correct line endings are used on git clone.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint

2021-09-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414479#comment-17414479
 ] 

ASF subversion and git services commented on AVRO-3150:
---

Commit 79a1ae9dc81873cfd767a23003846bea0f51c936 in avro's branch 
refs/heads/master from Daniel Kulp
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=79a1ae9 ]

[AVRO-3150] Allow different lf styles.


> Checkstyle requires LF line endings: add .gitattributes hint
> 
>
> Key: AVRO-3150
> URL: https://issues.apache.org/jira/browse/AVRO-3150
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.10.2
>Reporter: Ryan
>Priority: Major
>
> Running the Java unit tests on a Windows machine with the commonly configured 
> git line ending configuration:
> {quote}{{git config --global core.autocrlf true}}
> {quote}
> Results in test failure of:
> {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but 
> CRLF(\r\n) is detected.}}
> {quote}
> This is due to a checkstyle rule.   If the unit tests require LF line endings 
> then it would be helpful to add a .gitattributes file to automatically ensure 
> the correct line endings are used on git clone.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint

2021-05-24 Thread Ryan (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350568#comment-17350568
 ] 

Ryan commented on AVRO-3150:


https://github.com/apache/avro/pull/1236

> Checkstyle requires LF line endings: add .gitattributes hint
> 
>
> Key: AVRO-3150
> URL: https://issues.apache.org/jira/browse/AVRO-3150
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.10.2
>Reporter: Ryan
>Priority: Major
>
> Running the Java unit tests on a Windows machine with the commonly configured 
> git line ending configuration:
> {quote}{{git config --global core.autocrlf true}}
> {quote}
> Results in test failure of:
> {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but 
> CRLF(\r\n) is detected.}}
> {quote}
> This is due to a checkstyle rule.   If the unit tests require LF line endings 
> then it would be helpful to add a .gitattributes file to automatically ensure 
> the correct line endings are used on git clone.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)