Re: [VOTE] Avro release 1.6.2 (rc 1)

[Philip Zeyliger]

On Tue, Feb 14, 2012 at 5:34 PM, Douglas Creager wrote:

> > For those interested, here's the test failure.
> >
> > [0]air::tests(276231)$./test_avro_values
> >  Running boolean tests 
> > | 00 .. .. .. .. .. .. .. | .. .. .. .. .. .. .. .. | 
> > | 01 .. .. .. .. .. .. .. | .. .. .. .. .. .. .. .. | 
> >  Running bytes tests 
> > | 08 DE AD BE EF .. .. .. | .. .. .. .. .. .. .. .. | .^->o...
> > Incorrect sort order
>
> Thanks for the transcript.  I'm going to open an issue for this, but it
> definitely doesn't need to be a blocker for 1.6.2.  The issue is that
> memcmp on Oneiric returns "some negative value" for the less-than case, but
> that unit test expects it to specifically return -1.


Got it; thanks for looking into it.  Glad it's straight-forward.

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Douglas Creager]

> For those interested, here's the test failure.
> 
> [0]air::tests(276231)$./test_avro_values
>  Running boolean tests 
> | 00 .. .. .. .. .. .. .. | .. .. .. .. .. .. .. .. | 
> | 01 .. .. .. .. .. .. .. | .. .. .. .. .. .. .. .. | 
>  Running bytes tests 
> | 08 DE AD BE EF .. .. .. | .. .. .. .. .. .. .. .. | .^->o...
> Incorrect sort order

Thanks for the transcript.  I'm going to open an issue for this, but it 
definitely doesn't need to be a blocker for 1.6.2.  The issue is that memcmp on 
Oneiric returns "some negative value" for the less-than case, but that unit 
test expects it to specifically return -1.

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Doug Cutting]

This passes, with 3 +1 votes from PMC members and no -1 votes.

I'll publish the release.

Thanks!

Doug

On 02/09/2012 04:06 PM, Doug Cutting wrote:
> I have created a new candidate build for Avro release 1.6.2.
> 
> Changes are listed at:
> 
>   http://s.apache.org/4u3
> 
> Please download, test, and vote.
> 
>   http://people.apache.org/~cutting/avro-1.6.2-rc1/
> 
> The Maven staging repository is at:
> 
>   https://repository.apache.org/content/repositories/orgapacheavro-214/
> 
> Thanks in advance for voting!
> 
> Doug

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Philip Zeyliger]

I'm +1 on the release based on java unit tests passing.

For those interested, here's the test failure.

[0]air::tests(276231)$./test_avro_values
 Running boolean tests 
| 00 .. .. .. .. .. .. .. | .. .. .. .. .. .. .. .. | 
| 01 .. .. .. .. .. .. .. | .. .. .. .. .. .. .. .. | 
 Running bytes tests 
| 08 DE AD BE EF .. .. .. | .. .. .. .. .. .. .. .. | .^->o...
Incorrect sort order


On Tue, Feb 14, 2012 at 2:18 PM, Doug Cutting  wrote:

> On 02/14/2012 02:05 PM, Philip Zeyliger wrote:
> >> Is this a regression?  Do 1.6.1 tests pass on your machine?
> >
> > They do not; the same test fails.
>
> Thanks for checking!
>
> If it's not a regression then it shouldn't be a blocker.
>
> Doug
>

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Doug Cutting]

On 02/14/2012 02:05 PM, Philip Zeyliger wrote:
>> Is this a regression?  Do 1.6.1 tests pass on your machine?
> 
> They do not; the same test fails.

Thanks for checking!

If it's not a regression then it shouldn't be a blocker.

Doug

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Douglas Creager]

> They do not; the same test fails.  I'm not familiar with the cmake system
> here; is there a file where the test output goes?

You can do

  $ ctest --output-on-failure

which will print out the stdout and stderr of any failed test.  Alternatively, 
the tests are just statically linked executables in your $BUILD_DIR/tests 
directory, which if you're using build.sh, ends up being 
$SVN_ROOT/build/c/tests.  So you can execute those commands directly:

  $ build/c/tests/test_avro_values

–doug

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Philip Zeyliger]

On Tue, Feb 14, 2012 at 1:58 PM, Doug Cutting  wrote:

> On 02/14/2012 01:35 PM, Philip Zeyliger wrote:
> > I had trouble with the C unit tests (I ran "./build.sh test" on ubuntu
> > oneiric).
>
> Is this a regression?  Do 1.6.1 tests pass on your machine?
>
> http://www.apache.org/dyn/closer.cgi/avro/avro-1.6.1/


They do not; the same test fails.  I'm not familiar with the cmake system
here; is there a file where the test output goes?

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Doug Cutting]

On 02/14/2012 01:35 PM, Philip Zeyliger wrote:
> I had trouble with the C unit tests (I ran "./build.sh test" on ubuntu
> oneiric).

Is this a regression?  Do 1.6.1 tests pass on your machine?

http://www.apache.org/dyn/closer.cgi/avro/avro-1.6.1/

Thanks!

Doug

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Scott Carey]

FWIW, this is my output of C tests, from Mac OSX 10.6.8  (Snow Leopard).

[100%] Built target index_html
Running tests...
Test project /Users/scottc/avro/1.6.2-rc1/avro-src-1.6.2/build/c
Start 1: quickstop
1/9 Test #1: quickstop    Passed0.38 sec
Start 2: test_data_structures
2/9 Test #2: test_data_structures .   Passed0.01 sec
Start 3: test_avro_schema
3/9 Test #3: test_avro_schema .   Passed0.05 sec
Start 4: test_avro_schema_names
4/9 Test #4: test_avro_schema_names ...   Passed0.01 sec
Start 5: test_avro_values
5/9 Test #5: test_avro_values .   Passed0.59 sec
Start 6: test_avro_968
6/9 Test #6: test_avro_968    Passed0.02 sec
Start 7: test_avro_984
7/9 Test #7: test_avro_984    Passed0.02 sec
Start 8: test_avro_data
8/9 Test #8: test_avro_data ...   Passed0.20 sec
Start 9: test_cpp
9/9 Test #9: test_cpp .   Passed0.02 sec

100% tests passed, 0 tests failed out of 9





On 2/14/12 1:35 PM, "Philip Zeyliger"  wrote:

>-0 for now
>
>I had trouble with the C unit tests (I ran "./build.sh test" on ubuntu
>oneiric).  Are other folks having trouble?  The java unit tests work.
>
>Running tests...
>Test project /home/philip/Downloads/avro-src-1.6.2/build/c
>Start 1: quickstop
>1/9 Test #1: quickstop    Passed0.16 sec
>Start 2: test_data_structures
>2/9 Test #2: test_data_structures .   Passed0.01 sec
>Start 3: test_avro_schema
>3/9 Test #3: test_avro_schema .   Passed0.01 sec
>Start 4: test_avro_schema_names
>4/9 Test #4: test_avro_schema_names ...   Passed0.01 sec
>Start 5: test_avro_values
>5/9 Test #5: test_avro_values .***Failed0.01 sec
>Start 6: test_avro_968
>6/9 Test #6: test_avro_968    Passed0.01 sec
>Start 7: test_avro_984
>7/9 Test #7: test_avro_984    Passed0.01 sec
>Start 8: test_avro_data
>8/9 Test #8: test_avro_data ...   Passed0.06 sec
>Start 9: test_cpp
>9/9 Test #9: test_cpp .   Passed0.01 sec
>
>89% tests passed, 1 tests failed out of 9
>
>Total Test time (real) =   0.64 sec
>
>The following tests FAILED:
>  5 - test_avro_values (Failed)
>Errors while running CTest
>
>
>
>On Tue, Feb 14, 2012 at 1:24 PM, Scott Carey
>wrote:
>
>> +1
>>
>> Checksums match.  Src tarball builds and tests pass.
>>
>> Integrated my applications with the test maven repo, they compile and
>>pass
>> tests with the new version.
>>
>> On 2/9/12 4:06 PM, "Doug Cutting"  wrote:
>>
>> >I have created a new candidate build for Avro release 1.6.2.
>> >
>> >Changes are listed at:
>> >
>> >  http://s.apache.org/4u3
>> >
>> >Please download, test, and vote.
>> >
>> >  http://people.apache.org/~cutting/avro-1.6.2-rc1/
>> >
>> >The Maven staging repository is at:
>> >
>> >  https://repository.apache.org/content/repositories/orgapacheavro-214/
>> >
>> >Thanks in advance for voting!
>> >
>> >Doug
>>
>>

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Philip Zeyliger]

-0 for now

I had trouble with the C unit tests (I ran "./build.sh test" on ubuntu
oneiric).  Are other folks having trouble?  The java unit tests work.

Running tests...
Test project /home/philip/Downloads/avro-src-1.6.2/build/c
Start 1: quickstop
1/9 Test #1: quickstop    Passed0.16 sec
Start 2: test_data_structures
2/9 Test #2: test_data_structures .   Passed0.01 sec
Start 3: test_avro_schema
3/9 Test #3: test_avro_schema .   Passed0.01 sec
Start 4: test_avro_schema_names
4/9 Test #4: test_avro_schema_names ...   Passed0.01 sec
Start 5: test_avro_values
5/9 Test #5: test_avro_values .***Failed0.01 sec
Start 6: test_avro_968
6/9 Test #6: test_avro_968    Passed0.01 sec
Start 7: test_avro_984
7/9 Test #7: test_avro_984    Passed0.01 sec
Start 8: test_avro_data
8/9 Test #8: test_avro_data ...   Passed0.06 sec
Start 9: test_cpp
9/9 Test #9: test_cpp .   Passed0.01 sec

89% tests passed, 1 tests failed out of 9

Total Test time (real) =   0.64 sec

The following tests FAILED:
  5 - test_avro_values (Failed)
Errors while running CTest



On Tue, Feb 14, 2012 at 1:24 PM, Scott Carey wrote:

> +1
>
> Checksums match.  Src tarball builds and tests pass.
>
> Integrated my applications with the test maven repo, they compile and pass
> tests with the new version.
>
> On 2/9/12 4:06 PM, "Doug Cutting"  wrote:
>
> >I have created a new candidate build for Avro release 1.6.2.
> >
> >Changes are listed at:
> >
> >  http://s.apache.org/4u3
> >
> >Please download, test, and vote.
> >
> >  http://people.apache.org/~cutting/avro-1.6.2-rc1/
> >
> >The Maven staging repository is at:
> >
> >  https://repository.apache.org/content/repositories/orgapacheavro-214/
> >
> >Thanks in advance for voting!
> >
> >Doug
>
>

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Scott Carey]

+1

Checksums match.  Src tarball builds and tests pass.

Integrated my applications with the test maven repo, they compile and pass
tests with the new version.

On 2/9/12 4:06 PM, "Doug Cutting"  wrote:

>I have created a new candidate build for Avro release 1.6.2.
>
>Changes are listed at:
>
>  http://s.apache.org/4u3
>
>Please download, test, and vote.
>
>  http://people.apache.org/~cutting/avro-1.6.2-rc1/
>
>The Maven staging repository is at:
>
>  https://repository.apache.org/content/repositories/orgapacheavro-214/
>
>Thanks in advance for voting!
>
>Doug

Re: [VOTE] Avro release 1.6.2 (rc 1)

[James Baldassari]

Sounds good, Doug.  Thanks.

-James


On Mon, Feb 13, 2012 at 12:42 PM, Doug Cutting  wrote:

> On 02/10/2012 11:50 PM, James Baldassari wrote:
> >  AVRO-1027 just came
> in a
> > few hours ago with a patch.  I reviewed and tested it, and it looks good.
> > Any chance we could roll a new 1.6.2 rc with this patch?
>
> If we get two more +1 votes from the PMC today then we can release 1.6.2
> today.  I'd rather not restart that vote now.  If we restart votes every
> time a bug is identified then it's hard to get releases out.
>
> We can always roll a 1.6.3 candidate later this week and start that vote
> once AVRO-1027 is committed.  There are a few other issues which are
> nearly ready to commit that might make it too.
>
> So, in summary, I'm happy to roll another relase candidate and call
> another vote this week.  If the 1.6.2 vote never passes then we'll call
> this week's release 1.6.2, otherwise it'd be called 1.6.3.  It's better
> to have more releases than fewer.
>
> Doug
>

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Doug Cutting]

On 02/10/2012 11:50 PM, James Baldassari wrote:
>  AVRO-1027 just came in a
> few hours ago with a patch.  I reviewed and tested it, and it looks good.
> Any chance we could roll a new 1.6.2 rc with this patch?

If we get two more +1 votes from the PMC today then we can release 1.6.2
today.  I'd rather not restart that vote now.  If we restart votes every
time a bug is identified then it's hard to get releases out.

We can always roll a 1.6.3 candidate later this week and start that vote
once AVRO-1027 is committed.  There are a few other issues which are
nearly ready to commit that might make it too.

So, in summary, I'm happy to roll another relase candidate and call
another vote this week.  If the 1.6.2 vote never passes then we'll call
this week's release 1.6.2, otherwise it'd be called 1.6.3.  It's better
to have more releases than fewer.

Doug

Re: [VOTE] Avro release 1.6.2 (rc 1)

[James Baldassari]

 AVRO-1027 just came in a
few hours ago with a patch.  I reviewed and tested it, and it looks good.
Any chance we could roll a new 1.6.2 rc with this patch?

-James


On Fri, Feb 10, 2012 at 6:21 PM, Doug Cutting  wrote:

> +1
>
> Downloaded source tarball.  Checksums and signature are correct.  All
> tests passed.  Rat finds no license issues.
>
> Doug
>
> On 02/09/2012 04:06 PM, Doug Cutting wrote:
> > I have created a new candidate build for Avro release 1.6.2.
> >
> > Changes are listed at:
> >
> >   http://s.apache.org/4u3
> >
> > Please download, test, and vote.
> >
> >   http://people.apache.org/~cutting/avro-1.6.2-rc1/
> >
> > The Maven staging repository is at:
> >
> >   https://repository.apache.org/content/repositories/orgapacheavro-214/
> >
> > Thanks in advance for voting!
> >
> > Doug
>

Re: [VOTE] Avro release 1.6.2 (rc 1)

[Doug Cutting]

+1

Downloaded source tarball.  Checksums and signature are correct.  All
tests passed.  Rat finds no license issues.

Doug

On 02/09/2012 04:06 PM, Doug Cutting wrote:
> I have created a new candidate build for Avro release 1.6.2.
> 
> Changes are listed at:
> 
>   http://s.apache.org/4u3
> 
> Please download, test, and vote.
> 
>   http://people.apache.org/~cutting/avro-1.6.2-rc1/
> 
> The Maven staging repository is at:
> 
>   https://repository.apache.org/content/repositories/orgapacheavro-214/
> 
> Thanks in advance for voting!
> 
> Doug