Re: JIRA components

2020-09-17 Thread Kenneth Knowles 
What does it mean?

Kenn

On Thu, Sep 17, 2020 at 6:18 PM Udi Meiri  wrote:

> Hi, I was going to create a Python types component in our JIRA.
> (sdk-py-types)
> Any objections?
>

JIRA components

2020-09-17 Thread Udi Meiri 
Hi, I was going to create a Python types component in our JIRA.
(sdk-py-types)
Any objections?


smime.p7s
Description: S/MIME Cryptographic Signature

Re: Semantic versioning

2020-09-17 Thread Ahmet Altay 
Did we end up updating the documentation (in [1] and elsewhere)? There was
a (not major but still) breaking change in python related to typehints in
2.24.0 release [2].

/cc +Udi Meiri 

[1] https://beam.apache.org/get-started/downloads/
[2]
https://github.com/apache/beam/pull/12745/commits/222cd448fe0262fcc5557186b58013ec7bf26622

On Thu, Jun 4, 2020 at 5:07 PM Robert Bradshaw  wrote:

> That tool is looks great; we should use it more often! (In fact, there's a
> pending RC right now :). It looks like we don't generally do too bad, but
> can help prevent accidental slippage.
>
> As for whether we should provide semantic versioning, that's a really
> difficult question. I don't think Beam is at a point that we can or should
> provide 100% semantic versioning, but exceptions should be few and far
> between, and hopefully appropriately called out. Technically bugfixes can
> be "backwards incompatible" and I think discouraging/disallowing dangerous
> (or unexpected) behavior can also be fair game. @Experimental annotations
> can be useful, but when something has that label for years I think it
> loses its meaning.
>
> If we're claiming strict semantic versioning, we should update that, or at
> least add some caveats.
>
>
> On Fri, May 29, 2020 at 9:57 PM Kenneth Knowles  wrote:
>
>> Ismaël, this is awesome!! Can we incorporate it into our processes? No
>> matter what our policy, this is great data. (FWIW also we hit 100%
>> compatibility a lot of the time... so there! :-p)
>>
>> But anyhow I completely agree that strict semver is too hard and not
>> valuable enough. I think we should use semver "in spirit". We "basically"
>> and "mostly" and "most reasonably" expect to not break users when they
>> upgrade minor versions. And patch versions are irrelevant but if we
>> released one, they "should" also be reversible without breakage.
>>
>> To add my own spin on Ismaël's point about treating this as a tradeoff,
>> backwards compatibility is always more vague than it seems at first, and
>> usually prioritized wrong IMO.
>>
>>  - Breaking someone's compile is usually easy to detect (hence can be
>> automated) but also usually easy to fix so the user burden is minimal
>> except when you are a diamond dependency (and then semver doesn't help,
>> because transitive deps will not have compatible major versions... see
>> Guava or Protobuf)
>>  - Breaking someone via a runtime error is a bigger deal. It happens
>> often, of course, and we fix it pretty urgently.
>>  - Breaking someone via a performance degradation is just as broken, but
>> hard to repro if it isn't widespread. We may never fix them.
>>  - Breaking someone via giving a wrong answer is the worst possible
>> breakage. It is silent, looks fine, and simply breaks their results.
>>  - Breaking someone via upgrading a transitive dep where there is a
>> backwards-incompatible change somewhere deep is often unfixable.
>>  - Breaking someone via turning down a version of the client library.
>> Cloud providers do this because they cannot afford not to. Services have
>> shorter lifespans than shipped libraries (notably the opposite for
>> build-every-time libraries).
>>  - Breaking someone via keeping transitive deps stable, hence transitive
>> services turn down versions of their client library. This is a direct
>> conflict between "shipped library" style compatibility guarantees and
>> "service" style compatibility guarantees.
>>  - Breaking someone via some field they found via reflection, or
>> sdk/util, or context.stateInternals, or Python where private stuff sort of
>> exist but not really, and > limitations>. Really, only having very strict documentation can define a
>> supported API surface, and we are not even close to having this. And even
>> if we had it, IDEs would autocomplete things we don't want them to. This is
>> pretty hard.
>>
>> Examples where I am not that happy with how Beam went:
>>
>>  - https://s.apache.org/finishing-triggers-drop-data: Because it was a
>> construction-time breaking change, this was pushed back for years, even
>> though leaving it in caused data loss. (based on the StackOverflow and
>> email volume for this, plenty of users had finishing triggers)
>>  - https://issues.apache.org/jira/browse/BEAM-6906: mutable accumulators
>> are unsafe to use unless cloned, given our CombineFn API and standard
>> fusion techniques. We introduced a new API and documented that users should
>> probably use it, leaving the data loss risk in place to avoid a compile
>> time breaking change. It is still there.
>>  - Beam 2.0.0: we waited a long time to have a first "stable" release,
>> and rushed to make all the breaking changes, because we were going to
>> freeze everything forever. It is bad to wait for a long time and also bad
>> to rush in the breakages.
>>  - Beam 0.x: we only get to do it once. That is a mistake. Between 2.x.y
>> and 3.0.0 you need a period to mature the breaking APIs. You need a "0.x"
>> period in between each major version

Re: [ANNOUNCE] New committer: Reza Ardeshir Rokni

2020-09-17 Thread Michał Walenia 
Congratulations, Reza!

On Thu, Sep 17, 2020 at 11:43 AM Gleb Kanterov  wrote:

> Congratulations!
>
> On Tue, Sep 15, 2020 at 5:44 PM Ismaël Mejía  wrote:
>
>> Congratulations Reza, well done !
>>
>> On Mon, Sep 14, 2020 at 10:10 AM Katarzyna Kucharczyk
>>  wrote:
>> >
>> > Congratulations Reza! :)
>> >
>> > On Mon, Sep 14, 2020 at 10:05 AM Alexey Romanenko <
>> aromanenko@gmail.com> wrote:
>> >>
>> >> Congratulations! Thanks Reza for your contributions!
>> >>
>> >> On 12 Sep 2020, at 10:00, Jan Lukavský  wrote:
>> >>
>> >> Congrats Reza!
>> >>
>> >> On 9/12/20 5:29 AM, Thomas Weise wrote:
>> >>
>> >> Congratulations!
>> >>
>> >>
>> >> On Fri, Sep 11, 2020, 5:54 PM Andrew Psaltis 
>> wrote:
>> >>>
>> >>> Congrats!
>> >>>
>> >>> On Sat, Sep 12, 2020 at 7:43 AM Reza Rokni  wrote:
>> 
>>  Thanx everyone! Looking forward to being able to contribute more :-)
>> 
>>  On Sat, Sep 12, 2020 at 4:33 AM Valentyn Tymofieiev <
>> valen...@google.com> wrote:
>> >
>> > Congrats!
>> >
>> > On Thu, Sep 10, 2020 at 8:08 PM Connell O'Callaghan <
>> conne...@google.com> wrote:
>> >>
>> >> Excellent- well done Reza!!!
>> >>
>> >> On Thu, Sep 10, 2020 at 7:35 PM Austin Bennett <
>> whatwouldausti...@gmail.com> wrote:
>> >>>
>> >>> Thanks and congrats, Reza!
>> >>>
>> >>> On Thu, Sep 10, 2020 at 5:48 PM Heejong Lee 
>> wrote:
>> 
>>  Congratulations!
>> 
>>  On Thu, Sep 10, 2020 at 4:42 PM Robert Bradshaw <
>> rober...@google.com> wrote:
>> >
>> > Thank you and welcome, Reza!
>> >
>> > On Thu, Sep 10, 2020 at 4:00 PM Ahmet Altay 
>> wrote:
>> >>
>> >> Congratulations Reza! And thank you for your contributions!
>> >>
>> >> On Thu, Sep 10, 2020 at 3:59 PM Chamikara Jayalath <
>> chamik...@google.com> wrote:
>> >>>
>> >>> Congrats Reza!
>> >>>
>> >>> On Thu, Sep 10, 2020 at 10:35 AM Kenneth Knowles <
>> k...@apache.org> wrote:
>> 
>>  Hi all,
>> 
>>  Please join me and the rest of the Beam PMC in welcoming a
>> new committer: Reza Ardeshir Rokni.
>> 
>>  Reza has been part of the Beam community since 2017! Reza
>> has spearheaded advanced Beam examples [1], blogged and presented at
>> multiple Beam Summits. Reza helps out users on the mailing lists [2] and
>> StackOverflow [3]. When Reza's work uncovers a missing feature in Beam, he
>> adds it [4]. Considering these contributions, the Beam PMC trusts Reza with
>> the responsibilities of a Beam committer [5].
>> 
>>  Thank you, Reza, for your contributions.
>> 
>>  Kenn
>> 
>>  [1] https://github.com/apache/beam/pull/3961
>>  [2]
>> https://lists.apache.org/list.html?u...@beam.apache.org:gte=0d:reza%20rokni
>>  [3] https://stackoverflow.com/tags/apache-beam/topusers
>>  [4] https://github.com/apache/beam/pull/11929
>>  [5]
>> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>> 
>> 
>> >>>
>> >>>
>> >>
>> >>
>> >
>> >
>> 
>> 
>> >>>
>> >>>
>> >> --
>> >> Your feedback welcomed for Connello!!!
>> >>
>> >>
>>
>

-- 

Michał Walenia
Polidea  | Software Engineer

M: +48 791 432 002 <+48791432002>
E: michal.wale...@polidea.com

Unique Tech
Check out our projects!

Re: [ANNOUNCE] New committer: Reza Ardeshir Rokni

2020-09-17 Thread Gleb Kanterov 
Congratulations!

On Tue, Sep 15, 2020 at 5:44 PM Ismaël Mejía  wrote:

> Congratulations Reza, well done !
>
> On Mon, Sep 14, 2020 at 10:10 AM Katarzyna Kucharczyk
>  wrote:
> >
> > Congratulations Reza! :)
> >
> > On Mon, Sep 14, 2020 at 10:05 AM Alexey Romanenko <
> aromanenko@gmail.com> wrote:
> >>
> >> Congratulations! Thanks Reza for your contributions!
> >>
> >> On 12 Sep 2020, at 10:00, Jan Lukavský  wrote:
> >>
> >> Congrats Reza!
> >>
> >> On 9/12/20 5:29 AM, Thomas Weise wrote:
> >>
> >> Congratulations!
> >>
> >>
> >> On Fri, Sep 11, 2020, 5:54 PM Andrew Psaltis 
> wrote:
> >>>
> >>> Congrats!
> >>>
> >>> On Sat, Sep 12, 2020 at 7:43 AM Reza Rokni  wrote:
> 
>  Thanx everyone! Looking forward to being able to contribute more :-)
> 
>  On Sat, Sep 12, 2020 at 4:33 AM Valentyn Tymofieiev <
> valen...@google.com> wrote:
> >
> > Congrats!
> >
> > On Thu, Sep 10, 2020 at 8:08 PM Connell O'Callaghan <
> conne...@google.com> wrote:
> >>
> >> Excellent- well done Reza!!!
> >>
> >> On Thu, Sep 10, 2020 at 7:35 PM Austin Bennett <
> whatwouldausti...@gmail.com> wrote:
> >>>
> >>> Thanks and congrats, Reza!
> >>>
> >>> On Thu, Sep 10, 2020 at 5:48 PM Heejong Lee 
> wrote:
> 
>  Congratulations!
> 
>  On Thu, Sep 10, 2020 at 4:42 PM Robert Bradshaw <
> rober...@google.com> wrote:
> >
> > Thank you and welcome, Reza!
> >
> > On Thu, Sep 10, 2020 at 4:00 PM Ahmet Altay 
> wrote:
> >>
> >> Congratulations Reza! And thank you for your contributions!
> >>
> >> On Thu, Sep 10, 2020 at 3:59 PM Chamikara Jayalath <
> chamik...@google.com> wrote:
> >>>
> >>> Congrats Reza!
> >>>
> >>> On Thu, Sep 10, 2020 at 10:35 AM Kenneth Knowles <
> k...@apache.org> wrote:
> 
>  Hi all,
> 
>  Please join me and the rest of the Beam PMC in welcoming a
> new committer: Reza Ardeshir Rokni.
> 
>  Reza has been part of the Beam community since 2017! Reza has
> spearheaded advanced Beam examples [1], blogged and presented at multiple
> Beam Summits. Reza helps out users on the mailing lists [2] and
> StackOverflow [3]. When Reza's work uncovers a missing feature in Beam, he
> adds it [4]. Considering these contributions, the Beam PMC trusts Reza with
> the responsibilities of a Beam committer [5].
> 
>  Thank you, Reza, for your contributions.
> 
>  Kenn
> 
>  [1] https://github.com/apache/beam/pull/3961
>  [2]
> https://lists.apache.org/list.html?u...@beam.apache.org:gte=0d:reza%20rokni
>  [3] https://stackoverflow.com/tags/apache-beam/topusers
>  [4] https://github.com/apache/beam/pull/11929
>  [5]
> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
> 
> 
> >>>
> >>>
> >>
> >>
> >
> >
> 
> 
> >>>
> >>>
> >> --
> >> Your feedback welcomed for Connello!!!
> >>
> >>
>