Re: Empty projects defined in settings.xml

[Alexey Romanenko]

Kenn, I guess it was added back by mistake in rebase; so, I removed this:
PR: https://github.com/apache/beam/pull/7820

Michael, thank you for catching this.


> On 11 Feb 2019, at 19:39, Kenneth Knowles  wrote:
> 
> Looks like an accidental revert of changes in 
> https://github.com/apache/beam/commit/097be25fa77a0f1cff1883112fa8a863ac17b895
>  
> .
>  The modules that were deleted go way back to before settings.gradle.
> 
> On Mon, Feb 11, 2019 at 9:12 AM Alexey Romanenko  > wrote:
> Hmm, I’m confused since this is me, who is author of this commit [1], but 
> these 2 project definitions are absolutely not related to HadoopFormatIO.Write
> Do we need to drop it?
> 
> [1] 
> https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac
>  
> 
> 
>> On 11 Feb 2019, at 09:25, Michael Luckey > > wrote:
>> 
>> Thanks, Kenn.
>> 
>> So this is something 'yet to come'? As the definitions are pointing to 
>> folders that do not exist?
>> 
>> michel
>> 
>> On Mon, Feb 11, 2019 at 5:49 AM Kenneth Knowles > > wrote:
>> I think :beam-runners-gcp-gcsproxy would be an implementation of the 
>> artifact API [1] on top of GCS. Something fitting that description does 
>> exist [2].
>> 
>> Since settings.gradle renames all our folders, basically, I think each line 
>> deserves some commentary. And seems like a smoke test in the root project 
>> might catch when things get stale.
>> 
>> Kenn
>> 
>> [1] 
>> https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_artifact_api.proto
>>  
>> 
>> [2] 
>> https://github.com/apache/beam/tree/master/sdks/go/pkg/beam/artifact/gcsproxy
>>  
>> 
>> On Sun, Feb 10, 2019 at 4:23 PM Michael Luckey > > wrote:
>> Hi,
>> 
>> while looking into settings.gradle I stumbled upon 2 project definitions 
>> [1], 
>> 
>> - beam-runners-gcp-gcemd
>> - beam-runners-gcp-gcsproxy
>> 
>> which I can not make any sense of. Any insights, why these exists or what 
>> they are supposed to be?
>> 
>> They were added with HadoopFormatIO.Write [2].
>> 
>> Thanks,
>> 
>> michel
>> 
>> [1] https://github.com/apache/beam/blob/master/settings.gradle#L64-L67 
>> 
>> [2] 
>> https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac
>>  
>> 

Re: Empty projects defined in settings.xml

[Kenneth Knowles]

Looks like an accidental revert of changes in
https://github.com/apache/beam/commit/097be25fa77a0f1cff1883112fa8a863ac17b895.
The modules that were deleted go way back to before settings.gradle.

On Mon, Feb 11, 2019 at 9:12 AM Alexey Romanenko 
wrote:

> Hmm, I’m confused since this is me, who is author of this commit [1], but
> these 2 project definitions are absolutely not related
> to HadoopFormatIO.Write
> Do we need to drop it?
>
> [1]
> https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac
>
> On 11 Feb 2019, at 09:25, Michael Luckey  wrote:
>
> Thanks, Kenn.
>
> So this is something 'yet to come'? As the definitions are pointing to
> folders that do not exist?
>
> michel
>
> On Mon, Feb 11, 2019 at 5:49 AM Kenneth Knowles  wrote:
>
>> I think :beam-runners-gcp-gcsproxy would be an implementation of the
>> artifact API [1] on top of GCS. Something fitting that description does
>> exist [2].
>>
>> Since settings.gradle renames all our folders, basically, I think each
>> line deserves some commentary. And seems like a smoke test in the root
>> project might catch when things get stale.
>>
>> Kenn
>>
>> [1]
>> https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_artifact_api.proto
>> [2]
>> https://github.com/apache/beam/tree/master/sdks/go/pkg/beam/artifact/gcsproxy
>>
>> On Sun, Feb 10, 2019 at 4:23 PM Michael Luckey 
>> wrote:
>>
>>> Hi,
>>>
>>> while looking into settings.gradle I stumbled upon 2 project definitions
>>> [1],
>>>
>>> - beam-runners-gcp-gcemd
>>> - beam-runners-gcp-gcsproxy
>>>
>>> which I can not make any sense of. Any insights, why these exists or
>>> what they are supposed to be?
>>>
>>> They were added with HadoopFormatIO.Write [2].
>>>
>>> Thanks,
>>>
>>> michel
>>>
>>> [1] https://github.com/apache/beam/blob/master/settings.gradle#L64-L67
>>> [2]
>>> https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac
>>>
>>
>

Re: Empty projects defined in settings.xml

[Alexey Romanenko]

Hmm, I’m confused since this is me, who is author of this commit [1], but these 
2 project definitions are absolutely not related to HadoopFormatIO.Write
Do we need to drop it?

[1] 
https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac 


> On 11 Feb 2019, at 09:25, Michael Luckey  wrote:
> 
> Thanks, Kenn.
> 
> So this is something 'yet to come'? As the definitions are pointing to 
> folders that do not exist?
> 
> michel
> 
> On Mon, Feb 11, 2019 at 5:49 AM Kenneth Knowles  > wrote:
> I think :beam-runners-gcp-gcsproxy would be an implementation of the artifact 
> API [1] on top of GCS. Something fitting that description does exist [2].
> 
> Since settings.gradle renames all our folders, basically, I think each line 
> deserves some commentary. And seems like a smoke test in the root project 
> might catch when things get stale.
> 
> Kenn
> 
> [1] 
> https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_artifact_api.proto
>  
> 
> [2] 
> https://github.com/apache/beam/tree/master/sdks/go/pkg/beam/artifact/gcsproxy 
> 
> On Sun, Feb 10, 2019 at 4:23 PM Michael Luckey  > wrote:
> Hi,
> 
> while looking into settings.gradle I stumbled upon 2 project definitions [1], 
> 
> - beam-runners-gcp-gcemd
> - beam-runners-gcp-gcsproxy
> 
> which I can not make any sense of. Any insights, why these exists or what 
> they are supposed to be?
> 
> They were added with HadoopFormatIO.Write [2].
> 
> Thanks,
> 
> michel
> 
> [1] https://github.com/apache/beam/blob/master/settings.gradle#L64-L67 
> 
> [2] 
> https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac
>  
> 

Re: Empty projects defined in settings.xml

[Michael Luckey]

Thanks, Kenn.

So this is something 'yet to come'? As the definitions are pointing to
folders that do not exist?

michel

On Mon, Feb 11, 2019 at 5:49 AM Kenneth Knowles  wrote:

> I think :beam-runners-gcp-gcsproxy would be an implementation of the
> artifact API [1] on top of GCS. Something fitting that description does
> exist [2].
>
> Since settings.gradle renames all our folders, basically, I think each
> line deserves some commentary. And seems like a smoke test in the root
> project might catch when things get stale.
>
> Kenn
>
> [1]
> https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_artifact_api.proto
> [2]
> https://github.com/apache/beam/tree/master/sdks/go/pkg/beam/artifact/gcsproxy
>
> On Sun, Feb 10, 2019 at 4:23 PM Michael Luckey 
> wrote:
>
>> Hi,
>>
>> while looking into settings.gradle I stumbled upon 2 project definitions
>> [1],
>>
>> - beam-runners-gcp-gcemd
>> - beam-runners-gcp-gcsproxy
>>
>> which I can not make any sense of. Any insights, why these exists or what
>> they are supposed to be?
>>
>> They were added with HadoopFormatIO.Write [2].
>>
>> Thanks,
>>
>> michel
>>
>> [1] https://github.com/apache/beam/blob/master/settings.gradle#L64-L67
>> [2]
>> https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac
>>
>

Re: Empty projects defined in settings.xml

[Kenneth Knowles]

I think :beam-runners-gcp-gcsproxy would be an implementation of the
artifact API [1] on top of GCS. Something fitting that description does
exist [2].

Since settings.gradle renames all our folders, basically, I think each line
deserves some commentary. And seems like a smoke test in the root project
might catch when things get stale.

Kenn

[1]
https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_artifact_api.proto
[2]
https://github.com/apache/beam/tree/master/sdks/go/pkg/beam/artifact/gcsproxy

On Sun, Feb 10, 2019 at 4:23 PM Michael Luckey  wrote:

> Hi,
>
> while looking into settings.gradle I stumbled upon 2 project definitions
> [1],
>
> - beam-runners-gcp-gcemd
> - beam-runners-gcp-gcsproxy
>
> which I can not make any sense of. Any insights, why these exists or what
> they are supposed to be?
>
> They were added with HadoopFormatIO.Write [2].
>
> Thanks,
>
> michel
>
> [1] https://github.com/apache/beam/blob/master/settings.gradle#L64-L67
> [2]
> https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac
>

Empty projects defined in settings.xml

[Michael Luckey]

Hi,

while looking into settings.gradle I stumbled upon 2 project definitions
[1],

- beam-runners-gcp-gcemd
- beam-runners-gcp-gcsproxy

which I can not make any sense of. Any insights, why these exists or what
they are supposed to be?

They were added with HadoopFormatIO.Write [2].

Thanks,

michel

[1] https://github.com/apache/beam/blob/master/settings.gradle#L64-L67
[2]
https://github.com/apache/beam/commit/757b71e749ab8a9f0a08e3669596ce69920acbac