Re: Migrating Gradle scripts to Kotlin
Yes, that's me, thank you! From: Kenneth Knowles Sent: Tuesday, February 2, 2021 9:23:45 PM To: dev Subject: Re: Migrating Gradle scripts to Kotlin I took a guess that the Jira user 'ramazan-yapparov' was you and have added you to the project and assigned the ticket. Let me know if this is not you. Kenn On Thu, Jan 28, 2021 at 2:26 PM Brian Hulette mailto:bhule...@google.com>> wrote: I think generally smaller PRs are preferable if the work is easily separable, which it sounds like this is. I'd recommend you go ahead and put up a PR, you might even split it into one PR per file if that makes sense to you. Side note - do you have a Jira ID? We should get BEAM-11589 assigned to you if you are working on it :) Brian On Thu, Jan 28, 2021 at 2:52 AM Ramazan Yapparov mailto:ramazan.yappa...@akvelon.com>> wrote: Hi Beam Dev! I started to work on this issue https://issues.apache.org/jira/browse/BEAM-11589 - migrating Gradle scripts from Groovy to Kotlin. Currently, I've migrated settings.gradle, buildSrc/build.gradle and release/build.gradle files to Kotlin. I believe that this work should be done incrementally, so I wanted to ask if this amount of changes is enough for a PR or should I migrate more modules?
Re: Migrating Gradle scripts to Kotlin
I took a guess that the Jira user 'ramazan-yapparov' was you and have added you to the project and assigned the ticket. Let me know if this is not you. Kenn On Thu, Jan 28, 2021 at 2:26 PM Brian Hulette wrote: > I think generally smaller PRs are preferable if the work is easily > separable, which it sounds like this is. I'd recommend you go ahead and put > up a PR, you might even split it into one PR per file if that makes sense > to you. > > Side note - do you have a Jira ID? We should get BEAM-11589 assigned to > you if you are working on it :) > > Brian > > On Thu, Jan 28, 2021 at 2:52 AM Ramazan Yapparov < > ramazan.yappa...@akvelon.com> wrote: > >> Hi Beam Dev! >> I started to work on this issue >> https://issues.apache.org/jira/browse/BEAM-11589 - migrating Gradle >> scripts from Groovy to Kotlin. >> Currently, I've migrated settings.gradle, buildSrc/build.gradle and >> release/build.gradle files to Kotlin. >> I believe that this work should be done incrementally, so I wanted to ask >> if this amount of changes is enough for a PR or should I migrate more >> modules? >> >>
Re: Migrating Gradle scripts to Kotlin
I think generally smaller PRs are preferable if the work is easily separable, which it sounds like this is. I'd recommend you go ahead and put up a PR, you might even split it into one PR per file if that makes sense to you. Side note - do you have a Jira ID? We should get BEAM-11589 assigned to you if you are working on it :) Brian On Thu, Jan 28, 2021 at 2:52 AM Ramazan Yapparov < ramazan.yappa...@akvelon.com> wrote: > Hi Beam Dev! > I started to work on this issue > https://issues.apache.org/jira/browse/BEAM-11589 - migrating Gradle > scripts from Groovy to Kotlin. > Currently, I've migrated settings.gradle, buildSrc/build.gradle and > release/build.gradle files to Kotlin. > I believe that this work should be done incrementally, so I wanted to ask > if this amount of changes is enough for a PR or should I migrate more > modules? > >
Migrating Gradle scripts to Kotlin
Hi Beam Dev! I started to work on this issue https://issues.apache.org/jira/browse/BEAM-11589 - migrating Gradle scripts from Groovy to Kotlin. Currently, I've migrated settings.gradle, buildSrc/build.gradle and release/build.gradle files to Kotlin. I believe that this work should be done incrementally, so I wanted to ask if this amount of changes is enough for a PR or should I migrate more modules?
