Re: [PROPOSAL] Move testing utilities to a common place.

2018-10-11 Thread Łukasz Gajowy
>
> sdks/java/tests? Assuming this will be Java utility code and Java test
>> suites.
>>
>
Yes, I meant "sdks/java/tests".

I would prefer a more descriptive name than `common` if you can come up
> with something. As much as I usually dislike `util` in this case I would go
> with that, only because it names the thing what it is, rather than how it
> relates to other things (relationships change all the time). Not a big deal
> or a blocker.
>

I also don't like those names but couldn't find anything better yet. This
will become final in the pull request, I guess.


> Sounds great to me. More eyes on the Nexmark-related bits will definitely
> be valuable, too.
>

Great! I created a JIRA and assigned it to me:
https://issues.apache.org/jira/browse/BEAM-5716

Łukasz

>


Re: [PROPOSAL] Move testing utilities to a common place.

2018-10-08 Thread Kenneth Knowles
On Mon, Oct 8, 2018 at 9:43 AM Łukasz Gajowy  wrote:

>
> Therefore, I propose one of the following:
>
>1. creating a module called "sdks/tests" and place "load-tests" and
>"nexmark" modules inside it. Place the common code in "sdks/tests/common"
>(or similar) and reuse it in every testing code that needs it.
>
> sdks/java/tests? Assuming this will be Java utility code and Java test
suites.

I would prefer a more descriptive name than `common` if you can come up
with something. As much as I usually dislike `util` in this case I would go
with that, only because it names the thing what it is, rather than how it
relates to other things (relationships change all the time). Not a big deal
or a blocker.

WDYT?
>

Sounds great to me. More eyes on the Nexmark-related bits will definitely
be valuable, too.

Kenn