Re: Maven build broken

[Etienne Chauchot]

+1 to what Ismaël and JB said
Etienne
Le jeudi 26 avril 2018 à 16:25 +, Ismaël Mejía a écrit :
> Thanks Thomas for the fix,
> Agree 100% maven should still work until the decision to drop it off is
> taken.
> 
> On Thu, Apr 26, 2018 at 5:51 PM Thomas Weise  wrote:
> 
> > 
> > Here is a PR to fix it:
> > 
> > https://github.com/apache/beam/pull/5232
> > 
> > I think that until switch to gradle is complete, at least "mvn verify"
> should continue to run in Jenkins pre-commit.
> 
> > 
> > Thanks,
> > Thomas
> 
> > 
> > On Thu, Apr 26, 2018 at 4:53 AM, Jean-Baptiste Onofré 
> wrote:
> 
> > 
> > > 
> > > I would propose to revert in order to give us time to fix. As we still
> have the two build tools, they have to build the same way.
> 
> > 
> > > 
> > > Regards
> > > JB
> > > Le 26 avr. 2018, à 14:57, Colm O hEigeartaigh  a
> écrit:
> 
> > 
> > > 
> > > > 
> > > > Hi,
> > 
> > > 
> > > > 
> > > > This commit breaks the maven build:
> > 
> > > 
> > > > 
> > > > commit 5d5c052e890fb8af4bb9cd1a152300542feba0a2
> > > > Author: Ben Sidhom 
> > > > Date:   Mon Apr 16 17:03:21 2018 -0700
> > 
> > > 
> > > > 
> > > >  [BEAM-4071] Add Portable Runner Job API shim
> > 
> > > 
> > > > 
> > > > The changes to runners/reference/java/build.gradle were not also made
> to the pom:
> 
> > 
> > > 
> > > > 
> > > > +  shadow project(path: ":beam-sdks-java-fn-execution", configuration:
> "shadow")
> > 
> > > 
> > > > 
> > > > shadow library.java.slf4j_api
> > > > +  shadowTest project(path: ":beam-runners-core-construction-java",
> configuration: "shadowTest")
> 
> > 
> > > 
> > > > 
> > > > Colm.

Re: Maven build broken

[Ismaël Mejía]

Thanks Thomas for the fix,
Agree 100% maven should still work until the decision to drop it off is
taken.

On Thu, Apr 26, 2018 at 5:51 PM Thomas Weise  wrote:

> Here is a PR to fix it:

> https://github.com/apache/beam/pull/5232

> I think that until switch to gradle is complete, at least "mvn verify"
should continue to run in Jenkins pre-commit.

> Thanks,
> Thomas


> On Thu, Apr 26, 2018 at 4:53 AM, Jean-Baptiste Onofré 
wrote:

>> I would propose to revert in order to give us time to fix. As we still
have the two build tools, they have to build the same way.

>> Regards
>> JB
>> Le 26 avr. 2018, à 14:57, Colm O hEigeartaigh  a
écrit:

>>> Hi,

>>> This commit breaks the maven build:

>>> commit 5d5c052e890fb8af4bb9cd1a152300542feba0a2
>>> Author: Ben Sidhom 
>>> Date:   Mon Apr 16 17:03:21 2018 -0700

>>>  [BEAM-4071] Add Portable Runner Job API shim

>>> The changes to runners/reference/java/build.gradle were not also made
to the pom:

>>> +  shadow project(path: ":beam-sdks-java-fn-execution", configuration:
"shadow")
>>> shadow library.java.slf4j_api
>>> +  shadowTest project(path: ":beam-runners-core-construction-java",
configuration: "shadowTest")

>>> Colm.

Re: Maven build broken

[Thomas Weise]

Here is a PR to fix it:

https://github.com/apache/beam/pull/5232

I think that until switch to gradle is complete, at least "mvn verify"
should continue to run in Jenkins pre-commit.

Thanks,
Thomas


On Thu, Apr 26, 2018 at 4:53 AM, Jean-Baptiste Onofré 
wrote:

> I would propose to revert in order to give us time to fix. As we still
> have the two build tools, they have to build the same way.
>
> Regards
> JB
> Le 26 avr. 2018, à 14:57, Colm O hEigeartaigh  a
> écrit:
>>
>> Hi,
>>
>> This commit breaks the maven build:
>>
>> commit 5d5c052e890fb8af4bb9cd1a152300542feba0a2
>> Author: Ben Sidhom 
>> Date:   Mon Apr 16 17:03:21 2018 -0700
>>
>> [BEAM-4071] Add Portable Runner Job API shim
>>
>> The changes to runners/reference/java/build.gradle were not also made to
>> the pom:
>>
>> +  shadow project(path: ":beam-sdks-java-fn-execution", configuration:
>> "shadow")
>>shadow library.java.slf4j_api
>> +  shadowTest project(path: ":beam-runners-core-construction-java",
>> configuration: "shadowTest")
>>
>> Colm.
>>
>>

Re: Maven build broken

[Jean-Baptiste Onofré]

I would propose to revert in order to give us time to fix. As we still have the 
two build tools, they have to build the same way.

Regards
JB

Le 26 avr. 2018 à 14:57, à 14:57, Colm O hEigeartaigh  a 
écrit:
>Hi,
>
>This commit breaks the maven build:
>
>commit 5d5c052e890fb8af4bb9cd1a152300542feba0a2
>Author: Ben Sidhom 
>Date:   Mon Apr 16 17:03:21 2018 -0700
>
>[BEAM-4071] Add Portable Runner Job API shim
>
>The changes to runners/reference/java/build.gradle were not also made
>to
>the pom:
>
>+  shadow project(path: ":beam-sdks-java-fn-execution", configuration:
>"shadow")
>   shadow library.java.slf4j_api
>+  shadowTest project(path: ":beam-runners-core-construction-java",
>configuration: "shadowTest")
>
>Colm.
>
>
>--
>Colm O hEigeartaigh
>
>Talend Community Coder
>http://coders.talend.com