Re: Upgrading non-vendored Guava version

[Tomo Suzuki]

The PR has moved to https://github.com/apache/beam/pull/13804, after
reflecting Kyle's feedback. Kyle approved this.

I look for feedback, and merge if there's no problem.

Regards,
Tomo

On Tue, Jan 19, 2021 at 6:10 PM Ahmet Altay  wrote:

> +Kenneth Knowles  +Tyson Hamilton  +Kiley
> Sok 
>
> On Thu, Jan 14, 2021 at 4:23 PM Tomo Suzuki  wrote:
>
>> Hi Beam developers,
>>
>> I'm preparing a pull request (#13740)
>>  that upgrades the
>> non-vendored Guava version (currently 25.1-jre) to the latest version
>> (30.1-jre). I want Beam to be built, tested, and run with the newer version
>> of Guava so that its Guava dependency works with other libraries that
>> depend on newer Guava (e.g., gcsio).
>>
>> However, certain Hadoop/Cassandra-related modules in the Beam project
>> require Guava 25 or older (Details in BEAM-11626
>> ) when they run tests.
>> Therefore, this PR attempts to split guava versions: 25
>> for Hadoop/Cassandra-related modules and 30 for the rest of the project.
>>
>> I analyzed the effect of the change in the PR below. So far I see the
>> effect is minimal thanks to the fact that Beam vendors Guava and only 3
>> modules declares non-test dependency to the non-vendored Guava.
>>
>> https://github.com/apache/beam/pull/13740
>>
>> As I am not a Hadoop/Cassandra user, I might have missed
>> important points. I appreciate it if you can share your perspective on this.
>>
>> --
>> Regards,
>> Tomo
>>
>

-- 
Regards,
Tomo

Re: Upgrading non-vendored Guava version

[Ahmet Altay]

+Kenneth Knowles  +Tyson Hamilton  +Kiley
Sok 

On Thu, Jan 14, 2021 at 4:23 PM Tomo Suzuki  wrote:

> Hi Beam developers,
>
> I'm preparing a pull request (#13740)
>  that upgrades the
> non-vendored Guava version (currently 25.1-jre) to the latest version
> (30.1-jre). I want Beam to be built, tested, and run with the newer version
> of Guava so that its Guava dependency works with other libraries that
> depend on newer Guava (e.g., gcsio).
>
> However, certain Hadoop/Cassandra-related modules in the Beam project
> require Guava 25 or older (Details in BEAM-11626
> ) when they run tests.
> Therefore, this PR attempts to split guava versions: 25
> for Hadoop/Cassandra-related modules and 30 for the rest of the project.
>
> I analyzed the effect of the change in the PR below. So far I see the
> effect is minimal thanks to the fact that Beam vendors Guava and only 3
> modules declares non-test dependency to the non-vendored Guava.
>
> https://github.com/apache/beam/pull/13740
>
> As I am not a Hadoop/Cassandra user, I might have missed
> important points. I appreciate it if you can share your perspective on this.
>
> --
> Regards,
> Tomo
>

Upgrading non-vendored Guava version

[Tomo Suzuki]

Hi Beam developers,

I'm preparing a pull request (#13740)
 that upgrades the non-vendored
Guava version (currently 25.1-jre) to the latest version (30.1-jre). I want
Beam to be built, tested, and run with the newer version of Guava so that
its Guava dependency works with other libraries that depend on newer Guava
(e.g., gcsio).

However, certain Hadoop/Cassandra-related modules in the Beam project
require Guava 25 or older (Details in BEAM-11626
) when they run tests.
Therefore, this PR attempts to split guava versions: 25
for Hadoop/Cassandra-related modules and 30 for the rest of the project.

I analyzed the effect of the change in the PR below. So far I see the
effect is minimal thanks to the fact that Beam vendors Guava and only 3
modules declares non-test dependency to the non-vendored Guava.

https://github.com/apache/beam/pull/13740

As I am not a Hadoop/Cassandra user, I might have missed
important points. I appreciate it if you can share your perspective on this.

-- 
Regards,
Tomo