[jira] [Commented] (BOOKKEEPER-850) Use nanoseconds to calculate poll timeout when doing group commit
[ https://issues.apache.org/jira/browse/BOOKKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490466#comment-14490466 ] Hadoop QA commented on BOOKKEEPER-850: -- Testing JIRA BOOKKEEPER-850 Patch [0001-BOOKKEEPER-850-Use-nanoseconds-to-calculate-poll-tim.patch|https://issues.apache.org/jira/secure/attachment/12724672/0001-BOOKKEEPER-850-Use-nanoseconds-to-calculate-poll-tim.patch] downloaded at Fri Apr 10 22:16:41 UTC 2015 {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 120 .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:red}-1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:red}-1{color} patch does not compile .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} .{color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:red}-1 TESTS{color} - patch does not compile, cannot run testcases {color:red}-1 DISTRO{color} .{color:red}-1{color} distro tarball fails with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/918/ Use nanoseconds to calculate poll timeout when doing group commit - Key: BOOKKEEPER-850 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-850 Project: Bookkeeper Issue Type: Improvement Affects Versions: 4.3.0 Reporter: Matteo Merli Assignee: Matteo Merli Priority: Minor Fix For: 4.4.0 Attachments: 0001-BOOKKEEPER-850-Use-nanoseconds-to-calculate-poll-tim.patch When using group commit to reduce the number of fsync operations in the bookie journal, the timeout is rounded to the next millisecond. If the group commit is set to 1ms, that would mean that the effective wait time will be closer to 2ms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-850) Use nanoseconds to calculate poll timeout when doing group commit
[ https://issues.apache.org/jira/browse/BOOKKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490478#comment-14490478 ] Matteo Merli commented on BOOKKEEPER-850: - Needs the method MathUtils.elapsedNanos() from other jira patch Use nanoseconds to calculate poll timeout when doing group commit - Key: BOOKKEEPER-850 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-850 Project: Bookkeeper Issue Type: Improvement Affects Versions: 4.3.0 Reporter: Matteo Merli Assignee: Matteo Merli Priority: Minor Fix For: 4.4.0 Attachments: 0001-BOOKKEEPER-850-Use-nanoseconds-to-calculate-poll-tim.patch When using group commit to reduce the number of fsync operations in the bookie journal, the timeout is rounded to the next millisecond. If the group commit is set to 1ms, that would mean that the effective wait time will be closer to 2ms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BOOKKEEPER-852) Release LedgerDescriptor and master-key objects when not used anymore
Matteo Merli created BOOKKEEPER-852: --- Summary: Release LedgerDescriptor and master-key objects when not used anymore Key: BOOKKEEPER-852 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-852 Project: Bookkeeper Issue Type: Bug Affects Versions: 4.3.0 Reporter: Matteo Merli Assignee: Matteo Merli Fix For: 4.4.0 Maps with ledger descriptors and master-keys are not cleaned after a ledger gets deleted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-852) Release LedgerDescriptor and master-key objects when not used anymore
[ https://issues.apache.org/jira/browse/BOOKKEEPER-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli updated BOOKKEEPER-852: Attachment: 0001-BOOKKEEPER-852-Release-LedgerDescriptor-and-master-k.patch Release LedgerDescriptor and master-key objects when not used anymore - Key: BOOKKEEPER-852 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-852 Project: Bookkeeper Issue Type: Bug Affects Versions: 4.3.0 Reporter: Matteo Merli Assignee: Matteo Merli Fix For: 4.4.0 Attachments: 0001-BOOKKEEPER-852-Release-LedgerDescriptor-and-master-k.patch Maps with ledger descriptors and master-keys are not cleaned after a ledger gets deleted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-852) Release LedgerDescriptor and master-key objects when not used anymore
[ https://issues.apache.org/jira/browse/BOOKKEEPER-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490577#comment-14490577 ] Matteo Merli commented on BOOKKEEPER-852: - Code review: https://reviews.apache.org/r/33098/ Release LedgerDescriptor and master-key objects when not used anymore - Key: BOOKKEEPER-852 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-852 Project: Bookkeeper Issue Type: Bug Affects Versions: 4.3.0 Reporter: Matteo Merli Assignee: Matteo Merli Fix For: 4.4.0 Attachments: 0001-BOOKKEEPER-852-Release-LedgerDescriptor-and-master-k.patch Maps with ledger descriptors and master-keys are not cleaned after a ledger gets deleted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-851) Configurable LedgerStorageImplementation
[ https://issues.apache.org/jira/browse/BOOKKEEPER-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490587#comment-14490587 ] Hadoop QA commented on BOOKKEEPER-851: -- Testing JIRA BOOKKEEPER-851 Patch [0001-BOOKKEPER-851-Configurable-LedgerStorage-implementat.patch|https://issues.apache.org/jira/secure/attachment/12724682/0001-BOOKKEPER-851-Configurable-LedgerStorage-implementat.patch] downloaded at Fri Apr 10 23:38:11 UTC 2015 {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 120 .{color:green}+1{color} the patch does adds/modifies 3 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:red}-1 JAVADOC{color} .{color:red}-1{color} the patch seems to introduce 4 new Javadoc warning(s) {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} .{color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:green}+1 TESTS{color} .Tests run: 949 {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/921/ Configurable LedgerStorageImplementation Key: BOOKKEEPER-851 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-851 Project: Bookkeeper Issue Type: Improvement Affects Versions: 4.3.0 Reporter: Matteo Merli Assignee: Matteo Merli Fix For: 4.4.0 Attachments: 0001-BOOKKEPER-851-Configurable-LedgerStorage-implementat.patch Allow to configure a different implementation for the LedgerStorage interface in the Bookie configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-852) Release LedgerDescriptor and master-key objects when not used anymore
[ https://issues.apache.org/jira/browse/BOOKKEEPER-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490654#comment-14490654 ] Hadoop QA commented on BOOKKEEPER-852: -- Testing JIRA BOOKKEEPER-852 Patch [0001-BOOKKEEPER-852-Release-LedgerDescriptor-and-master-k.patch|https://issues.apache.org/jira/secure/attachment/12724705/0001-BOOKKEEPER-852-Release-LedgerDescriptor-and-master-k.patch] downloaded at Sat Apr 11 00:15:43 UTC 2015 {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 120 .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} .{color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:green}+1 TESTS{color} .Tests run: 949 {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/922/ Release LedgerDescriptor and master-key objects when not used anymore - Key: BOOKKEEPER-852 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-852 Project: Bookkeeper Issue Type: Bug Affects Versions: 4.3.0 Reporter: Matteo Merli Assignee: Matteo Merli Fix For: 4.4.0 Attachments: 0001-BOOKKEEPER-852-Release-LedgerDescriptor-and-master-k.patch Maps with ledger descriptors and master-keys are not cleaned after a ledger gets deleted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)