[GitHub] bookkeeper issue #126: BOOKKEEPER-1018: Allow client to select older V2 prot...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
+1 for separate JIRA

Overall LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1018) Allow client to select older V2 protocol (no protobuf)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960356#comment-15960356
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1018:


Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
+1 for separate JIRA

Overall LGTM


> Allow client to select older V2 protocol (no protobuf)
> --
>
> Key: BOOKKEEPER-1018
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1018
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-server
>Reporter: Govind Menon
>Assignee: Govind Menon
> Fix For: 4.5.0
>
>
> Oriignally done by Matteo Merli



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (BOOKKEEPER-1026) Ignore deleted ledgers

[Matteo Merli (JIRA)]

Matteo Merli created BOOKKEEPER-1026:


 Summary: Ignore deleted ledgers
 Key: BOOKKEEPER-1026
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1026
 Project: Bookkeeper
  Issue Type: Sub-task
Reporter: Matteo Merli


There is some corner case in which deleted ledgers are failing to get 
replicated, while they should just be ignored.

https://github.com/yahoo/bookkeeper/commit/56a0947e0c4ae902468abc4a96e5842a7a0aee9b



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (BOOKKEEPER-1025) Release underreplicated lock after errors

[Matteo Merli (JIRA)]

Matteo Merli created BOOKKEEPER-1025:


 Summary: Release underreplicated lock after errors
 Key: BOOKKEEPER-1025
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1025
 Project: Bookkeeper
  Issue Type: Sub-task
Reporter: Matteo Merli


There are some conditions in which the replication lock on some ledger is not 
being released, requiring manual intervention to bounce the replication work to 
let some other continue.

https://github.com/yahoo/bookkeeper/commit/850122ed56b9c3706cb44cce9f27989125b76e3a



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (BOOKKEEPER-1024) Make auto replication honor ensemble placement policy

[Matteo Merli (JIRA)]

Matteo Merli created BOOKKEEPER-1024:


 Summary: Make auto replication honor ensemble placement policy
 Key: BOOKKEEPER-1024
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1024
 Project: Bookkeeper
  Issue Type: Sub-task
Reporter: Matteo Merli


If you want to enforce a stricter control on which bookies to choose for the 
placement policy, the same policy needs to be honored by the replicator. 

Relevant commit in yahoo branch : 

https://github.com/yahoo/bookkeeper/commit/8b6f7f07793c6a1cbfe142c94c14a66c7c415eaa



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BOOKKEEPER-1018) Allow client to select older V2 protocol (no protobuf)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959912#comment-15959912
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1018:


Github user govind-menon commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
I was thinking of doing it in a separate JIRA. @merlimat  Had suggested a 
way of running the existing test suite with the V2 protocol set.


> Allow client to select older V2 protocol (no protobuf)
> --
>
> Key: BOOKKEEPER-1018
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1018
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-server
>Reporter: Govind Menon
>Assignee: Govind Menon
> Fix For: 4.5.0
>
>
> Oriignally done by Matteo Merli



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #126: BOOKKEEPER-1018: Allow client to select older V2 prot...

[govind-menon]

Github user govind-menon commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
I was thinking of doing it in a separate JIRA. @merlimat  Had suggested a 
way of running the existing test suite with the V2 protocol set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1018) Allow client to select older V2 protocol (no protobuf)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959908#comment-15959908
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1018:


Github user sijie commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
@merlimat @eolivelli - what is the deal for this pr? shall we add the tests 
now or doing it in a separated jira?


> Allow client to select older V2 protocol (no protobuf)
> --
>
> Key: BOOKKEEPER-1018
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1018
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-server
>Reporter: Govind Menon
>Assignee: Govind Menon
> Fix For: 4.5.0
>
>
> Oriignally done by Matteo Merli



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #126: BOOKKEEPER-1018: Allow client to select older V2 prot...

[sijie]

Github user sijie commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
@merlimat @eolivelli - what is the deal for this pr? shall we add the tests 
now or doing it in a separated jira?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] AutoRecovery bug fixes and improvements

[Sijie Guo]

Hi all,

As we discussed in today's community call, I created the master jira for
tracking the existing bug fixes (that are needed to merge) and the
improvements that we are looking for.

This is the master jira:
https://issues.apache.org/jira/browse/BOOKKEEPER-1023

Let's use this email thread for discussing that.

- Sijie

[jira] [Created] (BOOKKEEPER-1023) AutoRecovery bug fixes and improvements

[Sijie Guo (JIRA)]

Sijie Guo created BOOKKEEPER-1023:
-

 Summary: AutoRecovery bug fixes and improvements
 Key: BOOKKEEPER-1023
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1023
 Project: Bookkeeper
  Issue Type: Story
  Components: bookkeeper-auto-recovery
Reporter: Sijie Guo


This is the master ticket to track all the bug fixes and improvements that made 
to bookkeeper auto recovery, also discuss the architecture changes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Next community meeting and notes

[Enrico Olivelli]

Here are the meeting notes, fell free to edit/update/correct
https://cwiki.apache.org/confluence/display/BOOKKEEPER/2017-4-6+Meeting+notes

Thank you very much to all of the attendees !

2017-04-06 17:06 GMT+02:00 Yiming Zang :

> Hi Bobby, here's the link to the meeting
> https://goo.gl/iyRA6G
>
> On Thu, Apr 6, 2017 at 8:04 AM, Bobby Evans 
> wrote:
>
> > What is the URL.  I can never find it
> >
> >
> > - Bobby
> >
> > On Thursday, April 6, 2017, 5:02:53 AM CDT, Enrico Olivelli <
> > eolive...@gmail.com> wrote:Anyone on the Hangout ?
> >
> > 2017-04-05 14:19 GMT+02:00 Enrico Olivelli :
> >
> > > Hi all,
> > > I have just created the page for the upcoming meeting
> > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > > 2017-4-6+Meeting+notes
> > >
> > > I have just created the page (please update with missing parts)
> > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > > 2017-3-24+Meeting+notes
> > >
> > > I'm sorry I think I told I would have done the notes for the last
> meeting
> > > but I forgot
> > >
> > > I have created a proposed agenda, I think the most important topics
> are:
> > > - Netty 4 patch
> > > - V2 protocol support
> > > - Current PRs https://github.com/apache/bookkeeper/pulls
> > >
> > > @JV and @Kishore
> > > do you have any news about Netty 4 patch ?
> > >
> > > Cheers
> > >
> > > -- Enrico
> > >
> > >
> > >
> > >
> >
>

Re: Next community meeting and notes

[Yiming Zang]

Hi Bobby, here's the link to the meeting
https://goo.gl/iyRA6G

On Thu, Apr 6, 2017 at 8:04 AM, Bobby Evans 
wrote:

> What is the URL.  I can never find it
>
>
> - Bobby
>
> On Thursday, April 6, 2017, 5:02:53 AM CDT, Enrico Olivelli <
> eolive...@gmail.com> wrote:Anyone on the Hangout ?
>
> 2017-04-05 14:19 GMT+02:00 Enrico Olivelli :
>
> > Hi all,
> > I have just created the page for the upcoming meeting
> > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > 2017-4-6+Meeting+notes
> >
> > I have just created the page (please update with missing parts)
> > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > 2017-3-24+Meeting+notes
> >
> > I'm sorry I think I told I would have done the notes for the last meeting
> > but I forgot
> >
> > I have created a proposed agenda, I think the most important topics are:
> > - Netty 4 patch
> > - V2 protocol support
> > - Current PRs https://github.com/apache/bookkeeper/pulls
> >
> > @JV and @Kishore
> > do you have any news about Netty 4 patch ?
> >
> > Cheers
> >
> > -- Enrico
> >
> >
> >
> >
>

Re: Next community meeting and notes

[Matteo Merli]

https://goo.gl/iyRA6G

On Thu, Apr 6, 2017 at 8:05 AM Bobby Evans 
wrote:

> What is the URL.  I can never find it
>
>
> - Bobby
>
> On Thursday, April 6, 2017, 5:02:53 AM CDT, Enrico Olivelli <
> eolive...@gmail.com> wrote:Anyone on the Hangout ?
>
> 2017-04-05 14:19 GMT+02:00 Enrico Olivelli :
>
> > Hi all,
> > I have just created the page for the upcoming meeting
> > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > 2017-4-6+Meeting+notes
> >
> > I have just created the page (please update with missing parts)
> > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > 2017-3-24+Meeting+notes
> >
> > I'm sorry I think I told I would have done the notes for the last meeting
> > but I forgot
> >
> > I have created a proposed agenda, I think the most important topics are:
> > - Netty 4 patch
> > - V2 protocol support
> > - Current PRs https://github.com/apache/bookkeeper/pulls
> >
> > @JV and @Kishore
> > do you have any news about Netty 4 patch ?
> >
> > Cheers
> >
> > -- Enrico
> >
> >
> >
> >
>

Re: Next community meeting and notes

[Bobby Evans]

What is the URL.  I can never find it


- Bobby

On Thursday, April 6, 2017, 5:02:53 AM CDT, Enrico Olivelli 
 wrote:Anyone on the Hangout ?

2017-04-05 14:19 GMT+02:00 Enrico Olivelli :

> Hi all,
> I have just created the page for the upcoming meeting
> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> 2017-4-6+Meeting+notes
>
> I have just created the page (please update with missing parts)
> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> 2017-3-24+Meeting+notes
>
> I'm sorry I think I told I would have done the notes for the last meeting
> but I forgot
>
> I have created a proposed agenda, I think the most important topics are:
> - Netty 4 patch
> - V2 protocol support
> - Current PRs https://github.com/apache/bookkeeper/pulls
>
> @JV and @Kishore
> do you have any news about Netty 4 patch ?
>
> Cheers
>
> -- Enrico
>
>
>
>

Re: Next community meeting and notes

[Enrico Olivelli]

Anyone on the Hangout ?

2017-04-05 14:19 GMT+02:00 Enrico Olivelli :

> Hi all,
> I have just created the page for the upcoming meeting
> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> 2017-4-6+Meeting+notes
>
> I have just created the page (please update with missing parts)
> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> 2017-3-24+Meeting+notes
>
> I'm sorry I think I told I would have done the notes for the last meeting
> but I forgot
>
> I have created a proposed agenda, I think the most important topics are:
> - Netty 4 patch
> - V2 protocol support
> - Current PRs https://github.com/apache/bookkeeper/pulls
>
> @JV and @Kishore
> do you have any news about Netty 4 patch ?
>
> Cheers
>
> -- Enrico
>
>
>
>

Build failed in Jenkins: bookkeeper-master #1710

[Apache Jenkins Server]

See 

--
[...truncated 22.71 KB...]
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.173 sec - in 
org.apache.bookkeeper.test.AsyncLedgerOpsTest
Running org.apache.bookkeeper.test.CloseTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.281 sec - in 
org.apache.bookkeeper.test.CloseTest
Running org.apache.bookkeeper.test.ConcurrentLedgerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.566 sec - in 
org.apache.bookkeeper.test.ConcurrentLedgerTest
Running org.apache.bookkeeper.test.LedgerDeleteTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.986 sec - in 
org.apache.bookkeeper.test.LedgerDeleteTest
Running org.apache.bookkeeper.test.ForceReadOnlyBookieTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.199 sec - in 
org.apache.bookkeeper.test.ForceReadOnlyBookieTest
Running org.apache.bookkeeper.test.TestBackwardCompat
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.57 sec - in 
org.apache.bookkeeper.test.TestBackwardCompat
Running org.apache.bookkeeper.test.ReadOnlyBookieTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.484 sec - in 
org.apache.bookkeeper.test.ReadOnlyBookieTest
Running org.apache.bookkeeper.test.MultipleThreadReadTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.85 sec - in 
org.apache.bookkeeper.test.MultipleThreadReadTest
Running org.apache.bookkeeper.test.LedgerCreateDeleteTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.242 sec - in 
org.apache.bookkeeper.test.LedgerCreateDeleteTest
Running org.apache.bookkeeper.test.ConfigurationTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.224 sec - in 
org.apache.bookkeeper.test.ConfigurationTest
Running org.apache.bookkeeper.test.BookieFailureTest
Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.486 sec - 
in org.apache.bookkeeper.test.BookieFailureTest
Running org.apache.bookkeeper.test.LocalBookiesRegistryTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.767 sec - in 
org.apache.bookkeeper.test.LocalBookiesRegistryTest
Running org.apache.bookkeeper.test.ConditionalSetTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.805 sec - in 
org.apache.bookkeeper.test.ConditionalSetTest
Running org.apache.bookkeeper.test.BookieJournalRollingTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.186 sec - in 
org.apache.bookkeeper.test.BookieJournalRollingTest
Running org.apache.bookkeeper.test.BookieZKExpireTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.208 sec - in 
org.apache.bookkeeper.test.BookieZKExpireTest
Running 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 70.984 sec - in 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Running org.apache.bookkeeper.client.TestSpeculativeRead
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.503 sec - in 
org.apache.bookkeeper.client.TestSpeculativeRead
Running org.apache.bookkeeper.client.TestBookieHealthCheck
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.585 sec - in 
org.apache.bookkeeper.client.TestBookieHealthCheck
Running org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.178 sec - in 
org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Running org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.205 sec - in 
org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Running org.apache.bookkeeper.client.UpdateLedgerCmdTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.428 sec - in 
org.apache.bookkeeper.client.UpdateLedgerCmdTest
Running org.apache.bookkeeper.client.TestLedgerFragmentReplication
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.556 sec - in 
org.apache.bookkeeper.client.TestLedgerFragmentReplication
Running org.apache.bookkeeper.client.BookieRecoveryTest
Tests run: 96, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 66.538 sec <<< 
FAILURE! - in org.apache.bookkeeper.client.BookieRecoveryTest
ensurePasswordUsedForOldLedgers[4](org.apache.bookkeeper.client.BookieRecoveryTest)
  Time elapsed: 2.005 sec  <<< ERROR!
org.apache.bookkeeper.client.BKException$BKNoSuchLedgerExistsException

ensurePasswordUsedForOldLedgers[5](org.apache.bookkeeper.client.BookieRecoveryTest)
  Time elapsed: 1.988 sec  <<< ERROR!
org.apache.bookkeeper.client.BKException$BKNoSuchLedgerExistsException

Running org.apache.bookkeeper.client.LedgerCloseTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.616 sec - in 
org.apache.bookkeeper.clien

[jira] [Created] (BOOKKEEPER-1022) Make BookKeeperAdmin implement AutoCloseable

[Enrico Olivelli (JIRA)]

Enrico Olivelli created BOOKKEEPER-1022:
---

 Summary: Make BookKeeperAdmin implement AutoCloseable
 Key: BOOKKEEPER-1022
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1022
 Project: Bookkeeper
  Issue Type: Improvement
  Components: bookkeeper-client
Affects Versions: 4.4.0
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Priority: Minor


as BookKeeper and LedgerHandler are AutoCloseable it would be good to make 
BookKeeperAdmin AutoCloseable too



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)