[GitHub] bookkeeper issue #110: BOOKKEEPER-391 Support Kerberos authentication of boo...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/110
  
@revans2 I have double checked and with some other product (i.e. ZooKeeper) 
we are using legacy MD5 in some production deployment.
As in this implementation I would like to remain as much similar to ZK as 
possible I would like to keep MD5 as well, maybe we can write some "Warning" in 
the documentation

Is is OK for you ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-391) Support Kerberos authentication of bookkeeper

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962517#comment-15962517
 ] 

ASF GitHub Bot commented on BOOKKEEPER-391:
---

Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/110
  
@revans2 I have double checked and with some other product (i.e. ZooKeeper) 
we are using legacy MD5 in some production deployment.
As in this implementation I would like to remain as much similar to ZK as 
possible I would like to keep MD5 as well, maybe we can write some "Warning" in 
the documentation

Is is OK for you ?


> Support Kerberos authentication of bookkeeper
> -
>
> Key: BOOKKEEPER-391
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-391
> Project: Bookkeeper
>  Issue Type: New Feature
>  Components: bookkeeper-client, bookkeeper-server
>Reporter: Rakesh R
>Assignee: Enrico Olivelli
> Fix For: 4.5.0
>
>
> This JIRA to discuss authentication mechanism of bookie clients and server. 
> Assume ZK provides fully secured communication channel using Kerberos based 
> authentication and authorization model. We could also manage and renew users 
> authenticated to BK via Kerberos. There is currently no configuration or 
> hooks for the Bookie process to obtain Kerberos credentials.
> Today an unauthenticated bookie client can easily establish connection with 
> the bookkeeper server. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (BOOKKEEPER-1030) Better management of OutOfMemory errors

[Enrico Olivelli (JIRA)]

Enrico Olivelli created BOOKKEEPER-1030:
---

 Summary: Better management of OutOfMemory errors
 Key: BOOKKEEPER-1030
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1030
 Project: Bookkeeper
  Issue Type: Wish
  Components: bookkeeper-server
Affects Versions: 4.4.0
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Priority: Critical


Some bookie in production run OutOfMemory and the Bookie became really unstable.

17-01-24-13-11-42 Unexpected exception while writing 0@91465 :
17-01-24-13-11-42 java.lang.OutOfMemoryError: Java heap space

That error was inside "WriteEntryProcessorV3" class in a catch (Throwable ) 
clause.

I'm running the Bookie inside a Java process not started with the "standard" 
scripts.

My idea to handle this kind of errors is to add a global "System errors 
handler" to attach to any critical thread/operation and to pass any uncatched 
exception to it.
In case of existing "catch Throwable" the code will call the system handler as 
well.

Maybe we can provide a default implementation which only logs the error to the 
logger, a more invasive implementation which calls Runtime#halt.

I'm trying in production with ExitOnOutOfMemoryError option but it does not 
give any chance to report the status of the JVM



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper pull request #128: BOOKKEEPER-1022 Make BookKeeperAdmin implement...

[eolivelli]

GitHub user eolivelli opened a pull request:

https://github.com/apache/bookkeeper/pull/128

BOOKKEEPER-1022 Make BookKeeperAdmin implement AutoCloseable



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eolivelli/bookkeeper 
BOOKKEEPER-1022-bkadmin-autocloseable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/bookkeeper/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit ac7dbc75ce7837dacbadee5a868d547e80d8f697
Author: eolivelli 
Date:   2017-04-10T09:27:01Z

BOOKKEEPER-1022 Make BookKeeperAdmin implement AutoCloseable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1022) Make BookKeeperAdmin implement AutoCloseable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962638#comment-15962638
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1022:


GitHub user eolivelli opened a pull request:

https://github.com/apache/bookkeeper/pull/128

BOOKKEEPER-1022 Make BookKeeperAdmin implement AutoCloseable



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eolivelli/bookkeeper 
BOOKKEEPER-1022-bkadmin-autocloseable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/bookkeeper/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit ac7dbc75ce7837dacbadee5a868d547e80d8f697
Author: eolivelli 
Date:   2017-04-10T09:27:01Z

BOOKKEEPER-1022 Make BookKeeperAdmin implement AutoCloseable




> Make BookKeeperAdmin implement AutoCloseable
> 
>
> Key: BOOKKEEPER-1022
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1022
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-client
>Affects Versions: 4.4.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Minor
>
> as BookKeeper and LedgerHandler are AutoCloseable it would be good to make 
> BookKeeperAdmin AutoCloseable too



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: bookkeeper-master-git-pullrequest #293

[Apache Jenkins Server]

See 


Changes:

[eolivelli] BOOKKEEPER-1022 Make BookKeeperAdmin implement AutoCloseable

--
[...truncated 24.35 KB...]
Running org.apache.bookkeeper.client.TestWatchEnsembleChange
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.528 sec - in 
org.apache.bookkeeper.client.TestWatchEnsembleChange
Running org.apache.bookkeeper.client.BookieWriteLedgersWithDifferentDigestsTest
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.856 sec - in 
org.apache.bookkeeper.client.BookieWriteLedgersWithDifferentDigestsTest
Running org.apache.bookkeeper.client.ListLedgersTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.268 sec - in 
org.apache.bookkeeper.client.ListLedgersTest
Running org.apache.bookkeeper.client.TestLedgerChecker
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.058 sec - in 
org.apache.bookkeeper.client.TestLedgerChecker
Running org.apache.bookkeeper.client.SlowBookieTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.84 sec - in 
org.apache.bookkeeper.client.SlowBookieTest
Running org.apache.bookkeeper.client.BookieWriteLedgerTest
Tests run: 96, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 77.785 sec - 
in org.apache.bookkeeper.client.BookieWriteLedgerTest
Running org.apache.bookkeeper.client.TestReadTimeout
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.405 sec - in 
org.apache.bookkeeper.client.TestReadTimeout
Running org.apache.bookkeeper.client.LocalBookKeeperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.781 sec - in 
org.apache.bookkeeper.client.LocalBookKeeperTest
Running org.apache.bookkeeper.client.BookKeeperCloseTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.057 sec - in 
org.apache.bookkeeper.client.BookKeeperCloseTest
Running org.apache.bookkeeper.client.BookKeeperTest
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 64.173 sec - 
in org.apache.bookkeeper.client.BookKeeperTest
Running org.apache.bookkeeper.client.TestSpeculativeRead
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.89 sec - in 
org.apache.bookkeeper.client.TestSpeculativeRead
Running org.apache.bookkeeper.client.UpdateLedgerCmdTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.092 sec - in 
org.apache.bookkeeper.client.UpdateLedgerCmdTest
Running org.apache.bookkeeper.client.TestBookieHealthCheck
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.141 sec - in 
org.apache.bookkeeper.client.TestBookieHealthCheck
Running org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.233 sec - in 
org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Running org.apache.bookkeeper.client.TestLedgerFragmentReplication
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.354 sec - in 
org.apache.bookkeeper.client.TestLedgerFragmentReplication
Running org.apache.bookkeeper.client.TestFencing
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.222 sec - 
in org.apache.bookkeeper.client.TestFencing
Running org.apache.bookkeeper.client.TestRackawareEnsemblePlacementPolicy
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.611 sec - 
in org.apache.bookkeeper.client.TestRackawareEnsemblePlacementPolicy
Running org.apache.bookkeeper.client.GenericEnsemblePlacementPolicyTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.95 sec - in 
org.apache.bookkeeper.client.GenericEnsemblePlacementPolicyTest
Running org.apache.bookkeeper.client.TestRegionAwareEnsemblePlacementPolicy
Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.539 sec - in 
org.apache.bookkeeper.client.TestRegionAwareEnsemblePlacementPolicy
Running org.apache.bookkeeper.client.UpdateLedgerOpTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.922 sec - in 
org.apache.bookkeeper.client.UpdateLedgerOpTest
Running 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.29 sec - in 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Running org.apache.bookkeeper.client.LedgerCloseTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.491 sec - in 
org.apache.bookkeeper.client.LedgerCloseTest
Running org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.32 sec - in 
org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Running org.apache.bookkeeper.client.TestTryReadLastConfirmed
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.157 sec - in 
org.apache.bookkeeper.client.TestTryReadLastConfirmed
Running 
org.apache.bookkeeper.cli

[GitHub] bookkeeper issue #117: BOOKKEEPER-1010 Moving Guava to 20.0

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
@arvindkandhare do you have news ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1010) Bump up Guava version to 20.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962781#comment-15962781
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1010:


Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
@arvindkandhare do you have news ?


> Bump up Guava version to 20.0
> -
>
> Key: BOOKKEEPER-1010
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1010
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-server
>Reporter: Arvind Kandhare
>
> Currently bookkeeper is using Guava 13.0. Guava has moved forward and at 
> version 20.0 there are some API changes.
> This becomes an issue if a project using Guava 20.0 tries to run bookie 
> server inproc. Bumping the Guava version to 20.0 will fix that issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/116
  
@kishorekasi could you push your current local version so that me and 
@revans2 can help you with failing tests ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962783#comment-15962783
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1008:


Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/116
  
@kishorekasi could you push your current local version so that me and 
@revans2 can help you with failing tests ?


> Move to netty4
> --
>
> Key: BOOKKEEPER-1008
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1008
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-client, bookkeeper-server
>Affects Versions: 4.5.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>
> As part of the Yahoo push back and in general we would like to move to netty 
> 4, preferably netty 4.1.x for the client and server communication.
> This lays the ground work for zero copy, or very nearly zero copy handling on 
> the server side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #128: BOOKKEEPER-1022 Make BookKeeperAdmin implement AutoCl...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/bookkeeper/pull/128
  
+1 (non-binding)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1022) Make BookKeeperAdmin implement AutoCloseable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962838#comment-15962838
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1022:


Github user revans2 commented on the issue:

https://github.com/apache/bookkeeper/pull/128
  
+1 (non-binding)


> Make BookKeeperAdmin implement AutoCloseable
> 
>
> Key: BOOKKEEPER-1022
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1022
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-client
>Affects Versions: 4.4.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Minor
>
> as BookKeeper and LedgerHandler are AutoCloseable it would be good to make 
> BookKeeperAdmin AutoCloseable too



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BOOKKEEPER-391) Support Kerberos authentication of bookkeeper

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962848#comment-15962848
 ] 

ASF GitHub Bot commented on BOOKKEEPER-391:
---

Github user revans2 commented on the issue:

https://github.com/apache/bookkeeper/pull/110
  
@eolivelli I am OK with having MD5 in there, but it is horribly insecure 
and should not be used in production.  If we do put it in we should deprecate 
it very quickly afterwards and ask people to move to kerberos.

https://en.wikipedia.org/wiki/MD5

The fact that ZK still uses it is on my TODO list as it should be replaced 
with something better.


> Support Kerberos authentication of bookkeeper
> -
>
> Key: BOOKKEEPER-391
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-391
> Project: Bookkeeper
>  Issue Type: New Feature
>  Components: bookkeeper-client, bookkeeper-server
>Reporter: Rakesh R
>Assignee: Enrico Olivelli
> Fix For: 4.5.0
>
>
> This JIRA to discuss authentication mechanism of bookie clients and server. 
> Assume ZK provides fully secured communication channel using Kerberos based 
> authentication and authorization model. We could also manage and renew users 
> authenticated to BK via Kerberos. There is currently no configuration or 
> hooks for the Bookie process to obtain Kerberos credentials.
> Today an unauthenticated bookie client can easily establish connection with 
> the bookkeeper server. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #110: BOOKKEEPER-391 Support Kerberos authentication of boo...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/bookkeeper/pull/110
  
@eolivelli I am OK with having MD5 in there, but it is horribly insecure 
and should not be used in production.  If we do put it in we should deprecate 
it very quickly afterwards and ask people to move to kerberos.

https://en.wikipedia.org/wiki/MD5

The fact that ZK still uses it is on my TODO list as it should be replaced 
with something better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: bookkeeper-master #1714

[Apache Jenkins Server]

See 

--
[...truncated 23.22 KB...]
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.067 sec - in 
org.apache.bookkeeper.test.LedgerDeleteTest
Running org.apache.bookkeeper.test.ForceReadOnlyBookieTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.192 sec - in 
org.apache.bookkeeper.test.ForceReadOnlyBookieTest
Running org.apache.bookkeeper.test.TestBackwardCompat
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.666 sec - in 
org.apache.bookkeeper.test.TestBackwardCompat
Running org.apache.bookkeeper.test.ReadOnlyBookieTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.641 sec - in 
org.apache.bookkeeper.test.ReadOnlyBookieTest
Running org.apache.bookkeeper.test.MultipleThreadReadTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.878 sec - in 
org.apache.bookkeeper.test.MultipleThreadReadTest
Running org.apache.bookkeeper.test.LedgerCreateDeleteTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.615 sec - in 
org.apache.bookkeeper.test.LedgerCreateDeleteTest
Running org.apache.bookkeeper.test.ConfigurationTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.237 sec - in 
org.apache.bookkeeper.test.ConfigurationTest
Running org.apache.bookkeeper.test.BookieFailureTest
Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.057 sec - 
in org.apache.bookkeeper.test.BookieFailureTest
Running org.apache.bookkeeper.test.LocalBookiesRegistryTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.674 sec - in 
org.apache.bookkeeper.test.LocalBookiesRegistryTest
Running org.apache.bookkeeper.test.ConditionalSetTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.565 sec - in 
org.apache.bookkeeper.test.ConditionalSetTest
Running org.apache.bookkeeper.test.BookieJournalRollingTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.184 sec - in 
org.apache.bookkeeper.test.BookieJournalRollingTest
Running org.apache.bookkeeper.test.BookieZKExpireTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.303 sec - in 
org.apache.bookkeeper.test.BookieZKExpireTest
Running 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 72.099 sec - in 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Running org.apache.bookkeeper.client.TestSpeculativeRead
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.473 sec - in 
org.apache.bookkeeper.client.TestSpeculativeRead
Running org.apache.bookkeeper.client.TestBookieHealthCheck
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.452 sec - in 
org.apache.bookkeeper.client.TestBookieHealthCheck
Running org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.4 sec - in 
org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Running org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.197 sec - in 
org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Running org.apache.bookkeeper.client.UpdateLedgerCmdTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.365 sec - in 
org.apache.bookkeeper.client.UpdateLedgerCmdTest
Running org.apache.bookkeeper.client.TestLedgerFragmentReplication
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.596 sec - in 
org.apache.bookkeeper.client.TestLedgerFragmentReplication
Running org.apache.bookkeeper.client.BookieRecoveryTest
Tests run: 96, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 67.782 sec <<< 
FAILURE! - in org.apache.bookkeeper.client.BookieRecoveryTest
ensurePasswordUsedForOldLedgers[4](org.apache.bookkeeper.client.BookieRecoveryTest)
  Time elapsed: 1.998 sec  <<< ERROR!
org.apache.bookkeeper.client.BKException$BKNoSuchLedgerExistsException

ensurePasswordUsedForOldLedgers[5](org.apache.bookkeeper.client.BookieRecoveryTest)
  Time elapsed: 2.117 sec  <<< ERROR!
org.apache.bookkeeper.client.BKException$BKNoSuchLedgerExistsException

Running org.apache.bookkeeper.client.LedgerCloseTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.935 sec - in 
org.apache.bookkeeper.client.LedgerCloseTest
Running org.apache.bookkeeper.client.LedgerRecoveryTest
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.408 sec - 
in org.apache.bookkeeper.client.LedgerRecoveryTest
Running org.apache.bookkeeper.client.TestTryReadLastConfirmed
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.368 sec - in 
org.apache.bookkeeper.client.TestTryReadLastConfirmed
Running org.apache.bookkeeper.client.UpdateLedgerOpTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.

[GitHub] bookkeeper pull request #129: [BOOKEEPER-1002] Limiting the number of open f...

[kishorvpatil]

GitHub user kishorvpatil opened a pull request:

https://github.com/apache/bookkeeper/pull/129

[BOOKEEPER-1002] Limiting the number of open files to avoid process max



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kishorvpatil/bookkeeper bk1002

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/bookkeeper/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #126: BOOKKEEPER-1018: Allow client to select older V2 prot...

[govind-menon]

Github user govind-menon commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
@sijie Good to merge? As we discussed in the meeting the test cases and 
other parts of the API will be a separate PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1018) Allow client to select older V2 protocol (no protobuf)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962995#comment-15962995
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1018:


Github user govind-menon commented on the issue:

https://github.com/apache/bookkeeper/pull/126
  
@sijie Good to merge? As we discussed in the meeting the test cases and 
other parts of the API will be a separate PR


> Allow client to select older V2 protocol (no protobuf)
> --
>
> Key: BOOKKEEPER-1018
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1018
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-server
>Reporter: Govind Menon
>Assignee: Govind Menon
> Fix For: 4.5.0
>
>
> Oriignally done by Matteo Merli



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: bookkeeper-master-git-pullrequest #294

[Apache Jenkins Server]

See 


Changes:

[kpatil] Limiting the number of open files to avoid process max

--
[...truncated 24.41 KB...]
Running org.apache.bookkeeper.conf.NoSystemPropertiesConfigurationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.343 sec - in 
org.apache.bookkeeper.conf.NoSystemPropertiesConfigurationTest
Running org.apache.bookkeeper.conf.SystemPropertiesConfigurationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.261 sec - in 
org.apache.bookkeeper.conf.SystemPropertiesConfigurationTest
Running org.apache.bookkeeper.zookeeper.TestZooKeeperClient
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.215 sec - in 
org.apache.bookkeeper.zookeeper.TestZooKeeperClient
Running org.apache.bookkeeper.zookeeper.TestRetryPolicy
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.13 sec - in 
org.apache.bookkeeper.zookeeper.TestRetryPolicy
Running org.apache.bookkeeper.bookie.BookieJournalTest
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.052 sec - in 
org.apache.bookkeeper.bookie.BookieJournalTest
Running org.apache.bookkeeper.bookie.EntryLogTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.659 sec - in 
org.apache.bookkeeper.bookie.EntryLogTest
Running org.apache.bookkeeper.bookie.IndexCorruptionTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.595 sec - in 
org.apache.bookkeeper.bookie.IndexCorruptionTest
Running org.apache.bookkeeper.bookie.LedgerStorageTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.547 sec - in 
org.apache.bookkeeper.bookie.LedgerStorageTest
Running org.apache.bookkeeper.bookie.IndexPersistenceMgrTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.412 sec - in 
org.apache.bookkeeper.bookie.IndexPersistenceMgrTest
Running org.apache.bookkeeper.bookie.TestSyncThread
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.05 sec - in 
org.apache.bookkeeper.bookie.TestSyncThread
Running org.apache.bookkeeper.bookie.TestLedgerDirsManager
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.979 sec - in 
org.apache.bookkeeper.bookie.TestLedgerDirsManager
Running org.apache.bookkeeper.bookie.BookieShutdownTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.097 sec - in 
org.apache.bookkeeper.bookie.BookieShutdownTest
Running org.apache.bookkeeper.bookie.EnableZkSecurityBasicTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.962 sec - in 
org.apache.bookkeeper.bookie.EnableZkSecurityBasicTest
Running org.apache.bookkeeper.bookie.UpdateCookieCmdTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.286 sec - in 
org.apache.bookkeeper.bookie.UpdateCookieCmdTest
Running org.apache.bookkeeper.bookie.UpgradeTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.955 sec - in 
org.apache.bookkeeper.bookie.UpgradeTest
Running org.apache.bookkeeper.bookie.TestGcOverreplicatedLedger
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.286 sec - in 
org.apache.bookkeeper.bookie.TestGcOverreplicatedLedger
Running org.apache.bookkeeper.bookie.CookieTest
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.787 sec - in 
org.apache.bookkeeper.bookie.CookieTest
Running org.apache.bookkeeper.bookie.BookieThreadTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.365 sec - in 
org.apache.bookkeeper.bookie.BookieThreadTest
Running org.apache.bookkeeper.bookie.BookieInitializationTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.841 sec - in 
org.apache.bookkeeper.bookie.BookieInitializationTest
Running org.apache.bookkeeper.bookie.LedgerCacheTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.16 sec - in 
org.apache.bookkeeper.bookie.LedgerCacheTest
Running org.apache.bookkeeper.bookie.CreateNewLogTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.73 sec - in 
org.apache.bookkeeper.bookie.CreateNewLogTest
Running org.apache.bookkeeper.bookie.CompactionTest
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 107.147 sec - 
in org.apache.bookkeeper.bookie.CompactionTest
Running org.apache.bookkeeper.metastore.TestMetaStore
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.936 sec - in 
org.apache.bookkeeper.metastore.TestMetaStore
Running org.apache.bookkeeper.auth.TestAuth
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.922 sec - 
in org.apache.bookkeeper.auth.TestAuth
Running org.apache.bookkeeper.util.TestDiskChecker
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec - in 
org.apache.bookkeeper.util.TestDiskChecker
Running org.apache.bookkeeper.util.collections.ConcurrentLongLongHashMapTest
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, T

[GitHub] bookkeeper issue #108: BOOKKEEPER-944: LowWaterMark Storage Threshold

[reddycharan]

Github user reddycharan commented on the issue:

https://github.com/apache/bookkeeper/pull/108
  
still working on this..will get back in couple of days


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-944) Multiple issues and improvements to BK Compaction.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963213#comment-15963213
 ] 

ASF GitHub Bot commented on BOOKKEEPER-944:
---

Github user reddycharan commented on the issue:

https://github.com/apache/bookkeeper/pull/108
  
still working on this..will get back in couple of days


> Multiple issues and improvements to BK Compaction.
> --
>
> Key: BOOKKEEPER-944
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-944
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-server
>Affects Versions: 4.4.0
>Reporter: Venkateswararao Jujjuri (JV)
>Assignee: Venkateswararao Jujjuri (JV)
>
> We have identified multiple issues with BK compaction.
> This issue is to list all of them in one Jira ticket.
> 1.
> MajorCompaction and MinorCompaction are very basic. Either they do it or 
> won’t do it. Proposal is to  add Low Water Mark(LWM) and High Water Mark(HWM) 
> to the disk space. Have different compaction frequency and re-claim %s when 
> the disk space is < low water mark  ,  >  LWM < HWM, > HWM.
> 2.
> MajorCompaction and Minor Compactions are strictly frequency based. They 
> should at least time of the day based, and also run during low system load, 
> and if the system load raises, reduce the compaction depending on the disk 
> availability 
> 3.
> Current code disables compaction when disk space grows beyond configured 
> threshold. There is no exit from this point. Have an option to keep reserved 
> space for compaction, at least 2 entryLog file sizes when 
> isForceGCAllowWhenNoSpace enabled.
> 4.
> Current code toggles READONLY status of the bookie as soon as it falls below 
> the disk storage threshold. Imagine if we keep 95% as the threshold, Bookie 
> becomes RW as soon as it falls below 95 % and few more writes pushes it above 
> 95 and it turns back to RONLY. Use a set of defines (another set of LWM/HWM?) 
> where Bookie turns RO on high end and won't become RW until it hits low end.
> 5.
> Current code never checks if the compaction is enabled or disabled once the 
> major/minor compaction is started. If the bookie goes > disk threshold (95%) 
> and at that compaction is going on, it never checks until it finishes but 
> there may not be disk available for compaction to take place. So check if 
> compaction is enabled after processing every EntryLog.
> 6.
> Current code changes the Bookie Cookie value even when new storage is added. 
> When the cookie changes Bookie becomes a new one, and BK cluster treats it as 
> new bookie. If we have mechanism to keep valid cookie even after adding 
> additional disk space, we may have a chance to bring the bookie back to 
> healthy mode and have compaction going.
> 7. Bug
> CheckPoint was never attempted to complete after once sync failure. There is 
> a TODO in the code for this area.
> 8.
> When the disk is above threshold, Bookie goes to RO. If we have to restart 
> the bookie, on the way back, bookie tries to create new entrylog and other 
> files, which will fail because disk usage is above threshold, hence bookie 
> refuses to come up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #117: BOOKKEEPER-1010 Moving Guava to 20.0

[arvindkandhare]

Github user arvindkandhare commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
Hi, I am not able to get the same error locally and I have lost the Jenkins 
build. What is the procedure to kick it off again? If you could share that it 
will be helpful to get me started on this again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1010) Bump up Guava version to 20.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963279#comment-15963279
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1010:


Github user arvindkandhare commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
Hi, I am not able to get the same error locally and I have lost the Jenkins 
build. What is the procedure to kick it off again? If you could share that it 
will be helpful to get me started on this again.


> Bump up Guava version to 20.0
> -
>
> Key: BOOKKEEPER-1010
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1010
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-server
>Reporter: Arvind Kandhare
>
> Currently bookkeeper is using Guava 13.0. Guava has moved forward and at 
> version 20.0 there are some API changes.
> This becomes an issue if a project using Guava 20.0 tries to run bookie 
> server inproc. Bumping the Guava version to 20.0 will fix that issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #117: BOOKKEEPER-1010 Moving Guava to 20.0

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
Just push again a commit  agaist your branch on github or maybe close and 
reopen the PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1010) Bump up Guava version to 20.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963280#comment-15963280
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1010:


Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
Just push again a commit  agaist your branch on github or maybe close and 
reopen the PR


> Bump up Guava version to 20.0
> -
>
> Key: BOOKKEEPER-1010
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1010
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-server
>Reporter: Arvind Kandhare
>
> Currently bookkeeper is using Guava 13.0. Guava has moved forward and at 
> version 20.0 there are some API changes.
> This becomes an issue if a project using Guava 20.0 tries to run bookie 
> server inproc. Bumping the Guava version to 20.0 will fix that issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #117: BOOKKEEPER-1010 Moving Guava to 20.0

[arvindkandhare]

Github user arvindkandhare commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
Thanks for the pointers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1010) Bump up Guava version to 20.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963284#comment-15963284
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1010:


Github user arvindkandhare commented on the issue:

https://github.com/apache/bookkeeper/pull/117
  
Thanks for the pointers.


> Bump up Guava version to 20.0
> -
>
> Key: BOOKKEEPER-1010
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1010
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-server
>Reporter: Arvind Kandhare
>
> Currently bookkeeper is using Guava 13.0. Guava has moved forward and at 
> version 20.0 there are some API changes.
> This becomes an issue if a project using Guava 20.0 tries to run bookie 
> server inproc. Bumping the Guava version to 20.0 will fix that issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[Samuel Just (JIRA)]

Samuel Just created BOOKKEEPER-1031:
---

 Summary: ReplicationWorker.rereplicate fails to call close() on 
ReadOnlyLedgerHandle
 Key: BOOKKEEPER-1031
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-auto-recovery
Reporter: Samuel Just


This has the effect of permanently adding 1 listener per call into 
AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[Samuel Just (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963374#comment-15963374
 ] 

Samuel Just commented on BOOKKEEPER-1031:
-

I've got a simple patch (can't figure out how to assign this to myself).

> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Reporter: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: bookkeeper-master-git-pullrequest #295

[Apache Jenkins Server]

See 


Changes:

[arvind.kandhare] Moving Guava to 20.0

--
[...truncated 24.96 KB...]
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.977 sec - in 
org.apache.bookkeeper.zookeeper.TestZooKeeperClient
Running org.apache.bookkeeper.zookeeper.TestRetryPolicy
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.07 sec - in 
org.apache.bookkeeper.zookeeper.TestRetryPolicy
Running org.apache.bookkeeper.bookie.BookieJournalTest
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.753 sec - in 
org.apache.bookkeeper.bookie.BookieJournalTest
Running org.apache.bookkeeper.bookie.EntryLogTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.706 sec - in 
org.apache.bookkeeper.bookie.EntryLogTest
Running org.apache.bookkeeper.bookie.IndexCorruptionTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.335 sec - in 
org.apache.bookkeeper.bookie.IndexCorruptionTest
Running org.apache.bookkeeper.bookie.LedgerStorageTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.614 sec - in 
org.apache.bookkeeper.bookie.LedgerStorageTest
Running org.apache.bookkeeper.bookie.IndexPersistenceMgrTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.321 sec - in 
org.apache.bookkeeper.bookie.IndexPersistenceMgrTest
Running org.apache.bookkeeper.bookie.TestSyncThread
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.308 sec - in 
org.apache.bookkeeper.bookie.TestSyncThread
Running org.apache.bookkeeper.bookie.TestLedgerDirsManager
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.772 sec - in 
org.apache.bookkeeper.bookie.TestLedgerDirsManager
Running org.apache.bookkeeper.bookie.BookieShutdownTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.67 sec - in 
org.apache.bookkeeper.bookie.BookieShutdownTest
Running org.apache.bookkeeper.bookie.EnableZkSecurityBasicTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.281 sec - in 
org.apache.bookkeeper.bookie.EnableZkSecurityBasicTest
Running org.apache.bookkeeper.bookie.UpdateCookieCmdTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.312 sec - in 
org.apache.bookkeeper.bookie.UpdateCookieCmdTest
Running org.apache.bookkeeper.bookie.UpgradeTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.44 sec - in 
org.apache.bookkeeper.bookie.UpgradeTest
Running org.apache.bookkeeper.bookie.TestGcOverreplicatedLedger
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.376 sec - in 
org.apache.bookkeeper.bookie.TestGcOverreplicatedLedger
Running org.apache.bookkeeper.bookie.CookieTest
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.338 sec - in 
org.apache.bookkeeper.bookie.CookieTest
Running org.apache.bookkeeper.bookie.BookieThreadTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.331 sec - in 
org.apache.bookkeeper.bookie.BookieThreadTest
Running org.apache.bookkeeper.bookie.BookieInitializationTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.735 sec - in 
org.apache.bookkeeper.bookie.BookieInitializationTest
Running org.apache.bookkeeper.bookie.LedgerCacheTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.463 sec - in 
org.apache.bookkeeper.bookie.LedgerCacheTest
Running org.apache.bookkeeper.bookie.CreateNewLogTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.082 sec - in 
org.apache.bookkeeper.bookie.CreateNewLogTest
Running org.apache.bookkeeper.bookie.CompactionTest
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 108.024 sec - 
in org.apache.bookkeeper.bookie.CompactionTest
Running org.apache.bookkeeper.metastore.TestMetaStore
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.788 sec - in 
org.apache.bookkeeper.metastore.TestMetaStore
Running org.apache.bookkeeper.auth.TestAuth
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.406 sec - 
in org.apache.bookkeeper.auth.TestAuth
Running org.apache.bookkeeper.util.TestDiskChecker
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.586 sec - in 
org.apache.bookkeeper.util.TestDiskChecker
Running org.apache.bookkeeper.util.collections.ConcurrentLongLongHashMapTest
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.56 sec - in 
org.apache.bookkeeper.util.collections.ConcurrentLongLongHashMapTest
Running org.apache.bookkeeper.util.collections.ConcurrentLongHashSetTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.529 sec - in 
org.apache.bookkeeper.util.collections.ConcurrentLongHashSetTest
Running org.apache.bookkeeper.util.collections.ConcurrentLongHashMapTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.566 sec - in 
org.apache.bookkeeper.util.collections.

[GitHub] bookkeeper pull request #130: BOOKKEEPER-1031: close the ledger handle in Re...

[athanatos]

GitHub user athanatos opened a pull request:

https://github.com/apache/bookkeeper/pull/130

BOOKKEEPER-1031: close the ledger handle in ReplicationWorker.rerepli…

…cate

Otherwise, we build up an unbounded set of Listeners in the
AbstractZkLedgerManager listenerSet structure which never go
away.

Signed-off-by: Samuel Just 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/athanatos/bookkeeper 
forupstream/BOOKKEEPER-1031

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/bookkeeper/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit f5f595b1aadbef6d36b29d2f93de7cb3bcdb67ca
Author: Samuel Just 
Date:   2017-04-05T21:12:58Z

BOOKKEEPER-1031: close the ledger handle in ReplicationWorker.rereplicate

Otherwise, we build up an unbounded set of Listeners in the
AbstractZkLedgerManager listenerSet structure which never go
away.

Signed-off-by: Samuel Just 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963390#comment-15963390
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1031:


GitHub user athanatos opened a pull request:

https://github.com/apache/bookkeeper/pull/130

BOOKKEEPER-1031: close the ledger handle in ReplicationWorker.rerepli…

…cate

Otherwise, we build up an unbounded set of Listeners in the
AbstractZkLedgerManager listenerSet structure which never go
away.

Signed-off-by: Samuel Just 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/athanatos/bookkeeper 
forupstream/BOOKKEEPER-1031

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/bookkeeper/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit f5f595b1aadbef6d36b29d2f93de7cb3bcdb67ca
Author: Samuel Just 
Date:   2017-04-05T21:12:58Z

BOOKKEEPER-1031: close the ledger handle in ReplicationWorker.rereplicate

Otherwise, we build up an unbounded set of Listeners in the
AbstractZkLedgerManager listenerSet structure which never go
away.

Signed-off-by: Samuel Just 




> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Reporter: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[Samuel Just (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963391#comment-15963391
 ] 

Samuel Just commented on BOOKKEEPER-1031:
-

https://github.com/apache/bookkeeper/pull/130

> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Affects Versions: 4.6.0
>Reporter: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[Matteo Merli (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matteo Merli reassigned BOOKKEEPER-1031:


Assignee: Samuel Just

> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Affects Versions: 4.6.0
>Reporter: Samuel Just
>Assignee: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963393#comment-15963393
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1031:


Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/130
  
@sijie can you add Samuel to the contributors in JIRA so that the issue can 
be assigned to him?


> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Affects Versions: 4.6.0
>Reporter: Samuel Just
>Assignee: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/bookkeeper/pull/130
  
@sijie can you add Samuel to the contributors in JIRA so that the issue can 
be assigned to him?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: bookkeeper-master-git-pullrequest #296

[Apache Jenkins Server]

See 


Changes:

[sjust] BOOKKEEPER-1031: close the ledger handle in

--
[...truncated 24.35 KB...]
Running org.apache.bookkeeper.client.TestWatchEnsembleChange
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.901 sec - in 
org.apache.bookkeeper.client.TestWatchEnsembleChange
Running org.apache.bookkeeper.client.BookieWriteLedgersWithDifferentDigestsTest
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.513 sec - in 
org.apache.bookkeeper.client.BookieWriteLedgersWithDifferentDigestsTest
Running org.apache.bookkeeper.client.ListLedgersTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.858 sec - in 
org.apache.bookkeeper.client.ListLedgersTest
Running org.apache.bookkeeper.client.TestLedgerChecker
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.562 sec - in 
org.apache.bookkeeper.client.TestLedgerChecker
Running org.apache.bookkeeper.client.SlowBookieTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.823 sec - in 
org.apache.bookkeeper.client.SlowBookieTest
Running org.apache.bookkeeper.client.BookieWriteLedgerTest
Tests run: 96, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.206 sec - 
in org.apache.bookkeeper.client.BookieWriteLedgerTest
Running org.apache.bookkeeper.client.TestReadTimeout
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.031 sec - in 
org.apache.bookkeeper.client.TestReadTimeout
Running org.apache.bookkeeper.client.LocalBookKeeperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.317 sec - in 
org.apache.bookkeeper.client.LocalBookKeeperTest
Running org.apache.bookkeeper.client.BookKeeperCloseTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.675 sec - in 
org.apache.bookkeeper.client.BookKeeperCloseTest
Running org.apache.bookkeeper.client.BookKeeperTest
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.209 sec - 
in org.apache.bookkeeper.client.BookKeeperTest
Running org.apache.bookkeeper.client.TestSpeculativeRead
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.137 sec - in 
org.apache.bookkeeper.client.TestSpeculativeRead
Running org.apache.bookkeeper.client.UpdateLedgerCmdTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.864 sec - in 
org.apache.bookkeeper.client.UpdateLedgerCmdTest
Running org.apache.bookkeeper.client.TestBookieHealthCheck
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.545 sec - in 
org.apache.bookkeeper.client.TestBookieHealthCheck
Running org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.188 sec - in 
org.apache.bookkeeper.client.RoundRobinDistributionScheduleTest
Running org.apache.bookkeeper.client.TestLedgerFragmentReplication
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.09 sec - in 
org.apache.bookkeeper.client.TestLedgerFragmentReplication
Running org.apache.bookkeeper.client.TestFencing
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.633 sec - 
in org.apache.bookkeeper.client.TestFencing
Running org.apache.bookkeeper.client.TestRackawareEnsemblePlacementPolicy
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.167 sec - 
in org.apache.bookkeeper.client.TestRackawareEnsemblePlacementPolicy
Running org.apache.bookkeeper.client.GenericEnsemblePlacementPolicyTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.899 sec - in 
org.apache.bookkeeper.client.GenericEnsemblePlacementPolicyTest
Running org.apache.bookkeeper.client.TestRegionAwareEnsemblePlacementPolicy
Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.534 sec - 
in org.apache.bookkeeper.client.TestRegionAwareEnsemblePlacementPolicy
Running org.apache.bookkeeper.client.UpdateLedgerOpTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.233 sec - in 
org.apache.bookkeeper.client.UpdateLedgerOpTest
Running 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.638 sec - in 
org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest
Running org.apache.bookkeeper.client.LedgerCloseTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.453 sec - in 
org.apache.bookkeeper.client.LedgerCloseTest
Running org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.238 sec - in 
org.apache.bookkeeper.client.TestGetBookieInfoTimeout
Running org.apache.bookkeeper.client.TestTryReadLastConfirmed
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.168 sec - in 
org.apache.bookkeeper.client.TestTryReadLastConfirmed
Running 
org.apache.bookkeeper.client.TestRackaware

[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...

[athanatos]

Github user athanatos commented on the issue:

https://github.com/apache/bookkeeper/pull/130
  
Build's failing due to

Tests in error:
  BookieRecoveryTest.ensurePasswordUsedForOldLedgers[4] » 
BKNoSuchLedgerExists
  BookieRecoveryTest.ensurePasswordUsedForOldLedgers[5] » 
BKNoSuchLedgerExists

which seems to be broken in master.

I did a bisect and found that


https://github.com/apache/bookkeeper/commit/42e8f1294f206cbe51a6af669cf605833b78bf42
 introduced both a hang in that test and that test failure.  
https://github.com/apache/bookkeeper/commit/32ebf0ad68f85daffdec571e28206339a4d09443
 fixed the hang uncovering the test failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963462#comment-15963462
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1031:


Github user athanatos commented on the issue:

https://github.com/apache/bookkeeper/pull/130
  
Build's failing due to

Tests in error:
  BookieRecoveryTest.ensurePasswordUsedForOldLedgers[4] » 
BKNoSuchLedgerExists
  BookieRecoveryTest.ensurePasswordUsedForOldLedgers[5] » 
BKNoSuchLedgerExists

which seems to be broken in master.

I did a bisect and found that


https://github.com/apache/bookkeeper/commit/42e8f1294f206cbe51a6af669cf605833b78bf42
 introduced both a hang in that test and that test failure.  
https://github.com/apache/bookkeeper/commit/32ebf0ad68f85daffdec571e28206339a4d09443
 fixed the hang uncovering the test failure.


> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Affects Versions: 4.6.0
>Reporter: Samuel Just
>Assignee: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: bookkeeper-master-git-pullrequest #297

[Apache Jenkins Server]

See 


--
GitHub pull request #116 to apache/bookkeeper
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-us1 (ubuntu trusty) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository git://github.com/apache/bookkeeper.git
 > git init 
 >  # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/bookkeeper.git
 > git --version # timeout=10
 > git fetch --tags --progress git://github.com/apache/bookkeeper.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/bookkeeper.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/bookkeeper.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/bookkeeper.git
 > git fetch --tags --progress git://github.com/apache/bookkeeper.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10
 > git checkout -f origin/master
 > git branch -a -v --no-abbrev # timeout=10
 > git checkout -b master origin/master
  Opening connection
Done: 0
  Counting objects
Done: 99
  Finding sources
Done: 99
  Getting sizes
Done: 88
  Compressing objects
Done: 126013
  Writing objects
Done: 99
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/297
 > git rev-parse refs/tags/changes/297^{commit} # timeout=10
 > git merge 6babe12da3954728a20f02970a6f5b6fd6cc9835 # timeout=10
FATAL: Command "git merge 6babe12da3954728a20f02970a6f5b6fd6cc9835" returned 
status code 1:
stdout: Auto-merging pom.xml
CONFLICT (content): Merge conflict in pom.xml
Auto-merging 
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
CONFLICT (content): Merge conflict in 
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
Auto-merging 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRackawareEnsemblePlacementPolicy.java
Auto-merging 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTest.java
Removing 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/VMLocalChannelManager.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
CONFLICT (content): Merge conflict in 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
Removing 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NioServerSocketChannelManager.java
Removing 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ChannelManager.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookkeeperInternalCallbacks.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
CONFLICT (content): Merge conflict in 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
CONFLICT (content): Merge conflict in 
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
CONFLICT (content): Merge conflict in 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ExplicitLacFlushPolicy.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DefaultEnsemblePlacementPolicy.java
CONFLICT (content): Merge conflict in 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DefaultEnsemblePlacementPolicy.java
Auto-merging 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
CONFLICT (content): Merge conflict in 
bookkeeper-server/src/main/java/org/apache/bookkeeper/clien

Build failed in Jenkins: bookkeeper-master-git-pullrequest #298

[Apache Jenkins Server]

See 


Changes:

[kudayashankar] BOOKKEEPER-1008 Move to Netty4.1

--
[...truncated 24.23 KB...]
Downloading: 
https://repo.maven.apache.org/maven2/io/netty/netty-tcnative-boringssl-static/1.1.33.Fork25/netty-tcnative-boringssl-static-1.1.33.Fork25-linux-x86_64.jar
4/3501 KB   8/3501 KB   12/3501 KB   16/3501 KB   20/3501 KB   24/3501 KB   
28/3501 KB   32/3501 KB   36/3501 KB   40/3501 KB   44/3501 KB   48/3501 KB   
52/3501 KB   56/3501 KB   60/3501 KB   64/3501 KB   68/3501 KB   72/3501 KB   
76/3501 KB   80/3501 KB   84/3501 KB   88/3501 KB   92/3501 KB   96/3501 KB   
100/3501 KB   104/3501 KB   108/3501 KB   112/3501 KB   116/3501 KB   120/3501 
KB   124/3501 KB   128/3501 KB   132/3501 KB   136/3501 KB   140/3501 KB   
144/3501 KB   148/3501 KB   152/3501 KB   156/3501 KB   160/3501 KB   164/3501 
KB   168/3501 KB   172/3501 KB   176/3501 KB   180/3501 KB   184/3501 KB   
188/3501 KB   192/3501 KB   196/3501 KB   200/3501 KB   204/3501 KB   208/3501 
KB   212/3501 KB   216/3501 KB   220/3501 KB   224/3501 KB   228/3501 KB   
232/3501 KB   236/3501 KB   240/3501 KB   244/3501 KB   248/3501 KB   252/3501 
KB   256/3501 KB   260/3501 KB   264/3501 KB   268/3501 KB   272/3501 KB   
276/3501 KB   280/3501 KB   284/3501 KB   288/3501 KB   292/3501 KB   296/3501 
KB   300/3501 KB   304/3501 KB   308/3501 KB   312/3501 KB   316/3501 KB   
320/3501 KB   324/3501 KB   328/3501 KB   332/3501 KB   336/3501 KB   340/3501 
KB   344/3501 KB   348/3501 KB   352/3501 KB   356/3501 KB   360/3501 KB   
364/3501 KB   368/3501 KB   372/3501 KB   376/3501 KB   380/3501 KB   384/3501 
KB   388/3501 KB   392/3501 KB   396/3501 KB   400/3501 KB   404/3501 KB   
408/3501 KB   412/3501 KB   416/3501 KB   420/3501 KB   424/3501 KB   428/3501 
KB   432/3501 KB   436/3501 KB   440/3501 KB   444/3501 KB   448/3501 KB   
452/3501 KB   456/3501 KB   460/3501 KB   464/3501 KB   468/3501 KB   472/3501 
KB   476/3501 KB   480/3501 KB   484/3501 KB   488/3501 KB   492/3501 KB   
496/3501 KB   500/3501 KB   504/3501 KB   508/3501 KB   512/3501 KB   516/3501 
KB   520/3501 KB   524/3501 KB   528/3501 KB   532/3501 KB   536/3501 KB   
540/3501 KB   544/3501 KB   548/3501 KB   552/3501 KB   556/3501 KB   560/3501 
KB   564/3501 KB   568/3501 KB   572/3501 KB   576/3501 KB   580/3501 KB   
584/3501 KB   588/3501 KB   592/3501 KB   596/3501 KB   600/3501 KB   604/3501 
KB   608/3501 KB   612/3501 KB   616/3501 KB   620/3501 KB   624/3501 KB   
628/3501 KB   632/3501 KB   636/3501 KB   640/3501 KB   644/3501 KB   648/3501 
KB   652/3501 KB   656/3501 KB   660/3501 KB   664/3501 KB   668/3501 KB   
672/3501 KB   676/3501 KB   680/3501 KB   684/3501 KB   688/3501 KB   692/3501 
KB   696/3501 KB   700/3501 KB   704/3501 KB   708/3501 KB   712/3501 KB   
716/3501 KB   720/3501 KB   724/3501 KB   728/3501 KB   732/3501 KB   736/3501 
KB   740/3501 KB   744/3501 KB   748/3501 KB   752/3501 KB   756/3501 KB   
760/3501 KB   764/3501 KB   768/3501 KB   772/3501 KB   776/3501 KB   780/3501 
KB   784/3501 KB   788/3501 KB   792/3501 KB   796/3501 KB   800/3501 KB   
804/3501 KB   808/3501 KB   812/3501 KB   816/3501 KB   820/3501 KB   824/3501 
KB   828/3501 KB   832/3501 KB   836/3501 KB   840/3501 KB   844/3501 KB   
848/3501 KB   852/3501 KB   856/3501 KB   860/3501 KB   864/3501 KB   868/3501 
KB   872/3501 KB   876/3501 KB   880/3501 KB   884/3501 KB   888/3501 KB   
892/3501 KB   896/3501 KB   900/3501 KB   904/3501 KB   908/3501 KB   912/3501 
KB   916/3501 KB   920/3501 KB   924/3501 KB   928/3501 KB   932/3501 KB   
936/3501 KB   940/3501 KB   944/3501 KB   948/3501 KB   952/3501 KB   956/3501 
KB   960/3501 KB   964/3501 KB   968/3501 KB   972/3501 KB   976/3501 KB   
980/3501 KB   984/3501 KB   988/3501 KB   992/3501 KB   996/3501 KB   1000/3501 
KB   1004/3501 KB   1008/3501 KB   1012/3501 KB   1016/3501 KB   1020/3501 KB   
1024/3501 KB   1028/3501 KB   1032/3501 KB   1036/3501 KB   1036/3501 KB   
3/981 KB   1040/3501 KB   3/981 KB   1040/3501 KB   5/981 KB   1040/3501 KB   
8/981 KB   1040/3501 KB   11/981 KB   1040/3501 KB   13/981 KB   1040/3501 KB   
16/981 KB   1040/3501 KB   19/981 KB   1040/3501 KB   21/981 KB   1040/3501 KB  
 24/981 KB   1040/3501 KB   27/981 KB   1040/3501 KB   29/981 KB   1040/3501 KB 
  32/981 KB   1040/3501 KB   36/981 KB   1040/3501 KB   40/981 KB   1040/3501 
KB   44/981 KB   1040/3501 KB   48/981 KB   1044/3501 KB   48/981 KB   
1048/3501 KB   48/981 KB   1052/3501 KB   48/981 KB   1052/3501 KB   52/981 KB  
 1056/3501 KB   52/981 KB   1056/3501 KB   56/981 KB   1056/3501 KB   60/981 KB 
  1056/3501 KB   64/981 KB   1060/3501 KB   68/981 KB   1060/3501 KB   72/981 
KB   1060/3501 KB   76/981 KB   1060/3501 KB   80/981 KB   1060/3501 KB   
84/981 KB   1060/3501 KB   88/981 KB   1060/3501 KB   92/981 KB   1060/3501 KB  
 96/981 KB   1060/3501 KB   96/981 KB   1064/3501 KB

[jira] [Commented] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[Sijie Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963828#comment-15963828
 ] 

Sijie Guo commented on BOOKKEEPER-1031:
---

I think it is already assigned to [~sjust2].

> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Affects Versions: 4.6.0
>Reporter: Samuel Just
>Assignee: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...

[sijie]

Github user sijie commented on the issue:

https://github.com/apache/bookkeeper/pull/130
  
@athanatos I think those two are known failures. I think @eolivelli knew 
about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1031) ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963830#comment-15963830
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1031:


Github user sijie commented on the issue:

https://github.com/apache/bookkeeper/pull/130
  
@athanatos I think those two are known failures. I think @eolivelli knew 
about it.


> ReplicationWorker.rereplicate fails to call close() on ReadOnlyLedgerHandle
> ---
>
> Key: BOOKKEEPER-1031
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1031
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: bookkeeper-auto-recovery
>Affects Versions: 4.6.0
>Reporter: Samuel Just
>Assignee: Samuel Just
>
> This has the effect of permanently adding 1 listener per call into 
> AbstractZkLedgerManager.listenerSet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #125: BOOKKEEPER-997: Wire protocol change for supporting l...

[sijie]

Github user sijie commented on the issue:

https://github.com/apache/bookkeeper/pull/125
  
ping @merlimat 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-997) Wire protocol change for supporting long poll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963883#comment-15963883
 ] 

ASF GitHub Bot commented on BOOKKEEPER-997:
---

Github user sijie commented on the issue:

https://github.com/apache/bookkeeper/pull/125
  
ping @merlimat 


> Wire protocol change for supporting long poll
> -
>
> Key: BOOKKEEPER-997
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-997
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client, bookkeeper-server
>Reporter: Sijie Guo
>Assignee: Robin Dhamankar
> Fix For: 4.5.0
>
>
> In order to support piggybacking lac and long poll, there will be changes to 
> new fields added to the wire protocol.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper pull request #123: BOOKKEEPER-1021: Improve merge script to handl...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/bookkeeper/pull/123


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1021) Improve the merge script to handle github reviews api

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963893#comment-15963893
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1021:


Github user asfgit closed the pull request at:

https://github.com/apache/bookkeeper/pull/123


> Improve the merge script to handle github reviews api
> -
>
> Key: BOOKKEEPER-1021
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1021
> Project: Bookkeeper
>  Issue Type: Bug
>  Components: build
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 4.5.0
>
>
> Current script doesn't handle the new reviews API. 
> We need to improve the merge script to handle the new review API.
> https://developer.github.com/v3/pulls/reviews/
> We can do similar thing like what DistributedLog is doing.
> https://github.com/apache/incubator-distributedlog/blob/master/scripts/dev/dl-merge-pr.py



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

[kishorekasi]

Github user kishorekasi commented on the issue:

https://github.com/apache/bookkeeper/pull/116
  
Enrico,

I have updated the pull request with my local changes.

Kishore

> On Apr 10, 2017, at 5:42 AM, Enrico Olivelli  
wrote:
> 
> @kishorekasi could you push your current local version so that me and 
@revans2 can help you with failing tests ?
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963894#comment-15963894
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1008:


Github user kishorekasi commented on the issue:

https://github.com/apache/bookkeeper/pull/116
  
Enrico,

I have updated the pull request with my local changes.

Kishore

> On Apr 10, 2017, at 5:42 AM, Enrico Olivelli  
wrote:
> 
> @kishorekasi could you push your current local version so that me and 
@revans2 can help you with failing tests ?
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
> 



> Move to netty4
> --
>
> Key: BOOKKEEPER-1008
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1008
> Project: Bookkeeper
>  Issue Type: Improvement
>  Components: bookkeeper-client, bookkeeper-server
>Affects Versions: 4.5.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>
> As part of the Yahoo push back and in general we would like to move to netty 
> 4, preferably netty 4.1.x for the client and server communication.
> This lays the ground work for zero copy, or very nearly zero copy handling on 
> the server side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)