[DISCUSS] Release 4.14.1

2021-05-24 Thread Matteo Merli
While 4.14.0 is being released (tag was voted and pushed, jars
available in Maven central although not yet announced), an issue was
found that prevents Prometheus metrics to be collected for Bookies.
Details: https://github.com/apache/bookkeeper/pull/2718

Since we need 4.14.0 changes to be included in the imminent Pulsar
2.8.0 release, I think we should release a patch ASAP in order to
unblock that release.

If there are no objections, I'll move forward with the patch release.

Thanks,
Matteo

--
Matteo Merli



Re: [VOTE] Release 4.14.0, release candidate #0

2021-05-24 Thread Andrey Yegorov
Docker is published:
https://hub.docker.com/r/apache/bookkeeper/tags?page=1=last_updated
Python client: https://pypi.org/project/apache-bookkeeper-client/4.14.0/

I noticed that backwards-compat tests haven't been touched since release
4.9.2; updated https://github.com/apache/bookkeeper/pull/2719 - I haven't
spent much time figuring out what's going on there, I'll appreciate the
review.

Docs and release notes changes approved by Henry:
https://github.com/apache/bookkeeper/pull/2712
Unless I see requests to change I'll merge these to get the website updated.


On Mon, May 17, 2021 at 5:07 PM Andrey Yegorov 
wrote:

> Thank you!
>
> We have  quorum of 3 binding votes:
> +1 from Amit Chavan
> +1 from Matteo Merli (binding)
> +1 from Sijie Guo (binding)
> +1 from Enrico Olivelli (binding)
>
> I'll proceed with the final steps of the release tonight/tomorrow morning
> as time permits.
>
>
> On Mon, May 17, 2021 at 12:43 PM Enrico Olivelli 
> wrote:
>
>> +1 (binding)
>>
>> Built from sources
>> Run test from sources
>> Basic verifications
>>
>> Thanks for driving the release
>>
>> Enrico
>>
>> Il Lun 17 Mag 2021, 20:53 Sijie Guo  ha scritto:
>>
>> > +1 (binding)
>> >
>> > All things below are good.
>> >
>> >   * Signatures
>> >   * Source package structure, and compile
>> >   * Binary package
>> >   * Running standalone bookie and client
>> >
>> > On Mon, May 17, 2021 at 9:43 AM Matteo Merli  wrote:
>> >
>> > > +1 (binding)
>> > >
>> > > Checked:
>> > >   * Signatures
>> > >   * Source package structure, and compile
>> > >   * Binary package
>> > >   * Running standalone bookie and client
>> > >
>> > >
>> > > --
>> > > Matteo Merli
>> > > 
>> > >
>> > > On Fri, May 14, 2021 at 2:23 PM Andrey Yegorov
>> > >  wrote:
>> > > >
>> > > > I do not hear voices against it so I assume everyone is ok with
>> this.
>> > > > (I started building RC1 and docker hanged mid-process; happy to not
>> > deal
>> > > > with retry).
>> > > >
>> > > > The vote has been out for about 5 days already.
>> > > > I need votes from 3 PMCs to proceed.
>> > > >
>> > > >
>> > > > On Fri, May 14, 2021 at 12:10 PM Henry Saputra <
>> > henry.sapu...@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > I am +1 to keep Gradle out from this release since the files are
>> ok
>> > > not to
>> > > > > be included.
>> > > > >
>> > > > > I am ok to keep RC0 for 4.14.0 for VOTE as release candidate.
>> > > > >
>> > > > > - Henry
>> > > > >
>> > > > > On Fri, May 14, 2021 at 12:14 AM Enrico Olivelli <
>> > eolive...@gmail.com>
>> > > > > wrote:
>> > > > >
>> > > > > > Andrey,
>> > > > > > I have merged the patch.
>> > > > > >
>> > > > > > In my opinion the source tarball should reflect the git repo
>> > without
>> > > > > > the '.git' database.
>> > > > > > That said, the most important thing is that the source release
>> > > > > > contains the files to build the project and produce working
>> > binaries.
>> > > > > >
>> > > > > > This is in the spirit of Open Source (of the ASF at least), you
>> can
>> > > > > > pick the sources, modify them, build and run the new binaries.
>> > > > > >
>> > > > > > AFAIK The Gradle build is not fully implemented so it is not so
>> > > > > > important to see those files at the moment
>> > > > > > I agree that we can strip away the website, it is useless to the
>> > > > > > purpose of building the project.
>> > > > > >
>> > > > > > Enrico
>> > > > > >
>> > > > > >
>> > > > > > Il giorno gio 13 mag 2021 alle ore 23:43 Andrey Yegorov
>> > > > > >  ha scritto:
>> > > > > > >
>> > > > > > > I looked at the situation with src release artifact, and:
>> > > > > > > - it was definitely built from the right changelist (I spot
>> > checked
>> > > > > some
>> > > > > > > files affected by the last commit)
>> > > > > > > - site/ is explicitly excluded
>> > > > > > >
>> > > > > >
>> > > > >
>> > >
>> >
>> https://github.com/apache/bookkeeper/blob/732b6cf2a6576c844a4b43176125e82d500a6ea8/bookkeeper-dist/src/assemble/src.xml#L61
>> > > > > > > - site2 is not excluded (should be fixed)
>> > > > > > > - gradle files are not explicitly included, pom are
>> > > > > > >
>> > > > > >
>> > > > >
>> > >
>> >
>> https://github.com/apache/bookkeeper/blob/732b6cf2a6576c844a4b43176125e82d500a6ea8/bookkeeper-dist/src/assemble/src.xml#L33
>> > > > > > >
>> > > > > > > that src.xml is used to package the release artifacts
>> > > > > > >
>> > > > > >
>> > > > >
>> > >
>> >
>> https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/pom.xml#L55
>> > > > > > >
>> > > > > > > It looks like the plugin resolves the situation with the file
>> not
>> > > > > > matching
>> > > > > > > includes and excludes by excluding it.
>> > > > > > >
>> > > > > > > PR that adds gradle into the includes patterns and excludes
>> > site2:
>> > > > > > > https://github.com/apache/bookkeeper/pull/2714
>> > > > > > >
>> > > > > > > I can either rebuild the RC or we can decide to proceed.
>> > > > > > > Gradle was not used to build/release 4.14.0
>> > > > > > >
>> > > > > > >
>>