Re: [DISCUSS] BookKeeper 4.15.2 release

[Enrico Olivelli]

Il giorno lun 19 set 2022 alle ore 07:36 Yong Zhang
 ha scritto:
>
> Hi everyone,
>
> I want to discuss starting 4.15.2 release to resolve the regression
> mentioned here:
> https://lists.apache.org/thread/d9gm50kysgjcpbq448s2sy822kho6z6k
>
> Although it is an unexpected setting caused, we never know how the users to
> configure
> it. And we have a PR for fixing it, let's start a new release to include it.
>
> I wanted to also wait for this issue
>  resolution before. But
> it looks won't be resolved
> recently.
>
> Any ideas?

I agree

I think that the PR has not been chery-picked yet to branch-4.15
https://github.com/apache/bookkeeper/commits/branch-4.15

Please also take a look if we need to upgrade some dependencies, like SnakeYAML
https://github.com/apache/bookkeeper/commit/457eaf8dbc0101deef2159e7ec1c312ab66af2db

also
https://github.com/apache/bookkeeper/pull/3470

Thanks

Enrico

>
> Yong

Re: [VOTE] BP-56: Support data migration

[Yong Zhang]

+1 (non-binding)

Yong

On Fri, 16 Sept 2022 at 14:31, ZhangJian He  wrote:

> +1 non-binding
>
> Thanks
> ZhangJian He
>
> On Fri, 16 Sept 2022 at 14:27, Enrico Olivelli 
> wrote:
>
> > +1 (binding)
> >
> > Enrico
> >
> > Il giorno ven 16 set 2022 alle ore 08:26 r...@apache.org
> >  ha scritto:
> > >
> > > LGTM +1
> > >
> > > On 2022/09/15 04:47:25 lordcheng10 wrote:
> > > > Hi Bookkeeper Community, I would like to start a VOTE on "Support
> data
> > > migration."(BP-56)
> > > >
> > > > Here is the design detail:
> > > https://github.com/apache/bookkeeper/issues/3456
> > > > and the discussion thread:
> > > https://lists.apache.org/thread/0zlsm7z5j34j23gtlhf7rf72lfq62jyk
> > > >
> > > > Thanks,
> > > > lordcheng10
> >
>

Re: [DISCUSS] BP-57 Add a public API for creating embeddable servers

[Yong Zhang]

+1

Sounds great

Yong

On Sun, 18 Sept 2022 at 21:20, Enrico Olivelli  wrote:

> +1
> Really helpful!
>
> Enrico
>
> Il Dom 18 Set 2022, 15:02 Diego Salvi  ha
> scritto:
>
> > Hi BookKeepers,
> > I've added a new BP to add a public API for creating embeddable servers:
> > BP-57 
> >
> > *Motivation*
> > BK is used and run in many OS project as an embedded resource.
> > Every time a project needs to embed BK (think about Pulsar, Pravega or
> > HerdDB as some examples) boilerplate code need to be written (and then
> > mantained as per 4.15 changes).
> > Depending from the contest new feature cannot be made directly available
> > and more code need to be added.
> > To run an embedded bookie you need to instantiate many components that
> are
> > really in "public" api and can and will be subject to changes.
> >
> > *Proposal*
> > We already have the whole code to start a BK server instance, it just
> needs
> > to be refactored and exposed as a public API.
> > My idea is to refactor all the code currently at
> > org.apache.bookkeeper.server.Main#buildBookieServer and expose it with a
> > builder pattern.
> > The builder will accept an initial BookieConfiguration (and with no more
> > interaction will produce the same server currently produced from
> > org.apache.bookkeeper.server.Main#buildBookieServer) and will create from
> > the configuration any component not directly provided to the builder.
> > For example you can provide your instances for StatsProvider or
> > MetadataBookieDriver instance or your custom ByteBufAllocator without the
> > need to rewrite the same plain old code.
> > Another big improvement: new features that whould need additional code to
> > be added (just think when integrity checking has been added in BP-46) are
> > already and directly usable.
> >
> > What do you think about it?
> >
> > Diego Salvi
> >
>

[DISCUSS] BookKeeper 4.15.2 release

[Yong Zhang]

Hi everyone,

I want to discuss starting 4.15.2 release to resolve the regression
mentioned here:
https://lists.apache.org/thread/d9gm50kysgjcpbq448s2sy822kho6z6k

Although it is an unexpected setting caused, we never know how the users to
configure
it. And we have a PR for fixing it, let's start a new release to include it.

I wanted to also wait for this issue
 resolution before. But
it looks won't be resolved
recently.

Any ideas?

Yong

Re: [DISCUSS] BP-57 Add a public API for creating embeddable servers

[Enrico Olivelli]

+1
Really helpful!

Enrico

Il Dom 18 Set 2022, 15:02 Diego Salvi  ha
scritto:

> Hi BookKeepers,
> I've added a new BP to add a public API for creating embeddable servers:
> BP-57 
>
> *Motivation*
> BK is used and run in many OS project as an embedded resource.
> Every time a project needs to embed BK (think about Pulsar, Pravega or
> HerdDB as some examples) boilerplate code need to be written (and then
> mantained as per 4.15 changes).
> Depending from the contest new feature cannot be made directly available
> and more code need to be added.
> To run an embedded bookie you need to instantiate many components that are
> really in "public" api and can and will be subject to changes.
>
> *Proposal*
> We already have the whole code to start a BK server instance, it just needs
> to be refactored and exposed as a public API.
> My idea is to refactor all the code currently at
> org.apache.bookkeeper.server.Main#buildBookieServer and expose it with a
> builder pattern.
> The builder will accept an initial BookieConfiguration (and with no more
> interaction will produce the same server currently produced from
> org.apache.bookkeeper.server.Main#buildBookieServer) and will create from
> the configuration any component not directly provided to the builder.
> For example you can provide your instances for StatsProvider or
> MetadataBookieDriver instance or your custom ByteBufAllocator without the
> need to rewrite the same plain old code.
> Another big improvement: new features that whould need additional code to
> be added (just think when integrity checking has been added in BP-46) are
> already and directly usable.
>
> What do you think about it?
>
> Diego Salvi
>

Re: Public API for creating embeddable servers

[Diego Salvi]

I've opened BP-57 

Diego Salvi

Il giorno dom 18 set 2022 alle ore 14:46 Enrico Olivelli <
eolive...@gmail.com> ha scritto:

> Diego,
> That's a great idea!
>
> Looking forward for the BP
>
>
> Enrico
>
> Il Mer 14 Set 2022, 12:24 Lothruin Mirwen  ha
> scritto:
>
> > Hi bookkeepers!
> >
> > Using BK in many project I had to write each time boilerplate code to
> > create a BK embedded instance. With changes published in 4.15 I had to
> > change such code in each project to handle the new interfaces.
> >
> > I think a public API to create server instances from configuration would
> be
> > really really useful.
> >
> > I published a PR https://github.com/apache/bookkeeper/pull/3489 to adda
> > simple way to create an embeddable server. All the code was really
> already
> > there in Main class, just needed to be refactored a little to insert a
> > builder pattern. I've added many parameters on builder to be able to
> > provide instances for many component instead to build them from the
> > configuration (for example to provide your statsprovider instance).
> >
> > What do you think about it?
> >
> > Diego Salvi
> >
>

[DISCUSS] BP-57 Add a public API for creating embeddable servers

[Diego Salvi]

Hi BookKeepers,
I've added a new BP to add a public API for creating embeddable servers:
BP-57 

*Motivation*
BK is used and run in many OS project as an embedded resource.
Every time a project needs to embed BK (think about Pulsar, Pravega or
HerdDB as some examples) boilerplate code need to be written (and then
mantained as per 4.15 changes).
Depending from the contest new feature cannot be made directly available
and more code need to be added.
To run an embedded bookie you need to instantiate many components that are
really in "public" api and can and will be subject to changes.

*Proposal*
We already have the whole code to start a BK server instance, it just needs
to be refactored and exposed as a public API.
My idea is to refactor all the code currently at
org.apache.bookkeeper.server.Main#buildBookieServer and expose it with a
builder pattern.
The builder will accept an initial BookieConfiguration (and with no more
interaction will produce the same server currently produced from
org.apache.bookkeeper.server.Main#buildBookieServer) and will create from
the configuration any component not directly provided to the builder.
For example you can provide your instances for StatsProvider or
MetadataBookieDriver instance or your custom ByteBufAllocator without the
need to rewrite the same plain old code.
Another big improvement: new features that whould need additional code to
be added (just think when integrity checking has been added in BP-46) are
already and directly usable.

What do you think about it?

Diego Salvi

Re: Public API for creating embeddable servers

[Enrico Olivelli]

Diego,
That's a great idea!

Looking forward for the BP


Enrico

Il Mer 14 Set 2022, 12:24 Lothruin Mirwen  ha
scritto:

> Hi bookkeepers!
>
> Using BK in many project I had to write each time boilerplate code to
> create a BK embedded instance. With changes published in 4.15 I had to
> change such code in each project to handle the new interfaces.
>
> I think a public API to create server instances from configuration would be
> really really useful.
>
> I published a PR https://github.com/apache/bookkeeper/pull/3489 to adda
> simple way to create an embeddable server. All the code was really already
> there in Main class, just needed to be refactored a little to insert a
> builder pattern. I've added many parameters on builder to be able to
> provide instances for many component instead to build them from the
> configuration (for example to provide your statsprovider instance).
>
> What do you think about it?
>
> Diego Salvi
>