Re: [VOTE] Release 4.15.3, release candidate #1

2022-11-11 Thread Hang Chen
+1 (non-binding)

- Build from source code (JDK8, maven 3.8.6 on MacOs)
- Verified checksums and signatures
- Verified the licenses
- Run bkperf to test journal write
- Integrate with Pulsar master code and Pulsar unit tests passed
(https://github.com/hangc0276/pulsar/pull/7)


Thanks Yong for driving the release

Thanks,
Hang

Andrey Yegorov  于2022年11月12日周六 00:08写道:
>
> +1 (binding)
>
> On Thu, Nov 10, 2022 at 8:06 PM Yong Zhang 
> wrote:
>
> > Hi Andrey,
> >
> > I run the test multiple times, I found that depends on how the DNS
> > resolve the address.
> > When the DNS resolves to 127.0.0.1/localhost, the test will be failed.
> > But if it resolves another INet interface, like lo0, the hostname will be
> > 192.168.50.240(in my computer) and the test passed.
> >
> > Thanks,
> > Yong
> >
> > On Fri, 11 Nov 2022 at 09:46, Yong Zhang 
> > wrote:
> >
> > > I downloaded the src package and run the tests successfully.
> > > And build from branch-4.15 passed as well. But failed when
> > > I run it with IDE.
> > >
> > > It looks like sometimes it uses the loopback address and we
> > > are not allowed that.
> > > But it shouldn't be a problem for this release.
> > >
> > > Thanks,
> > > Yong
> > >
> > > On Fri, 11 Nov 2022 at 09:01, Andrey Yegorov <
> > andrey.yego...@datastax.com>
> > > wrote:
> > >
> > >> I tested the following:
> > >>
> > >> * bookkeeper-all
> > >>   ** unpacks
> > >>   ** shell works, standalone starts, localbookie starts
> > >> * src
> > >>   ** unpacks, builds
> > >>   ** tests - there are some know flakes
> > >> and org.apache.bookkeeper.client.TestSpeculativeRead fails for me
> > >>
> > >> I don't recall any issues with TestSpeculativeRead in the previous
> > >> releases; does it repro for you (I built from unpacked sources for the
> > >> RC)?
> > >>
> > >> $ mvn test -f bookkeeper-server/pom.xml
> > >> -Dtest=org.apache.bookkeeper.client.TestSpeculativeRead
> > >>
> > >> [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> > >> 73.673 s <<< FAILURE! - in
> > >> org.apache.bookkeeper.client.TestSpeculativeRead
> > >> [ERROR]
> > >>
> > >>
> > org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble
> > >>  Time elapsed: 6.341 s  <<< ERROR!
> > >> java.lang.RuntimeException:
> > >> java.net.UnknownHostException: Trying to listen on loopback address,
> > >> 127.0.0.1:3181 but this is forbidden by default (see
> > >> ServerConfiguration#getAllowLoopback()).
> > >> If this happen, you can consider specifying the network interface to
> > >> listen
> > >> on (e.g. listeningInterface=eth0) or specifying the advertised address
> > >> (e.g. advertisedAddress=172.x.y.z)
> > >> at
> > >>
> > >>
> > org.apache.bookkeeper.bookie.LocalBookieEnsemblePlacementPolicy.initialize(LocalBookieEnsemblePlacementPolicy.java:68)
> > >> at
> > >>
> > >>
> > org.apache.bookkeeper.client.BookKeeper.initializeEnsemblePlacementPolicy(BookKeeper.java:583)
> > >> at org.apache.bookkeeper.client.BookKeeper.(BookKeeper.java:507)
> > >> at
> > >>
> > >>
> > org.apache.bookkeeper.client.BookKeeperTestClient.(BookKeeperTestClient.java:51)
> > >> at
> > >>
> > >>
> > org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble(TestSpeculativeRead.java:395)
> > >> at
> > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> > >> Method)
> > >> at
> > >>
> > >>
> > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> > >> at
> > >>
> > >>
> > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > >> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> > >> at
> > >>
> > >>
> > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> > >> at
> > >>
> > >>
> > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > >> at
> > >>
> > >>
> > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> > >> at
> > >>
> > >>
> > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> > >> at
> > >>
> > >>
> > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > >> at
> > >>
> > >>
> > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > >> at
> > >>
> > >>
> > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
> > >> at
> > >>
> > >>
> > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
> > >> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> > >> at java.base/java.lang.Thread.run(Thread.java:829)
> > >> Caused by: java.net.UnknownHostException: Trying to listen on loopback
> > >> address, 127.0.0.1:3181 but this is forbidden by default (see
> > >> ServerConfiguration#getAllowLoopback()).
> > >> If this happen, you can consider specifying the network interface to
> 

Re: [VOTE] Release 4.15.3, release candidate #1

2022-11-11 Thread Andrey Yegorov
+1 (binding)

On Thu, Nov 10, 2022 at 8:06 PM Yong Zhang 
wrote:

> Hi Andrey,
>
> I run the test multiple times, I found that depends on how the DNS
> resolve the address.
> When the DNS resolves to 127.0.0.1/localhost, the test will be failed.
> But if it resolves another INet interface, like lo0, the hostname will be
> 192.168.50.240(in my computer) and the test passed.
>
> Thanks,
> Yong
>
> On Fri, 11 Nov 2022 at 09:46, Yong Zhang 
> wrote:
>
> > I downloaded the src package and run the tests successfully.
> > And build from branch-4.15 passed as well. But failed when
> > I run it with IDE.
> >
> > It looks like sometimes it uses the loopback address and we
> > are not allowed that.
> > But it shouldn't be a problem for this release.
> >
> > Thanks,
> > Yong
> >
> > On Fri, 11 Nov 2022 at 09:01, Andrey Yegorov <
> andrey.yego...@datastax.com>
> > wrote:
> >
> >> I tested the following:
> >>
> >> * bookkeeper-all
> >>   ** unpacks
> >>   ** shell works, standalone starts, localbookie starts
> >> * src
> >>   ** unpacks, builds
> >>   ** tests - there are some know flakes
> >> and org.apache.bookkeeper.client.TestSpeculativeRead fails for me
> >>
> >> I don't recall any issues with TestSpeculativeRead in the previous
> >> releases; does it repro for you (I built from unpacked sources for the
> >> RC)?
> >>
> >> $ mvn test -f bookkeeper-server/pom.xml
> >> -Dtest=org.apache.bookkeeper.client.TestSpeculativeRead
> >>
> >> [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> >> 73.673 s <<< FAILURE! - in
> >> org.apache.bookkeeper.client.TestSpeculativeRead
> >> [ERROR]
> >>
> >>
> org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble
> >>  Time elapsed: 6.341 s  <<< ERROR!
> >> java.lang.RuntimeException:
> >> java.net.UnknownHostException: Trying to listen on loopback address,
> >> 127.0.0.1:3181 but this is forbidden by default (see
> >> ServerConfiguration#getAllowLoopback()).
> >> If this happen, you can consider specifying the network interface to
> >> listen
> >> on (e.g. listeningInterface=eth0) or specifying the advertised address
> >> (e.g. advertisedAddress=172.x.y.z)
> >> at
> >>
> >>
> org.apache.bookkeeper.bookie.LocalBookieEnsemblePlacementPolicy.initialize(LocalBookieEnsemblePlacementPolicy.java:68)
> >> at
> >>
> >>
> org.apache.bookkeeper.client.BookKeeper.initializeEnsemblePlacementPolicy(BookKeeper.java:583)
> >> at org.apache.bookkeeper.client.BookKeeper.(BookKeeper.java:507)
> >> at
> >>
> >>
> org.apache.bookkeeper.client.BookKeeperTestClient.(BookKeeperTestClient.java:51)
> >> at
> >>
> >>
> org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble(TestSpeculativeRead.java:395)
> >> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> >> Method)
> >> at
> >>
> >>
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> >> at
> >>
> >>
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> >> at
> >>
> >>
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> >> at
> >>
> >>
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> >> at
> >>
> >>
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> >> at
> >>
> >>
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> >> at
> >>
> >>
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> >> at
> >>
> >>
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> >> at
> >>
> >>
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
> >> at
> >>
> >>
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
> >> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> >> at java.base/java.lang.Thread.run(Thread.java:829)
> >> Caused by: java.net.UnknownHostException: Trying to listen on loopback
> >> address, 127.0.0.1:3181 but this is forbidden by default (see
> >> ServerConfiguration#getAllowLoopback()).
> >> If this happen, you can consider specifying the network interface to
> >> listen
> >> on (e.g. listeningInterface=eth0) or specifying the advertised address
> >> (e.g. advertisedAddress=172.x.y.z)
> >> at
> >>
> >>
> org.apache.bookkeeper.bookie.BookieImpl.getBookieAddress(BookieImpl.java:292)
> >> at
> >> org.apache.bookkeeper.bookie.BookieImpl.getBookieId(BookieImpl.java:247)
> >> at
> >>
> >>
> org.apache.bookkeeper.bookie.LocalBookieEnsemblePlacementPolicy.initialize(LocalBookieEnsemblePlacementPolicy.java:65)
> >> ... 18 more
> >>
> >> On Wed, Nov 9, 2022 at 1:06 AM Yong Zhang 
> >> wrote:
> >>
> >> > Hi everyone,
> >> > Please review and vote on the release candidate #0 for the version
> >> 4.1

Re: [VOTE] Release 4.15.3, release candidate #1

2022-11-11 Thread Enrico Olivelli
+1 (binding)

- RAT, checksums, signatures, all good
- built on Mac on JDK11
- tested localbookie from the results of the build

Thanks
Enrico

Il giorno ven 11 nov 2022 alle ore 06:11 Yong Zhang
 ha scritto:
>
> The maven repo link should be
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1075
>
> Yong
>
> On Fri, 11 Nov 2022 at 12:05, Yong Zhang  wrote:
>
> > Hi Andrey,
> >
> > I run the test multiple times, I found that depends on how the DNS
> > resolve the address.
> > When the DNS resolves to 127.0.0.1/localhost, the test will be failed.
> > But if it resolves another INet interface, like lo0, the hostname will be
> > 192.168.50.240(in my computer) and the test passed.
> >
> > Thanks,
> > Yong
> >
> > On Fri, 11 Nov 2022 at 09:46, Yong Zhang 
> > wrote:
> >
> >> I downloaded the src package and run the tests successfully.
> >> And build from branch-4.15 passed as well. But failed when
> >> I run it with IDE.
> >>
> >> It looks like sometimes it uses the loopback address and we
> >> are not allowed that.
> >> But it shouldn't be a problem for this release.
> >>
> >> Thanks,
> >> Yong
> >>
> >> On Fri, 11 Nov 2022 at 09:01, Andrey Yegorov 
> >> wrote:
> >>
> >>> I tested the following:
> >>>
> >>> * bookkeeper-all
> >>>   ** unpacks
> >>>   ** shell works, standalone starts, localbookie starts
> >>> * src
> >>>   ** unpacks, builds
> >>>   ** tests - there are some know flakes
> >>> and org.apache.bookkeeper.client.TestSpeculativeRead fails for me
> >>>
> >>> I don't recall any issues with TestSpeculativeRead in the previous
> >>> releases; does it repro for you (I built from unpacked sources for the
> >>> RC)?
> >>>
> >>> $ mvn test -f bookkeeper-server/pom.xml
> >>> -Dtest=org.apache.bookkeeper.client.TestSpeculativeRead
> >>>
> >>> [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> >>> 73.673 s <<< FAILURE! - in
> >>> org.apache.bookkeeper.client.TestSpeculativeRead
> >>> [ERROR]
> >>>
> >>> org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble
> >>>  Time elapsed: 6.341 s  <<< ERROR!
> >>> java.lang.RuntimeException:
> >>> java.net.UnknownHostException: Trying to listen on loopback address,
> >>> 127.0.0.1:3181 but this is forbidden by default (see
> >>> ServerConfiguration#getAllowLoopback()).
> >>> If this happen, you can consider specifying the network interface to
> >>> listen
> >>> on (e.g. listeningInterface=eth0) or specifying the advertised address
> >>> (e.g. advertisedAddress=172.x.y.z)
> >>> at
> >>>
> >>> org.apache.bookkeeper.bookie.LocalBookieEnsemblePlacementPolicy.initialize(LocalBookieEnsemblePlacementPolicy.java:68)
> >>> at
> >>>
> >>> org.apache.bookkeeper.client.BookKeeper.initializeEnsemblePlacementPolicy(BookKeeper.java:583)
> >>> at org.apache.bookkeeper.client.BookKeeper.(BookKeeper.java:507)
> >>> at
> >>>
> >>> org.apache.bookkeeper.client.BookKeeperTestClient.(BookKeeperTestClient.java:51)
> >>> at
> >>>
> >>> org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble(TestSpeculativeRead.java:395)
> >>> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> >>> Method)
> >>> at
> >>>
> >>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> >>> at
> >>>
> >>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >>> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> >>> at
> >>>
> >>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> >>> at
> >>>
> >>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> >>> at
> >>>
> >>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> >>> at
> >>>
> >>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> >>> at
> >>>
> >>> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> >>> at
> >>>
> >>> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> >>> at
> >>>
> >>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
> >>> at
> >>>
> >>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
> >>> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> >>> at java.base/java.lang.Thread.run(Thread.java:829)
> >>> Caused by: java.net.UnknownHostException: Trying to listen on loopback
> >>> address, 127.0.0.1:3181 but this is forbidden by default (see
> >>> ServerConfiguration#getAllowLoopback()).
> >>> If this happen, you can consider specifying the network interface to
> >>> listen
> >>> on (e.g. listeningInterface=eth0) or specifying the advertised address
> >>> (e.g. advertisedAddress=172.x.y.z)
> >>> at
> >>>
> >>> org.apache.bookkeeper.bookie.BookieImpl.getBookieAddress(BookieImpl.java:292)
> >>> at
> >>> org.apache.boo