Re: [DISCUSS] BookKeeper 4.15.4 release

2023-02-13 Thread Enrico Olivelli
Good idea

+1

Enrico

Il Mar 14 Feb 2023, 02:23 Hang Chen  ha scritto:

> +1
>
> -  As we discussed in [2], For the PRs list in [1], I think we can
> skip cherry-pick first.
> - For PR [3], I removed label `release/4.15.4` due to [4]
>
> Thanks,
> Hang
>
> [1] https://github.com/apache/bookkeeper/issues/3686
> [2] https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc
> [3] https://github.com/apache/bookkeeper/pull/3653
> [4] https://github.com/apache/bookkeeper/issues/3734
>
> Yong Zhang  于2023年2月14日周二 08:40写道:
> >
> > Hi everyone,
> >
> > It has been a long time since we did the last release
> > from branch-4.15. We made a lot of improvements and
> > bug fixes. I'd propose doing a minor release for the
> > branch-4.15.
> >
> > Here is the PRs list for 4.15.4.
> > <
> https://github.com/apache/bookkeeper/pulls?q=+is%3Apr+label%3Arelease%2F4.15.4+
> >
> >
> >
> > If you have PR want to include in this release, please
> > comment on that PR or tag the label `release/4.15.4`.
> >
> > Thanks,
> > Yong
>


Re: [VOTE] Release 4.14.7, release candidate #1

2023-02-13 Thread Hang Chen
I opened one PR[1] to upgrade BookKeeper dependency to 4.14.7 for
Pulsar branch-2.10 and all tests passed. Please help verify this
candidate. Thanks a lot.

Thanks,
Hang

[1] https://github.com/hangc0276/pulsar/pull/9

Hang Chen  于2023年2月13日周一 21:17写道:
>
> Hi everyone,
> Please review and vote on the release candidate #1 for version 4.14.7,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.14.7-rc1" [4] with git sha [5]
>
> BookKeeper's KEYS file contains the PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review the maven repo, release tag, licenses, and any other things you think
> it is important to release.
>
> The vote will be open for at least 72 hours. It is adopted by the majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1] https://github.com/apache/bookkeeper/pull/3770/files
> [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.7-rc1/
> [3] 
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1079
> [4] https://github.com/apache/bookkeeper/tree/v4.14.7-rc1
> [5] c22136b03489db1643521f586e9cae2c4a511e10


Re: [DISCUSS] BookKeeper 4.15.4 release

2023-02-13 Thread Hang Chen
+1

-  As we discussed in [2], For the PRs list in [1], I think we can
skip cherry-pick first.
- For PR [3], I removed label `release/4.15.4` due to [4]

Thanks,
Hang

[1] https://github.com/apache/bookkeeper/issues/3686
[2] https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc
[3] https://github.com/apache/bookkeeper/pull/3653
[4] https://github.com/apache/bookkeeper/issues/3734

Yong Zhang  于2023年2月14日周二 08:40写道:
>
> Hi everyone,
>
> It has been a long time since we did the last release
> from branch-4.15. We made a lot of improvements and
> bug fixes. I'd propose doing a minor release for the
> branch-4.15.
>
> Here is the PRs list for 4.15.4.
> 
>
>
> If you have PR want to include in this release, please
> comment on that PR or tag the label `release/4.15.4`.
>
> Thanks,
> Yong


[DISCUSS] BookKeeper 4.15.4 release

2023-02-13 Thread Yong Zhang
Hi everyone,

It has been a long time since we did the last release
from branch-4.15. We made a lot of improvements and
bug fixes. I'd propose doing a minor release for the
branch-4.15.

Here is the PRs list for 4.15.4.



If you have PR want to include in this release, please
comment on that PR or tag the label `release/4.15.4`.

Thanks,
Yong


Re: Prometheus metrics provider > upgrade dataskeches lib

2023-02-13 Thread ZhangJian He
Hi, Salvi. I have tried it in https://github.com/apache/bookkeeper/pull/3264
and sent an issue to https://github.com/apache/datasketches-java/issues/398
You can see these for details. Recently, I had no time to keep working on
this. Thank you for working on this.

Thanks
ZhangJian He


On Mon, 13 Feb 2023 at 19:34, Enrico Olivelli  wrote:

> Diego,
>
> Il giorno lun 13 feb 2023 alle ore 11:37 Diego Salvi
>  ha scritto:
> >
> > Hi,
> > I was looking into prometheus-metrics-provider dependencies and I found a
> > dependency to com.yahoo.datasketches:sketches-core:0.8.3.
> > This is really a very old implementation pre apache incubating. Currently
> > it has been ported from yahoo to apache with a current version 3.3.0.
> > In the meantime it changed packages too.
> > Wouldn't it be better to upgrade the dependency to a stable one?
>
> I agree.
> Could you send a patch ?
> Maybe we are on time to deliver the change for 4.16.0
>
> Enrico
>
> >
> > Diego Salvi
>


[VOTE] Release 4.14.7, release candidate #1

2023-02-13 Thread Hang Chen
Hi everyone,
Please review and vote on the release candidate #1 for version 4.14.7,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.14.7-rc1" [4] with git sha [5]

BookKeeper's KEYS file contains the PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS

Please download these packages and review this release candidate:

- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review the maven repo, release tag, licenses, and any other things you think
it is important to release.

The vote will be open for at least 72 hours. It is adopted by the majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1] https://github.com/apache/bookkeeper/pull/3770/files
[2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.7-rc1/
[3] https://repository.apache.org/content/repositories/orgapachebookkeeper-1079
[4] https://github.com/apache/bookkeeper/tree/v4.14.7-rc1
[5] c22136b03489db1643521f586e9cae2c4a511e10


Re: Prometheus metrics provider > upgrade dataskeches lib

2023-02-13 Thread Enrico Olivelli
Diego,

Il giorno lun 13 feb 2023 alle ore 11:37 Diego Salvi
 ha scritto:
>
> Hi,
> I was looking into prometheus-metrics-provider dependencies and I found a
> dependency to com.yahoo.datasketches:sketches-core:0.8.3.
> This is really a very old implementation pre apache incubating. Currently
> it has been ported from yahoo to apache with a current version 3.3.0.
> In the meantime it changed packages too.
> Wouldn't it be better to upgrade the dependency to a stable one?

I agree.
Could you send a patch ?
Maybe we are on time to deliver the change for 4.16.0

Enrico

>
> Diego Salvi


Prometheus metrics provider > upgrade dataskeches lib

2023-02-13 Thread Diego Salvi
Hi,
I was looking into prometheus-metrics-provider dependencies and I found a
dependency to com.yahoo.datasketches:sketches-core:0.8.3.
This is really a very old implementation pre apache incubating. Currently
it has been ported from yahoo to apache with a current version 3.3.0.
In the meantime it changed packages too.
Wouldn't it be better to upgrade the dependency to a stable one?

Diego Salvi