Prometheus metrics provider > upgrade dataskeches lib
Hi, I was looking into prometheus-metrics-provider dependencies and I found a dependency to com.yahoo.datasketches:sketches-core:0.8.3. This is really a very old implementation pre apache incubating. Currently it has been ported from yahoo to apache with a current version 3.3.0. In the meantime it changed packages too. Wouldn't it be better to upgrade the dependency to a stable one? Diego Salvi
Re: [ANNOUNCE] New Committer Steven Lu
Congratulations Steven! Diego Salvi Il giorno ven 14 ott 2022 alle ore 18:34 1060026287 <1060026...@qq.com.invalid> ha scritto: > Congratulations! > > > > -- Original -- > From: ZhangJian He Date: Fri,Oct 14,2022 8:58 PM > To: dev Subject: Re: [ANNOUNCE] New Committer Steven Lu > > > > Congratulations! > > Thanks > ZhangJian He > > On Fri, 14 Oct 2022 at 19:02, Max Xu > > Congratulations! Steven > > > > Best, > > Max Xu > > > > > > On Fri, Oct 14, 2022 at 3:25 PM Enrico Olivelli > > > wrote: > > > > > Hello BookKeepers, > > > I am happy to announce that Steven Lu has been invited to join > the > > > Apache BookKeeper project as committer and he accepted the > invitation. > > > > > > > > > Congratulations Steven ! > > > > > > Best regards > > > Enrico > > > > >
Re: [VOTE] BP-57 Add a public API for creating embeddable servers
The VOTE passed with 8 votes, 3 of those were binding. Binding votes: * Enrico Olivelli * Matteo Merli * Andrey Yegorow Non binding votes: * Dennis Mercuriali * Steven Lu * Lan Liang * ZhangJian He * Nicolò Boschi I'll complete the work on the PR. Thank you everyone Diego Salvi Il Mer 12 Ott 2022, 17:21 Andrey Yegorov ha scritto: > +1 (binding) > > On Tue, Oct 11, 2022 at 3:31 PM Matteo Merli > wrote: > > > +1 (binding) > > > > Very good addition! > > > > > > -- > > Matteo Merli > > > > > > On Tue, Oct 11, 2022 at 4:38 AM Enrico Olivelli > > wrote: > > > > > > Up > > > > > > We need 1 more binding vote from a PMC member > > > > > > Enrico > > > > > > Il Mar 27 Set 2022, 11:36 Nicolò Boschi ha > > scritto: > > > > > > > +1 (non binding) > > > > Nicolò Boschi > > > > > > > > > > > > Il giorno mar 27 set 2022 alle ore 11:25 Enrico Olivelli < > > > > eolive...@gmail.com> ha scritto: > > > > > > > > > I think that we need some more binding VOTEs please > > > > > > > > > > Enrico > > > > > > > > > > Il giorno dom 25 set 2022 alle ore 16:15 ZhangJian He > > > > > ha scritto: > > > > > > > > > > > > +1 , non binding > > > > > > > > > > > > Thanks > > > > > > ZhangJian He > > > > > > > > > > > > On Sun, 25 Sept 2022 at 21:56, Lan Liang < > liangyuanpen...@163.com> > > > > > wrote: > > > > > > > > > > > > > +1 , non binding. > > > > > > > > > > > > > > This is a useful feature! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > Lan Liang > > > > > > > Replied Message > > > > > > > | From | steven lu | > > > > > > > | Date | 9/25/2022 08:25 | > > > > > > > | To | | > > > > > > > | Subject | Re: [VOTE] BP-57 Add a public API for creating > > embeddable > > > > > > > servers | > > > > > > > +1 (non binding) > > > > > > > Great work > > > > > > > > > > > > > > Diego Salvi 于2022年9月24日周六 00:00写道： > > > > > > > > > > > > > > Hi Bookkeeper Community, > > > > > > > I would like to start a VOTE on " Add a public API for creating > > > > > embeddable > > > > > > > servers."(BP-57) > > > > > > > > > > > > > > It is a new public API to create bookie from configuration > and/or > > > > > custom > > > > > > > implementations without having to deep dive into internal > > structure. > > > > > The > > > > > > > code will be the same used to build standard BK server through > > Main > > > > > class > > > > > > > > > > > > > > Here is the design detail: > > > > > > > https://github.com/apache/bookkeeper/issues/3494 > > > > > > > > > > > > > > Diego Salvi > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > Andrey Yegorov >
[VOTE] BP-57 Add a public API for creating embeddable servers
Hi Bookkeeper Community, I would like to start a VOTE on " Add a public API for creating embeddable servers."(BP-57) It is a new public API to create bookie from configuration and/or custom implementations without having to deep dive into internal structure. The code will be the same used to build standard BK server through Main class Here is the design detail: https://github.com/apache/bookkeeper/issues/3494 Diego Salvi
Re: Public API for creating embeddable servers
I've opened BP-57 <https://github.com/apache/bookkeeper/issues/3494> Diego Salvi Il giorno dom 18 set 2022 alle ore 14:46 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Diego, > That's a great idea! > > Looking forward for the BP > > > Enrico > > Il Mer 14 Set 2022, 12:24 Lothruin Mirwen ha > scritto: > > > Hi bookkeepers! > > > > Using BK in many project I had to write each time boilerplate code to > > create a BK embedded instance. With changes published in 4.15 I had to > > change such code in each project to handle the new interfaces. > > > > I think a public API to create server instances from configuration would > be > > really really useful. > > > > I published a PR https://github.com/apache/bookkeeper/pull/3489 to adda > > simple way to create an embeddable server. All the code was really > already > > there in Main class, just needed to be refactored a little to insert a > > builder pattern. I've added many parameters on builder to be able to > > provide instances for many component instead to build them from the > > configuration (for example to provide your statsprovider instance). > > > > What do you think about it? > > > > Diego Salvi > > >
[DISCUSS] BP-57 Add a public API for creating embeddable servers
Hi BookKeepers, I've added a new BP to add a public API for creating embeddable servers: BP-57 <https://github.com/apache/bookkeeper/issues/3494> *Motivation* BK is used and run in many OS project as an embedded resource. Every time a project needs to embed BK (think about Pulsar, Pravega or HerdDB as some examples) boilerplate code need to be written (and then mantained as per 4.15 changes). Depending from the contest new feature cannot be made directly available and more code need to be added. To run an embedded bookie you need to instantiate many components that are really in "public" api and can and will be subject to changes. *Proposal* We already have the whole code to start a BK server instance, it just needs to be refactored and exposed as a public API. My idea is to refactor all the code currently at org.apache.bookkeeper.server.Main#buildBookieServer and expose it with a builder pattern. The builder will accept an initial BookieConfiguration (and with no more interaction will produce the same server currently produced from org.apache.bookkeeper.server.Main#buildBookieServer) and will create from the configuration any component not directly provided to the builder. For example you can provide your instances for StatsProvider or MetadataBookieDriver instance or your custom ByteBufAllocator without the need to rewrite the same plain old code. Another big improvement: new features that whould need additional code to be added (just think when integrity checking has been added in BP-46) are already and directly usable. What do you think about it? Diego Salvi
