[GitHub] dlg99 commented on issue #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
dlg99 commented on issue #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes. URL: https://github.com/apache/bookkeeper/pull/425#issuecomment-322349767 @sijie addressed last set of comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #304: Improve Release Process
sijie closed issue #304: Improve Release Process URL: https://github.com/apache/bookkeeper/issues/304 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #305: Issue 304: New Release Guide
sijie closed pull request #305: Issue 304: New Release Guide URL: https://github.com/apache/bookkeeper/pull/305 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dlg99 commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
dlg99 commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133094310
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##
@@ -136,9 +208,11 @@ protected RackawareEnsemblePlacementPolicyImpl
initialize(DNSToSwitchMapping dns
int
maxWeightMultiple,
StatsLogger
statsLogger) {
this.statsLogger = statsLogger;
+this.bookiesJoinedCounter = statsLogger == null ? null :
statsLogger.getOpStatsLogger(BookKeeperServerStats.BOOKIES_JOINED);
Review comment:
Unit tests pass null as logger. will update unit tests, disallow null.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie closed pull request #448: Issue 434: Move the content from wikis to website
sijie closed pull request #448: Issue 434: Move the content from wikis to website URL: https://github.com/apache/bookkeeper/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #434: Move the content from wikis to website
sijie closed issue #434: Move the content from wikis to website URL: https://github.com/apache/bookkeeper/issues/434 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dlg99 commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
dlg99 commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes. URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133091156 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java ## @@ -80,36 +80,46 @@ protected int numBookies; protected BookKeeperTestClient bkc; -protected final ServerConfiguration baseConf = TestBKConfiguration.newServerConfiguration(); +protected final ServerConfiguration baseConf; Review comment: picked up by mistake, will revert. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new pull request #448: Issue 434: Move the content from wikis to website
sijie opened a new pull request #448: Issue 434: Move the content from wikis to website URL: https://github.com/apache/bookkeeper/pull/448 Descriptions of the changes in this PR: copied bunch of links from wiki pages and re-organized the links under `community`. - first section: mailing list, issue tracking, release schedule and community meetings. - second section: a few guides on how to contribute, how to report issue and how to release - last section: resources (e.g. presentations, proposals) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
sijie commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133080246
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##
@@ -77,11 +73,25 @@
static class DefaultResolver implements DNSToSwitchMapping {
+final Supplier defaultRackSupplier;
+
+// for backwards compat
+public DefaultResolver() {
+this(()->NetworkTopology.DEFAULT_REGION_AND_RACK);
Review comment:
add space "() -> Network"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
sijie commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133079593
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##
@@ -136,9 +208,11 @@ protected RackawareEnsemblePlacementPolicyImpl
initialize(DNSToSwitchMapping dns
int
maxWeightMultiple,
StatsLogger
statsLogger) {
this.statsLogger = statsLogger;
+this.bookiesJoinedCounter = statsLogger == null ? null :
statsLogger.getOpStatsLogger(BookKeeperServerStats.BOOKIES_JOINED);
Review comment:
when the statsLogger would be null? we should use NullStatsLogger for the
`null` case, rather than passing in a `null`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
sijie commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133079883
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##
@@ -93,6 +103,62 @@ public void reloadCachedMappings() {
}
+/**
+ * Decorator for any existing dsn resolver.
+ * Backfills returned data with appropriate default rack info.
+ */
+static class DNSResolverDecorator implements DNSToSwitchMapping {
+
+final Supplier defaultRackSupplier;
+final DNSToSwitchMapping resolver;
+
+DNSResolverDecorator(DNSToSwitchMapping resolver, Supplier
defaultRackSupplier) {
+Preconditions.checkNotNull(resolver, "Resolver cannot be null");
+Preconditions.checkNotNull(defaultRackSupplier,
"defaultRackSupplier should not be null");
+this.defaultRackSupplier = defaultRackSupplier;
+this.resolver= resolver;
+}
+
+public List resolve(List names) {
+if (names == null) {
+return new ArrayList<>();
Review comment:
use Collections.emptyList() to avoid constructing an object here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
sijie commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes. URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133078769 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java ## @@ -80,36 +80,46 @@ protected int numBookies; protected BookKeeperTestClient bkc; -protected final ServerConfiguration baseConf = TestBKConfiguration.newServerConfiguration(); +protected final ServerConfiguration baseConf; Review comment: This file seems to be changed for debugging purpose? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dlg99 commented on issue #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
dlg99 commented on issue #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes. URL: https://github.com/apache/bookkeeper/pull/425#issuecomment-322322485 @sijie tests that passed locally failed with TestTimedOutException, similarly to other pull requests earlier. Looks like a jenkins/build machine issue or unrelated build break. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dlg99 commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
dlg99 commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133054599
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/DNSToSwitchMapping.java
##
@@ -41,14 +41,14 @@
*
*
* If a name cannot be resolved to a rack, the implementation
- * should return {@link NetworkTopology#DEFAULT_RACK}. This
+ * should return {@link NetworkTopology#DEFAULT_REGION_AND_RACK}. This
* is what the bundled implementations do, though it is not a formal
requirement
*
* @param names the list of hosts to resolve (can be empty)
* @return list of resolved network paths.
* If names is empty, the returned list is also empty
*/
-public List resolve(List names);
+public List resolve(List names, String defaultRack);
Review comment:
makes sense, fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint
sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#issuecomment-322264799 @eolivelli @dcastor just to check if we are good to go with this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #443: Update mailing list instructions
sijie closed issue #443: Update mailing list instructions URL: https://github.com/apache/bookkeeper/issues/443 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #445: Issue 443: Update the mailing list
sijie closed pull request #445: Issue 443: Update the mailing list URL: https://github.com/apache/bookkeeper/pull/445 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #447: Issue 440: Update "who are we?" page
sijie closed pull request #447: Issue 440: Update "who are we?" page URL: https://github.com/apache/bookkeeper/pull/447 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new pull request #447: Issue 440: Update "who are we?" page
sijie opened a new pull request #447: Issue 440: Update "who are we?" page URL: https://github.com/apache/bookkeeper/pull/447 Descriptions of the changes in this PR: - add new DL PPMC members to BK PMC - fix full name and affiliations for a few members This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #444: Remove `doc` directory
sijie closed issue #444: Remove `doc` directory URL: https://github.com/apache/bookkeeper/issues/444 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #305: Issue 305: New Release Guide
sijie commented on issue #305: Issue 305: New Release Guide URL: https://github.com/apache/bookkeeper/pull/305#issuecomment-322130996 Update the pull request to incorporate the comments. https://sijie.github.io/bookkeeper-staging-site/community/release_guide/ is the staging page. Can any of you take a look at this again? @jvrao since you were the release manager for last release, it would be good for you to review this again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #444: Remove `doc` directory
sijie opened a new issue #444: Remove `doc` directory URL: https://github.com/apache/bookkeeper/issues/444 *why?* The `doc` directory was used by CMS to generate the old bookkeeper website. since we already moved to a new jekyll website, the files in this directory are not used anymore. we can remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #443: Update mailing list instructions
sijie opened a new issue #443: Update mailing list instructions URL: https://github.com/apache/bookkeeper/issues/443 **Why?** The bookkeeper community decides to send jenkins, jira and github notifications to iss...@bookkeeper.apache.org. We need to update the mailing lists to reflect the movement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #441: Fix some Typos
sijie closed issue #441: Fix some Typos URL: https://github.com/apache/bookkeeper/issues/441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #442: Issue 441: fix typos
sijie closed pull request #442: Issue 441: fix typos URL: https://github.com/apache/bookkeeper/pull/442 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack commented on a change in pull request #442: Issue 441: fix typos
zhaijack commented on a change in pull request #442: Issue 441: fix typos URL: https://github.com/apache/bookkeeper/pull/442#discussion_r132829832 ## File path: docker/README.md ## @@ -1,14 +1,14 @@ # What is Apache Bookkeeper? -Apache ZooKeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. +Apache Bookkeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. > [Apache Bookkeeper](http://bookkeeper.apache.org/) # How to use this image -Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkepeer servers). The client only need to connect to a Zookkeeper server in the ensamble in order to obtain the list of Bookkeeper servers. +Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkeeper servers). The client only need to connect to a Zookeeper server in the ensamble in order to obtain the list of Bookkeeper servers. Review comment: Thanks, have changed bookkeeper into Bookkeeper in this md file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jvrao commented on a change in pull request #442: Issue 441: fix typos
jvrao commented on a change in pull request #442: Issue 441: fix typos URL: https://github.com/apache/bookkeeper/pull/442#discussion_r132827919 ## File path: docker/README.md ## @@ -1,14 +1,14 @@ # What is Apache Bookkeeper? -Apache ZooKeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. +Apache Bookkeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. > [Apache Bookkeeper](http://bookkeeper.apache.org/) # How to use this image -Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkepeer servers). The client only need to connect to a Zookkeeper server in the ensamble in order to obtain the list of Bookkeeper servers. +Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkeeper servers). The client only need to connect to a Zookeeper server in the ensamble in order to obtain the list of Bookkeeper servers. Review comment: +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on a change in pull request #442: Issue 441: fix typos
sijie commented on a change in pull request #442: Issue 441: fix typos URL: https://github.com/apache/bookkeeper/pull/442#discussion_r132827637 ## File path: docker/README.md ## @@ -1,14 +1,14 @@ # What is Apache Bookkeeper? -Apache ZooKeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. +Apache Bookkeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. > [Apache Bookkeeper](http://bookkeeper.apache.org/) # How to use this image -Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkepeer servers). The client only need to connect to a Zookkeeper server in the ensamble in order to obtain the list of Bookkeeper servers. +Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkeeper servers). The client only need to connect to a Zookeeper server in the ensamble in order to obtain the list of Bookkeeper servers. Review comment: @eolivelli do you mean "with K uppercase" => BookKeeper? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #442: Issue 441: fix typos
eolivelli commented on a change in pull request #442: Issue 441: fix typos URL: https://github.com/apache/bookkeeper/pull/442#discussion_r132822638 ## File path: docker/README.md ## @@ -1,14 +1,14 @@ # What is Apache Bookkeeper? -Apache ZooKeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. +Apache Bookkeeper is a software project of the Apache Software Foundation, providing a replicated log service which can be used to build replicated state machines. A log contains a sequence of events which can be applied to a state machine. BookKeeper guarantees that each replica state machine will see all the same entries, in the same order. > [Apache Bookkeeper](http://bookkeeper.apache.org/) # How to use this image -Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkepeer servers). The client only need to connect to a Zookkeeper server in the ensamble in order to obtain the list of Bookkeeper servers. +Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve its state and publish its bookies (bookkeeper servers). The client only need to connect to a Zookeeper server in the ensamble in order to obtain the list of Bookkeeper servers. Review comment: Bookkeeper with B uppercase? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack opened a new pull request #442: Issue 441: fix typos
zhaijack opened a new pull request #442: Issue 441: fix typos URL: https://github.com/apache/bookkeeper/pull/442 Descriptions of the changes in this PR: Fix typos in docker readme. "Apache ZooKeeper is a software project of the Apache Software Foundation" -> "Apache Bookkeeper is a software project of the Apache Software Foundation" "bookkepeer servers" -> "bookkeeper servers" "The client only need to connect to a Zookkeeper server in the ensamble" -> "The client only need to connect to a Zookeeper server in the ensemble" typo of other place: bookeeper -> bookkeeper wile -> while acknoledge -> acknowledge > --- > Be sure to do all of the following to help us incorporate your contribution > quickly and easily: > > - [X] Make sure the PR title is formatted like: > `: Description of pull request` > `e.g. Issue 123: Description ...` > `e.g. BOOKKEEPER-1234: Description ...` > - [ ] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`. > - [X] Replace `` in the title with the actual Issue/JIRA number. > > --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack opened a new issue #441: Typo in docker Readme
zhaijack opened a new issue #441: Typo in docker Readme URL: https://github.com/apache/bookkeeper/issues/441 Fix typos in docker readme. "*Apache ZooKeeper* is a software project of the Apache Software Foundation" -> "Apache Bookkeeper is a software project of the Apache Software Foundation" "bookkepeer servers" -> "bookkeeper servers" "The client only need to connect to a Zookkeeper server in the ensamble" -> "The client only need to connect to a Zookeeper server in the ensemble" ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #440: Update "who we are?" page
sijie opened a new issue #440: Update "who we are?" page URL: https://github.com/apache/bookkeeper/issues/440 Why? - we have DL PPMC members joining BK PMC - update JV's name to full name "Venkateswararao (JV) Jujjuri" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #386: Issue-385 Upgrade to commons-lang 2.6
sijie closed pull request #386: Issue-385 Upgrade to commons-lang 2.6 URL: https://github.com/apache/bookkeeper/pull/386 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #418: Bump Docker to use 4.5.0 binarary
sijie closed issue #418: Bump Docker to use 4.5.0 binarary URL: https://github.com/apache/bookkeeper/issues/418 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0
sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0 URL: https://github.com/apache/bookkeeper/pull/436#issuecomment-321933396 merging this now. - merge this to both master and branch-4.5 - git checkout a new branch from tag `release-4.5.0` (because it was created before docker files are added) - cherry-pick the docker changes to that the temp branch, retag `release-4.5.0` to include the docker files I will update the `release_guide` about it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #435: Build javadoc for releases
sijie closed issue #435: Build javadoc for releases URL: https://github.com/apache/bookkeeper/issues/435 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #438: Issue 435: Build javadoc for releases
sijie closed pull request #438: Issue 435: Build javadoc for releases URL: https://github.com/apache/bookkeeper/pull/438 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing
sijie commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing URL: https://github.com/apache/bookkeeper/issues/221#issuecomment-321931809 sorry I typed the wrong issue id at #437. revert the labels and milestone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #437: Issue-431 Issue-221: merge scripts should mark milestone when merging pull requests
sijie closed pull request #437: Issue-431 Issue-221: merge scripts should mark milestone when merging pull requests URL: https://github.com/apache/bookkeeper/pull/437 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #431: merge scripts should mark milestone when merging pull requests
sijie closed issue #431: merge scripts should mark milestone when merging pull requests URL: https://github.com/apache/bookkeeper/issues/431 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on a change in pull request #305: Issue 305: New Release Guide
sijie commented on a change in pull request #305: Issue 305: New Release Guide
URL: https://github.com/apache/bookkeeper/pull/305#discussion_r132793031
##
File path: site/community/release_guide.md
##
@@ -0,0 +1,475 @@
+# Apache BookKeeper Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache BookKeeper release.
+
+## Introduction
+
+The Apache BookKeeper project periodically declares and publishes releases. A
release is one or more packages of the project artifact(s) that are approved
for general public distribution and use. They may come with various degrees of
caveat regarding their perceived quality and potential for change, such as
?alpha?, ?beta?, ?incubating?, ?stable?, etc.
+
+The BookKeeper community treats releases with great importance. They are a
public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire BookKeeper
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[BookKeeper committers](http://bookkeeper.apache.org/credits.html). This
document describes the process that the Release Manager follows to perform a
release. Any changes to this process should be discussed and adopted on the
[dev@ mailing list](http://bookkeeper.apache.org/lists.html).
+
+Please remember that publishing software has legal consequences. This guide
complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+The release process consists of several steps:
+
+1. Decide to release
+2. Prepare for the release
+3. Build a release candidate
+4. Vote on the release candidate
+5. If necessary, fix any issues and go back to step 3.
+6. Finalize the release
+7. Promote the release
+
+**
+
+## Decide to release
+
+Deciding to release and selecting a Release Manager is the first step of the
release process. This is a consensus-based decision of the entire community.
+
+Anybody can propose a release on the dev@ mailing list, giving a solid
argument and nominating a committer as the Release Manager (including
themselves). There?s no formal process, no vote requirements, and no timing
requirements. Any objections should be resolved by consensus before starting
the release.
+
+In general, the community prefers to have a rotating set of 3-5 Release
Managers. Keeping a small core set of managers allows enough people to build
expertise in this area and improve processes over time, without Release
Managers needing to re-learn the processes for each release. That said, if you
are a committer interested in serving the community in this way, please reach
out to the community on the dev@ mailing list.
+
+### Checklist to proceed to the next step
+
+1. Community agrees to release
+2. Community selects a Release Manager
+
+**
+
+## Prepare for the release
+
+Before your first release, you should perform one-time configuration steps.
This will set up your security keys for signing the release and access to
various release repositories.
+
+To prepare for each release, you should audit the project status both in the
JIRA issue tracker and the Github issue tracker, and do necessary bookkeeping.
Finally, you should create a release branch from which individual release
candidates will be built.
+
+### One-time setup instructions
+
+ GPG Key
+
+You need to have a GPG key to sign the release artifacts. Please be aware of
the ASF-wide [release signing
guidelines](https://www.apache.org/dev/release-signing.html). If you don?t have
a GPG key associated with your Apache account, please create one according to
the guidelines.
+
+Determine your Apache GPG Key and Key ID, as follows:
+
+gpg --list-keys
+
+This will list your GPG keys. One of these should reflect your Apache account,
for example:
+
+--
+pub 2048R/845E6689 2016-02-23
+uid Nomen Nescio <anonym...@apache.org>
+sub 2048R/BA4D50BE 2016-02-23
+
+Here, the key ID is the 8-digit hex string in the `pub` line: `845E6689`.
+
+Now, add your Apache GPG key to the BookKeeper?s `KEYS` file in
[`dist`](https://svn.apache.org/repos/asf/bookkeeper/dist/KEYS). Follow the
instructions listed at the top of these files.
+
+Configure `git` to use this key when signing code by giving it your key ID, as
follows:
+
+ git config --global user.signingkey 845E6689
+
+You may drop the `--global` option if you?d prefer to use this key for the
current repository only.
+
+You may wish to start `gpg-agent` to unlock your GPG key only once using your
passphrase. Otherwise, you may need to enter this passphrase hundreds of times.
The setup for `gpg-agent` varies based on operating system, but may be
something like this:
+
+eval $(gpg-agent --
[GitHub] sijie opened a new issue #439: BP-12 - Improve documentation
sijie opened a new issue #439: BP-12 - Improve documentation
URL: https://github.com/apache/bookkeeper/issues/439
Created a master issue for
[BP-12](https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-12+-+Improve+documentation)
> How does it work?
>
> If you are interested in contributing to this big project, feel free to
pick up any items by doing as follows:
> - if you are committers, you can create an issue and append the issue and
you github id to an item:
> for example, '- [ ] item : #{issue-id} @{github-login}'
> - if you are contributors, you can create an issue for the item you want
to work on, and comment
> here, saying "i'd like to work on xxx, and here is the #{issue_id}".
committers will update the description for you
> What can you work on?
>
> If you are new to this project, you can contribute to this by playing
around the library and write
> tutorials or examples.
> If you are not familiar with one area but still like to contribute, try to
pick up an item and fill up
> the content that you know, the committers will help improve it. It is also
a good chance to learn
> more about bookkeeper when writing docs.
## Sections:
### Deployment
- [ ] Deployment
- [ ] Add a page about docker deployment.
- [ ] Add a page about deploying on k8s (including Google Cloud Platform,
AWS)
- [ place holder - add more deployment methods ]
### Administration
- [ ] Administration: reorganize the pages under `Administration` in this
order:
- [ ] Pre Deployment - e.g. Hardware considerations, Configuration settings
- [ ] Post Deployment - e.g. Monitoring, Tools, Software Upgrade, Bookie
decommissions, Deploy
- [ place holder - add more administration related topics ]
### API
- [ ] API
- [ ] Add a page about best practices
- [ ] Add pages about examples or tutorials
- [ ] How to use API (ledger, advanced ledger or distributedlog apis) to
develop different type of applications
- [ ] How to use bookkeeper in embedded environment (network less or local
mode)
- [ place holder - add more examples, tutorials ]
### Development
- [ ] Development: rewrite the development section following the structure
below.
- [ ] Architecture
- [ ] Basic Concepts
- [ ] Request Flow
- [ ] Bookie
- [ ] Journal
- [ ] Ledger Storage
- [ ] Index
- [ ] Garbage Collection
- [ ] Compaction
- [ ] Client
- [ ] Metadata Management
- [ ] Replication & Consistency
- [ ] Fencing
- [ ] LAC Protocol
- [ ] Tail latency
- [ ] Ack quorum and Ensemble change
- [ ] Speculative reads
- [ ] Long poll reads
- [ ] Auto Recovery
- [ ] Code Structure
### Reference
- [ ] Reference
- [ ] Fill up the details on `metrics` page
### Performance
- [ ] Performance: We can include the basic benchmark, how to run it, what
is the results and include other reliability test results such as jepsen
results.
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie closed issue #318: Documentation Improvements
sijie closed issue #318: Documentation Improvements URL: https://github.com/apache/bookkeeper/issues/318 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #318: Documentation Improvements
sijie commented on issue #318: Documentation Improvements URL: https://github.com/apache/bookkeeper/issues/318#issuecomment-321924306 This issue was for the new website. all the sub-tasks have been completed. close it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #438: Issue 435: Build javadoc for releases
sijie commented on issue #438: Issue 435: Build javadoc for releases URL: https://github.com/apache/bookkeeper/pull/438#issuecomment-321921080 this is the staging view: https://sijie.github.io/bookkeeper-staging-site/docs/4.5.0/overview/overview/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new pull request #438: Issue 435: Build javadoc for releases
sijie opened a new pull request #438: Issue 435: Build javadoc for releases URL: https://github.com/apache/bookkeeper/pull/438 Descriptions of the changes in this PR: - add javadoc links on sidebar and overview pages (try to promote this link for users to find the link easier) - update javadoc-gen.sh to be able to generate latest javadoc and all javadocs for versions under `docs` minor fixes: - pass "JEKYLL_ENV=production" to docker because ci uses docker to build the documentation - This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0
sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0 URL: https://github.com/apache/bookkeeper/pull/436#issuecomment-321904168 @zhaijack @caiok @eolivelli based on the response on https://issues.apache.org/jira/browse/INFRA-14756, Dockerhub is not the official channel for hosting docker images. that means any docker images we have to mark them as non-official. as the community, we can still merge this pull request and publish the docker images. however unfortunately these images have to be marked as non-official, we have to state that in documentation if we are writing the docker related documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on a change in pull request #305: Issue 305: New Release Guide
sijie commented on a change in pull request #305: Issue 305: New Release Guide
URL: https://github.com/apache/bookkeeper/pull/305#discussion_r132767603
##
File path: site/community/release_guide.md
##
@@ -0,0 +1,475 @@
+# Apache BookKeeper Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache BookKeeper release.
+
+## Introduction
+
+The Apache BookKeeper project periodically declares and publishes releases. A
release is one or more packages of the project artifact(s) that are approved
for general public distribution and use. They may come with various degrees of
caveat regarding their perceived quality and potential for change, such as
?alpha?, ?beta?, ?incubating?, ?stable?, etc.
+
+The BookKeeper community treats releases with great importance. They are a
public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire BookKeeper
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[BookKeeper committers](http://bookkeeper.apache.org/credits.html). This
document describes the process that the Release Manager follows to perform a
release. Any changes to this process should be discussed and adopted on the
[dev@ mailing list](http://bookkeeper.apache.org/lists.html).
+
+Please remember that publishing software has legal consequences. This guide
complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+The release process consists of several steps:
+
+1. Decide to release
+2. Prepare for the release
+3. Build a release candidate
+4. Vote on the release candidate
+5. If necessary, fix any issues and go back to step 3.
+6. Finalize the release
+7. Promote the release
+
+**
+
+## Decide to release
+
+Deciding to release and selecting a Release Manager is the first step of the
release process. This is a consensus-based decision of the entire community.
+
+Anybody can propose a release on the dev@ mailing list, giving a solid
argument and nominating a committer as the Release Manager (including
themselves). There?s no formal process, no vote requirements, and no timing
requirements. Any objections should be resolved by consensus before starting
the release.
+
+In general, the community prefers to have a rotating set of 3-5 Release
Managers. Keeping a small core set of managers allows enough people to build
expertise in this area and improve processes over time, without Release
Managers needing to re-learn the processes for each release. That said, if you
are a committer interested in serving the community in this way, please reach
out to the community on the dev@ mailing list.
+
+### Checklist to proceed to the next step
+
+1. Community agrees to release
+2. Community selects a Release Manager
+
+**
+
+## Prepare for the release
+
+Before your first release, you should perform one-time configuration steps.
This will set up your security keys for signing the release and access to
various release repositories.
+
+To prepare for each release, you should audit the project status both in the
JIRA issue tracker and the Github issue tracker, and do necessary bookkeeping.
Finally, you should create a release branch from which individual release
candidates will be built.
+
+### One-time setup instructions
+
+ GPG Key
+
+You need to have a GPG key to sign the release artifacts. Please be aware of
the ASF-wide [release signing
guidelines](https://www.apache.org/dev/release-signing.html). If you don?t have
a GPG key associated with your Apache account, please create one according to
the guidelines.
+
+Determine your Apache GPG Key and Key ID, as follows:
+
+gpg --list-keys
+
+This will list your GPG keys. One of these should reflect your Apache account,
for example:
+
+--
+pub 2048R/845E6689 2016-02-23
+uid Nomen Nescio <anonym...@apache.org>
+sub 2048R/BA4D50BE 2016-02-23
+
+Here, the key ID is the 8-digit hex string in the `pub` line: `845E6689`.
+
+Now, add your Apache GPG key to the BookKeeper?s `KEYS` file in
[`dist`](https://svn.apache.org/repos/asf/bookkeeper/dist/KEYS). Follow the
instructions listed at the top of these files.
+
+Configure `git` to use this key when signing code by giving it your key ID, as
follows:
+
+ git config --global user.signingkey 845E6689
+
+You may drop the `--global` option if you?d prefer to use this key for the
current repository only.
+
+You may wish to start `gpg-agent` to unlock your GPG key only once using your
passphrase. Otherwise, you may need to enter this passphrase hundreds of times.
The setup for `gpg-agent` varies based on operating system, but may be
something like this:
+
+eval $(gpg-agent --
[GitHub] sijie opened a new pull request #437: Issue 431: merge scripts should mark milestone when merging pull requests
sijie opened a new pull request #437: Issue 431: merge scripts should mark milestone when merging pull requests URL: https://github.com/apache/bookkeeper/pull/437 Descriptions of the changes in this PR: improve merge script to do: - assign a milestone - add `area/` label - add `type/` label - add `release/` label - when a change needs to merge to a different branch, add the bug fix `release/` label This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #424: Issue 414: use a clone of baseconf in new ServerConfiguration(baseConf)
sijie closed pull request #424: Issue 414: use a clone of baseconf in new ServerConfiguration(baseConf) URL: https://github.com/apache/bookkeeper/pull/424 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #414: Test failure in UpdateLedgerOpTest
sijie closed issue #414: Test failure in UpdateLedgerOpTest URL: https://github.com/apache/bookkeeper/issues/414 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0
sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0 URL: https://github.com/apache/bookkeeper/pull/436#issuecomment-321776907 FYI. I also cherry-picked the docker changes to branch 4.5. once this merge, the docker change would be in branch 4.5. However, I'd like tho hold on retagging the 4.5.0 release. because, based on the comment in https://issues.apache.org/jira/browse/INFRA-14756, we *can't* mark the images generated by dockerhub autobuilds as official apache image based on apache policy. so I would like to wait for INFRA's response before we move on. If dockerhub builds is not the right approach to generate the official apache image, we have to take a different approach. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0
sijie commented on issue #436: Issue 418: bump docker to use bk - 4.5.0 URL: https://github.com/apache/bookkeeper/pull/436#issuecomment-321774564 since docker files are added for 4.5.0, I don't think we need to support previous releases. let's keep things simpler to just support 4.5.0 and onwards. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #436: Issue 418: bump docker to use bk - 4.5.0
eolivelli commented on issue #436: Issue 418: bump docker to use bk - 4.5.0 URL: https://github.com/apache/bookkeeper/pull/436#issuecomment-321759593 I think that as 4.5 bookie is fully compatible with 4.4 clients we can support only 4.5 onwards This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack commented on issue #436: Issue 418: bump docker to use bk - 4.5.0
zhaijack commented on issue #436: Issue 418: bump docker to use bk - 4.5.0 URL: https://github.com/apache/bookkeeper/pull/436#issuecomment-321759275 @caiok @eolivelli Thanks for your review. @caiok, Yes , it need cherry pick for 4.5.0, thanks for the reminder. I would like to do it after this merge. Regarding 4.4.0, one issue is that the ZooKeeperMain not work as expected (more info contained in issue #418). If support 4.4.0 branch, in docker file, we may need some more change, like download latest zk, and replace ZooKeeperMain in entrypoint.sh with the downloaded zk, for better support. That seems not simple cherry pick, I am not sure if this will bring trouble to code management. @sijie , what do you think 4.4.0? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #424: Issue 414: use a clone of baseconf in new ServerConfiguration(baseConf)
sijie commented on issue #424: Issue 414: use a clone of baseconf in new ServerConfiguration(baseConf) URL: https://github.com/apache/bookkeeper/pull/424#issuecomment-321750002 @zhaijack fyi - I am testing a merge script change on updating labels, milestone and assignee. don't worry about the label changes here :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack opened a new pull request #436: Issue 418: bump docker to use bk - 4.5.0
zhaijack opened a new pull request #436: Issue 418: bump docker to use bk - 4.5.0 URL: https://github.com/apache/bookkeeper/pull/436 Descriptions of the changes in this PR: - bump the docker image to use 4.5.0 binary, update pgp_key and bk version. - delete yum install for md5sum and sha1sum, since they are already in coreutils, which is default installed; and left them here will report error: 'No Match for argument: md5sum/sha1sum', while 'yum remove' in docker build. have tested by running make run-dice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack commented on issue #418: Bump Docker to use 4.5.0 binarary
zhaijack commented on issue #418: Bump Docker to use 4.5.0 binarary URL: https://github.com/apache/bookkeeper/issues/418#issuecomment-321717321 @eolivelli. Thanks for the comments. In our use case it is a problem. I have verified the zk binary that contained in bookkeeper-4.4.0, with command "bin/bookkeeper org.apache.zookeeper.ZooKeeperMain", the wanted operation could not success, such as the command `ls /` and `create /new_root_dir`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #435: Build javadoc for releases
sijie opened a new issue #435: Build javadoc for releases URL: https://github.com/apache/bookkeeper/issues/435 Is this a question, feature request, or bug report? **FEATURE REQUEST** 1. Please describe the feature you are requesting. Currently CI only builds javadoc for master. It doesn't build the javadoc for other branches and there is no place to display the javadoc for releases. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? *nice-to-have* 3. Provide any additional detail on your proposed use case for this feature. N/A This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #434: Move the content from wikis to website
sijie opened a new issue #434: Move the content from wikis to website URL: https://github.com/apache/bookkeeper/issues/434 **FEATURE REQUEST** 1. Please describe the feature you are requesting. The wiki page was used for: - documents for release, contribution, and other technical documentation. - tracking the bi-weekly meeting notes - tracking for the BPs It is in general good for using wiki to track project related or things that requires iterations, for example meeting notes and BPs. However it is not really good for tracking things that might not be changes frequently (like contribution or release guide), and technical documentation. for contribution and release guide, it would be good to place them in website, so people would be easy to find them; for technical documentation, it should be kept updated with the implementation, whenever there is a code change, the documentation should be added accordingly. This issue is to move the static content (like contribution guide) and the technical documentation to the website. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? *nice-to-have* 3. Provide any additional detail on your proposed use case for this feature. N/A This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #433: Issue 432: Add "Google Analytics" to the website
sijie closed pull request #433: Issue 432: Add "Google Analytics" to the website URL: https://github.com/apache/bookkeeper/pull/433 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jvrao commented on issue #433: Issue 432: Add "Google Analytics" to the website
jvrao commented on issue #433: Issue 432: Add "Google Analytics" to the website URL: https://github.com/apache/bookkeeper/pull/433#issuecomment-321677086 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #432: Add "Google Analytics" to the website
sijie opened a new issue #432: Add "Google Analytics" to the website URL: https://github.com/apache/bookkeeper/issues/432 **FEATURE REQUEST** 1. Please describe the feature you are requesting. We are launching a new website along with 4.5.0 release. It would be good to add some analytics tool (e.g. google analytics) to the website to track the usage of bookkeeper website and learn how we can potentially improve bookkeeper documentation in future. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? *nice-to-have* 3. Provide any additional detail on your proposed use case for this feature. N/A This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #312: Remove scripts under bin/
sijie commented on issue #312: Remove scripts under bin/ URL: https://github.com/apache/bookkeeper/issues/312#issuecomment-321665273 I think I cleaned up the bin directory a while ago. so we don't need this task anymore. close it as won'tfix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #312: Remove scripts under bin/
sijie closed issue #312: Remove scripts under bin/ URL: https://github.com/apache/bookkeeper/issues/312 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #319: Release 4.5.0
sijie closed issue #319: Release 4.5.0 URL: https://github.com/apache/bookkeeper/issues/319 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #319: Release 4.5.0
sijie commented on issue #319: Release 4.5.0 URL: https://github.com/apache/bookkeeper/issues/319#issuecomment-321664978 Release 4.5 is almost there. There are a few documentation items. We will defer to next release. Close this task now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #356: Release Notes for 4.5.0
sijie closed issue #356: Release Notes for 4.5.0 URL: https://github.com/apache/bookkeeper/issues/356 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #402: Issue 356: Release notes 4.5.0
sijie closed pull request #402: Issue 356: Release notes 4.5.0 URL: https://github.com/apache/bookkeeper/pull/402 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #431: merge scripts should mark milestone when merging pull requests
sijie opened a new issue #431: merge scripts should mark milestone when merging pull requests URL: https://github.com/apache/bookkeeper/issues/431 **FEATURE REQUEST** 1. Please describe the feature you are requesting. the merge script handles closing jira, but doesn't have any constraints on closing pull requests. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? *nice-to-have* 3. Provide any additional detail on your proposed use case for this feature. N/A This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #430: Add an instruction in docker README to run standalone cluster
sijie opened a new issue #430: Add an instruction in docker README to run standalone cluster URL: https://github.com/apache/bookkeeper/issues/430 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Currently there is no instruction in docker `README.md` to run standalone cluster. It would be good to write an instruction in `README.md` to run a standalone cluster. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? *nice-to-have* 3. Provide any additional detail on your proposed use case for this feature. N/A This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #402: Issue 356: Release notes 4.5.0
sijie commented on issue #402: Issue 356: Release notes 4.5.0 URL: https://github.com/apache/bookkeeper/pull/402#issuecomment-321660706 release notes are ready to merge now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed pull request #429: release 4.5.0: update website
sijie closed pull request #429: release 4.5.0: update website URL: https://github.com/apache/bookkeeper/pull/429 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #402: Issue 356: Release notes 4.5.0
sijie commented on issue #402: Issue 356: Release notes 4.5.0 URL: https://github.com/apache/bookkeeper/pull/402#issuecomment-321647699 update the release notes This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on a change in pull request #305: Issue 305: New Release Guide
sijie commented on a change in pull request #305: Issue 305: New Release Guide
URL: https://github.com/apache/bookkeeper/pull/305#discussion_r132539863
##
File path: site/community/release_guide.md
##
@@ -0,0 +1,475 @@
+# Apache BookKeeper Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache BookKeeper release.
+
+## Introduction
+
+The Apache BookKeeper project periodically declares and publishes releases. A
release is one or more packages of the project artifact(s) that are approved
for general public distribution and use. They may come with various degrees of
caveat regarding their perceived quality and potential for change, such as
?alpha?, ?beta?, ?incubating?, ?stable?, etc.
+
+The BookKeeper community treats releases with great importance. They are a
public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire BookKeeper
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[BookKeeper committers](http://bookkeeper.apache.org/credits.html). This
document describes the process that the Release Manager follows to perform a
release. Any changes to this process should be discussed and adopted on the
[dev@ mailing list](http://bookkeeper.apache.org/lists.html).
+
+Please remember that publishing software has legal consequences. This guide
complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+The release process consists of several steps:
+
+1. Decide to release
+2. Prepare for the release
+3. Build a release candidate
+4. Vote on the release candidate
+5. If necessary, fix any issues and go back to step 3.
+6. Finalize the release
+7. Promote the release
+
+**
+
+## Decide to release
+
+Deciding to release and selecting a Release Manager is the first step of the
release process. This is a consensus-based decision of the entire community.
+
+Anybody can propose a release on the dev@ mailing list, giving a solid
argument and nominating a committer as the Release Manager (including
themselves). There?s no formal process, no vote requirements, and no timing
requirements. Any objections should be resolved by consensus before starting
the release.
+
+In general, the community prefers to have a rotating set of 3-5 Release
Managers. Keeping a small core set of managers allows enough people to build
expertise in this area and improve processes over time, without Release
Managers needing to re-learn the processes for each release. That said, if you
are a committer interested in serving the community in this way, please reach
out to the community on the dev@ mailing list.
+
+### Checklist to proceed to the next step
+
+1. Community agrees to release
+2. Community selects a Release Manager
+
+**
+
+## Prepare for the release
+
+Before your first release, you should perform one-time configuration steps.
This will set up your security keys for signing the release and access to
various release repositories.
+
+To prepare for each release, you should audit the project status both in the
JIRA issue tracker and the Github issue tracker, and do necessary bookkeeping.
Finally, you should create a release branch from which individual release
candidates will be built.
+
+### One-time setup instructions
+
+ GPG Key
+
+You need to have a GPG key to sign the release artifacts. Please be aware of
the ASF-wide [release signing
guidelines](https://www.apache.org/dev/release-signing.html). If you don?t have
a GPG key associated with your Apache account, please create one according to
the guidelines.
+
+Determine your Apache GPG Key and Key ID, as follows:
+
+gpg --list-keys
+
+This will list your GPG keys. One of these should reflect your Apache account,
for example:
+
+--
+pub 2048R/845E6689 2016-02-23
+uid Nomen Nescio <anonym...@apache.org>
+sub 2048R/BA4D50BE 2016-02-23
+
+Here, the key ID is the 8-digit hex string in the `pub` line: `845E6689`.
+
+Now, add your Apache GPG key to the BookKeeper?s `KEYS` file in
[`dist`](https://svn.apache.org/repos/asf/bookkeeper/dist/KEYS). Follow the
instructions listed at the top of these files.
+
+Configure `git` to use this key when signing code by giving it your key ID, as
follows:
+
+ git config --global user.signingkey 845E6689
+
+You may drop the `--global` option if you?d prefer to use this key for the
current repository only.
+
+You may wish to start `gpg-agent` to unlock your GPG key only once using your
passphrase. Otherwise, you may need to enter this passphrase hundreds of times.
The setup for `gpg-agent` varies based on operating system, but may be
something like this:
+
+eval $(gpg-agent --
[GitHub] sijie opened a new pull request #429: 4.5 release : update website
sijie opened a new pull request #429: 4.5 release : update website URL: https://github.com/apache/bookkeeper/pull/429 Descriptions of the changes in this PR: under `site`, run `./scripts/release.sh` what the script does: - copy the `latest` to `4.5.0`. - finalize the version - update config yml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #412: css and js files are broken in `archives` links
sijie closed issue #412: css and js files are broken in `archives` links URL: https://github.com/apache/bookkeeper/issues/412 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #412: css and js files are broken in `archives` links
sijie commented on issue #412: css and js files are broken in `archives` links URL: https://github.com/apache/bookkeeper/issues/412#issuecomment-321634079 This has been merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #417: New website bug: content overlap under some view
sijie commented on issue #417: New website bug: content overlap under some view URL: https://github.com/apache/bookkeeper/issues/417#issuecomment-321633850 @jiazhai I think @lucperkins fixed this in #426 . can you check? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on a change in pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
sijie commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r132529923
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/DNSToSwitchMapping.java
##
@@ -41,14 +41,14 @@
*
*
* If a name cannot be resolved to a rack, the implementation
- * should return {@link NetworkTopology#DEFAULT_RACK}. This
+ * should return {@link NetworkTopology#DEFAULT_REGION_AND_RACK}. This
* is what the bundled implementations do, though it is not a formal
requirement
*
* @param names the list of hosts to resolve (can be empty)
* @return list of resolved network paths.
* If names is empty, the returned list is also empty
*/
-public List resolve(List names);
+public List resolve(List names, String defaultRack);
Review comment:
This would break the binary compatibility for any people who implemented
DNSToSwitchMapping.
The main problem is
```java
public static String resolveNetworkLocation(DNSToSwitchMapping
dnsResolver, InetSocketAddress addr) {
List names = new ArrayList(1);
if (dnsResolver instanceof CachedDNSToSwitchMapping) {
names.add(addr.getAddress().getHostAddress());
} else {
names.add(addr.getHostName());
}
// resolve network addresses
List rNames = dnsResolver.resolve(names);
String netLoc;
if (null == rNames) {
logger.warn("Failed to resolve network location for {}, using
default rack for them : {}.", names,
NetworkTopology.DEFAULT_RACK);
netLoc = NetworkTopology.DEFAULT_RACK;
} else {
netLoc = rNames.get(0);
}
return netLoc;
}
```
I think a clean solution without breaking the binary compatibility is
- Fix the DefaultResolver to allow passing in a `defaultRack`
```java
class DefaultResolver {
final String defaultRack = ...;
DefaultResolver() {
this(...);
}
DefaultResolver(String defaultRack) {
this.defaultRack = defaultRack;
}
}
```
the rackware can use new DefaultResolver(`/default-rack`) and regionaware
can use new DefaultResolver(`/default-region/default-rack`)
- create a DNSResolverDelegator with default-rack and remove the logic
`NetUtils#resolveNetworkLocation` to this delegator.
```java
class DNSResolverDelegator extends DefaultResolver {
DNSToSwitchMapping resolver;
DNSResolverDelegator(DNSToSwitchMapping resolver, String defaultRack) {
super(defaultRack);
this.resolver= resolver;
}
List resolve(List names) {
List resolvedNames = resolver.resolve(names);
if (null == resolvedNames) {
// return default rack
}
}
}
```
- on initialization
```java
if (optionalDnsResolver.isPresent()) {
dnsResolver = optionalDnsResolver.get();
} else {
String dnsResolverName = conf.getString(REPP_DNS_RESOLVER_CLASS,
ScriptBasedMapping.class.getName());
try {
dnsResolver = ReflectionUtils.newInstance(dnsResolverName,
DNSToSwitchMapping.class);
if (dnsResolver instanceof Configurable) {
((Configurable) dnsResolver).setConf(conf);
}
} catch (RuntimeException re) {
LOG.info("Failed to initialize DNS Resolver {}, used default
subnet resolver.", dnsResolverName, re);
dnsResolver = new DefaultResolver(`default-rack`); // <= add
default rack
}
}
this.dnsResolver = new DNSResolverDelegator(dnsResolver,
defaultRack);
```
In this way you don't need to change the signature of the methods. How does
that sound?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eolivelli commented on issue #402: Issue 356: Release notes 4.5.0
eolivelli commented on issue #402: Issue 356: Release notes 4.5.0 URL: https://github.com/apache/bookkeeper/pull/402#issuecomment-321593105 I forgot to mention networkless bookie but I think it does not make sense yet for the general audience This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #402: Issue 356: Release notes 4.5.0
eolivelli commented on issue #402: Issue 356: Release notes 4.5.0 URL: https://github.com/apache/bookkeeper/pull/402#issuecomment-321592178 I forgot to mention networkless bookie but I think it does not make sense yet for the general audience This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jvrao commented on issue #402: Issue 356: Release notes 4.5.0
jvrao commented on issue #402: Issue 356: Release notes 4.5.0 URL: https://github.com/apache/bookkeeper/pull/402#issuecomment-321590994 @sijie with these changes it looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiazhai closed pull request #428: Issue 427: [website] sidebar doesn't work on documentation index page
jiazhai closed pull request #428: Issue 427: [website] sidebar doesn't work on documentation index page URL: https://github.com/apache/bookkeeper/pull/428 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiazhai closed issue #427: [website] sidebar doesn't work on documentation index page
jiazhai closed issue #427: [website] sidebar doesn't work on documentation index page URL: https://github.com/apache/bookkeeper/issues/427 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins commented on issue #428: Issue 427: [website] sidebar doesn't work on documentation index page
lucperkins commented on issue #428: Issue 427: [website] sidebar doesn't work on documentation index page URL: https://github.com/apache/bookkeeper/pull/428#issuecomment-321424354 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #428: Issue 427: [website] sidebar doesn't work on documentation index page
sijie commented on issue #428: Issue 427: [website] sidebar doesn't work on documentation index page URL: https://github.com/apache/bookkeeper/pull/428#issuecomment-321423294 /cc @lucperkins This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new pull request #428: Issue 427: [website] sidebar doesn't work on documentation index page
sijie opened a new pull request #428: Issue 427: [website] sidebar doesn't work on documentation index page URL: https://github.com/apache/bookkeeper/pull/428 Descriptions of the changes in this PR: sidebar uses `../../` for relative paths. in order to make this work, we need to move any pages under `docs` on level down and not use `index.md`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #427: [website] sidebar doesn't work on documentation index page
sijie commented on issue #427: [website] sidebar doesn't work on documentation index page URL: https://github.com/apache/bookkeeper/issues/427#issuecomment-321419741 The problem is the sidebar now uses relative path, which assume the content is 2-depths. but in a index page, it is actually only one depth. so we need to change it to not use index page. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #427: [website] sidebar doesn't work on documentation index page
sijie opened a new issue #427: [website] sidebar doesn't work on documentation index page URL: https://github.com/apache/bookkeeper/issues/427 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? navigate to the documentation index page - What did you expect to see? the sidebar should work as expected. - What did you see instead? the links at sidebar are broken. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiazhai closed issue #419: Dockerfile: automatic the signature verification
jiazhai closed issue #419: Dockerfile: automatic the signature verification URL: https://github.com/apache/bookkeeper/issues/419 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack commented on issue #420: Issue 419: dockerfile - auto verify asc file GPG_KEY
zhaijack commented on issue #420: Issue 419: dockerfile - auto verify asc file GPG_KEY URL: https://github.com/apache/bookkeeper/pull/420#issuecomment-321416771 OK, then i would like to close this PR. Thanks for @caiok and @sijie 's help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack closed pull request #420: Issue 419: dockerfile - auto verify asc file GPG_KEY
zhaijack closed pull request #420: Issue 419: dockerfile - auto verify asc file GPG_KEY URL: https://github.com/apache/bookkeeper/pull/420 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack commented on a change in pull request #424: Issue 414: use a clone of baseconf in new ServerConfiguration(baseConf)
zhaijack commented on a change in pull request #424: Issue 414: use a clone of
baseconf in new ServerConfiguration(baseConf)
URL: https://github.com/apache/bookkeeper/pull/424#discussion_r132336522
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##
@@ -127,18 +127,8 @@ public void loadConf(URL confURL) throws
ConfigurationException {
* @param baseConf
* Other Configuration
*/
-public void loadConf(AbstractConfiguration baseConf) {
-addConfiguration(baseConf);
-}
-
-/**
- * Load configuration from other configuration object
- *
- * @param otherConf
- * Other configuration object
- */
-public void loadConf(Configuration otherConf) {
-addConfiguration(otherConf);
+public void loadConf(CompositeConfiguration baseConf) {
Review comment:
As descripted above, configuration is an interface provided in
common-configs, and not extends cloneable interface.
This part of change is mainly to delete:
```
public void loadConf(Configuration otherConf) {
addConfiguration(otherConf);
}
```
And change other place and compromise this method is calling.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie closed pull request #426: Issue #416: Some small post-release documentation fixes
sijie closed pull request #426: Issue #416: Some small post-release documentation fixes URL: https://github.com/apache/bookkeeper/pull/426 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie closed issue #416: New website small bug: tab at the top-right conner not click-able sometime
sijie closed issue #416: New website small bug: tab at the top-right conner not click-able sometime URL: https://github.com/apache/bookkeeper/issues/416 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins opened a new pull request #426: Issue #416: Some small post-release documentation fixes
lucperkins opened a new pull request #426: Issue #416: Some small post-release documentation fixes URL: https://github.com/apache/bookkeeper/pull/426 There were a few issues pointed out with the new BookKeeper website/documentation. This fixes issue #416 and makes a handful of spelling and wording fixes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #418: Bump Docker to use 4.5.0 binarary
eolivelli commented on issue #418: Bump Docker to use 4.5.0 binarary URL: https://github.com/apache/bookkeeper/issues/418#issuecomment-321362548 I am ok with this change, it will be possible once we promote a rc to general availability This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #418: Bump Docker to use 4.5.0 binarary
eolivelli commented on issue #418: Bump Docker to use 4.5.0 binarary URL: https://github.com/apache/bookkeeper/issues/418#issuecomment-321362292 I think that that message is normal for zk clients without auth. It is somehow scary but it is not a problem This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dlg99 opened a new pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes.
dlg99 opened a new pull request #425: BOOKKEEPER-1105: RackAwarePolicy: Failure to map node into rack may result in failure to add other nodes. URL: https://github.com/apache/bookkeeper/pull/425 - RackAwarePolicy's no longer uses /default-region if rack mapping fails unless required (by RegionAwarePolicy) - it no longer fails to add rest of nodes after one node's failed addition, - added unit tests - added counters for successful/failed bookie adds/removal (PR description content here)... UpdateLedgerOpTest failed but it seems to be known/unrelated issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
