[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I merged #138 . do you mind closing this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I think I fixed the epoll test issues. Added a couple of small commits on my branch. All tests are now passing on local linux. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I get a clean build on mac from my branch. I'm looking at the reasons it's failing with netty-all dependency on linux. I think we shouldn't be forcing the nio transport on linux. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli I have not looked into @merlimat changes. I will take a look and add them if they are not already addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi it is great to see all tests now passing ! @kishorekasi did you take a look to latest @merlimat commit on this issue ? @kishorekasi @sijie @revans2 Now that all the tests are passing I think we should restore the refactor of https://issues.apache.org/jira/browse/BOOKKEEPER-930, the change is quite simple, it is just a better code, see the PR https://github.com/apache/bookkeeper/pull/49 and the discussion about the refactor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli @sijie @merlimat With my latest commit this evening, all tests seem to pass now. Let me know if you are seeing any test failures in your local runs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I'll push my branch in a new PR to trigger Jenkins with my changes as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I have fixed the issues with the `BookieFailureTest`. I have applied multiple ref-count fixes as well from the yahoo branch.. pushed to https://github.com/merlimat/bookkeeper/commits/netty-4.1 Please take a look. I'll try to get to the others tests now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi can you also rebase on top of last master? This should reduce the count of tests failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 I have been testing quite a while with the leak detector and across all the leaked files I haven't seen any since netty 4 created socket. What I mostly saw with the file leak detector has been a whole bunch of file leaks in different tests. Eg: * Tests that instantiate bookies and call `shutdown()` without calling `start()` before are creating and initializing the ledger storage but not closing it, leaking threads and several fds * ZooKeeperClient sometimes doesn't shutdown the zk handle if the test completes too quickly, leaking sockets. * Several tests are passing bad config, so the bookie/client start gets exception (on purpose) and then doesn't clean up some partial objects. * ... I don't think there is an easy fix for the issue. A bigger refactor would be needed to address them. Also, I've noticed that in `pom.xml` there was already: ```xml always ``` This directive was intended to use a fresh JVM fork for each test, but it's deprecated in maven and it doesn't seem to be working. I'd propose to fix that and to use in the surefire configuration: ```xml true ``` I'll create a separate Jira for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 It seems entry log file descriptors are being leaked: https://gist.github.com/merlimat/18ecfc83b7312625755610d4d59bac9b Investigating on why --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 I didn't see the problem locally either. I'm trying now with a file leak detector agent: http://file-leak-detector.kohsuke.org/ to see if it gives any clue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Hmm so the leak was there but you were not noticing it in your limited test run. Is that the case Kishore? On Wed, May 3, 2017 at 8:36 AM, kishorekasi wrote: > Github user kishorekasi commented on the issue: > > https://github.com/apache/bookkeeper/pull/116 > > @revans2 I have seen "too many open files" in the past. Recently I > have not seen them. But, I had to increase ulimit on my dev machines for a > different reason. That explains why I am not seeing them locally > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > -- Jvrao --- First they ignore you, then they laugh at you, then they fight you, then you win. - Mahatma Gandhi
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @revans2 I have seen "too many open files" in the past. Recently I have not seen them. But, I had to increase ulimit on my dev machines for a different reason. That explains why I am not seeing them locally --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user revans2 commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli I get them too. It may be differences in the default value of ulimit. Probably the simplest thing to do it to try and trace down who is leaking all of the file descriptors. It most likely is a missed close and falling back to GC to issue the close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 @merlimat @kishorekasi Even on @merlimat brach I get a lot of too many open files, like this ``` 2017-05-03 09:33:12,232 - ERROR - [ZKC-connect-executor-0:ZooKeeperClient$1$1@125] - Failed to create zookeeper instance to 127.0.0.1:15000 java.io.IOException: Couldn't instantiate org.apache.zookeeper.ClientCnxnSocketNIO at org.apache.zookeeper.ZooKeeper.getClientCnxnSocket(ZooKeeper.java:2732) at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:728) at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:786) at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:653) at org.apache.bookkeeper.zookeeper.ZooKeeperClient.createZooKeeper(ZooKeeperClient.java:324) at org.apache.bookkeeper.zookeeper.ZooKeeperClient$1$1.call(ZooKeeperClient.java:123) at org.apache.bookkeeper.zookeeper.ZooKeeperClient$1$1.call(ZooKeeperClient.java:114) at org.apache.bookkeeper.zookeeper.ZooWorker.syncCallWithRetries(ZooWorker.java:141) at org.apache.bookkeeper.zookeeper.ZooKeeperClient$1.call(ZooKeeperClient.java:114) at org.apache.bookkeeper.zookeeper.ZooKeeperClient$1.call(ZooKeeperClient.java:109) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: java.io.IOException: Too many open files at sun.nio.ch.EPollArrayWrapper.epollCreate(Native Method) at sun.nio.ch.EPollArrayWrapper.(EPollArrayWrapper.java:130) at sun.nio.ch.EPollSelectorImpl.(EPollSelectorImpl.java:69) at sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:36) at java.nio.channels.Selector.open(Selector.java:227) at org.apache.zookeeper.ClientCnxnSocketNIO.(ClientCnxnSocketNIO.java:44) at sun.reflect.GeneratedConstructorAccessor7.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at java.lang.Class.newInstance(Class.java:442) at org.apache.zookeeper.ZooKeeper.getClientCnxnSocket(ZooKeeper.java:2730) ... 13 more ``` I'm running tests on two different laptops. Don't you get errors like those ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Thanks @merlimat I will pick those changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi @eolivelli @revans2 Addressed Bobby comments in a new commit on top of this PR. https://github.com/merlimat/bookkeeper/commits/netty-4.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 I think there was a socket leak in the original commit. The leak was fixed in a subsequent commit in the `yahoo-4.3` branch: yahoo/bookkeeper@f19c1d8c67caec2006962574adcf483d40fe6dc7 I have rebased that commit on this PR at https://github.com/merlimat/bookkeeper/commit/68a711577fe8121f5179462a0c5ee0fa61ddb86d @kishorekasi Can you apply this commit to your branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 Thank you @kishorekasi now running the full suite I get sometimes this error ``` Caused by: java.io.IOException: Too many open files at sun.nio.ch.IOUtil.makePipe(Native Method) at sun.nio.ch.EPollSelectorImpl.(EPollSelectorImpl.java:65) at sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:36) at io.netty.channel.nio.NioEventLoop.openSelector(NioEventLoop.java:155) ... 50 more ``` Maybe we have some leak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
> Kishore is seeing epoll compatibility issues with nio on netty 4.1. What do you guys mean by incompatibility? Netty can have the event loop to work either with the regular JDK nio select or by using JNI to call epoll directly, but it should be either everything goes with NIO or everything goes with epoll. On Sun, Apr 30, 2017 at 7:57 AM Venkateswara Rao Jujjuri wrote: > Kishore is seeing epoll compatibility issues with nio on netty 4.1. > Kishore did that go away when you moved to 4.1.9 as suggested by > @eolivelli? > > > JV > > On Sat, Apr 29, 2017 at 6:38 AM, eolivelli wrote: > > > Github user eolivelli commented on the issue: > > > > https://github.com/apache/bookkeeper/pull/116 > > > > I got these other errors which can be due to some resource leak > > ``` > > > > recoverWithoutPasswordInConf[7](org.apache.bookkeeper.client.BookieRecoveryTest) > > Time elapsed: 0.299 sec <<< ERROR! > > java.lang.IllegalStateException: failed to create a child event loop > > at org.apache.bookkeeper.client.BookieRecoveryTest. > > recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) > > Caused by: io.netty.channel.ChannelException: failed to open a new > > selector > > at org.apache.bookkeeper.client.BookieRecoveryTest. > > recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) > > Caused by: java.io.IOException: Too many open files > > at org.apache.bookkeeper.client.BookieRecoveryTest. > > recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) > > > > testSyncBookieRecoveryToSpecificBookie[7](org.apache. > > bookkeeper.client.BookieRecoveryTest) Time elapsed: 2.27 sec <<< ERROR! > > java.lang.IllegalStateException: failed to create a child event loop > > at org.apache.bookkeeper.client.BookieRecoveryTest.setUp( > > BookieRecoveryTest.java:112) > > Caused by: io.netty.channel.ChannelException: failed to open a new > > selector > > at org.apache.bookkeeper.client.BookieRecoveryTest.setUp( > > BookieRecoveryTest.java:112) > > Caused by: java.io.IOException: Too many open files > > at org.apache.bookkeeper.client.BookieRecoveryTest.setUp( > > BookieRecoveryTest.java:112) > > > > ``` > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at infrastruct...@apache.org or file a JIRA > ticket > > with INFRA. > > --- > > > > > > -- > Jvrao > --- > First they ignore you, then they laugh at you, then they fight you, then > you win. - Mahatma Gandhi >
Re: [GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Kishore is seeing epoll compatibility issues with nio on netty 4.1. Kishore did that go away when you moved to 4.1.9 as suggested by @eolivelli? JV On Sat, Apr 29, 2017 at 6:38 AM, eolivelli wrote: > Github user eolivelli commented on the issue: > > https://github.com/apache/bookkeeper/pull/116 > > I got these other errors which can be due to some resource leak > ``` > > recoverWithoutPasswordInConf[7](org.apache.bookkeeper.client.BookieRecoveryTest) > Time elapsed: 0.299 sec <<< ERROR! > java.lang.IllegalStateException: failed to create a child event loop > at org.apache.bookkeeper.client.BookieRecoveryTest. > recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) > Caused by: io.netty.channel.ChannelException: failed to open a new > selector > at org.apache.bookkeeper.client.BookieRecoveryTest. > recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) > Caused by: java.io.IOException: Too many open files > at org.apache.bookkeeper.client.BookieRecoveryTest. > recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) > > testSyncBookieRecoveryToSpecificBookie[7](org.apache. > bookkeeper.client.BookieRecoveryTest) Time elapsed: 2.27 sec <<< ERROR! > java.lang.IllegalStateException: failed to create a child event loop > at org.apache.bookkeeper.client.BookieRecoveryTest.setUp( > BookieRecoveryTest.java:112) > Caused by: io.netty.channel.ChannelException: failed to open a new > selector > at org.apache.bookkeeper.client.BookieRecoveryTest.setUp( > BookieRecoveryTest.java:112) > Caused by: java.io.IOException: Too many open files > at org.apache.bookkeeper.client.BookieRecoveryTest.setUp( > BookieRecoveryTest.java:112) > > ``` > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > -- Jvrao --- First they ignore you, then they laugh at you, then they fight you, then you win. - Mahatma Gandhi
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 I got these other errors which can be due to some resource leak ``` recoverWithoutPasswordInConf[7](org.apache.bookkeeper.client.BookieRecoveryTest) Time elapsed: 0.299 sec <<< ERROR! java.lang.IllegalStateException: failed to create a child event loop at org.apache.bookkeeper.client.BookieRecoveryTest.recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) Caused by: io.netty.channel.ChannelException: failed to open a new selector at org.apache.bookkeeper.client.BookieRecoveryTest.recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) Caused by: java.io.IOException: Too many open files at org.apache.bookkeeper.client.BookieRecoveryTest.recoverWithoutPasswordInConf(BookieRecoveryTest.java:846) testSyncBookieRecoveryToSpecificBookie[7](org.apache.bookkeeper.client.BookieRecoveryTest) Time elapsed: 2.27 sec <<< ERROR! java.lang.IllegalStateException: failed to create a child event loop at org.apache.bookkeeper.client.BookieRecoveryTest.setUp(BookieRecoveryTest.java:112) Caused by: io.netty.channel.ChannelException: failed to open a new selector at org.apache.bookkeeper.client.BookieRecoveryTest.setUp(BookieRecoveryTest.java:112) Caused by: java.io.IOException: Too many open files at org.apache.bookkeeper.client.BookieRecoveryTest.setUp(BookieRecoveryTest.java:112) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 with the dependency set (with no epoll native libs, only java dep and with the needed netty parts) which I suggested in previous comments and the fix to testWriteGaps I get only 5 failures, maybe due to the bug on ref counted buffers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I noticed we are using Netty 4.1.7, on 4.1.9 release notes I see https://github.com/netty/netty/issues/6303 see http://netty.io/news/2017/03/10/4-0-45-Final-4-1-9-Final.html On my projects I am using 4.1.9 now, maybe you can try to upgrade as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/116
I am locally testing a more cleaner dependency set against netty
```
io.netty
netty-common
${netty.version}
io.netty
netty-codec
${netty.version}
io.netty
netty-transport
${netty.version}
io.netty
netty-handler
${netty.version}
io.netty
netty-transport-native-epoll
${netty.version}
io.netty
netty-tcnative-boringssl-static
${netty-tcnative.version}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi Maybe you can add commits without squashing, this way we can track more easily the new changes you are pushing in. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 I have checked out the lastest version of this PR But I am still seeing this kind of errors, for instance in BookieFailuresTest. Did you push your local code to GitHub ? ``` Tests in error: BookieFailureTest.testAsyncBK4:121->auxTestReadWriteAsyncSingleClient:183->Object.wait:-2 » TestTimedOut ``` > 2017-04-28 13:09:43,496 - ERROR - [BookKeeperClientWorker-orderedsafeexecutor-0-0:SafeRunnable@33] - Unexpected throwable caught > io.netty.util.IllegalReferenceCountException: refCnt: 0, increment: 1 > at io.netty.buffer.AbstractReferenceCountedByteBuf.retain0(AbstractReferenceCountedByteBuf.java:68) > at io.netty.buffer.AbstractReferenceCountedByteBuf.retain(AbstractReferenceCountedByteBuf.java:53) > at io.netty.buffer.CompositeByteBuf.retain(CompositeByteBuf.java:1906) > at io.netty.buffer.CompositeByteBuf.retain(CompositeByteBuf.java:44) > at org.apache.bookkeeper.proto.BookieClient.addEntry(BookieClient.java:223) > at org.apache.bookkeeper.client.PendingAddOp.sendWriteRequest(PendingAddOp.java:103) > at org.apache.bookkeeper.client.PendingAddOp.unsetSuccessAndSendWriteRequest(PendingAddOp.java:169) > at org.apache.bookkeeper.client.LedgerHandle.unsetSuccessAndSendWriteRequest(LedgerHandle.java:1347) > at org.apache.bookkeeper.client.LedgerHandle$ChangeEnsembleCb.safeOperationComplete(LedgerHandle.java:1211) > at org.apache.bookkeeper.client.LedgerHandle$ChangeEnsembleCb.safeOperationComplete(LedgerHandle.java:1181) > at org.apache.bookkeeper.util.OrderedSafeExecutor$OrderedSafeGenericCallback$1.safeRun(OrderedSafeExecutor.java:443) > at org.apache.bookkeeper.util.SafeRunnable.run(SafeRunnable.java:31) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli - I fixed a refcnt bug with ByteBuf and consistently pass SlowBookieTest now; updated the pull request. I am not able to see the jenkins build output, waiting for this next run to address if there are any more test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi adding simple debug logs fixes some error on the SlowBookieTest, I think we have race conditions on ByteBuf usage, I am checking now the flow of the pendingOps in case of network error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 On my laptop (Linux fedora 24) I have: > testDuplicateBookieServerStartup(org.apache.bookkeeper.bookie.BookieInitializationTest) Time elapsed: 0.028 sec <<< ERROR! > io.netty.channel.unix.Errors$NativeIoException: bind() failed: Address already in use > The test is failing because using the NativeIoException is not a BindException I suggest to change the 'catch' clause to a more naive 'catch IOException' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 I fixed a merge conflict. Also as Netty channel and write and flush semantics have changed in 4.x; made few more changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 Let me take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 Ok, I see only ~5 tests are failing there, not the 100s I understood yesterday :) https://builds.apache.org/job/bookkeeper-master-git-pullrequest/309/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Yes @merlimat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 Hi @kishorekasi, is this the latest version of the patch you were mentioning yesterday? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Just back from vacation. There seems to be new commits to the repo. I will resolve the conflicts and generate a new pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 Thank you @kishorekasi. At this point this branch fails to build What would be the best way to help you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Enrico, I have updated the pull request with my local changes. Kishore > On Apr 10, 2017, at 5:42 AM, Enrico Olivelli wrote: > > @kishorekasi could you push your current local version so that me and @revans2 can help you with failing tests ? > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi could you push your current local version so that me and @revans2 can help you with failing tests ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
