[GitHub] eolivelli commented on issue #232: Add code-coverage report
eolivelli commented on issue #232: Add code-coverage report URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315330556 @sijie @fpj is using CodeCov which is well integrated with PRs, I will take a look too It seems that it requires Cobertura too. Both Coveralls and Codecov do not require "tokens" if the build is run from Travis-CI I think that the better approach is to run from Travis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #232: Add code-coverage report
eolivelli commented on issue #232: Add code-coverage report URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315330556 @sijie @fpj is using CodeCov which is well integrated with PRs, I will take a look too It seems that it requires Cobertura too. Both Coveralls and Codecov do not require "tokens" if the build is run from Travis-CI I think that the better approch is to run from Travis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo
eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315092290 in coveralls.io docs it seems that the best java8 support is with JaCoCo https://github.com/trautonen/coveralls-maven-plugin This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo
eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315085394 @sijie it seems that DL uses Coveralls + Cobertura, I will try with Cobertura https://github.com/apache/incubator-distributedlog/blob/master/pom.xml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo
eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315085394 @sijie it seems that DL uses Overalls + Cobertura, I will try with Cobertura https://github.com/apache/incubator-distributedlog/blob/master/pom.xml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo
eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-312905153 After running this command in bookkeeper-server directory: mvn clean install -Pcode-coverage the HTML report will be in: bookkeeper-server/target/site/jacoco/index.html we could also add some warning/error thresholds if a new patch introduces too much "uncovered" code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo
eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-312903670 created PR #233 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
